Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-30 Thread Pierre-Anthony Lemieux
On Wed, May 11, 2022 at 8:02 AM Zane van Iperen wrote: > > > > On 10/5/22 23:18, Andreas Rheinhardt wrote: > > >> +int av_uuid_parse_range(const char *in_start, const char *in_end, AVUUID > >> uu) > >> +{ > >> +int i; > >> +const char *cp; > >> +char buf[3]; > >> + > >> +if

Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-30 Thread Pierre-Anthony Lemieux
On Wed, May 11, 2022 at 8:03 AM Zane van Iperen wrote: > > > > On 11/5/22 21:53, Anton Khirnov wrote: > > Quoting Zane van Iperen (2022-04-24 12:14:03) > >> +void av_uuid_nil_set(AVUUID uu) > > ^^^ > > sounds weird > > > > av_uuid_zero()? > > av_uuid_reset()? > > > > Good

[FFmpeg-devel] [PATCH v3 6/6] avfilter/showinfo: refactor to use avutil/uuid

2022-05-30 Thread pal
From: Pierre-Anthony Lemieux --- libavfilter/vf_showinfo.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 12d39310ef..0d6f2805bb 100644 --- a/libavfilter/vf_showinfo.c +++

[FFmpeg-devel] [PATCH v3 5/6] avformat/imf: refactor to use avutil/uuid

2022-05-30 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imf.h | 18 - libavformat/imf_cpl.c | 60 +++-- libavformat/imfdec.c| 34 +++ libavformat/tests/imf.c | 18 ++--- 4 files changed, 52 insertions(+), 78

[FFmpeg-devel] [PATCH v3 4/6] avformat/smoothstreamingenc: refactor to use avutil/uuid

2022-05-30 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/smoothstreamingenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c index 1713dd9009..ade6d5723b 100644 --- a/libavformat/smoothstreamingenc.c +++

[FFmpeg-devel] [PATCH v3 3/6] avformat/mov: refactor to use avutil/uuid

2022-05-30 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/mov.c| 25 + libavformat/movenc.c | 9 + 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d7be593a86..f8248ab65b 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH v3 2/6] avutil/tests/uuid: add uuid tests

2022-05-30 Thread pal
From: Pierre-Anthony Lemieux --- libavutil/Makefile | 1 + libavutil/tests/.gitignore | 1 + libavutil/tests/uuid.c | 141 + tests/fate/libavutil.mak | 5 ++ 4 files changed, 148 insertions(+) create mode 100644 libavutil/tests/uuid.c

[FFmpeg-devel] [PATCH v3 1/6] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-30 Thread pal
From: Zane van Iperen Addresses review comments including: * simplifying av_uuid_parse_range() * removing avcodec/cbs_sei from this refactoring exercise Co-authored-by: Pierre-Anthony Lemieux Signed-off-by: Zane van Iperen --- libavutil/Makefile | 2 + libavutil/uuid.c | 142

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: Alpha workaround

2022-05-30 Thread Michael Niedermayer
alpha-linux-gnu-gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 with qemu-alpha version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.39) trigger a FPE on the first iteration None of the intermediate values when printed shows an anomaly nor does casting the final value. I did not investigate this further by

[FFmpeg-devel] [PATCH 1/2] avutil/opt: Alpha workaround

2022-05-30 Thread Michael Niedermayer
alpha-linux-gnu-gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 with qemu-alpha version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.39) trigger a FPE on the DBL_MAX * 9 operation Iam not 100% sure why, but if i mess with mfp-trap-mode the compiler produces internal compiler errors This issue seems not

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Fix undefined left shifts of negative numbers

2022-05-30 Thread Michael Niedermayer
On Mon, May 30, 2022 at 06:34:10PM +0200, Andreas Rheinhardt wrote: > Maybe this fixes the FPE encountered here: > https://fate.ffmpeg.org/report.cgi?slot=alpha-debian-qemu-gcc-4.7=20220530144951 > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ffv1enc.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avcodec/iff: Remove redundant #if

2022-05-30 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/iff: Remove redundant #if

2022-05-30 Thread Andreas Rheinhardt
Since ec0275843d8eb933699807da81f6f366291f034a this file is compiled iff IFF ILBM decoder is enabled. Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index 36c9535d54..74ebddc621 100644 ---

[FFmpeg-devel] [PATCH] avcodec/ffv1enc: Fix undefined left shifts of negative numbers

2022-05-30 Thread Andreas Rheinhardt
Maybe this fixes the FPE encountered here: https://fate.ffmpeg.org/report.cgi?slot=alpha-debian-qemu-gcc-4.7=20220530144951 Signed-off-by: Andreas Rheinhardt --- libavcodec/ffv1enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c

Re: [FFmpeg-devel] [PATCH] libavformat/tls_libtls: handle TLS_WANT_{POLLIN, POLLOUT} in read/write functions

2022-05-30 Thread Matthieu Bouron
On Mon, May 23, 2022 at 12:44:33PM +0200, Matthieu Bouron wrote: > According to the tls documentation: tls_read() and tls_write() can > return TLS_WANT_POLLIN and TLS_WANT_POLLOUT which indicates that the > same operation must be repeated immediately. > > This commit prevents the libtls backend

[FFmpeg-devel] [PATCH v4 1/4] lavc/libaribcaption.c: add ARIB caption decoder using libaribcaption

2022-05-30 Thread TADANO Tokumei
This patch add another ARIB caption decoder using libaribcaption external library. Unlike libaribb24, it supports 3 types of subtitle outputs: * text: plain text * ass: ASS formatted text * bitmap: bitmap image Default subtitle type is ass as same as libaribb24. To compile with this feature: *

[FFmpeg-devel] [PATCH v4 3/4] lavf/mpegts.c: set some properties for ARIB caption

2022-05-30 Thread TADANO Tokumei
Some additional properties are set for ARIB caption. * need_parsing = 0 ARIB caption doesn't require any parser. This avoids "parser not found" warning message. * need_context_update = 1 When any profiles are changed, set this flag to notify. * codecpar->width / codecpar->height Find best

[FFmpeg-devel] [PATCH v4 4/4] doc/decoders.texi: add document of aribcaption decoder

2022-05-30 Thread TADANO Tokumei
Signed-off-by: TADANO Tokumei --- doc/decoders.texi | 99 +++ 1 file changed, 99 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index de2429abba..eb82b4df48 100644 --- a/doc/decoders.texi +++ b/doc/decoders.texi @@ -334,6 +334,105 @@

[FFmpeg-devel] [PATCH v4 2/4] lavc/codec_desc.c: remove AV_CODEC_PROP_TEXT_SUB property

2022-05-30 Thread TADANO Tokumei
To support bitmap type of subtitles, remove AV_CODEC_PROP_TEXT_SUB property from codec descriptor for AV_CODEC_ID_ARIB_CAPTION. It is similar way to `libavcodec/libzvbi-teletextdec.c` (AV_CODEC_ID_DVB_TELETEXT). Instead, each subtitle decoder has to specify subtitile format.

[FFmpeg-devel] [PATCH v4 0/4] add ARIB caption decoder using libaribcaption

2022-05-30 Thread TADANO Tokumei
This patch set add another ARIB caption decoder using libaribcaption external library: https://github.com/xqq/libaribcaption The library decodes subtitles of ISDB-based TV broadcasting. It is not only for Japanese ARIB STD-B24 caption, but also for Brazilian ABNT NBR 15606-1 and Philippines

[FFmpeg-devel] [PATCH 5/5] fate/wavpack: Test APE cuesheet tags

2022-05-30 Thread Andreas Rheinhardt
The cue_sheet.wv sample contains a cue sheet as APE tags, yet this is not really covered by fate-wavpack-cuesheet because the metadata does not affect the output of said test. So add a proper test for this. Signed-off-by: Andreas Rheinhardt --- tests/fate/wavpack.mak | 7 +-

[FFmpeg-devel] [PATCH 4/5] fate/wavpack: Avoid temp files

2022-05-30 Thread Andreas Rheinhardt
Use the md5 protocol instead of creating a file just to calculate its MD5 checksum. This is possible because there are no output seeks involved in any of these tests. Signed-off-by: Andreas Rheinhardt --- tests/fate/wavpack.mak | 64 +- 1 file changed, 32

[FFmpeg-devel] [PATCH 3/5] fate/wavpack: Fix test requirements

2022-05-30 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/wavpack.mak | 66 ++ 1 file changed, 35 insertions(+), 31 deletions(-) diff --git a/tests/fate/wavpack.mak b/tests/fate/wavpack.mak index 8a15e536cc..dc9cc29268 100644 --- a/tests/fate/wavpack.mak +++

[FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Remove redundant av_channel_layout_uninit()

2022-05-30 Thread Andreas Rheinhardt
av_channel_layout_copy() will uninit the dst channel layout before copying the new one. Signed-off-by: Andreas Rheinhardt --- libavcodec/wavpack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c index efd9e0fdd0..8bfbb654e8 100644 ---

[FFmpeg-devel] [PATCH 2/6] fate/vpx: Remove unused define parameters

2022-05-30 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/vpx.mak | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/vpx.mak b/tests/fate/vpx.mak index 9b27a4a657..e18f3df38b 100644 --- a/tests/fate/vpx.mak +++ b/tests/fate/vpx.mak @@ -88,9 +88,9 @@ FATE_SAMPLES_AVCONV

[FFmpeg-devel] [PATCH 1/6] fate/opus: Restore fate-opus-(celt|hybrid|silk)

2022-05-30 Thread Andreas Rheinhardt
Also fix the test requirements. Signed-off-by: Andreas Rheinhardt --- tests/fate/opus.mak | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak index cf8eeb555d..573044ed15 100644 --- a/tests/fate/opus.mak

Re: [FFmpeg-devel] [PATCH] avcodec/pcm-dvdenc: Mark unreachable defaults

2022-05-30 Thread Michael Niedermayer
On Thu, May 26, 2022 at 03:04:31AM +0200, Michael Niedermayer wrote: > Helps: CID1441929 > Helps: CID1441931 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/pcm-dvdenc.c | 4 > 1 file changed, 4 insertions(+) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, May 30, 2022 12:24 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem > alignment for vsynth..mpeg2-422 tests

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Soft Works (2022-05-30 10:35:26) >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of >>> Anton Khirnov >>> Sent: Monday, May 30, 2022 9:35 AM >>> To: FFmpeg development discussions and patches >> de...@ffmpeg.org> >>> Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Anton Khirnov
Quoting Soft Works (2022-05-30 11:26:56) > Well, the test .mak files are full of hacks then, with the many super- > special flags in place that do not reflect any real world use at all. There are AFAIK zero tests that override cpuflags. > > That flag does nothing more than to assure that the

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Anton Khirnov
Quoting Soft Works (2022-05-30 10:35:26) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Monday, May 30, 2022 9:35 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v2]

[FFmpeg-devel] [PATCH] avcodec/proresdec2: fix description of known fourcc

2022-05-30 Thread Zhao Zhili
'acpo' should be 'apco', and add missing 'ap4x'. Signed-off-by: Zhao Zhili --- libavcodec/proresdec2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index dba64a2489..385ca2fb1c 100644 --- a/libavcodec/proresdec2.c +++

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Anton Khirnov
Quoting Soft Works (2022-05-30 10:08:11) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Monday, May 30, 2022 9:35 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v2]

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Eliminate float/double from find_best_state()

2022-05-30 Thread Michael Niedermayer
On Mon, May 30, 2022 at 11:16:41AM +0300, Martin Storsjö wrote: > On Mon, 30 May 2022, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2022-05-27 20:52:09) > > > log2() remains, this can either be replaced by a integer implementation > > > or the table > > > hardcoded if needed > > > >

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Monday, May 30, 2022 11:07 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem > alignment for vsynth..mpeg2-422 tests >

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Paul B Mahol
On Mon, May 30, 2022 at 10:35 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Monday, May 30, 2022 9:35 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v2]

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, May 30, 2022 9:35 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem > alignment for vsynth..mpeg2-422 tests >

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Monday, May 30, 2022 10:08 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem > alignment for vsynth..mpeg2-422 tests >

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Eliminate float/double from find_best_state()

2022-05-30 Thread Martin Storsjö
On Mon, 30 May 2022, Anton Khirnov wrote: Quoting Michael Niedermayer (2022-05-27 20:52:09) log2() remains, this can either be replaced by a integer implementation or the table hardcoded if needed Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c| 25

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, May 30, 2022 9:35 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem > alignment for vsynth..mpeg2-422 tests >

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: enable compressorname for mp4 mode

2022-05-30 Thread Zhao Zhili
Signed-off-by: Zhao Zhili --- libavformat/movenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index de971f94e8..c2dc354ed3 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2121,7 +2121,9 @@ static void

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: enable btrt for mov mode

2022-05-30 Thread Zhao Zhili
Signed-off-by: Zhao Zhili --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c2dc354ed3..69726d93e3 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6897,7 +6897,7 @@ static int

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Eliminate float/double from find_best_state()

2022-05-30 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-05-27 20:52:09) > log2() remains, this can either be replaced by a integer implementation or > the table > hardcoded if needed > > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c| 25 - >

Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

2022-05-30 Thread Anton Khirnov
Quoting Soft Works (2022-05-28 15:17:54) > Do you have a better idea? > > The one advantage of this method is that you don’t need to change compilation > parameters > nor any source code. It’s only a runtime flag being set only for this > specific family of tests. At the very least, I would