Re: [FFmpeg-devel] [PATCH v2] avformat/riffenc: don't force WAVEFORMATEXTENSIBLE for flt/dbl LPCM

2023-12-25 Thread Gyan Doshi
Plan to push in 48h, barring objections. On 2023-12-21 03:31 pm, Gyan Doshi wrote: 2c2a167ca7 forced WAVEFORMATEXTENSIBLE for all LPCM streams with greater than 16 bits per sample. However, WAVEFORMATEX allows IEEE Float samples or any depth where raw depth == coded depth, see Remarks section

Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list

2023-12-25 Thread Wang, Fei W
On Fri, 2023-12-22 at 08:41 +0100, Andreas Rheinhardt wrote: > Wang, Fei W: > > On Thu, 2023-12-21 at 20:14 +0100, Andreas Rheinhardt wrote: > > > Wang, Fei W: > > > > On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote: > > > > > fei.w.wang-at-intel@ffmpeg.org: > > > > > > From: Fei

[FFmpeg-devel] [PATCH v1 2/2] avcodec/av1dec: Return error for unsupported tile list OBU

2023-12-25 Thread fei . w . wang-at-intel . com
From: Fei Wang Otherwise decoding maybe successful but output result is incorrect. Signed-off-by: Fei Wang --- libavcodec/av1dec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index e8041c1f58..9b1778dcc4 100644 --- a/libavcodec/av1dec.c

[FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning

2023-12-25 Thread fei . w . wang-at-intel . com
From: Fei Wang So that can show OBU info even it doesn't have decomposed content. Signed-off-by: Fei Wang --- libavcodec/av1dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index da05a0f039..e8041c1f58 100644 ---

Re: [FFmpeg-devel] [PATCH v2] configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm

2023-12-25 Thread Brad Smith
On 2023-12-24 9:08 p.m., Michael Niedermayer wrote: On Sun, Dec 24, 2023 at 02:33:31PM -0500, Brad Smith wrote: configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm Fixes the build. It's a requirement when utilizing PIE. Signed-off-by: Brad Smith --- configure | 2 ++

Re: [FFmpeg-devel] [PATCH] cbs_av1: Reject thirty-two zero bits in uvlc code

2023-12-25 Thread Michael Niedermayer
Hi On Sun, Oct 22, 2023 at 07:35:52PM +0100, Mark Thompson wrote: > The spec allows at least thirty-two zero bits followed by a one to mean > 2^32-1, with no constraint on the number of zeroes. The libaom > reference decoder does not match this, instead reading thirty-two zeroes > but not the

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpegxl_parser: check ANS cluster alphabet size vs bundle size

2023-12-25 Thread Michael Niedermayer
On Mon, Dec 25, 2023 at 12:04:17PM -0500, Leo Izen wrote: > The specification doesn't mention that clusters cannot have alphabet > sizes greater than 1 << bundle->log_alphabet_size, but the reference > implementation rejects these entropy streams as invalid, so we should > too. Refusing to do so

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-25 Thread Leo Izen
On 12/21/23 21:32, Michael Niedermayer wrote: Can you think of a way to add some lines of code to this that makes it more maintainable ? if yes, then i think you proofed that adding code can reduce maintaince burden thx This is clearly not the point here. The point is that an in-house

[FFmpeg-devel] [PATCH v2] avcodec/jpegxl_parser: check ANS cluster alphabet size vs bundle size

2023-12-25 Thread Leo Izen
The specification doesn't mention that clusters cannot have alphabet sizes greater than 1 << bundle->log_alphabet_size, but the reference implementation rejects these entropy streams as invalid, so we should too. Refusing to do so can overflow a stack variable on line 556 that should be large

[FFmpeg-devel] 回复: [PATCH 1/5] avcodec/d3d12va_vp9: fix vp9 max_num_refs value

2023-12-25 Thread Wu Jianhua
Tong Wu : > subject: [FFmpeg-devel] [PATCH 1/5] avcodec/d3d12va_vp9: fix vp9 max_num_refs > value > > Previous max_num_refs was based on pp.frame_refs plus 1 and it could possibly > reaches the size limit. Actually it should be the size of pp.ref_frame_map > plus 1. > > Signed-off-by: Tong Wu >

[FFmpeg-devel] [PATCH 5/5] avcodec/dxva2(h264|mpeg2|vc1): use av_assert0 instead of assert

2023-12-25 Thread Tong Wu
Signed-off-by: Tong Wu --- libavcodec/dxva2.c | 6 +++--- libavcodec/dxva2_h264.c | 16 libavcodec/dxva2_mpeg2.c | 2 +- libavcodec/dxva2_vc1.c | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c index

[FFmpeg-devel] [PATCH 4/5] avcodec/d3d12va_decode: remove assertion from get_surface_index

2023-12-25 Thread Tong Wu
Return zero for failed case and avoid aborting the program. Signed-off-by: Tong Wu --- libavcodec/d3d12va_decode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c index 50d5b8d601..20dc485284 100644 --- a/libavcodec/d3d12va_decode.c

[FFmpeg-devel] [PATCH 3/5] avcodec/d3d12va_h264: replace assert with av_assert0

2023-12-25 Thread Tong Wu
Signed-off-by: Tong Wu --- libavcodec/d3d12va_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/d3d12va_h264.c b/libavcodec/d3d12va_h264.c index 5a6d6852c8..24e1c523fa 100644 --- a/libavcodec/d3d12va_h264.c +++ b/libavcodec/d3d12va_h264.c @@ -60,7 +60,7 @@

[FFmpeg-devel] [PATCH 2/5] avcodec/d3d12va_decode: delete an empty line and fix a fuction alignment

2023-12-25 Thread Tong Wu
Signed-off-by: Tong Wu --- libavcodec/d3d12va_decode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c index e0b67bf964..50d5b8d601 100644 --- a/libavcodec/d3d12va_decode.c +++ b/libavcodec/d3d12va_decode.c @@

[FFmpeg-devel] [PATCH 1/5] avcodec/d3d12va_vp9: fix vp9 max_num_refs value

2023-12-25 Thread Tong Wu
Previous max_num_refs was based on pp.frame_refs plus 1 and it could possibly reaches the size limit. Actually it should be the size of pp.ref_frame_map plus 1. Signed-off-by: Tong Wu --- libavcodec/d3d12va_vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Zhao Zhili
> On Dec 25, 2023, at 18:21, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-25 10:27:59) >> >> >>> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: >>> >>> Quoting Kacper Michajlow (2023-12-24 11:41:52) On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > Quoting

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Anton Khirnov
Quoting Zhao Zhili (2023-12-25 10:27:59) > > > > On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > > > > Quoting Kacper Michajlow (2023-12-24 11:41:52) > >> On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > >>> > >>> Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > Avoids

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Zhao Zhili
> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > > Quoting Kacper Michajlow (2023-12-24 11:41:52) >> On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: >>> >>> Quoting Andreas Rheinhardt (2023-12-22 14:48:45) Avoids relocations. Signed-off-by: Andreas Rheinhardt ---

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Anton Khirnov
Quoting Kacper Michajlow (2023-12-24 11:41:52) > On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > > > Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > > > Avoids relocations. > > > > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > > Maybe mention that it's not needed after > >