Re: [FFmpeg-devel] [PATCH 2/2] lavc/qsvenc: add support for oneVPL string API

2024-05-03 Thread Xiang, Haihao
On Do, 2024-02-29 at 13:34 +0800, Xiang, Haihao wrote: > From: "Mandava, Mounika" > > A new option -qsv_params is added, where is a :-separated > list of key=value parameters. > > Example: > $ ffmpeg -y -f lavfi -i testsrc -vf "format=nv12" -c:v h264_qsv -qsv_params >

Re: [FFmpeg-devel] [PATCH 1/9] lavu/hwcontext_qsv: update AVQSVFramesContext to support dynamic frame pool

2024-05-03 Thread Xiang, Haihao
On Do, 2024-05-02 at 20:35 +0100, Mark Thompson wrote: > On 28/04/2024 08:39, Xiang, Haihao wrote: > > From: Haihao Xiang > > > > Add AVQSVFramesContext.info and update the description. > > > > Signed-off-by: Haihao Xiang > > --- > >  doc/APIchanges    |  3 +++ > >  

[FFmpeg-devel] Samples with invalid permissions

2024-05-03 Thread Marton Balint
Hi, There are a couple of files in samples.ffmpeg.org with invalid permissions, rsync is not able to read those: /V-codecs/UCOD/noextradata/CLV1_tony.mov /V-codecs/UCOD/noextradata/freddie2.mov /V-codecs/UCOD/noextradata/pittc.mov /V-codecs/UCOD/noextradata/smilla_cv.mov

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: only check index_edit_rate when calculating the index tables

2024-05-03 Thread Marton Balint
On Fri, 3 May 2024, Tomas Härdin wrote: tor 2024-05-02 klockan 23:01 +0200 skrev Marton Balint: On Mon, 29 Apr 2024, Tomas Härdin wrote: > mån 2024-04-15 klockan 21:34 +0200 skrev Marton Balint: > > Commit ed49391961999f028e0bc55767d0eef6eeb15e49 started rejecting > > negative > > index

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread flow gg
I saw about comparing emails and gitlab/hub .., I did not comprehensively understand their advantages and disadvantages, but I want to say that I support it to change to gitlab/hub Simple reason: If you need to use git-send-email, I may not be able to submit any code If you do not need to use

Re: [FFmpeg-devel] [PATCH v1] scale: Bring back the old yuv2yuvX, use it when disable-x86asm.

2024-05-03 Thread Michael Niedermayer
On Fri, May 03, 2024 at 04:07:36AM +0800, hu heng wrote: > 于2024年4月26日周五 20:21写道: > > > > From: huheng > > > > rename old inline yuv2yuvX to yuv2yuv_X, to avoid conflicts with > > the names of standalone asm functions. When ffmpeg is compiled with > > --disable-x86asm, using the scale function

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

2024-05-03 Thread Michael Niedermayer
On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596607 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dovi_rpuenc.c | 2 +- > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Check av_malloc()

2024-05-03 Thread Michael Niedermayer
On Thu, May 02, 2024 at 11:34:15PM +0200, Andreas Rheinhardt wrote: > Fixes Coverity issue #1596735. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/movenc.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: Avoid overflow when calculating DAR

2024-05-03 Thread Michael Niedermayer
On Fri, May 03, 2024 at 05:36:23PM +0100, Derek Buitenhuis wrote: > Both the codecpar's width and height, and the SAR num and den are > ints, which can overflow. Cast to int64_t, which is what av_reduce > takes. > > Without this, occasionally, display_aspect_ratio can be negative in > ffprobe's

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

2024-05-03 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1596607 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/dovi_rpuenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/dovi_rpuenc.c

[FFmpeg-devel] [PATCH 5/5] avcodec/exr: Fix preview overflow

2024-05-03 Thread Michael Niedermayer
Fixes: CID1515456 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 8bd39f78a45..4bac0be89b2 100644 ---

[FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

2024-05-03 Thread Michael Niedermayer
Fixes: CID1596607 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dovi_rpuenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index

[FFmpeg-devel] [PATCH 3/5] avcodec/dovi_rpuenc: fix compaatibility

2024-05-03 Thread Michael Niedermayer
Fixes: a frequency Found while reviewing: CID1596607 Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dovi_rpuenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index

[FFmpeg-devel] [PATCH 2/5] avcodec/dovi_rpuenc: initialize profile

2024-05-03 Thread Michael Niedermayer
Code is taken from dovi_rpudec Fixes: CID1596604 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dovi_rpuenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index

[FFmpeg-devel] [PATCH 1/5] avcodec/decode: decode_simple_internal() only implements audio and video

2024-05-03 Thread Michael Niedermayer
Fixes: CID1538861 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index d031b1ca176..900b0c07a35 100644 ---

[FFmpeg-devel] [PATCH] avfilter/vf_scale: add missing filter flag

2024-05-03 Thread Niklas Haas
From: Niklas Haas Fixes: bb8044581366fe286e16b14515d873979133dbda --- libavfilter/vf_scale.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index bc53571c1c..696ee272ec 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@

[FFmpeg-devel] [PATCH] lavc/ac3dsp: R-V Zbb ac3_exponent_min

2024-05-03 Thread Rémi Denis-Courmont
SiFive U74: ac3_exponent_min_reuse0_c: 10.0 ac3_exponent_min_reuse0_rvb_b:8.0 ac3_exponent_min_reuse1_c: 2924.7 ac3_exponent_min_reuse1_rvb_b: 1803.0 ac3_exponent_min_reuse2_c: 5043.0 ac3_exponent_min_reuse2_rvb_b: 2827.5 ac3_exponent_min_reuse3_c: 7028.7

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Rémi Denis-Courmont
Le perjantaina 3. toukokuuta 2024, 20.30.16 EEST Ondřej Fiala a écrit : > > You can't expect the whole community to accomodate your unwillingness to > > run a web browser or update a ridiculous underprovisioned computer > > system. > There is a huge difference between running a web browser and

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Ondřej Fiala
On Fri May 3, 2024 at 4:41 PM CEST, Rémi Denis-Courmont wrote: > Le perjantaina 3. toukokuuta 2024, 15.58.50 EEST Ondřej Fiala a écrit : > > > And in the end, I could be wrong, but I haven't seen you doing much code > > > review here. This is all about optimising the workflow for people doing > >

[FFmpeg-devel] [PATCH 1/2] lavu/riscv: indent code

2024-05-03 Thread Rémi Denis-Courmont
This reindents code to prepare for the next changeset. No functional changes. --- libavutil/riscv/cpu.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/libavutil/riscv/cpu.c b/libavutil/riscv/cpu.c index 460d3e9f91..984293aef0 100644 ---

[FFmpeg-devel] [PATCH 2/2] lavu/riscv: add hwprobe() for CPU detection

2024-05-03 Thread Rémi Denis-Courmont
This adds the Linux-specific function call to detect CPU features. Unlike the more portable auxillary vector, this supports extensions other than single lettered ones. At this point, FFmpeg already needs this to detect Zba and Zbb at run-time, and probably will need it for Zvbb in the near future.

[FFmpeg-devel] [PATCH] fftools/ffprobe: Avoid overflow when calculating DAR

2024-05-03 Thread Derek Buitenhuis
Both the codecpar's width and height, and the SAR num and den are ints, which can overflow. Cast to int64_t, which is what av_reduce takes. Without this, occasionally, display_aspect_ratio can be negative in ffprobe's -show_stream output. Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c |

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Cosmin Stejerean via ffmpeg-devel
> On May 3, 2024, at 6:54 AM, Ronald S. Bultje wrote: > > On Fri, May 3, 2024 at 7:33 AM Rémi Denis-Courmont wrote: > >> >> There is no technical plan how that would actually work in practice, and I >> don't think it is even feasible. Not to speak of a realistic plan who would >> actually

[FFmpeg-devel] RISC-V review process notice

2024-05-03 Thread Rémi Denis-Courmont
Hi, To preserve my own sanity as a volunteer, and until/unless FFmpeg moves to a different code review workflow, I will *only* be reviewing code submitted in git-format-patch format. That is to say in-line. If you do not like it, you are most welcome to support a change to a non-mail-

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: only check index_edit_rate when calculating the index tables

2024-05-03 Thread Tomas Härdin
tor 2024-05-02 klockan 23:01 +0200 skrev Marton Balint: > > > On Mon, 29 Apr 2024, Tomas Härdin wrote: > > > mån 2024-04-15 klockan 21:34 +0200 skrev Marton Balint: > > > Commit ed49391961999f028e0bc55767d0eef6eeb15e49 started rejecting > > > negative > > > index segment edit rates to avoid

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Rémi Denis-Courmont
Le perjantaina 3. toukokuuta 2024, 15.58.50 EEST Ondřej Fiala a écrit : > > And in the end, I could be wrong, but I haven't seen you doing much code > > review here. This is all about optimising the workflow for people doing > > code reviews and code merges, so why do you even care? > > Because

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Rémi Denis-Courmont
Le perjantaina 3. toukokuuta 2024, 16.54.14 EEST Ronald S. Bultje a écrit : > To clarify: I myself much prefer gitlab's workflow and would use that if it > was available. I think providing a CLI-based workflow (which Anton and some > others have requested) is feasible and fair. If an email variant

[FFmpeg-devel] [PATCH] avcodec/allcodecs: Remove LIBX264_CONST

2024-05-03 Thread Andreas Rheinhardt
Possible since 71669f2ad54d92a40dc2748cd5bd6ca4c8651231. Signed-off-by: Andreas Rheinhardt --- libavcodec/allcodecs.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index f4705651fb..b102a8069e 100644 ---

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Ronald S. Bultje
Hi, On Fri, May 3, 2024 at 7:33 AM Rémi Denis-Courmont wrote: > > > Le 3 mai 2024 14:28:59 GMT+03:00, "Ronald S. Bultje" > a écrit : > >Hi, > > > >On Fri, May 3, 2024 at 1:53 AM Rémi Denis-Courmont > wrote: > > > >> Le 2 mai 2024 21:38:13 GMT+03:00, "Ronald S. Bultje" < > rsbul...@gmail.com>

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Rémi Denis-Courmont
Le 3 mai 2024 15:58:50 GMT+03:00, "Ondřej Fiala" a écrit : >On Fri May 3, 2024 at 7:46 AM CEST, Rémi Denis-Courmont wrote: >> Le 2 mai 2024 22:32:16 GMT+03:00, "Ondřej Fiala" a écrit  >> : >> >On Thu May 2, 2024 at 4:38 PM CEST, Rémi Denis-Courmont wrote: >> >> Le torstaina 2. toukokuuta 2024,

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Ondřej Fiala
On Fri May 3, 2024 at 7:46 AM CEST, Rémi Denis-Courmont wrote: > > Since the Web and web > >browsers weren't meant for performing code review either. > > I was obviously and explicitly talking about Github and Gitlab web > applications, not the browsers. You're being ridiculous. By the way,

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Ondřej Fiala
On Thu May 2, 2024 at 10:06 PM CEST, epirat07 wrote: > On 2 May 2024, at 21:32, Ondřej Fiala wrote: > > Of course, the quality of your toolings matters a lot. If your email client > > can't pipe a bunch of emails to a shell command, it's not fit for being used > > to review git patches. On the

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Ondřej Fiala
On Fri May 3, 2024 at 7:46 AM CEST, Rémi Denis-Courmont wrote: > Le 2 mai 2024 22:32:16 GMT+03:00, "Ondřej Fiala" a écrit : > >On Thu May 2, 2024 at 4:38 PM CEST, Rémi Denis-Courmont wrote: > >> Le torstaina 2. toukokuuta 2024, 17.25.06 EEST Ondřej Fiala a écrit : > >> > On Wed May 1, 2024 at

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Rémi Denis-Courmont
Le 3 mai 2024 14:28:59 GMT+03:00, "Ronald S. Bultje" a écrit : >Hi, > >On Fri, May 3, 2024 at 1:53 AM Rémi Denis-Courmont wrote: > >> Le 2 mai 2024 21:38:13 GMT+03:00, "Ronald S. Bultje" >> a écrit : >> >On Thu, May 2, 2024 at 1:44 PM Vittorio Giovara < >> vittorio.giov...@gmail.com> >>

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-03 Thread Ronald S. Bultje
Hi, On Fri, May 3, 2024 at 1:53 AM Rémi Denis-Courmont wrote: > Le 2 mai 2024 21:38:13 GMT+03:00, "Ronald S. Bultje" > a écrit : > >On Thu, May 2, 2024 at 1:44 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > >wrote: > >> I believe the path forward would be designing a system that can >