Hello, thank you for taking the time to review my code.
I've made a new commit incorporating the code style improvements you suggested.
This includes adding spaces before pointers, removing unnecessary comments,
performing case-insensitive comparisons, applying consistent brace styles,
and adding
Update digest authentication in httpauth.c
- Refactor make_digest_auth() to support RFC 2617 and RFC 7617
- Add support for SHA-256 and SHA-512/256 algorithms along with MD5
- MD5 and SHA-256 tested, but SHA-512/256 untested due to lack of server
- Replace AVMD5 structure with AVHashContext for ha
- Updated the make_digest_auth() function to support both RFC 2617 and RFC 7617
digest authentication.
- Supports sha256 , sha512-256 along with the existing md5. MD5 and sha256 were
tested, but sha512-256 was not tested due to lack of testable server.
- AVHashContext instead of AVMD5 structure.
add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h
- make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash
- combine with lint fix patch
Signed-off-by: Eugene-bitsensing
---
libavformat/httpauth.c | 130 ++---
libavformat/httpauth.h |
- add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h
- make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash
- combine with lint fix patch
(Please ignore previous patch requests that were requested by mistake):
[FFmpeg-devel] [PATCH] fix typo(1),style(1),nit(4) issue
Sign
- typo(1) : Line 242 : RFIC7616 ->RFC7616
- style(1) : make_digest_auth() , make_digest_auth_sha() : A1hash-> a1_hash and
A2hash -> a2_hash
- nit(3) : httpauth.c: Line 245,265,389:
- nit(1) : httpauth.h: Line 85
Signed-off-by: Eugene-bitsensing
---
libavformat/httpauth.c | 34 +-
- add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h
Signed-off-by: Eugene-bitsensing
---
libavformat/httpauth.c | 116 -
libavformat/httpauth.h | 8 +++
2 files changed, 123 insertions(+), 1 deletion(-)
diff --git a/libavformat/httpauth.c
