Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

On 12/30/2017 8:44 AM, wm4 wrote: There is no POSIX error code for EOF - recv() signals EOF by simply returning 0. But libavformat recently changed its conventionts and "conventionts" -> "conventions" requires an explicit AVERROR_EOF, or it might get into an endless retry loop, consuming

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

done label: store the return value of ScheduleAudioSamples() in a local variable. Then, free outbuf if appropriate. Then handle the ScheduleAudioSamples() failure case. Eliminating the goto will also make the code easier to understand, and it will result in the memory being dealloca

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

4 VANC", OFFSET(enable_scte_104), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, DEC, "enable_scte_104"}, { NULL }, }; diff --git a/libavdevice/version.h b/libavdevice/version.h index 364404d65e..0d4477f82e 100644 --- a/libavdevice/version.h +++ b/libavdevice/version.h @@ -29,7 +29,7 @@ #define

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

input to AVERROR(). +goto error; +} else { +ctx->vanc_ctx->verbose = 0; +ctx->vanc_ctx->callbacks = +} +#endif + if (ctx->dli->StartStreams() != S_OK) { av_log(avctx, AV_LOG_ERROR, "Cannot start input stream\n"); ret = AVERROR(EIO); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

c 8.2.5) */ +sei_data[7] = 0x41; +sei_data[8] = 0xf0 | side_data->data[0]; + +return 0; +} + int64_t ff_guess_coded_bitrate(AVCodecContext *avctx) { AVRational framerate = avctx->framerate; I don't know enough about this to review the technical aspects of this c

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

udio_mode), AV_OPT_TYPE_INT, { .i64 = AUDIO_MODE_DISCRETE}, 0, 1,DEC, "audio_mode"}, +{ "discrete", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_DISCRETE}, 0, 0,DEC, "audio_mode"}, +{ "pairs

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

te, based on a similar review I did awhile back, if this set of patches only supports a specific set of video modes, then there probably ought to be checks to make sure the code changes are only exercised for those video modes. Aaron Levinson ___ ffmpe

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

. According to the blog post, it builds at least twice as fast under WSL than it does with msys2. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

On 12/9/2017 11:25 PM, Rostislav Pehlivanov wrote: On 10 December 2017 at 02:41, Aaron Levinson <alevinsn_...@levland.net> wrote: On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 201

Re: [FFmpeg-devel] [PATCH] lavc/utils: remove unnecessary locking

. This approach would also eliminate the codec_mutex memory leak. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz <mateu...@poczta.onet.pl> wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb &q

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz <mateu...@poczta.onet.pl> wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" <mateu...@poczt

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: On Thu,

Re: [FFmpeg-devel] [PATCH] configure, fftools/Makefile: Copy .pdb files to bindir for MSVC builds for make install

Ping On 10/31/2017 11:05 AM, Aaron Levinson wrote: When ffmpeg is built using MSVC, symbols are stored separately from executables and libraries in .pdb files. However, unlike with gcc-based builds, when make install is invoked, symbols, in the form of .pdb files, which are important

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

On 11/8/2017 7:20 PM, James Almer wrote: Should fix ticket #6822 Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index

Re: [FFmpeg-devel] [PATCH] Fixing small memory leak when wrapping texture in AVD3D11FrameDescriptor

base, and this issue exists there as well. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

See comments below. Aaron Levinson On 11/5/2017 4:49 PM, Marton Balint wrote: On Fri, 27 Oct 2017, Jeyapal, Karthick wrote: Please find the patch attached. Thanks, below some comments: From b18679b91a79f5e23a5ad23ae70f3862a34ddfb8 Mon Sep 17 00:00:00 2001 From: Karthick J <kj

Re: [FFmpeg-devel] [PATCH 1/2] configure: Rename wincrypt to advapi32 for consistency with existing uses of check_lib

On 10/31/2017 11:44 AM, Hendrik Leppkes wrote: On Tue, Oct 31, 2017 at 6:50 PM, Aaron Levinson <alevinsn_...@levland.net> wrote: Signed-off-by: Aaron Levinson <alevinsn_...@levland.net> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] configure, fftools/Makefile: Copy .pdb files to bindir for MSVC builds for make install

. Signed-off-by: Aaron Levinson <alevinsn_...@levland.net> --- configure| 4 +++- fftools/Makefile | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 2ac6fed98a..feb86b2069 100755 --- a/configure +++ b/configure @@ -5101,9 +5101,10 @

[FFmpeg-devel] [PATCH 2/2] configure: Fix backup libmfx MSVC build by adding advapi32 library dependency

Signed-off-by: Aaron Levinson <alevinsn_...@levland.net> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 572299c9d3..2ac6fed98a 100755 --- a/configure +++ b/configure @@ -5994,7 +5994,7 @@ enabled libk

[FFmpeg-devel] [PATCH 1/2] configure: Rename wincrypt to advapi32 for consistency with existing uses of check_lib

Signed-off-by: Aaron Levinson <alevinsn_...@levland.net> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ea22d692b9..572299c9d3 100755 --- a/configure +++ b/configure @@ -3327,7 +3327,7 @@ avformat_deps="avc

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: add support for receiving op47 teletext

On 7/3/2017 1:06 PM, Marton Balint wrote: On Mon, 3 Jul 2017, Aaron Levinson wrote: +22, and lines 318 to 335. Line 6 is the LSB in the mask. Selected lines which +do not contain teletext information will be ignored. You can use the special +@option{all} constant to select all possible

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: add support for receiving op47 teletext

, AV_LOG_ERROR, "Libzvbi support is needed for capturing teletext, please recompile FFmpeg.\n"); -return AVERROR(ENOSYS); -} -#endif - /* Check audio channel option for valid values: 2, 8 or 16 */ switch (cctx->audio_channels) {

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

22) +i = 317; } -if (i == 22) - i = 317; } vanc->Release(); if (txt_buf - txt_buf0 > 1) { Overall, looks good. I'll review the second patch in a bit. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] compat: LoadLibrary isn't available on UWP/WinRT

osed patch isn't sufficient. Plus, there is no reason to #define LOAD_LIBRARY_SEARCH_SYSTEM32 if the code won't be built anyway. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: If vfwcap_indev disabled, don't do vfw32 checks; if enabled, require vfw32

On 5/18/2017 9:21 AM, Hendrik Leppkes wrote: On Thu, May 18, 2017 at 3:18 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: On Tue, May 16, 2017 at 03:38:32PM -0700, Aaron Levinson wrote: Signed-off-by: Aaron Levinson <alevi...@aracnet.com> --- configure | 4 ++-- 1 fil

Re: [FFmpeg-devel] [PATCH] configure: If vfwcap_indev disabled, don't do vfw32 checks; if enabled, require vfw32

On 5/16/2017 4:23 PM, Steven Liu wrote: 2017-05-17 6:38 GMT+08:00 Aaron Levinson <alevi...@aracnet.com>: Signed-off-by: Aaron Levinson <alevi...@aracnet.com> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 7980

[FFmpeg-devel] [PATCH] configure: If vfwcap_indev disabled, don't do vfw32 checks; if enabled, require vfw32

Signed-off-by: Aaron Levinson <alevi...@aracnet.com> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 7980d92..49f91ac 100755 --- a/configure +++ b/configure @@ -6013,10 +6013,10 @@ check_header sys/videoio.h check_code

[FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: Don't improperly free IDirect3DSurface9 objects

ely results in memory corruption, since av_free() is being called on memory that was allocated using IDirectXVideoAccelerationService::CreateSurface(). Signed-off-by: Aaron Levinson <alevi...@aracnet.com> --- libavutil/hwcontext_dxva2.c | 9 - 1 file changed, 8 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: No longer improperly freeing IDirect3DSurface9 objects

Please disregard--I will submit a new patch with a better commit message. Aaron On 5/16/2017 4:09 AM, Aaron Levinson wrote: Purpose: No longer improperly freeing IDirect3DSurface9 objects in hwcontext_dxva2.c. Added dxva2_pool_release_dummy() and using it in call to av_buffer_create

[FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: No longer improperly freeing IDirect3DSurface9 objects

ear to result in a crash when the release version of the C-runtime is used on Windows, it likely results in memory corruption, since av_free() is being called on memory that was allocated using IDirectXVideoAccelerationService::CreateSurface(). Signed-off-by: Aaron Levinson <alevi...@aracn

Re: [FFmpeg-devel] FFMpeg GPL license Violations by Android apps

the source code that was used to build the FFmpeg binaries that were shipped with the app. Aaron Levinson On Mon, May 15, 2017 at 1:38 PM, Kieran Kunhya <kier...@obe.tv> wrote: Hi, Out of interest, how did you automate this process? Is it as simple as looking for the FFmpeg configure

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 5/12/2017 5:51 PM, Michael Niedermayer wrote: On Fri, May 12, 2017 at 01:19:43PM -0700, Aaron Levinson wrote: On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I created

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Made execution of reap_filters() more deterministic with respect to when headers are written

tream's codecpar (mux_par->field_order in do_video_out()). However, check_init_output_file() calls avformat_write_header() prior to the initial call to do_video_out(), so field_order is populated too late, and the header is written with the default field_order value, progressive. Signed-off-by: Aa

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from init_output_stream()

Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson <al

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

Please disregard--I messed up the subject. I'll send a new one. Aaron Levinson On 5/12/2017 1:22 PM, Aaron Levinson wrote: Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson <al

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I created the first version of the patch on March 26th, this was the first patch that I submitted to ffmpeg, and some aspects were

Re: [FFmpeg-devel] [PATCH] configure: jni no longer requires -ldl

e_pkg_config libass ass/ass.h ass_library_init LGTM--I see that the use of dl was eliminated in 33d69a9 (at https://github.com/FFmpeg/FFmpeg/commit/33d69a90085d30af8a292d9364b835a26565d6b9 ). Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: move old_filename free operation earlier

On 5/10/2017 3:33 AM, Steven Liu wrote: Suggested-by: Aaron Levinson <alevi...@aracnet.com> Signed-off-by: Steven Liu <l...@chinaffmpeg.org> --- libavformat/hlsenc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hl

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix memleak

te any subsequent calls to av_free(old_filename). } ret = ff_write_chained(oc, stream_index, pkt, s, 0); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

that use '\' for multi-line TAG spans, and in addition, there is no mention of '\' anywhere in the actual grammar documented in the specification. So, it seems that that this patch isn't needed. Aaron Levinson On 5/9/2017 1:01 PM, Aaron Levinson wrote: I would rewrite the commit message

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

F:8.64, out1.ts #EXTINF:9.16, out2.ts Reported-by: Aaron Levinson <alevi...@aracnet.com> Signed-off-by: Steven Liu <l...@chinaffmpeg.org> --- libavformat/hlsenc.c | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsen

Re: [FFmpeg-devel] [PATCH] videotoolbox: add hwcontext support

Are you also planning to change ffmpeg_videotoolbox.c? See below for more comments. Aaron Levinson On 5/2/2017 8:26 PM, wm4 wrote: This adds tons of code for no other benefit than making VideoToolbox support conform with the new hwaccel API (using hw_device_ctx and hw_frames_ctx). Since

[FFmpeg-devel] [PATCH 2/2] qsvenc: Make sure the interlaced encoding works

From 30eb78bac7bd92b0c085ba6873341e8319072acc Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Fri, 5 May 2017 21:31:30 -0700 Subject: [PATCH 2/2] qsvenc: Make sure the interlaced encoding works Purpose: qsvenc: make sure that interlaced encoding works. Also,

[FFmpeg-devel] [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters

From 2882d77d76805e74fe139f6763f91c39746bebaf Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Fri, 5 May 2017 18:49:57 -0700 Subject: [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters Purpose: Fill out the default/unset parameters wit

Re: [FFmpeg-devel] [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding

Please disregard this patch--I'm submitting two new patches that have already been reviewed and applied to libav. Aaron Levinson On 4/13/2017 11:36 PM, Aaron Levinson wrote: From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com>

Re: [FFmpeg-devel] [PATCH] build: remove --enable-raise-major configure option

ncoder bug fix that matters for the decoder). The third component always starts at 100 to distinguish FFmpeg from Libav." Note that my review only covers the content of the patch, and I don't know whether or not it makes sense to discontinue this practice. Aaron Levinson __

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 5/5/2017 2:26 AM, wm4 wrote: On Fri, 5 May 2017 01:11:17 -0700 Aaron Levinson <alevi...@aracnet.com> wrote: As I said on IRC, I'm skeptic against this, but I'm also not sure whether I understand the situation. First, your change seems a bit fragile, and almost relies on coinci

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

On 5/5/2017 4:50 AM, Michael Niedermayer wrote: > On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote: >> On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch <u...@pkh.me> wrote: >>> On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: >>> [.

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

On 5/5/2017 4:57 PM, Marton Balint wrote: > > > On Fri, 5 May 2017, Aaron Levinson wrote: > >> On 4/16/2017 4:11 PM, Aaron Levinson wrote: >>> On 4/15/2017 6:13 AM, Aaron Levinson wrote: >>>> On 4/15/2017 4:19 AM, Marton Balint wrote: >>>&g

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

The entire patch set LGTM. Aaron Levinson On 5/3/2017 6:41 PM, James Almer wrote: On 5/3/2017 9:39 PM, Aaron Levinson wrote: James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Patch 2 depends on 1. Patches 3

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

On 5/5/2017 12:57 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: [...] Back to your issue: you should fix the .pc in the upstream project, this is the correct fix. The "upstream project" in this case is the Intel Media SDK. This is not an o

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 5/5/2017 12:55 AM, wm4 wrote: On Thu, 4 May 2017 23:46:30 -0700 Aaron Levinson <alevi...@aracnet.com> wrote: On 4/12/2017 6:08 PM, Aaron Levinson wrote: On 3/26/2017 10:34 AM, Aaron Levinson wrote: On 3/26/2017 4:41 AM, Matthias Hunstock wrote: Am 26.03.2017 um 11:50 schrieb

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote: 2017-05-05 9:42 GMT+02:00 Aaron Levinson <alevi...@aracnet.com>: On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson <alevi...@aracnet.com>: On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! At

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

On 5/5/2017 12:42 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: On 4/19/2017 10:43 AM, Aaron Levinson wrote: On 4/14/2017 6:51 PM, Aaron Levinson wrote: From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson <alevi...@aracnet.com>: On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In fu

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

On 4/16/2017 4:11 PM, Aaron Levinson wrote: > On 4/15/2017 6:13 AM, Aaron Levinson wrote: >> On 4/15/2017 4:19 AM, Marton Balint wrote: >>> >>> On Thu, 13 Apr 2017, Aaron Levinson wrote: >>> >>>> On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: >&

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

On 4/19/2017 10:43 AM, Aaron Levinson wrote: > On 4/14/2017 6:51 PM, Aaron Levinson wrote: >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson <alevi...@aracnet.com> >> Date: Fri, 14 Apr 2017 18:38:37 -0700 >> Subjec

Re: [FFmpeg-devel] [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install

On 4/14/2017 6:27 PM, Aaron Levinson wrote: From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Fri, 14 Apr 2017 18:14:21 -0700 Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 4/12/2017 6:08 PM, Aaron Levinson wrote: > On 3/26/2017 10:34 AM, Aaron Levinson wrote: >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: >>>> When using the following command to play back either file: >>

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

On 5/2/2017 2:29 PM, wm4 wrote: On Tue, 2 May 2017 14:17:33 -0700 Aaron Levinson <alevi...@aracnet.com> wrote: On 5/1/2017 11:06 PM, MFojtak wrote: Currently this muxer does not work at all. I don't know if 000Z would make it compatible with more player as I don't know any. However, ad

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

On 5/4/2017 9:15 PM, Steven Liu wrote: 2017-05-03 9:49 GMT+08:00 Aaron Levinson <alevi...@aracnet.com>: On 4/27/2017 7:21 PM, Steven Liu wrote: 2017-04-26 7:30 GMT+08:00 Steven Liu <l...@chinaffmpeg.org>: fix ticket id: #6353 Signed-off-by: Steven Liu <l...@

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

its not a big deal to have a little waste here. The buffer size should match the format specification. An alternative would be to use "%02hd" or "%02hhd", but doing so would require casts or using different types for hh, mm, etc. Aaron Levinson __

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

TY : NAN); In order to preserve the original logic, why not do the following: +num = den ? num * intnum / den : (((num * intnum) != 0) ? INFINITY : NAN); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Thanks, Aaron Levinson On 5/2/2017 2:55 PM, James Almer wrote: Some changes and fixes suggested on IRC. Some patches are v3 as they have been sent before

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

On 4/21/2017 2:03 PM, James Almer wrote: On 4/21/2017 12:09 PM, Michael Niedermayer wrote: On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Thu, 20 Ap

[FFmpeg-devel] [PATCH] doc: Enhanced fate.texi to reference Windows line endings section from git-howto.texi

From 345a98d31c6c758f0f82edab1b502cd8aeb3354b Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Wed, 3 May 2017 12:38:39 -0700 Subject: [PATCH] doc: Enhanced fate.texi to reference Windows line endings section from git-howto.texi Purpose: Enhanced fate.texi to in

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

On 4/22/2017 12:22 PM, Aaron Levinson wrote: On 4/22/2017 12:09 PM, Hendrik Leppkes wrote: On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson <alevi...@aracnet.com> wrote: On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

I don't seem to have the original e-mail in my inbox anymore, so I'll respond to wm4's response. Overall, the new code is a lot cleaner and easier to understand than the existing code. See below for more. Aaron Levinson On 5/2/2017 5:04 PM, wm4 wrote: On Fri, 28 Apr 2017 21:27:56 -0300

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

of(hls->key_uri)). In addition, based on the EXT-X-KEY example at https://developer.apple.com/library/content/technotes/tn2288/_index.html , it would appear that an EXT-X-KEY declaration may span multiple lines. Your solution will not work properly in this case. Aaron Levins

Re: [FFmpeg-devel] [PATCH]configure: Fix libopus detection

hough such a build would be possible. It is true that the approach currently taken in configure doesn't distinguish between encoding and decoding, but the patch as originally proposed just trades decoding API requirements for encoding API requirements. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

fully someone else will do so. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]compat/strtod: Add missing const qualifiers

On 5/1/2017 1:51 AM, Carl Eugen Hoyos wrote: Hi! Even without the casts, the patch reduces the number of warnings shown when compiling compat/strtod from seven to three. Please comment, Carl Eugen LGTM Aaron Levinson ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

buf, size, "%Y-%m-%dT%H:%M:%S.000Z", ptm)) Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

On 4/26/2017 12:47 PM, James Almer wrote: On 4/26/2017 2:46 AM, Aaron Levinson wrote: On 4/24/2017 3:47 PM, James Almer wrote: Free coded_frame, coded_side_data and unref hw_device_ctx to prevent potential leaks. Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/options.

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CID 1405135

copy up to max LINE_BUFFER_SIZE characters and make sure the string is null-terminated in that case. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

> 0) { \ I'm not sure if this patch is intended to be a replacement for your last "2/2" patch, but this version is missing the the coded_side_data population code that was in the first version of your "2/2" patch. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [rfc] coc violation tribunal

n and move forward. Its one thing to fire off an e-mail--its another to say things to someone's "face", so to speak. I'd also suggest, when passions are up, to step aside and then maybe come back to it later. Aaron Levinson ___ ffmpeg-devel

Re: [FFmpeg-devel] [RFC] Reviewing merges

was to contribute it to libav first. But, if this patch has to pass yet another round of code reviews, code reviews that weren't forthcoming in the first place on ffmpeg-devel when I originally submitted the patch, then that could be problematic. Aaron Levinson

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: copy the coded_side_data in avcodec_copy_context()

ink you can fix this by setting dest->coded_side_data to NULL and dest->nb_coded_side_data to 0. Everything else looks good. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/options: factorize avcodec_copy_context cleanup code

I guess that would have been a preexisting issue with this function and not really relevant for this patch. And this function is deprecated anyway. If there is no issue with the additional call to av_buffer_unref(), as mentioned above, this patch looks good. Aaron Levinson __

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

On 4/22/2017 12:09 PM, Hendrik Leppkes wrote: On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson <alevi...@aracnet.com> wrote: On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] diff --git a/doc/fate.texi b/doc/fate.texi

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] diff --git a/doc/fate.texi b/doc/fate.texi index 7a96c25..f3b8c0c8 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate @float NOTE

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

se accessors at all. Then why have the accessors at all if the fields are public? As far as I can tell, the benefit to using these accessors is that, if certain properties become internal in the future, or variable names change, or the structures become opaque, etc, the code will continue to w

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

Note that in case it wasn't clear, I confirmed that this patch works by running make on Linux and examining both the generated text file and the generated HTML file in a Web browser. Aaron On 4/21/2017 4:48 PM, Aaron Levinson wrote: On 4/21/2017 4:17 PM, Lou Logan wrote: On Fri, 21 Apr 2017

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

On 4/21/2017 4:17 PM, Lou Logan wrote: > On Fri, 21 Apr 2017 16:05:16 -0700 > Aaron Levinson <alevi...@aracnet.com> wrote: > >> From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson <alevi...@aracnet.com> >> Date: Fri

[FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Fri, 21 Apr 2017 15:55:11 -0700 Subject: [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set t

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

On 4/19/2017 2:27 PM, Marton Balint wrote: On Mon, 17 Apr 2017, James Almer wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <al

[FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Thu, 20 Apr 2017 23:20:20 -0700 Subject: [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined Purpose: Fixed memory leaks asso

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

On 4/14/2017 6:51 PM, Aaron Levinson wrote: From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Fri, 14 Apr 2017 18:38:37 -0700 Subject: [PATCH] Added require fallback for libmfx in the case that pkg-config cannot find

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

On 4/17/2017 8:28 AM, wm4 wrote: On Mon, 17 Apr 2017 12:06:59 -0300 James Almer <jamr...@gmail.com> wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 200

[FFmpeg-devel] [PATCH] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Sun, 16 Apr 2017 17:13:31 -0700 Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1 Purpose: libavutil/thread.h: Fixed g++

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

I'll try that again with [PATCH] in the subject line. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson <alevi...@aracnet.com> Date: Sun, 16 Apr 2017 17:13:31 -0700 Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1 Purpose: libavutil/thread.h: Fixed g++

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

On 4/16/2017 4:25 PM, Aaron Levinson wrote: On 4/16/2017 3:31 PM, Hendrik Leppkes wrote: On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson <alevi...@aracnet.com> wrote: On 4/16/2017 1:33 PM, Timo Rothenpieler wrote: Thanks, applied. Regards, Marton This seems to have broken the co

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

On 4/16/2017 3:31 PM, Hendrik Leppkes wrote: On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson <alevi...@aracnet.com> wrote: On 4/16/2017 1:33 PM, Timo Rothenpieler wrote: Thanks, applied. Regards, Marton This seems to have broken the coverity builds: https://travis-ci.org/FFmpeg/

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

On 4/15/2017 6:13 AM, Aaron Levinson wrote: > On 4/15/2017 4:19 AM, Marton Balint wrote: >> >> On Thu, 13 Apr 2017, Aaron Levinson wrote: >> >>> On 4/13/2017

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

On 4/16/2017 1:33 PM, Timo Rothenpieler wrote: Thanks, applied. Regards, Marton This seems to have broken the coverity builds: https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds/222597943#L1103 It was suggested on IRC by James Almer that "it seems to complain about ubitux's 'strict'

  1   2   >