Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-15 Thread Adam Richter
On Tue, May 14, 2019 at 6:48 PM myp...@gmail.com wrote: > > On Wed, May 15, 2019 at 7:01 AM Hendrik Leppkes wrote: > > > > On Tue, May 14, 2019 at 11:25 PM Adam Richter > > wrote: > > > > > > Consider, for example, if you agree that columnizatio

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-14 Thread Adam Richter
On Sun, May 12, 2019 at 11:16 AM Michael Niedermayer wrote: > > On Sun, May 12, 2019 at 05:58:50PM +0100, Mark Thompson wrote: > > On 12/05/2019 16:24, Adam Richter wrote: > > > This patch separates statements of the form "assert(a && b);" into > &g

Re: [FFmpeg-devel] [PATCH] libswcale: Fix possible string overflow in test

2019-05-13 Thread Adam Richter
wrote: > > On Sun, May 12, 2019 at 05:40:00AM -0700, Adam Richter wrote: > > This is a possible fix for a string overflow in some sscanf calls in > > libswcale/tests/swscale.c, in the function fileTest(), found by > > cppcheck. Please see the attachment for more discussion

[FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-12 Thread Adam Richter
81a19cfd191b9f97e246b307b71d6c790 Mon Sep 17 00:00:00 2001 From: Adam Richter Date: Sun, 12 May 2019 08:02:51 -0700 Subject: [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat. This patch separates statements of th

[FFmpeg-devel] [PATCH] libavformat: Separate assertions of the form "av_assertN(a && b)" to "av_assertN(a); av_assertN(b)" for more precise diagnostics.

2019-05-12 Thread Adam Richter
have confirmed that the resulting tree built without any apparent complaints about the assert statements and that "make fate" completed with a zero exit code. I have not done any other tests though. Thanks in advance for considering this patch. Adam From edb58a5ee8030ec66c04736a025d2a44

[FFmpeg-devel] [PATCH] libswcale: Fix possible string overflow in test

2019-05-12 Thread Adam Richter
Mon Sep 17 00:00:00 2001 From: Adam Richter Date: Sun, 12 May 2019 05:03:25 -0700 Subject: [PATCH] libswcale: Fix possible string overflow in test. In libswcale/tests/swcale.c, the function fileTest() calls sscanf in an argument of "%12s" on character srcStr[] and dstStr[], which are onl