Re: [FFmpeg-devel] [PATCH] configure: Fix debugging on mingw-w64 with gdb

2016-03-28 Thread Alex Smith
I think the logic is correct but I won't be able to test it with the changes until tomorrow. I wanted to get the patch on the ML as soon as possible since debugging is currently broken. As I mentioned in the original patch thread I'll see about taking another stab at binutils to see if this can't

[FFmpeg-devel] [PATCH] configure: Fix debugging on mingw-w64 with gdb

2016-03-28 Thread Alex Smith
ng it outright if it proves to be more trouble than it's worth. For now keeping it enabled for release builds is a reasonable trade off. Signed-off-by: Alex Smith --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e550547..e8c4

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-28 Thread Alex Smith
On Sun, Mar 20, 2016 at 6:29 AM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > > > I understand the sentiment, and there's probably little lost in > keeping it, but... is it not a hack? ie: > - When do you notice the added security is no longer there/it breaks > in even worse ways? >

[FFmpeg-devel] [PATCH 2/3 v2] configure: Support for HEASLR on mingw targets

2015-09-25 Thread Alex Smith
From: Alex Smith The appropriate flag for HEASLR (--high-entropy-va) was added in binutils 2.25. Also set the image base >4GB so higher entropy gets applied to image base randomization when used with HEASLR (8 -> 17 bits of randomization). Windows does this for compatibility because of &

[FFmpeg-devel] [PATCH] configure: Combine dynamicbase and nxcompat checks

2015-09-25 Thread Alex Smith
They were added to binutils in the same version so it's safe to combine. Signed-off-by: Alex Smith --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 3339126..b572d59 100755 --- a/configure +++ b/configure @@ -4367,8 +4367,6 @@

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2015-09-22 Thread Alex Smith
On Tue, Sep 22, 2015 at 7:43 PM, Michael Niedermayer wrote: > > > this is ugly, but ASLR is important thus applied > i did not apply the nxcompat dynamicbase merge as its unrelated > > Thanks > > PS: if this breaks some version of mingw then this should be reverted > > [...] > > The only thing I'm

[FFmpeg-devel] [PATCH 3/3] configure: Disable automatic image base calculation

2015-09-20 Thread Alex Smith
From: Alex Smith There's no reason for it. ASLR will rebase it regardless so "preventing collisions" isn't really relevant. This also brings it in line with what a msvc produced dll will have (an image base of 0x1000). Signed-off-by: Alex Smith --- configure | 2 +

[FFmpeg-devel] [PATCH 2/3] configure: Support for HEASLR on mingw targets

2015-09-20 Thread Alex Smith
From: Alex Smith The appropriate flag for HEASLR (--high-entropy-va) is scheduled for inclusion in the next version of binutils (2.25), doesn't hurt to include it a little early. Also set the image base >4GB so higher entropy gets applied to image base randomization when used with H

[FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2015-09-20 Thread Alex Smith
From: Alex Smith Binutils will always strip the relocation information from executable files even if it needs it (dynamicbase/ASLR). We can work around this by using the pic-executable flag combined with setting the correct entry point since apparently ld forgets what that should be. This