Re: [FFmpeg-devel] [PATCH 01/11] avformat/dashenc: renamed 'min_seg_duration' to 'seg_duration'

2018-03-23 Thread Aurelien Jacobs
On Fri, Mar 23, 2018 at 02:32:30PM +0800, Steven Liu wrote: > > > > On 23 Mar 2018, at 13:20, vdi...@akamai.com wrote: > > > > From: Vishwanath Dixit > > > > --- > > doc/muxers.texi | 2 +- > > libavformat/dashenc.c | 10 +- > > 2 files changed, 6

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-23 Thread Aurelien Jacobs
On Fri, Mar 23, 2018 at 10:18:47AM +0100, Paul B Mahol wrote: > On 3/22/18, Aurelien Jacobs <au...@gnuage.org> wrote: > > On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote: > >> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote: > >> > Signed-of

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: added alpha decompanding in rgba12

2018-03-22 Thread Aurelien Jacobs
On Wed, Mar 21, 2018 at 10:19:58PM +0530, Gagandeep Singh wrote: > alpha decompanding curve added to post process the decoded alpha channel > --- > libavcodec/cfhd.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-22 Thread Aurelien Jacobs
On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote: > On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > doc/filters.texi | 60 ++ > > libavfilter/Makefile | 1 + > > libavfilter/af_hrtfm.c | 486 > >

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: only accept full us duration, do not accept mss duration

2018-03-07 Thread Aurelien Jacobs
On Thu, Mar 08, 2018 at 12:14:00AM +0100, Hendrik Leppkes wrote: > On Thu, Mar 8, 2018 at 12:05 AM, Aurelien Jacobs <au...@gnuage.org> wrote: > > On Wed, Mar 07, 2018 at 11:45:03PM +0100, Marton Balint wrote: > >> > >> > >> On Wed, 7 Mar 2018, Aurelie

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: only accept full us duration, do not accept mss duration

2018-03-07 Thread Aurelien Jacobs
On Wed, Mar 07, 2018 at 11:45:03PM +0100, Marton Balint wrote: > > > On Wed, 7 Mar 2018, Aurelien Jacobs wrote: > > > On Tue, Mar 06, 2018 at 01:02:48AM +0100, Marton Balint wrote: > > > Accepting 'u' suffix for a time specification is neither intuitive nor > >

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: only accept full us duration, do not accept mss duration

2018-03-07 Thread Aurelien Jacobs
On Tue, Mar 06, 2018 at 01:02:48AM +0100, Marton Balint wrote: > Accepting 'u' suffix for a time specification is neither intuitive nor > consistent (now that we don't accept m). The 'm' SI prefix is still accepted in various time options, and the 'u' prefix is still accepted in those options

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-07 Thread Aurelien Jacobs
On Mon, Mar 05, 2018 at 08:46:43PM +, Rostislav Pehlivanov wrote: > On 3 March 2018 at 16:20, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Thu, Mar 01, 2018 at 10:46:07PM +, Rostislav Pehlivanov wrote: > > > On 1 March 2018 at 20:45, Aurelien Jaco

Re: [FFmpeg-devel] [PATCH] parseutils: accept only full "ms" and "us" prefixes

2018-03-05 Thread Aurelien Jacobs
On Sat, Mar 03, 2018 at 08:19:43PM +, Rostislav Pehlivanov wrote: > The commit which added those was pushed prematurely before anyone could object > to illogical suffixes like just m for milliseconds. What you call illogical is following the same convention as pretty much all numeric

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-03 Thread Aurelien Jacobs
On Thu, Mar 01, 2018 at 10:46:07PM +, Rostislav Pehlivanov wrote: > On 1 March 2018 at 20:45, Aurelien Jacobs <au...@gnuage.org> wrote > > > > > So what I propose is to rename sbc_delay to sbc_latency (for example), > > and to add a opus_latecy using AV_OPT_TYP

Re: [FFmpeg-devel] [PATCH] parseutils: add support for ms and us suffix for AV_OPT_TYPE_DURATION

2018-03-03 Thread Aurelien Jacobs
On Fri, Mar 02, 2018 at 11:59:33PM +0100, Marton Balint wrote: > > On Fri, 2 Mar 2018, Hendrik Leppkes wrote: > > > On Fri, Mar 2, 2018 at 11:19 PM, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Fri, Mar 02, 2018 at 10:02:58PM +, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH] parseutils: add support for ms and us suffix for AV_OPT_TYPE_DURATION

2018-03-03 Thread Aurelien Jacobs
On Fri, Mar 02, 2018 at 11:28:29PM +0100, Hendrik Leppkes wrote: > On Fri, Mar 2, 2018 at 11:19 PM, Aurelien Jacobs <au...@gnuage.org> wrote: > > On Fri, Mar 02, 2018 at 10:02:58PM +, Rostislav Pehlivanov wrote: > >> On 2 March 2018 at 21:57, Aurelien Jacobs

Re: [FFmpeg-devel] [PATCH] parseutils: add support for ms and us suffix for AV_OPT_TYPE_DURATION

2018-03-02 Thread Aurelien Jacobs
On Fri, Mar 02, 2018 at 10:02:58PM +, Rostislav Pehlivanov wrote: > On 2 March 2018 at 21:57, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Fri, Mar 02, 2018 at 09:39:48PM +0100, Michael Niedermayer wrote: > > > On Thu, Mar 01, 2018 at 09:41:20PM +

Re: [FFmpeg-devel] [PATCH] parseutils: add support for ms and us suffix for AV_OPT_TYPE_DURATION

2018-03-02 Thread Aurelien Jacobs
On Fri, Mar 02, 2018 at 09:39:48PM +0100, Michael Niedermayer wrote: > On Thu, Mar 01, 2018 at 09:41:20PM +0100, Aurelien Jacobs wrote: > > supported suffixes are: > > - s: seconds (default when no suffix specified) > > - m or ms: milliseconds > > - u or us: microsec

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-01 Thread Aurelien Jacobs
On Thu, Mar 01, 2018 at 01:27:06AM +, Rostislav Pehlivanov wrote: > On 28 February 2018 at 23:34, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Wed, Feb 28, 2018 at 12:59:40AM +, Rostislav Pehlivanov wrote: > > > On 27 February 2018 at 23:56, Aurelien Jaco

[FFmpeg-devel] [PATCH] parseutils: add support for ms and us suffix for AV_OPT_TYPE_DURATION

2018-03-01 Thread Aurelien Jacobs
supported suffixes are: - s: seconds (default when no suffix specified) - m or ms: milliseconds - u or us: microseconds --- libavutil/parseutils.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c index

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-28 Thread Aurelien Jacobs
On Wed, Feb 28, 2018 at 12:59:40AM +, Rostislav Pehlivanov wrote: > On 27 February 2018 at 23:56, Aurelien Jacobs <au...@gnuage.org> wrote: > > > > > So I've updated the patch with only a msbc and a delay option and > > I've added some sane parameters decisions,

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-27 Thread Aurelien Jacobs
On Sat, Feb 24, 2018 at 09:31:30PM +, Rostislav Pehlivanov wrote: > On 24 February 2018 at 12:01, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Thu, Feb 22, 2018 at 06:18:48PM +, Rostislav Pehlivanov wrote: > > > On 21 February 2018 at 22:37, Aurelien Jaco

Re: [FFmpeg-devel] [PATCH 7/9] sbcenc: add MMX optimizations

2018-02-24 Thread Aurelien Jacobs
On Thu, Feb 22, 2018 at 05:21:57PM +, Rostislav Pehlivanov wrote: > On 21 February 2018 at 22:37, Aurelien Jacobs <au...@gnuage.org> wrote: > [...] > > +;*** > > +;void ff_sbc_analyze_4(const int16_t

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-24 Thread Aurelien Jacobs
On Thu, Feb 22, 2018 at 06:18:48PM +, Rostislav Pehlivanov wrote: > On 21 February 2018 at 22:37, Aurelien Jacobs <au...@gnuage.org> wrote: > > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > doc/general.texi |

[FFmpeg-devel] [PATCH 9/9] Changelog: list the new SBC codec

2018-02-21 Thread Aurelien Jacobs
--- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 2acdbbea30..163cc77880 100644 --- a/Changelog +++ b/Changelog @@ -39,6 +39,7 @@ version : - Removed the ffmenc and ffmdec muxer and demuxer - VideoToolbox HEVC encoder and hwaccel - VAAPI-accelerated

[FFmpeg-devel] [PATCH 6/9] sbc: add raw muxer for SBC

2018-02-21 Thread Aurelien Jacobs
--- doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 13 + 4 files changed, 16 insertions(+), 1 deletion(-) diff --git a/doc/general.texi b/doc/general.texi index bf62288f64..118bfd8bd9 100644 ---

[FFmpeg-devel] [PATCH 7/9] sbcenc: add MMX optimizations

2018-02-21 Thread Aurelien Jacobs
* SIMD optimized SBC encoder DSP functions +;* +;* Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> +;* Copyright (C) 2008-2010 Nokia Corporation +;* Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +;* Copyright (C) 2004-2005 Henryk Ploetz <hen...@ploetzli.ch>

[FFmpeg-devel] [PATCH 3/9] sbc: add parser for SBC

2018-02-21 Thread Aurelien Jacobs
@@ -0,0 +1,124 @@ +/* + * SBC parser + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by th

[FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-21 Thread Aurelien Jacobs
) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-2010 Nokia Corporation + * Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> + * Copyright (C) 2004-2005 Henryk Ploetz <hen...@ploetzli.ch> + *

[FFmpeg-devel] [PATCH 8/9] sbcenc: add armv6 and neon asm optimizations

2018-02-21 Thread Aurelien Jacobs
--- /dev/null +++ b/libavcodec/arm/sbcdsp_init_arm.c @@ -0,0 +1,105 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2008-2010 Nokia Corporation + * Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +

[FFmpeg-devel] [PATCH 4/9] sbc: add raw demuxer for SBC

2018-02-21 Thread Aurelien Jacobs
; extern AVInputFormat ff_scc_demuxer; extern AVOutputFormat ff_scc_muxer; diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c new file mode 100644 index 00..ae74a220dc --- /dev/null +++ b/libavformat/sbcdec.c @@ -0,0 +1,33 @@ +/* + * RAW SBC demuxer + * Copyright (C) 2017 Aurelien

[FFmpeg-devel] [PATCH 2/9] sbc: implement SBC decoder (low-complexity subband codec)

2018-02-21 Thread Aurelien Jacobs
odec/sbc.c b/libavcodec/sbc.c new file mode 100644 index 00..f7dba79f4f --- /dev/null +++ b/libavcodec/sbc.c @@ -0,0 +1,271 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corpora

[FFmpeg-devel] [PATCH 1/9] crc: add AV_CRC_8_SBC as a 8 bits CRC with polynomial 0x1D

2018-02-21 Thread Aurelien Jacobs
--- libavutil/crc.c | 26 ++ libavutil/crc.h | 1 + libavutil/tests/crc.c | 7 --- tests/ref/fate/crc| 1 + 4 files changed, 32 insertions(+), 3 deletions(-) diff --git a/libavutil/crc.c b/libavutil/crc.c index d44550c9c0..c45ea63a62 100644 ---

[FFmpeg-devel] SBC codec reworked

2018-02-21 Thread Aurelien Jacobs
Hi, I finnally came back to this SBC codec patchset. I made the changes to only have one CODEC_ID for both sbc and msbc. I think I took care of all the remarks from previous review. Any more comments ? ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for aptx.c

2018-02-10 Thread Aurelien Jacobs
On Fri, Feb 09, 2018 at 10:27:39PM +0100, Aurelien Jacobs wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ba7a7284eb..b691bd56ec 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -139,6 +1

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself for aptx.c

2018-02-09 Thread Aurelien Jacobs
Jaikrishnan Menon alsdec.c Thilo Borgmann, Umair Khan + aptx.cAurelien Jacobs ass* Aurelien Jacobs asv* Michael Niedermayer atrac3plus

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-02-09 Thread Aurelien Jacobs
On Mon, Feb 05, 2018 at 12:27:20AM +0100, Michael Niedermayer wrote: > On Sun, Feb 04, 2018 at 04:07:26PM +0100, Aurelien Jacobs wrote: > > On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote: > > > On 20 January 2018 at 17:26, Aurelien Jacobs <au

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-02-04 Thread Aurelien Jacobs
On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote: > On 20 January 2018 at 17:26, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote: > > > 2018-01-14 14:06 GMT+01:00 Aureli

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-20 Thread Aurelien Jacobs
On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote: > 2018-01-14 14:06 GMT+01:00 Aurelien Jacobs <au...@gnuage.org>: > > > Well, here is an updated patch which uses codec tags for the decoder and > > profile for the encoder. > > Sorry but I obj

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-20 Thread Aurelien Jacobs
On Sun, Jan 14, 2018 at 05:19:12PM +, Rostislav Pehlivanov wrote: > On 14 January 2018 at 13:06, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote: > > > On 9 January 2018 at 14:07, Rostislav Pehl

Re: [FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

2018-01-14 Thread Aurelien Jacobs
On Sun, Jan 07, 2018 at 04:55:43PM +0100, Aurelien Jacobs wrote: > On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote: > > On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote: > > > --- > > > Changelog| 2 +- > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-14 Thread Aurelien Jacobs
parameter, the encoding will just fail but user will have to guess how to fix it. And the reported stream is much less explicit: Stream #0:0: Audio: aptx ([36][0][215][0] / 0xD70024), 48000 Hz, 2 channels, s32p vs. Stream #0:0: Audio: aptx_hd, 48000 Hz, 2 channels, s32p So for the good of user

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-08 Thread Aurelien Jacobs
On Mon, Jan 08, 2018 at 12:38:19AM +, Rostislav Pehlivanov wrote: > On 7 January 2018 at 22:54, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote: > > > On 6 January 2018 at 16:48, Aurelien Jaco

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-08 Thread Aurelien Jacobs
On Mon, Jan 08, 2018 at 01:27:16PM +0100, Carl Eugen Hoyos wrote: > 2018-01-08 11:32 GMT+01:00 Hendrik Leppkes : > > On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov > > wrote: > >> > >> That's okay - for encoding switch the profile depending on both

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-07 Thread Aurelien Jacobs
On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote: > On 6 January 2018 at 16:48, Aurelien Jacobs <au...@gnuage.org> wrote: > > > --- > > Changelog | 2 +- > > configure | 2 + > > libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

2018-01-07 Thread Aurelien Jacobs
On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote: > On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote: > > --- > > Changelog| 2 +- > > libavformat/Makefile | 2 ++ > > libavformat/allformats.c | 1 + > &g

[FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

2018-01-06 Thread Aurelien Jacobs
--- Changelog| 2 +- libavformat/Makefile | 2 ++ libavformat/allformats.c | 1 + libavformat/aptxdec.c| 51 libavformat/rawenc.c | 13 5 files changed, 64 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/5] aptx: factorize FFABS calculation

2018-01-06 Thread Aurelien Jacobs
--- libavcodec/aptx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c index 7b9556ce42..64a63a7d5b 100644 --- a/libavcodec/aptx.c +++ b/libavcodec/aptx.c @@ -462,10 +462,12 @@ static void aptx_quantize_difference(Quantize

[FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-06 Thread Aurelien Jacobs
--- Changelog | 2 +- configure | 2 + libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/aptx.c | 352 libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + 7 files

[FFmpeg-devel] [PATCH 3/5] aptx: do some clipping to match original codec in extreme cases

2018-01-06 Thread Aurelien Jacobs
--- libavcodec/aptx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c index 64a63a7d5b..4173402d03 100644 --- a/libavcodec/aptx.c +++ b/libavcodec/aptx.c @@ -466,6 +466,7 @@ static void aptx_quantize_difference(Quantize *quantize,

[FFmpeg-devel] (no subject)

2018-01-06 Thread Aurelien Jacobs
This patchset add support for the aptX HD codec. This codec is a variation of the aptX codec using less aggressive quantization and thus producing higher bitrate and higher quality. The first 3 patches are simple cleanup / preparatory work. [PATCH 1/5] aptx: simplify by pre-calculating

[FFmpeg-devel] [PATCH 1/5] aptx: simplify by pre-calculating factor_max

2018-01-06 Thread Aurelien Jacobs
--- libavcodec/aptx.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c index a35d2861c1..7b9556ce42 100644 --- a/libavcodec/aptx.c +++ b/libavcodec/aptx.c @@ -188,7 +188,7 @@ typedef const struct { const int32_t

Re: [FFmpeg-devel] [PATCH 6/9] sbc: add raw muxer for SBC

2017-12-26 Thread Aurelien Jacobs
On Mon, Dec 25, 2017 at 12:43:18PM +, Rostislav Pehlivanov wrote: > On 23 December 2017 at 18:01, Aurelien Jacobs <au...@gnuage.org> wrote: > > > --- > > doc/general.texi | 2 +- > > libavformat/Makefile | 2 ++ > > libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH 7/9] sbcenc: add MMX optimizations

2017-12-23 Thread Aurelien Jacobs
On Sat, Dec 23, 2017 at 09:52:11PM +0100, Aurelien Jacobs wrote: > On Sat, Dec 23, 2017 at 05:47:04PM -0300, James Almer wrote: > > On 12/23/2017 5:44 PM, Aurelien Jacobs wrote: > > > On Sat, Dec 23, 2017 at 03:35:28PM -0300, James Almer wrote: > > >> On 12/23/2017

Re: [FFmpeg-devel] [PATCH 7/9] sbcenc: add MMX optimizations

2017-12-23 Thread Aurelien Jacobs
On Sat, Dec 23, 2017 at 05:47:04PM -0300, James Almer wrote: > On 12/23/2017 5:44 PM, Aurelien Jacobs wrote: > > On Sat, Dec 23, 2017 at 03:35:28PM -0300, James Almer wrote: > >> On 12/23/2017 3:01 PM, Aurelien Jacobs wrote: > >>> This was originally based on li

Re: [FFmpeg-devel] [PATCH 7/9] sbcenc: add MMX optimizations

2017-12-23 Thread Aurelien Jacobs
On Sat, Dec 23, 2017 at 03:35:28PM -0300, James Almer wrote: > On 12/23/2017 3:01 PM, Aurelien Jacobs wrote: > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > > > Rough speed test: > > C version:speed= 592x > > MMX version: sp

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-23 Thread Aurelien Jacobs
Updated to match new identifier for CRC (AV_CRC_8_EBU). >From 380c36ec392b066d4b70b0f9fd4957a595294f5a Mon Sep 17 00:00:00 2001 From: Aurelien Jacobs <au...@gnuage.org> Date: Sun, 17 Dec 2017 19:59:30 +0100 Subject: [PATCH 5/9] sbc: implement SBC encoder (low-complexity subb

Re: [FFmpeg-devel] [PATCH 2/9] sbc: implement SBC decoder (low-complexity subband codec)

2017-12-23 Thread Aurelien Jacobs
Updated to match new identifier for CRC (AV_CRC_8_EBU). >From c168e5e7b288edc2730a4a14614ead5c22d67289 Mon Sep 17 00:00:00 2001 From: Aurelien Jacobs <au...@gnuage.org> Date: Sun, 17 Dec 2017 19:53:35 +0100 Subject: [PATCH 2/9] sbc: implement SBC decoder (low-complexity subb

Re: [FFmpeg-devel] [PATCH 1/9] crc: add AV_CRC_8_SBC as a 8 bits CRC with polynomial 0x1D

2017-12-23 Thread Aurelien Jacobs
On Sat, Dec 23, 2017 at 04:32:26PM -0300, James Almer wrote: > On 12/23/2017 3:01 PM, Aurelien Jacobs wrote: > > --- > > libavutil/crc.c | 26 ++ > > libavutil/crc.h | 1 + > > libavutil/tests/crc.c | 7 --- > > tests/re

[FFmpeg-devel] [PATCH 8/9] sbcenc: add armv6 and neon asm optimizations

2017-12-23 Thread Aurelien Jacobs
--- /dev/null +++ b/libavcodec/arm/sbcdsp_init_arm.c @@ -0,0 +1,105 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2008-2010 Nokia Corporation + * Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +

[FFmpeg-devel] [PATCH 7/9] sbcenc: add MMX optimizations

2017-12-23 Thread Aurelien Jacobs
* SIMD optimized SBC encoder DSP functions +;* +;* Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> +;* Copyright (C) 2008-2010 Nokia Corporation +;* Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +;* Copyright (C) 2004-2005 Henryk Ploetz <hen...@ploetzli.ch>

[FFmpeg-devel] [PATCH 9/9] Changelog: list the new SBC codec

2017-12-23 Thread Aurelien Jacobs
--- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index ee48876128..4a98884a3c 100644 --- a/Changelog +++ b/Changelog @@ -27,6 +27,7 @@ version : - video setrange filter - nsp demuxer - support LibreSSL (via libtls) +- native SBC and mSBC encoder and

[FFmpeg-devel] [PATCH 6/9] sbc: add raw muxer for SBC

2017-12-23 Thread Aurelien Jacobs
--- doc/general.texi | 2 +- libavformat/Makefile | 2 ++ libavformat/allformats.c | 4 ++-- libavformat/rawenc.c | 28 4 files changed, 33 insertions(+), 3 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index e5669b0e93..560465a4b8

[FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-23 Thread Aurelien Jacobs
index 00..e155387f0d --- /dev/null +++ b/libavcodec/sbcdsp.c @@ -0,0 +1,382 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-2010 Nokia Corpo

[FFmpeg-devel] [PATCH 3/9] sbc: add parser for SBC

2017-12-23 Thread Aurelien Jacobs
index 00..032f72cf2b --- /dev/null +++ b/libavcodec/sbc_parser.c @@ -0,0 +1,124 @@ +/* + * SBC parser + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it

[FFmpeg-devel] [PATCH 4/9] sbc: add raw demuxer for SBC

2017-12-23 Thread Aurelien Jacobs
); diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c new file mode 100644 index 00..a04a7c4328 --- /dev/null +++ b/libavformat/sbcdec.c @@ -0,0 +1,47 @@ +/* + * RAW SBC demuxer + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of

[FFmpeg-devel] [PATCH 2/9] sbc: implement SBC decoder (low-complexity subband codec)

2017-12-23 Thread Aurelien Jacobs
ile mode 100644 index 00..af3e9a3fa8 --- /dev/null +++ b/libavcodec/sbc.c @@ -0,0 +1,280 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-2010 Nok

[FFmpeg-devel] [PATCH 1/9] crc: add AV_CRC_8_SBC as a 8 bits CRC with polynomial 0x1D

2017-12-23 Thread Aurelien Jacobs
--- libavutil/crc.c | 26 ++ libavutil/crc.h | 1 + libavutil/tests/crc.c | 7 --- tests/ref/fate/crc| 1 + 4 files changed, 32 insertions(+), 3 deletions(-) diff --git a/libavutil/crc.c b/libavutil/crc.c index d44550c9c0..8e44a76ec8 100644 ---

Re: [FFmpeg-devel] [PATCH 02/10] crc: add av_crc_bits() to compute CRC on block with bit boundary

2017-12-23 Thread Aurelien Jacobs
On Thu, Dec 21, 2017 at 11:39:02AM +, Rostislav Pehlivanov wrote: > On 20 December 2017 at 19:58, Aurelien Jacobs <au...@gnuage.org> wrote: > > > --- > > libavutil/crc.c | 20 > > libavutil/crc.h | 12 > > 2 files changed,

Re: [FFmpeg-devel] [PATCH 08/10] sbcenc: add MMX optimizations

2017-12-23 Thread Aurelien Jacobs
On Wed, Dec 20, 2017 at 10:22:54PM -0300, James Almer wrote: > On 12/20/2017 4:58 PM, Aurelien Jacobs wrote: > > +;*** > > +;void ff_sbc_calc_scalefactors(int32_t sb_sample_f[16][2][8], > > +;

Re: [FFmpeg-devel] [PATCH 01/10] crc: add AV_CRC_8_SBC as a 8 bits CRC with polynomial 0x1D

2017-12-23 Thread Aurelien Jacobs
On Thu, Dec 21, 2017 at 02:12:26AM +0100, Michael Niedermayer wrote: > On Wed, Dec 20, 2017 at 08:58:05PM +0100, Aurelien Jacobs wrote: > > --- > > libavutil/crc.c | 26 ++ > > libavutil/crc.h | 1 + > > libavutil/tests/crc.c | 7 +

Re: [FFmpeg-devel] [PATCH 6/8] sbcenc: add MMX optimizations

2017-12-20 Thread Aurelien Jacobs
On Wed, Dec 20, 2017 at 03:47:35PM -0300, James Almer wrote: > On 12/17/2017 6:47 PM, Aurelien Jacobs wrote: > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > libavcodec/sbcdsp.c | 3 + > > libavcodec/sbcdsp.h

[FFmpeg-devel] [PATCH 10/10] Changelog: list the new SBC codec

2017-12-20 Thread Aurelien Jacobs
--- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index ee48876128..4a98884a3c 100644 --- a/Changelog +++ b/Changelog @@ -27,6 +27,7 @@ version : - video setrange filter - nsp demuxer - support LibreSSL (via libtls) +- native SBC and mSBC encoder and

[FFmpeg-devel] [PATCH 09/10] sbcenc: add armv6 and neon asm optimizations

2017-12-20 Thread Aurelien Jacobs
--- /dev/null +++ b/libavcodec/arm/sbcdsp_init_arm.c @@ -0,0 +1,105 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2008-2010 Nokia Corporation + * Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +

[FFmpeg-devel] [PATCH 08/10] sbcenc: add MMX optimizations

2017-12-20 Thread Aurelien Jacobs
* SIMD optimized SBC encoder DSP functions +;* +;* Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> +;* Copyright (C) 2008-2010 Nokia Corporation +;* Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +;* Copyright (C) 2004-2005 Henryk Ploetz <hen...@ploetzli.ch>

[FFmpeg-devel] [PATCH 07/10] sbc: add raw muxer for SBC

2017-12-20 Thread Aurelien Jacobs
--- doc/general.texi | 2 +- libavformat/Makefile | 2 ++ libavformat/allformats.c | 4 ++-- libavformat/rawenc.c | 28 4 files changed, 33 insertions(+), 3 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index e5669b0e93..560465a4b8

[FFmpeg-devel] [PATCH 06/10] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-20 Thread Aurelien Jacobs
index 00..e155387f0d --- /dev/null +++ b/libavcodec/sbcdsp.c @@ -0,0 +1,382 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-2010 Nokia Corpo

[FFmpeg-devel] [PATCH 05/10] sbc: add raw demuxer for SBC

2017-12-20 Thread Aurelien Jacobs
--- doc/general.texi | 1 + libavformat/Makefile | 2 ++ libavformat/allformats.c | 2 ++ libavformat/rawdec.c | 24 4 files changed, 29 insertions(+) diff --git a/doc/general.texi b/doc/general.texi index ed137f999f..65aee47f2a 100644 ---

[FFmpeg-devel] [PATCH 04/10] sbc: add parser for SBC

2017-12-20 Thread Aurelien Jacobs
index 00..032f72cf2b --- /dev/null +++ b/libavcodec/sbc_parser.c @@ -0,0 +1,124 @@ +/* + * SBC parser + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it

[FFmpeg-devel] [PATCH 03/10] sbc: implement SBC decoder (low-complexity subband codec)

2017-12-20 Thread Aurelien Jacobs
ode 100644 index 00..61bc27da6e --- /dev/null +++ b/libavcodec/sbc.c @@ -0,0 +1,257 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-2010 Nok

[FFmpeg-devel] [PATCH 02/10] crc: add av_crc_bits() to compute CRC on block with bit boundary

2017-12-20 Thread Aurelien Jacobs
--- libavutil/crc.c | 20 libavutil/crc.h | 12 2 files changed, 32 insertions(+) diff --git a/libavutil/crc.c b/libavutil/crc.c index 8e44a76ec8..cb26a09a20 100644 --- a/libavutil/crc.c +++ b/libavutil/crc.c @@ -413,3 +413,23 @@ uint32_t av_crc(const AVCRC

[FFmpeg-devel] [PATCH 01/10] crc: add AV_CRC_8_SBC as a 8 bits CRC with polynomial 0x1D

2017-12-20 Thread Aurelien Jacobs
--- libavutil/crc.c | 26 ++ libavutil/crc.h | 1 + libavutil/tests/crc.c | 7 --- 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/libavutil/crc.c b/libavutil/crc.c index d44550c9c0..8e44a76ec8 100644 --- a/libavutil/crc.c +++

Re: [FFmpeg-devel] [PATCH 1/8] sbc: implement SBC decoder (low-complexity subband codec)

2017-12-20 Thread Aurelien Jacobs
On Mon, Dec 18, 2017 at 01:05:39AM +, Rostislav Pehlivanov wrote: > On 17 December 2017 at 21:47, Aurelien Jacobs <au...@gnuage.org> wrote: > > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > doc/general.texi |

Re: [FFmpeg-devel] [PATCH 4/8] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-20 Thread Aurelien Jacobs
On Mon, Dec 18, 2017 at 12:45:12PM +0100, Michael Niedermayer wrote: > On Sun, Dec 17, 2017 at 10:47:16PM +0100, Aurelien Jacobs wrote: > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > [...] > > +static inline void sbc_analyze_4b_

Re: [FFmpeg-devel] [PATCH 8/8] Changelog: list the new SBC features

2017-12-17 Thread Aurelien Jacobs
On Mon, Dec 18, 2017 at 12:22:27AM +0100, Carl Eugen Hoyos wrote: > 2017-12-17 22:47 GMT+01:00 Aurelien Jacobs <au...@gnuage.org>: > > --- > > Changelog | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Changelog b/Changelog

Re: [FFmpeg-devel] [PATCH 6/8] sbcenc: add MMX optimizations

2017-12-17 Thread Aurelien Jacobs
On Mon, Dec 18, 2017 at 12:21:00AM +0100, Carl Eugen Hoyos wrote: > 2017-12-17 22:47 GMT+01:00 Aurelien Jacobs <au...@gnuage.org>: > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > Very rough numbers are useful in the commit messag

Re: [FFmpeg-devel] [PATCH 3/8] sbc: add raw demuxer for SBC

2017-12-17 Thread Aurelien Jacobs
On Mon, Dec 18, 2017 at 12:19:06AM +0100, Carl Eugen Hoyos wrote: > 2017-12-17 22:47 GMT+01:00 Aurelien Jacobs <au...@gnuage.org>: > > > +#if CONFIG_SBC_DEMUXER > > +AVInputFormat ff_sbc_demuxer = { > > +.name = "sbc", > > +.long_

[FFmpeg-devel] [PATCH] aptx: add codec cap SMALL_LAST_FRAME and INIT_THREADSAFE as appropriate

2017-12-17 Thread Aurelien Jacobs
--- libavcodec/aptx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c index d09ce8f838..a35d2861c1 100644 --- a/libavcodec/aptx.c +++ b/libavcodec/aptx.c @@ -836,6 +836,7 @@ AVCodec ff_aptx_decoder = { .decode= aptx_decode_frame,

[FFmpeg-devel] [PATCH 8/8] Changelog: list the new SBC features

2017-12-17 Thread Aurelien Jacobs
--- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index ee48876128..8eebcd810c 100644 --- a/Changelog +++ b/Changelog @@ -27,6 +27,8 @@ version : - video setrange filter - nsp demuxer - support LibreSSL (via libtls) +- native SBC and mSBC encoder and

[FFmpeg-devel] [PATCH 7/8] sbcenc: add armv6 and neon asm optimizations

2017-12-17 Thread Aurelien Jacobs
--- /dev/null +++ b/libavcodec/arm/sbcdsp_init_arm.c @@ -0,0 +1,105 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2008-2010 Nokia Corporation + * Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> +

[FFmpeg-devel] [PATCH 6/8] sbcenc: add MMX optimizations

2017-12-17 Thread Aurelien Jacobs
* Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2008-2010 Nokia Corporation + * Copyright (C) 2004-2010 Marcel Holtmann <mar...@holtmann.org> + * Copyright (C) 2004-2005 Henryk Ploetz <hen...@

[FFmpeg-devel] [PATCH 1/8] sbc: implement SBC decoder (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs
ile mode 100644 index 00..99d02cc56a --- /dev/null +++ b/libavcodec/sbc.c @@ -0,0 +1,316 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-

[FFmpeg-devel] [PATCH 4/8] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs
index 00..16faf5ba9b --- /dev/null +++ b/libavcodec/sbcdsp.c @@ -0,0 +1,390 @@ +/* + * Bluetooth low-complexity, subband codec (SBC) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * Copyright (C) 2012-2013 Intel Corporation + * Copyright (C) 2008-2010 Nokia Corpo

[FFmpeg-devel] [PATCH 2/8] sbc: add parser for SBC

2017-12-17 Thread Aurelien Jacobs
index 00..032f72cf2b --- /dev/null +++ b/libavcodec/sbc_parser.c @@ -0,0 +1,124 @@ +/* + * SBC parser + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it

[FFmpeg-devel] [PATCH 3/8] sbc: add raw demuxer for SBC

2017-12-17 Thread Aurelien Jacobs
); REGISTER_DEMUXER (SDP, sdp); diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c new file mode 100644 index 00..a04a7c4328 --- /dev/null +++ b/libavformat/sbcdec.c @@ -0,0 +1,47 @@ +/* + * RAW SBC demuxer + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * Thi

[FFmpeg-devel] [PATCH 5/8] sbc: add raw muxer for SBC

2017-12-17 Thread Aurelien Jacobs
--- doc/general.texi | 2 +- libavformat/Makefile | 2 ++ libavformat/allformats.c | 4 ++-- libavformat/rawenc.c | 28 4 files changed, 33 insertions(+), 3 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index e5669b0e93..560465a4b8

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:53:38PM -0300, James Almer wrote: > On 11/5/2017 8:35 PM, Aurelien Jacobs wrote: > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > doc/general.texi | 2 + > > libavcodec/

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 04:40:56AM +, Rostislav Pehlivanov wrote: > On 5 November 2017 at 23:35, Aurelien Jacobs <au...@gnuage.org> wrote: > > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > doc/general.texi

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 04:22:30AM +0100, Michael Niedermayer wrote: > Hi > > On Mon, Nov 06, 2017 at 12:35:18AM +0100, Aurelien Jacobs wrote: > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > doc/general.texi

Re: [FFmpeg-devel] adding bluetooth SBC codec

2017-12-03 Thread Aurelien Jacobs
On Sun, Dec 03, 2017 at 10:57:59AM +, Rostislav Pehlivanov wrote: > On 5 November 2017 at 23:35, Aurelien Jacobs <au...@gnuage.org> wrote: > > > Hello everyone, > > > > Long time no see ! > > > > I'm glad to see ffmpeg still strong. > > >

[FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-10 Thread Aurelien Jacobs
a/libavformat/aptxdec.c b/libavformat/aptxdec.c new file mode 100644 index 00..3b8fae1b55 --- /dev/null +++ b/libavformat/aptxdec.c @@ -0,0 +1,78 @@ +/* + * RAW aptX demuxer + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of FFmpeg. + * + *

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-10 Thread Aurelien Jacobs
On Fri, Nov 10, 2017 at 12:25:12AM +, Rostislav Pehlivanov wrote: > On 9 November 2017 at 22:48, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Thu, Nov 09, 2017 at 02:32:44PM +, Rostislav Pehlivanov wrote: > > > On 9 November 2017 at 13:37, Aurelien Jaco

[FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-10 Thread Aurelien Jacobs
+1,860 @@ +/* + * Audio Processing Technology codec for Bluetooth (aptX) + * + * Copyright (C) 2017 Aurelien Jacobs <au...@gnuage.org> + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: > On 11/9/2017 2:46 PM, Clément Bœsch wrote: > > On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: > >> Signed-off-by: Rostislav Pehlivanov > >> --- > >> doc/developer.texi | 3 +++ > >> 1 file

  1   2   >