Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 02:32:44PM +, Rostislav Pehlivanov wrote: > On 9 November 2017 at 13:37, Aurelien Jacobs wrote: > > > On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote: > > > On 8 November 2017 at 22:41, Aurelien Jacobs wrote: > > > &

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 03:22:21AM +0100, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 11:41:16PM +0100, Aurelien Jacobs wrote: > > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > > > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aur

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:41, Aurelien Jacobs wrote: > > > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > > > On Wed, Nov 08, 2017 at 02:06:09PM +0100,

Re: [FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-08 Thread Aurelien Jacobs
On Wed, Nov 08, 2017 at 05:24:34PM +, Rostislav Pehlivanov wrote: > > [...] > > Patch doesn't apply Here is a rebased patch.>From f6d9a7a804bc1c833e7c2e61411ac1b9155cb6ba Mon Sep 17 00:00:00 2001 From: Aurelien Jacobs Date: Thu, 31 Aug 2017 20:42:15 +0200 Subject: [PATC

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Aurelien Jacobs
On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > [...] > > +typedef const struct { > > +const int32_t *quantize_intervals; > > +const int32_t *invert_quantize_dither_factors

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Aurelien Jacobs
On Wed, Nov 08, 2017 at 10:54:18AM +0100, Paul B Mahol wrote: > On 11/7/17, Aurelien Jacobs wrote: > > The encoder was reverse engineered from binary library and from > > EP0398973B1 patent (long expired). > > The decoder was simply deduced from the encoder. > >

[FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-07 Thread Aurelien Jacobs
--git a/libavformat/aptxdec.c b/libavformat/aptxdec.c new file mode 100644 index 00..90ce789454 --- /dev/null +++ b/libavformat/aptxdec.c @@ -0,0 +1,58 @@ +/* + * RAW aptX demuxer + * + * Copyright (C) 2017 Aurelien Jacobs + * + * This file is part of FFmpeg. + * + * FFmpeg is free software

[FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-07 Thread Aurelien Jacobs
.c @@ -0,0 +1,826 @@ +/* + * Audio Processing Technology codec for Bluetooth (aptX) + * + * Copyright (C) 2017 Aurelien Jacobs + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + *

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-07 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:30:02AM +, Rostislav Pehlivanov wrote: > On 5 November 2017 at 23:39, Aurelien Jacobs wrote: > > > The encoder was reverse engineered from binary library and from > > EP0398973B1 patent (long expired). > > The decoder was simply

Re: [FFmpeg-devel] [PATCH 2/3] sbc: add parser for SBC

2017-11-05 Thread Aurelien Jacobs
On Sun, Nov 05, 2017 at 11:43:37PM +, Rostislav Pehlivanov wrote: > On 5 November 2017 at 23:35, Aurelien Jacobs wrote: > > > --- > > libavcodec/Makefile | 2 + > > libavcodec/allcodecs.c | 2 + > >

Re: [FFmpeg-devel] [PATCH 3/3] sbc: add raw muxer and demuxer for SBC

2017-11-05 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:48:32AM +0100, Carl Eugen Hoyos wrote: > 2017-11-06 0:35 GMT+01:00 Aurelien Jacobs : > > > +static int sbc_probe(AVProbeData *p) > > +{ > > +int score = 0; > > > +int l = strlen(p->filename); > > +if

Re: [FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-05 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:51:19AM +0100, Carl Eugen Hoyos wrote: > 2017-11-06 0:39 GMT+01:00 Aurelien Jacobs : > > > +static int aptx_probe(AVProbeData *p) > > +{ > > +int len, score = 0; > > +if (!p || !p->filename) > > +return 0; > >

Re: [FFmpeg-devel] adding bluetooth aptX codec

2017-11-05 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:51:55AM +0100, Carl Eugen Hoyos wrote: > 2017-11-06 0:39 GMT+01:00 Aurelien Jacobs : > > > Here is the other codec I added for my bluetooth needs: aptX. > > Just curious: > Could you comment on the quality? Well, my ears aren't really

[FFmpeg-devel] adding bluetooth aptX codec

2017-11-05 Thread Aurelien Jacobs
Hi again, Here is the other codec I added for my bluetooth needs: aptX. This one is based on my reverse engineering and my understanding of patent EP0398973B1 (long expired). [PATCH 1/2] aptx: implement the aptX bluetooth codec [PATCH 2/2] aptx: add raw muxer and demuxer for aptX -- Aurel _

[FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-05 Thread Aurelien Jacobs
a/libavformat/aptxdec.c b/libavformat/aptxdec.c new file mode 100644 index 00..769b666b4d --- /dev/null +++ b/libavformat/aptxdec.c @@ -0,0 +1,70 @@ +/* + * RAW aptX demuxer + * + * Copyright (C) 2017 Aurelien Jacobs + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you

[FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-05 Thread Aurelien Jacobs
.c @@ -0,0 +1,854 @@ +/* + * Audio Processing Technology codec for Bluetooth (aptX) + * + * Copyright (C) 2017 Aurelien Jacobs + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + *

[FFmpeg-devel] [PATCH 3/3] sbc: add raw muxer and demuxer for SBC

2017-11-05 Thread Aurelien Jacobs
= "truehd", diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c new file mode 100644 index 00..1eb99bae03 --- /dev/null +++ b/libavformat/sbcdec.c @@ -0,0 +1,76 @@ +/* + * RAW SBC demuxer + * Copyright (C) 2017 Aurelien Jacobs + * + * This file is part of FFmpeg. + *

[FFmpeg-devel] [PATCH 2/3] sbc: add parser for SBC

2017-11-05 Thread Aurelien Jacobs
,vc1); diff --git a/libavcodec/sbc_parser.c b/libavcodec/sbc_parser.c new file mode 100644 index 00..278ac6f84f --- /dev/null +++ b/libavcodec/sbc_parser.c @@ -0,0 +1,135 @@ +/* + * SBC parser + * + * Copyright (C) 2017 Aurelien Jacobs + * + * This file is part of FFmpeg. + * + * FFmpeg is

[FFmpeg-devel] adding bluetooth SBC codec

2017-11-05 Thread Aurelien Jacobs
Hello everyone, Long time no see ! I'm glad to see ffmpeg still strong. I'm curently playing with bluetooth audio (A2DP) and I wanted to use lavc to do the encoding/decoding, so I added some codecs that I need to ffmpeg. Here is the result for the SBC codec. [PATCH 1/3] sbc: implement SBC code

<    1   2