Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Ben Boeckel
On Sat, 24 Oct, 2015 at 21:37:57 GMT, Michael Bradshaw wrote: > Crap, you're right. Before I started this I checked if Ubuntu had openjpeg2 > and they do[1] but it turns out it's really just openjpeg 1.3 (if anyone > knows why they made a separate package named libopenjpeg2 when it's really > openj

Re: [FFmpeg-devel] [PATCH] configure: fix configure when using gcc

2015-10-11 Thread Ben Boeckel
On Sun, 11 Oct, 2015 at 16:34:51 GMT, Ganesh Ajjanagadde wrote: > That is a long time hopefully (estimated 15+ years), unless gcc starts > pulling a "fast release" cycle like Firefox or Chrome. Sort of. Old point releases will be major version number bumps (GCC 6 is under development already). --

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Sun, 08 Feb, 2015 at 02:05:45 GMT, Michael Niedermayer wrote: > i tried clementine > it happily adds and edits id3 tags on ogg files, one has to rename > the file to .mp3 though. > So no problem as noone would be doing that if it wherent for a > small detail > clementine does not play ogg f

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Sun, 08 Feb, 2015 at 02:07:28 GMT, Michael Niedermayer wrote: > iam not a user of EXPLODE but it seems most code using it checks no > other flags OK. Added locally. --Ben ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Fri, 06 Feb, 2015 at 10:51:22 GMT, wm4 wrote: >> +av_dict_copy(&other_meta, s->metadata, 0); >> +av_dict_free(&s->metadata); > > Just swap these pointers? Done. --Ben ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Fri, 06 Feb, 2015 at 19:46:39 GMT, wm4 wrote: > Discussing this topic further, it seems id3v2 tags really can happen > with literally almost any container format, including mp4 and ogg. Many > of these formats will have the same problems. Well, it's only a problem if vorbis tags also exist sinc

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Fri, 06 Feb, 2015 at 22:26:16 GMT, Michael Niedermayer wrote: > hard erroring out with no atempt to somehow recover should probably > only happen when AV_EF_EXPLODE is set unless its near certain that > continuing is not possible. (this may be the case for CRC errors in > critical headers) Shou

[FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-05 Thread Ben Boeckel
FLAC doesn't really support ID3 tags, so warn if they are found at all. If vorbis tags are found, toss out duplicate ID3 tags. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavf

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 04:13:49 GMT, Michael Niedermayer wrote: > isnt the id3 + vorbis tag issue the same as if the user would seek > back to the begin and read metadata afterwards ? Metadata isn't in-stream for flac (AFAICT, it is only read with the header; I certainly can't get the code to re-

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 01:37:05 GMT, James Almer wrote: > On 02/02/15 10:02 PM, Lou Logan wrote: >> I wonder what the percentage is of flacs with only ID3 or whatever, only >> Vorbis comment, or a mix. I have no idea. Seeing as EAC adds IDv3 to the files it creates, I'd not be surprised if it isn

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 00:40:46 GMT, Reimar Döffinger wrote: > Yes, and? > Point one: ID3 won, it is generally supported. Insisting on something > else IMHO is just being a pain on the user for little reason and > nothing we should strive to emulate. > Point two: If despite that warning a ID3 tag

[FFmpeg-devel] [PATCHv3] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
FLAC doesn't really support IDv3 tags, so warn if they are found at all. If vorbis tags are found, toss out the IDv3 tags. They are kept if vorbis tags aren't found to at least have something there. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 20 +

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 00:23:55 GMT, Michael Niedermayer wrote: > this doesnt build > libavformat/flacdec.c: In function =E2=80=98flac_read_header=E2=80=99: > libavformat/flacdec.c:59:14: error: =E2=80=98AVFormatContext=E2=80=99 has n= > o member named =E2=80=98err_recognition=E2=80=99 > make: ***

[FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
FLAC doesn't really support IDv3 tags, so warn if they are found at all. If vorbis tags are found, toss out the IDv3 tags. They are kept if vorbis tags aren't found to at least have something there. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 20 +

Re: [FFmpeg-devel] [PATCH] flac: ignore IDv3 tags if vorbis tags exist

2015-02-01 Thread Ben Boeckel
On Mon, 02 Feb, 2015 at 01:10:47 GMT, James Almer wrote: >> +if (has_idv3) { >> +av_log(s, AV_LOG_WARNING, "FLAC does not support IDv3 tags.\n"); >> +} > > You could check for s->error_recognition & AV_EF_COMPLIANT and abort if true > instead of just warning. > And the message coul

[FFmpeg-devel] [PATCH] vorbis: parse out setup headers as well

2015-02-01 Thread Ben Boeckel
Prevents an 'Invalid packet' message. Currently mid-stream setup packets are ignored. Theoretically, they could, based on the specification, be used to reinitialize the stream if parameters change, but I don't expect that to be common (and no one seems to have asked for it). Sig

[FFmpeg-devel] [PATCH] flac: ignore IDv3 tags if vorbis tags exist

2015-02-01 Thread Ben Boeckel
FLAC doesn't really support IDv3 tags, so warn if they are found at all. If vorbis tags are found, toss out the IDv3 tags. They are kept if vorbis tags aren't found to at least have something there. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 17 ++