Re: [FFmpeg-devel] Fwd: [PATCH] added expr evaluation to drawtext - fontsize

2017-04-18 Thread Brett Harrison
On Mon, Apr 17, 2017 at 5:48 PM, Michael Niedermayer wrote: > On Sun, Apr 16, 2017 at 10:01:01PM -0700, Brett Harrison wrote: > > Any comments on this patch? > > > > -- Forwarded message -- > > From: Brett Harrison > > Date: Tue, Apr 11, 2017 at

[FFmpeg-devel] Fwd: [PATCH] added expr evaluation to drawtext - fontsize

2017-04-16 Thread Brett Harrison
Any comments on this patch? -- Forwarded message -- From: Brett Harrison Date: Tue, Apr 11, 2017 at 1:37 PM Subject: Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize To: FFmpeg development discussions and patches Pinging for comments / review... On Tue

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2017-04-11 Thread Brett Harrison
Pinging for comments / review... On Tue, Apr 4, 2017 at 3:45 PM, Brett Harrison wrote: > Resurrecting this patch. > > On Thu, Sep 15, 2016 at 3:20 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Fri, Sep 09, 2016 at 05:26:03PM -0700, Brett Harris

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2017-04-04 Thread Brett Harrison
Resurrecting this patch. On Thu, Sep 15, 2016 at 3:20 AM, Michael Niedermayer wrote: > On Fri, Sep 09, 2016 at 05:26:03PM -0700, Brett Harrison wrote: > > Here are the changes requested > [...] > > +static av_cold int parse_fontsize(AVFilterContext *ctx) > > +{ > >

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-14 Thread Brett Harrison
Any feedback on the most recent patch? On Fri, Sep 9, 2016 at 5:26 PM, Brett Harrison wrote: > Here are the changes requested > > On Thu, Sep 8, 2016 at 8:50 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Tue, Sep 06, 2016 at 10:27:24AM -0700, Bret

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-09 Thread Brett Harrison
Here are the changes requested On Thu, Sep 8, 2016 at 8:50 AM, Michael Niedermayer wrote: > On Tue, Sep 06, 2016 at 10:27:24AM -0700, Brett Harrison wrote: > > This patch addresses your concerns. > > > > On Fri, Sep 2, 2016 at 5:05 PM, Michael Niedermayer > > > w

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-06 Thread Brett Harrison
This patch addresses your concerns. On Fri, Sep 2, 2016 at 5:05 PM, Michael Niedermayer wrote: > On Fri, Sep 02, 2016 at 03:31:21PM -0700, Brett Harrison wrote: > > Addressed the following concerns. > > > > === > > > > >libavfilter/vf_drawtext.c: In function

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-02 Thread Brett Harrison
Addressed the following concerns. === >libavfilter/vf_drawtext.c: In function ‘update_fontsize’: >libavfilter/vf_drawtext.c:422:5: warning: ISO C90 forbids mixed declarations >and code [->Wdeclaration-after-statement] Fixed this. >also patch breaks: >./ffmpeg -i m.mpg -vf >>drawtext=fontfile

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-01 Thread Brett Harrison
Most recent patch. I was evaluating fontsize too early before when using the 'n' variable in equations. On Thu, Sep 1, 2016 at 3:44 PM, Brett Harrison wrote: > Any feedback on this newest patch? > > On Tue, Aug 30, 2016 at 2:17 PM, Brett Harrison < > brett.har

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-01 Thread Brett Harrison
Any feedback on this newest patch? On Tue, Aug 30, 2016 at 2:17 PM, Brett Harrison wrote: > Since there are differing opinions on how the default fontsize should be > established this patch adds my changes while preserving the current > behavior when fontsize is not specified. > &

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-30 Thread Brett Harrison
Since there are differing opinions on how the default fontsize should be established this patch adds my changes while preserving the current behavior when fontsize is not specified. On Tue, Aug 30, 2016 at 2:43 AM, Nicolas George wrote: > Le tridi 13 fructidor, an CCXXIV, Brett Harrison a éc

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-29 Thread Brett Harrison
t; On Sat, Aug 27, 2016 at 04:30:05PM -0700, Brett Harrison wrote: > > Fixed patch based on comments. > > > > This time attaching patch file. > > > > On Sat, Aug 27, 2016 at 6:21 AM, Moritz Barsnick > wrote: > > > > > On Fri, Aug 26, 2016 at 14:37:42

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-27 Thread Brett Harrison
Fixed patch based on comments. This time attaching patch file. On Sat, Aug 27, 2016 at 6:21 AM, Moritz Barsnick wrote: > On Fri, Aug 26, 2016 at 14:37:42 -0700, Brett Harrison wrote: > > > +if (diff != 0) { > > + return diff > 0 ? 1 : diff < 0 ? -1 : 0; > &g

[FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-26 Thread Brett Harrison
Allows expr evaluation in the fontsize parameter for drawtext. examples (fontsize 1/3 of video height): ffmpeg -i http://i.giphy.com/kwAi4WrChkSfm.gif -vf "drawtext=fontfile=/Library/Fonts/Verdana Bold.ttf:text='HI':fontcolor=yellow:x=(w-tw)/2:y=(h-th)/1.3:fontsize=h/3" out.gif ffmpeg -i http: