[FFmpeg-devel] fix for defect #10531

2023-09-11 Thread Francesco Carusi
I attached a patch for defect [ #10531: vf_drawtext causing font rendering jitter after libharfbuz commit. ] Before the patch the width of a text line was measured up to the rightmost visible pixel of the last character. Pros: the right padding specified with the boxborderw parameter is exact

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: add letter_spacing as an evaluated parameter

2023-06-20 Thread Francesco Carusi
You can find an overview of the changes here: https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md and the new code here: https://github.com/yethie/FFmpeg/blob/master/libavfilter/vf_drawtext.c On 19/06/2023 19:56, Mark Ren wrote: Ah alright I see. When might that push come throug

Re: [FFmpeg-devel] drawtext filter

2023-03-14 Thread Francesco Carusi
Can I help in any way in advancing this patch? On 03/02/2023 15:18, Francesco Carusi wrote: On 30/01/2023 13:19, Paul B Mahol wrote: On 1/30/23, Francesco Carusi wrote: On 28/01/2023 16:32, Paul B Mahol wrote: On 1/28/23, Francesco Carusi wrote: On 27/01/2023 18:31, Paul B Mahol wrote

Re: [FFmpeg-devel] drawtext filter

2023-02-03 Thread Francesco Carusi
On 30/01/2023 13:19, Paul B Mahol wrote: On 1/30/23, Francesco Carusi wrote: On 28/01/2023 16:32, Paul B Mahol wrote: On 1/28/23, Francesco Carusi wrote: On 27/01/2023 18:31, Paul B Mahol wrote: On 1/27/23, Francesco Carusi wrote: On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23

Re: [FFmpeg-devel] drawtext filter

2023-01-30 Thread Francesco Carusi
On 28/01/2023 16:32, Paul B Mahol wrote: On 1/28/23, Francesco Carusi wrote: On 27/01/2023 18:31, Paul B Mahol wrote: On 1/27/23, Francesco Carusi wrote: On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23

Re: [FFmpeg-devel] drawtext filter

2023-01-28 Thread Francesco Carusi
On 27/01/2023 18:31, Paul B Mahol wrote: On 1/27/23, Francesco Carusi wrote: On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: The drawtext reinit command is also used in the docs as

Re: [FFmpeg-devel] drawtext filter

2023-01-27 Thread Francesco Carusi
On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: The drawtext reinit command is also used in the docs as an example for the sendcmd filter, so I thought it was fine to use commands in

Re: [FFmpeg-devel] drawtext filter

2023-01-26 Thread Francesco Carusi
On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: The drawtext reinit command is also used in the docs as an example for the sendcmd filter, so I thought it was fine to use commands in that way. In my opinion it is also a convenient way to modify multiple options at

Re: [FFmpeg-devel] drawtext filter

2023-01-26 Thread Francesco Carusi
? On 26/01/2023 11:50, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: Hi, I'm new to contributing to ffmpeg! I modified the drawtext filter to improve text rendering and add some features. You can find a high level description of the changes at this link: https://github.com/y

[FFmpeg-devel] drawtext filter

2023-01-26 Thread Francesco Carusi
@url{http://fribidi.org/}. +For more information about libharfbuzz, check: +@url{https://github.com/harfbuzz/harfbuzz}. + @section edgedetect Detect and draw edges. The filter uses the Canny Edge Detection algorithm. diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-26 Thread Francesco Carusi
As Michael Koch mentioned in his message, also the meaning of the 'y' parameter may be changed to improve the filter interface, but it would also break its compatibility with the current implementation. Thanks for reading! On 24/04/2022 12:07, Nicolas George wrote: Francesco Carusi (

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Francesco Carusi
Hi Michael, you're right, the default y position is not referred to the baseline but to the upper left corner of the text. I initially referred it to the baseline but that is not the default used by the current drawtext filter, so I thought it would be better to keep compatibility with the cu

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Francesco Carusi
On 22/04/2022 12:30, Michael Niedermayer wrote: On Fri, Apr 22, 2022 at 12:01:31PM +0200, Francesco Carusi wrote: Hello ffmpeg team, I'm working on an enhanced version of the drawtext filter and would like to discuss with you about a minor change in its behavior related to line sp

[FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Francesco Carusi
Hello ffmpeg team, I'm working on an enhanced version of the drawtext filter and would like to discuss with you about a minor change in its behavior related to line spacing management. In the current implementation the space between two lines of text is set equal to the height of the highest g