Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

Ok, let's use cast, new patch attached. On Mon, Jul 30, 2018 at 4:53 PM Michael Niedermayer wrote: > On Mon, Jul 30, 2018 at 01:49:24PM -0700, Fredrik Hubinette wrote: > > Is casting a negative integer to unsigned defined behavior? > > yes > > 6.3.1.3 Signed and un

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior by limiting PTS to 62 bits in ogg decoder

in oggdec or somewhere else. On Mon, Jul 30, 2018 at 4:23 PM Michael Niedermayer wrote: > On Mon, Jul 30, 2018 at 01:31:59PM -0700, Fredrik Hubinette wrote: > > Not sure how to update the commit message. > > git commit --amend > > > > The undefined behavior occ

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

Is casting a negative integer to unsigned defined behavior? On Wed, Jul 18, 2018 at 3:55 AM Michael Niedermayer wrote: > On Tue, Jul 17, 2018 at 02:37:55PM -0700, Fredrik Hubinette wrote: > > > > > utils.c |2 +- > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior by limiting PTS to 62 bits in ogg decoder

n, Jul 16, 2018 at 04:32:14PM -0700, Fredrik Hubinette wrote: > > With some (garbled) OGG data, PTS can overflow causing undefined > behavior. > > This patch avoids that by zeroing out PTS values greater than 2^62. > > > oggdec.h |3 ++- > > 1 fi

[FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

From d7bd55c3d280c10b990577003a985296f10a2b59 Mon Sep 17 00:00:00 2001 From: Fredrik Hubinette Date: Tue, 17 Jul 2018 14:35:55 -0700 Subject: [PATCH] Avoid undefined behavior when start_time_text is -1<<63 --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH] Avoid undefined behavior by limiting PTS to 62 bits in ogg decoder

With some (garbled) OGG data, PTS can overflow causing undefined behavior. This patch avoids that by zeroing out PTS values greater than 2^62. From 26a8582bc04f5bddc037ffcce99025e2f977abe0 Mon Sep 17 00:00:00 2001 From: Fredrik Hubinette Date: Mon, 16 Jul 2018 14:54:43 -0700 Subject: [PATCH

Re: [FFmpeg-devel] Check size of STSC allocation

Fixed indentation. On Wed, Nov 15, 2017 at 3:40 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-11-16 0:21 GMT+01:00 Fredrik Hubinette <hubbe-at-google.com@ffmpeg. > org>: > > This patch checks that the memory allocated for stsc entries isn't larger > &g

[FFmpeg-devel] Check size of STSC allocation

This patch checks that the memory allocated for stsc entries isn't larger than the atom. Without this, corrupt data can easily try to allocate all the memory, causing a crash. From e79de93ea8426985d63a2369e8274ceaf296ba2d Mon Sep 17 00:00:00 2001 From: Fredrik Hubinette <hu...@google.com>

[FFmpeg-devel] check size of stsc allocation

This patch checks that the memory allocated for stsc entries isn't larger than the atom. Without this, corrupt data can easily try to allocate all the memory, causing a crash. --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c

Re: [FFmpeg-devel] fix minor leak in id3v2 parsing

Sorry, it was an old patch that I had delayed to submit for various reasons. Glad it's fixed. /Hubbe On Thu, Oct 26, 2017 at 9:57 AM, James Almer wrote: > On 10/24/2017 8:09 PM, Moritz Barsnick wrote: > > On Tue, Oct 24, 2017 at 19:38:58 -0300, James Almer wrote: > >>>

[FFmpeg-devel] fix minor leak in id3v2 parsing

From a6a79bda55868f7faee0f183a45191d3251fb5f1 Mon Sep 17 00:00:00 2001 From: Fredrik Hubinette <hu...@google.com> Date: Tue, 7 Feb 2017 12:19:38 -0800 Subject: [PATCH] Fix minor ffmpeg memory leak in id3v2 parsing. Reviewed-on: https://chromium-review.googlesource.com/439405 Reviewed-by

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

On Fri, Mar 24, 2017 at 12:47 AM, wm4 <nfx...@googlemail.com> wrote: > On Mon, 20 Mar 2017 14:39:07 -0700 > Fredrik Hubinette <hubbe-at-google@ffmpeg.org> wrote: > > > It looks like the value in s->error also comes from an earlier call to > > avio_read().

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

ping? On Mon, Mar 20, 2017 at 2:49 PM, Fredrik Hubinette <hu...@google.com> wrote: > Hopefully valid patch attached. > > > On Mon, Mar 20, 2017 at 2:39 PM, Fredrik Hubinette <hu...@google.com> > wrote: > >> It looks like the value in s->error also com

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

Hopefully valid patch attached. On Mon, Mar 20, 2017 at 2:39 PM, Fredrik Hubinette <hu...@google.com> wrote: > It looks like the value in s->error also comes from an earlier call to > avio_read(). > ogg_read_page tries to read 4439 bytes from the file. It has 524 bytes

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

;error. /Fredrik "Hubbe" Hubinette On Mon, Mar 20, 2017 at 1:53 PM, Fredrik Hubinette <hu...@google.com> wrote: > > On Mon, Mar 20, 2017 at 1:35 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Mon, Mar 20, 2017 at 10:21:08AM -0700, Fre

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

On Mon, Mar 20, 2017 at 1:35 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Mon, Mar 20, 2017 at 10:21:08AM -0700, Fredrik Hubinette wrote: > > In some cases (when parsing OGG) non-fatal errors can happen, which > > will cause s->error

[FFmpeg-devel] [PATCH] clear s->error in avio_read

In some cases (when parsing OGG) non-fatal errors can happen, which will cause s->error to be set. In most cases, this is not a problem beucase s->error is not checked unless an actual error has occurred. However, when avio_read() fails to read more bytes, it checks s->error to decide if it just