[FFmpeg-devel] [PATCH] avformat/tls_gnutls: add initial dtls support (PR #20464)

2025-09-08 Thread Jack Lau via ffmpeg-devel
PR #20464 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20464 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20464.patch >From 042808e328443b002bd64bd6f3bcf1749e8be4a9 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Mon, 8 Sep 2025 16:08:22 +0800 Subject: [P

[FFmpeg-devel] [PATCH] avformat/whip: enable RTCP NACK for whip (PR #20460)

2025-09-07 Thread Jack Lau via ffmpeg-devel
PR #20460 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20460 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20460.patch Refer to RFC 4585 4.2, Add SDP "a=rtcp-fb" so the peer can request rtx through sending NACKs. Add basic parsing for NACK packet. Decrypt

[FFmpeg-devel] [PATCH] configure: remove openssl version check for whip (PR #20452)

2025-09-05 Thread Jack Lau via ffmpeg-devel
PR #20452 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20452 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20452.patch This version check for whip is unnecessary. Since several rencet patches to the configure have already added version checks for OpenSSL.

[FFmpeg-devel] [PATCH] avformat/whip: fix SDP ICE candidates parsing (PR #20423)

2025-09-04 Thread Jack Lau via ffmpeg-devel
PR #20423 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20423 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20423.patch fix issue #20407 Refer to RFC 5245 15.1, the foundation may be any string up to 32 chars. The old code could misread foundations as tran

[FFmpeg-devel] [PATCH] avformat/whip: add PRIORITY and ICE_CONTROLLING for STUN binding request (PR #20405)

2025-09-02 Thread Jack Lau via ffmpeg-devel
PR #20405 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20405 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20405.patch fix issue 20402 See RFC 8445 7.1, The PRIORITY and ICE-CONTROLLED or ICE-CONTROLLING must be included in a Binding request. FFmpeg is a

[FFmpeg-devel] [PATCH] avformat/whip: make time measure more precise (PR #20391)

2025-09-01 Thread Jack Lau via ffmpeg-devel
PR #20391 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20391 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20391.patch Use av_gettime_relative() replace av_gettime() to get better measure Changed the display precision from showing only integers to showing

[FFmpeg-devel] [PATCH] av_format/whip: fix potential overflow (PR #20357)

2025-08-27 Thread Jack Lau via ffmpeg-devel
PR #20357 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20357 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20357.patch >From 7c533ae7404fb20a4513ef766e368300dfe3cc54 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Thu, 28 Aug 2025 07:22:04 +0800 Subject: [

[FFmpeg-devel] [PATCH] avformat/whip: simplify the udp read in whip_write_packet (PR #20339)

2025-08-25 Thread Jack Lau via ffmpeg-devel
PR #20339 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20339 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20339.patch Reduce nested if statements to make the code structure clearer Signed-off-by: Jack Lau >From 74004772075c5cf4856d05a7dc6560d343525f81

[FFmpeg-devel] [PATCH] avformat/whip: set the first sequence number for video and audio (PR #20332)

2025-08-24 Thread Jack Lau via ffmpeg-devel
PR #20332 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20332 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20332.patch this patch will make whip be able to get the first rtp seq easily and compute something sequence-based (e.g. NACK and RTX handling) Sign

[FFmpeg-devel] [PATCH] avformat/whip: add generate_unique_ssrc to avoid ssrc collision (PR #20318)

2025-08-22 Thread Jack Lau via ffmpeg-devel
PR #20318 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20318 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20318.patch Signed-off-by: Jack Lau >From 8f27dbfcaac61282dbe30553dbe957566dbc336d Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Sat, 23 Aug 2025

[FFmpeg-devel] [PATCH] avformat/whip: check the peer whether is ice lite (PR #20256)

2025-08-16 Thread Jack Lau via ffmpeg-devel
PR #20256 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20256 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20256.patch See RFC 5245 Section 4.3 If an agent is a lite implementation, it MUST include an "a=ice-lite" session-level attribute in its SDP. If an

[FFmpeg-devel] [PATCH] avformat/tls_gnutls: add dtls support (PR #20254)

2025-08-16 Thread Jack Lau via ffmpeg-devel
PR #20254 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20254 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20254.patch >From a303893bdfb1ca740a36ba517d5780ec828ad850 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Wed, 13 Aug 2025 10:04:33 +0800 Subject: [

[FFmpeg-devel] [PATCH v5 3/3] avformat/whip: fix typos

2025-06-28 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options descriptions Signed-off-by: Jack Lau --- libavformat/tls.c | 2 +- libavformat/whip.c | 152 ++--- 2 files changed, 77

[FFmpeg-devel] [PATCH v4 3/3] avformat/whip: fix typos

2025-06-27 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options "The Optional" > "(Optional)" Signed-off-by: Jack Lau --- libavformat/tls.c | 2 +- libavformat/whip.c | 152 ++--- 2

[FFmpeg-devel] [PATCH v4 2/3] avformat/whip: reindent whip options

2025-06-27 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index be6ee9c951..8d1be90f32 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1904,13

[FFmpeg-devel] [PATCH v4 1/3] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-06-27 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/

[FFmpeg-devel] [PATCH 1/3] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-06-27 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/

[FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-15 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem In higher versions (openssl 1.0.2 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the func

[FFmpeg-devel] [PATCH v3 3/3] avformat/whip: reindent whip options

2025-06-13 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 84c2092e5e..6a33966472 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1898,13

[FFmpeg-devel] [PATCH v3 2/3] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-13 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/

[FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING

2025-06-13 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..a6827d3478 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1885,13 +1885,13

[FFmpeg-devel] [PATCH v2 1/2] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-12 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- replace AV_OPT_FLAG_DECODING_PARAM to ENCODING mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 25 +++-- 1 file c

[FFmpeg-devel] [PATCH v2 2/2] avformat/whip: reindent whip options

2025-06-12 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 84c2092e5e..ef219defb7 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1898,13

[FFmpeg-devel] [PATCH] avformat/whip: mark as experimental

2025-06-10 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- This muxer has been marked AVFMT_EXPERIMENTAL. Add a note in muxers.texi that WHIP is an experimental feature This patch doesn't effect WHIP usage command, as WHIP always needs to be explicitly specified The details as follows: https://ffmpeg.org/pipermail/ffmpeg-devel/2025

[FFmpeg-devel] [PATCH] doc/muxers: add a note that WHIP is an experimental feaeture

2025-06-09 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- this muxer has been marked AVFMT_EXPERIMENTAL. Signed-off-by: Jack Lau --- doc/muxers.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 30c95c3d34..d2ee90bf33 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -3885,6 +388

[FFmpeg-devel] [PATCH 3/3] avformat/whip: align whip options

2025-06-09 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index ed007255ce..e713f7c741 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1898,13 +1898,1

[FFmpeg-devel] [PATCH 2/3] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-09 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/

[FFmpeg-devel] [PATCH 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING

2025-06-09 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..a6827d3478 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1885,13 +1885,13

[FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental

2025-06-09 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..bb7b8657dc 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1907,7 +1907,7 @@ const FFOutp

[FFmpeg-devel] [PATCH v2] avformat/whip: set this muxer as experimental

2025-06-09 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..bb7b8657dc 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1907,7 +1907,7 @@ const FFOutp

[FFmpeg-devel] [PATCH] avformat/format: fix muxer experimental check is always false

2025-06-07 Thread Jack Lau via ffmpeg-devel
if muxer has a name, !short_name is always false Signed-off-by: Jack Lau --- libavformat/format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/format.c b/libavformat/format.c index 516925e7e4..ad8c17b6d7 100644 --- a/libavformat/format.c +++ b/libavformat/forma

[FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-07 Thread Jack Lau via ffmpeg-devel
api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem In higher versions (openssl 1.0.2 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes

[FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-06 Thread Jack Lau via ffmpeg-devel
In higher versions (like openssl 1.1.1 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), which le

[FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-06 Thread Jack Lau via ffmpeg-devel
add the missing data structure pkey in the tls_context properly set this pkey and free it Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open

[FFmpeg-devel] [PATCH] avformat/whip: set this muxer as experimental

2025-06-05 Thread Jack Lau via ffmpeg-devel
Signed-off-by: Jack Lau --- libavformat/whip.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/whip.c b/libavformat/whip.c index 0671e23635..e7cd57400d 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1733,6 +1733,12 @@ static av_cold int whip_init(AVFormatContex

[FFmpeg-devel] [PATCH] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-04 Thread Jack Lau via ffmpeg-devel
fix the missing data structure pkey in the tls_context Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index b589d5d90a..bddeee9af8 100

[FFmpeg-devel] [PATCH] avformat/dashdec: just make seg->url in absolute path once

2025-04-09 Thread Jack Lau via ffmpeg-devel
Should fix ticket 11543 if input url is relative path, the seg-url would make absolute url twice in get_content_url and open_input function but it doesn't need make absolute url in open_input since we set it already Signed-off-by: Jack Lau --- libavformat/dashdec.c | 2 +- 1 file changed, 1 i

[FFmpeg-devel] [PATCH] avformat/rtpdec_mpeg4: add need_parsing for rtsp AAC

2025-04-08 Thread Jack Lau via ffmpeg-devel
fix ticket #11531 the rtsp aac did not marked keyframe which cannot easy copy to output. because f265f9c9d04863180503707bfad285f48e6bf080 commit change the AAC props to match xHE-AAC. in some formats like MOV, need_parsing is set, so AAC can be still parsed be keyframe but rtsp did not, so this

[FFmpeg-devel] [PATCH] avformat/hlsenc: calculate bitrate for segments with duration < 0.5

2025-03-23 Thread Jack Lau via ffmpeg-devel
The previous code sets the bitrate to be calculated only when duration>0.5, which is obviously not general enough. In some scenarios, we may need to set hls_time<0.5, then the generated segments are all <0.5. At this time, because the bitrate is not calculated, max_bitrate is empty, and ff_hls_

[FFmpeg-devel] [PATCH] avformat/dashenc: add hevc codec attributes parse

2025-03-12 Thread Jack Lau via ffmpeg-devel
fix ticket: 11316 add set_hevc_codec_str function refer to hlsenc.c but do some necessary changes Signed-off-by: Jack Lau --- libavformat/dashenc.c | 81 +++ 1 file changed, 81 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 38 +++--- 1 file changed, 35 i

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 38 +++--- 1 file changed, 35 i

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 41 ++--- 1 file changed, 3

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-01 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 37 ++--- 1 file changed, 34 in

[FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau via ffmpeg-devel
--- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3bdc1bc848..c2130bb883 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1993,7 +1993,7 @@ static int hls_read_header(AVFormatContext *s) return r

[FFmpeg-devel] [PATCH] avformat/mpegenc: increase the default size of the VBV buffer

2025-02-08 Thread Jack Lau via ffmpeg-devel
Increase the default buffer size to match more modern encoding scenarios. --- libavformat/mpegenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c index 6b6763c30f..2b3b98b894 100644 --- a/libavformat/mpegenc.c +++ b/libavform

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-05 Thread Jack Lau via ffmpeg-devel
From: Jack Lau The `dec_ctx->time_base` was incorrectly default set by avcodec_open2(), while `enc_ctx->time_base` was derived from `dec_ctx->framerate`. This mismatch could cause incorrect video duration in the output. This patch corrects the issue by adjusting the `enc_ctx->time_base` calcul

[FFmpeg-devel] [PATCH v2] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau via ffmpeg-devel
The `dec_ctx->time_base` was incorrectly default set by avcodec_open2(), while `enc_ctx->time_base` was derived from `dec_ctx->framerate`. This mismatch could cause incorrect video duration in the output. This patch corrects the issue by adjusting the `enc_ctx->time_base` calculation to accoun