[FFmpeg-devel] FFmpeg, zlib based modules' FATE tests expecting bit-exact and Fedora switching to zlib-ng

2024-05-10 Thread Jan Ekström
Hi, As of Fedora 40, the zlib provider has been switched to zlib-ng (https://fedoraproject.org/wiki/Changes/ZlibNGTransition). This has reared the ugly fact that we expect that the usage of zlib APIs is bit-exact. Some of these tests such as copy-apng that only do remux can be moved from

Re: [FFmpeg-devel] [PATCH] avcodec/riscv/vp9dsp: Fix inclusion guard

2024-04-29 Thread Jan Ekström
On Mon, Apr 29, 2024 at 9:33 PM Andreas Rheinhardt wrote: > > Fixes fate-source. > > Signed-off-by: Andreas Rheinhardt > --- > I intend to apply this soon. Verified that this fixes fate-source, LGTM. Thanks for noticing this. Jan ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: Fix typo

2024-04-22 Thread Jan Ekström
On Mon, Apr 22, 2024 at 3:34 PM Xiang, Haihao wrote: > > From: Haihao Xiang > > Otherwise there are link errors: > LD ffprobe_g > /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to > `ff_dovi_rpu_generate' > /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to >

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-03 Thread Jan Ekström
On Tue, Apr 2, 2024 at 8:58 PM Jan Ekström wrote: > > On Mon, Apr 1, 2024 at 2:34 PM Jan Ekström wrote: > > > > On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > > > > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > > &g

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-02 Thread Jan Ekström
On Mon, Apr 1, 2024 at 2:34 PM Jan Ekström wrote: > > On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi >

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-01 Thread Jan Ekström
On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi > > Profile 5. Profile 5 can thus now be represented in VUI as > > {AVCO

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-03-29 Thread Jan Ekström
On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi > Profile 5. Profile 5 can thus now be represented in VUI as > {AVCOL_RANGE_JPEG, AVCOL_PRI_BT2020, AVCOL_TRC_SMPTE2084, >AVCOL_SPC_IPT_C2, AVCHROMA_LOC_

[FFmpeg-devel] [PATCH 4/4] avcodec/libx265: do not arbitrarily limit color values

2024-03-28 Thread Jan Ekström
Newer specifications such as H.273 have, and probably will further in the future add new values to these, so - instead of trying to update these limits - we should simply check if the values are not set to the value of "unspecified". This should allow newer avutil values such as IPT-C2 or YCgCo-R

[FFmpeg-devel] [PATCH 3/4] avfilter/{buffersrc, vf_setparams}: map IPT-C2, YCgCo-R variants

2024-03-28 Thread Jan Ekström
--- libavfilter/buffersrc.c| 3 +++ libavfilter/vf_setparams.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index ddcd403785..680eedf25b 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -337,12 +337,15 @@ static

[FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-03-28 Thread Jan Ekström
* SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi Profile 5. Profile 5 can thus now be represented in VUI as {AVCOL_RANGE_JPEG, AVCOL_PRI_BT2020, AVCOL_TRC_SMPTE2084, AVCOL_SPC_IPT_C2, AVCHROMA_LOC_LEFT} (although other chroma sample locations are allowed).

[FFmpeg-devel] [PATCH 2/4] avcodec/options_table: map IPT-C2, YCgCo-R variants in colorspace

2024-03-28 Thread Jan Ekström
--- libavcodec/options_table.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 7a2ef3474e..7a70fa7b6c 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -331,8 +331,11 @@ static const AVOption

Re: [FFmpeg-devel] [PATCH] tests: Remove fate-libx265-hdr10

2024-03-22 Thread Jan Ekström
On Fri, Mar 22, 2024 at 10:18 PM Anton Khirnov wrote: > > Quoting Zhao Zhili (2024-03-22 13:43:43) > > From: Zhao Zhili > > > > The test depends on the compile option of x265. It failed when > > HIGH_BIT_DEPTH isn't enabled. It also failed when asan is enabled > > because of memory issue inside

Re: [FFmpeg-devel] [PATCH 5/5] avutil/frame: Use av_realloc_array(), improve overflow check

2024-03-22 Thread Jan Ekström
On Fri, Mar 22, 2024 at 4:41 PM Andreas Rheinhardt wrote: > > Also use sizeof of the proper type, namely sizeof(**sd) > and not sizeof(*sd). > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/frame.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Don't call frame_data twice

2024-03-22 Thread Jan Ekström
On Fri, Mar 22, 2024 at 6:07 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_enc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c > index f01be1c22f..5f7fcf8a5f 100644 > --- a/fftools/ffmpeg_enc.c >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: encode dovi RPUs

2024-03-20 Thread Jan Ekström
On Wed, Mar 20, 2024 at 9:30 PM Michael Niedermayer wrote: > > On Tue, Mar 19, 2024 at 08:16:42PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > libx265 supports these natively, we just need to forward them to the > > x265picture. > > --- > > libavcodec/libx265.c | 11 +++ > >

Re: [FFmpeg-devel] [PATCH v10 00/14] encoder AVCodecContext configuration side data

2024-03-20 Thread Jan Ekström
On Wed, Mar 20, 2024 at 7:00 PM James Almer wrote: > > On 3/18/2024 6:31 PM, Jan Ekström wrote: > > Differences to v9: > > 1. rebased on top of current master > > 2. renamed the avctx AVFrameSideData array according to Anton's naming > > sense, > > as a

[FFmpeg-devel] [PATCH v10 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89

[FFmpeg-devel] [PATCH v10 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v10 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v10 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-18 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v10 10/14] avcodec: add frame side data array to AVCodecContext

2024-03-18 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 13 + libavcodec/options.c | 2 ++ libavcodec/version.h | 4 ++-- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges

[FFmpeg-devel] [PATCH v10 09/14] {avutil/version, APIchanges}: bump, document new AVFrameSideData functions

2024-03-18 Thread Jan Ekström
--- doc/APIchanges | 5 + libavutil/version.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index a44c8e4f10..4f906432d5 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,11 @@ The last version increases of all libraries

[FFmpeg-devel] [PATCH v10 08/14] avutil/frame: add helper for getting side data from array

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 922185b823..e8dfd4d926 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@

[FFmpeg-devel] [PATCH v10 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-18 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9d3eae4bae..922185b823

[FFmpeg-devel] [PATCH v10 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index e4c2fa4f6a..9d3eae4bae 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v10 05/14] avutil/frame: add helper for adding side data to array

2024-03-18 Thread Jan Ekström
ta_array.c new file mode 100644 index 00..793a62c009 --- /dev/null +++ b/libavutil/tests/side_data_array.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under

[FFmpeg-devel] [PATCH v10 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-18 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 382e1f6d58..2a319adb86 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v10 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..382e1f6d58 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef

[FFmpeg-devel] [PATCH v10 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void

[FFmpeg-devel] [PATCH v10 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-18 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v10 00/14] encoder AVCodecContext configuration side data

2024-03-18 Thread Jan Ekström
to list handled side data from f.ex. `ffmpeg -h encoder=libsvtav1`. Jan Jan Ekström (14): avutil/frame: split side data list wiping out to non-AVFrame function avutil/frame: add helper for freeing arrays of side data avutil/frame: split side_data_from_buf to base and AVFrame func avut

[FFmpeg-devel] [PATCH v9 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-17 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89

[FFmpeg-devel] [PATCH v9 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-17 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v9 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-17 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v9 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-17 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v9 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-03-17 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 31 +++ libavcodec/avcodec.h | 21 + 2 files changed, 52 insertions(+) diff --git

[FFmpeg-devel] [PATCH v9 09/14] avcodec: add frame side data array to AVCodecContext

2024-03-17 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 12 libavcodec/options.c | 2 ++ 2 files changed, 14 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 554501aa44..550df0e589 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH v9 08/14] avutil/frame: add helper for getting side data from array

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 30db83a5e5..47ecd964b8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@

[FFmpeg-devel] [PATCH v9 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-17 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 46f976a3ed..30db83a5e5

[FFmpeg-devel] [PATCH v9 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4074391a92..46f976a3ed 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v9 05/14] avutil/frame: add helper for adding side data to array

2024-03-17 Thread Jan Ekström
c new file mode 100644 index 00..793a62c009 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the

[FFmpeg-devel] [PATCH v9 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-17 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9ebe830c5c..dd27456031 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v9 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..9ebe830c5c 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef

[FFmpeg-devel] [PATCH v9 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void

[FFmpeg-devel] [PATCH v9 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-17 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v9 00/14] encoder AVCodecContext configuration side data

2024-03-17 Thread Jan Ekström
handled_side_data list, so that if format specific generic logic is added, it could be checked whether the codec itself handles this side data? This could also be utilized to list handled side data from f.ex. `ffmpeg -h encoder=libsvtav1`. Jan Jan Ekström (14): avutil/frame: split side

[FFmpeg-devel] [PATCH v8 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-11 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 88

[FFmpeg-devel] [PATCH v8 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-11 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v8 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-11 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v8 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-11 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v8 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-03-11 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 30 ++ libavcodec/avcodec.h | 21 + 2 files changed, 51 insertions(+) diff --git

[FFmpeg-devel] [PATCH v8 09/14] avcodec: add frame side data array to AVCodecContext

2024-03-11 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 21fc74707f..432a3fd153 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH v8 08/14] avutil/frame: add helper for getting side data from array

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 30db83a5e5..47ecd964b8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@

[FFmpeg-devel] [PATCH v8 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-11 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 46f976a3ed..30db83a5e5

[FFmpeg-devel] [PATCH v8 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4074391a92..46f976a3ed 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v8 05/14] avutil/frame: add helper for adding side data to array

2024-03-11 Thread Jan Ekström
c new file mode 100644 index 00..793a62c009 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the

[FFmpeg-devel] [PATCH v8 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-11 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9ebe830c5c..dd27456031 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v8 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..9ebe830c5c 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef

[FFmpeg-devel] [PATCH v8 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void

[FFmpeg-devel] [PATCH v8 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-11 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v8 00/14] encoder AVCodecContext configuration side data

2024-03-11 Thread Jan Ekström
=libsvtav1`. Jan Jan Ekström (14): avutil/frame: split side data list wiping out to non-AVFrame function avutil/frame: add helper for freeing arrays of side data avutil/frame: split side_data_from_buf to base and AVFrame func avutil/frame: split side data removal out to non-AVFrame function

[FFmpeg-devel] [PATCH v7 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 88

[FFmpeg-devel] [PATCH v7 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v7 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v7 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-02-29 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v7 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-02-29 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 30 ++ libavcodec/avcodec.h | 20 2 files changed, 50 insertions(+) diff --git

[FFmpeg-devel] [PATCH v7 09/14] avcodec: add frame side data array to AVCodecContext

2024-02-29 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 43859251cc..411f4caad3 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH v7 08/14] avutil/frame: add helper for getting side data from array

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 3a2084d1ca..fd4b53f9ff 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -940,16 +940,26 @@

[FFmpeg-devel] [PATCH v7 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-02-29 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 57 +++ libavutil/frame.h | 20 + 2 files changed, 58 insertions(+), 19 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 99c9ce4119..3a2084d1ca

[FFmpeg-devel] [PATCH v7 06/14] avutil/frame: add helper for adding existing side data to array

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 19 ++ 2 files changed, 68 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d9741240e7..99c9ce4119 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v7 05/14] avutil/frame: add helper for adding side data to array

2024-02-29 Thread Jan Ekström
0644 index 00..7ef99db3d2 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser Gene

[FFmpeg-devel] [PATCH v7 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-02-29 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 5d30887ec9..788999bdeb 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v7 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 615dcb1b83..5d30887ec9 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -787,23 +787,23 @@ FF_ENABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] [PATCH v7 02/14] avutil/frame: add helper for freeing arrays of side data

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d94710687b..615dcb1b83 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -90,6 +90,11 @@ static void

[FFmpeg-devel] [PATCH v7 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-02-29 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index a3f07ca089..d94710687b 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v7 00/14] encoder AVCodecContext configuration side data

2024-02-29 Thread Jan Ekström
be utilized to list handled side data from f.ex. `ffmpeg -h encoder=libsvtav1`. Jan Jan Ekström (14): avutil/frame: split side data list wiping out to non-AVFrame function avutil/frame: add helper for freeing arrays of side data avutil/frame: split side_data_from_buf to base

Re: [FFmpeg-devel] [PATCH v6 12/13] avcodec/libx264: add support for writing out CLL and MDCV

2024-02-28 Thread Jan Ekström
On Wed, Feb 28, 2024 at 1:39 AM Jan Ekström wrote: > > On Wed, Feb 28, 2024 at 12:24 AM Andreas Rheinhardt > wrote: > > > > Jan Ekström: > > > Both of these two structures were first available with X264_BUILD > > > 163, so make relevant functionality

Re: [FFmpeg-devel] [PATCH v6 12/13] avcodec/libx264: add support for writing out CLL and MDCV

2024-02-27 Thread Jan Ekström
On Wed, Feb 28, 2024 at 12:24 AM Andreas Rheinhardt wrote: > > Jan Ekström: > > Both of these two structures were first available with X264_BUILD > > 163, so make relevant functionality conditional on the version > > being at least such. > > > > Keep han

[FFmpeg-devel] [PATCH v6 13/13] avcodec/libx265: add support for writing out CLL and MDCV

2024-02-27 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 88

[FFmpeg-devel] [PATCH v6 12/13] avcodec/libx264: add support for writing out CLL and MDCV

2024-02-27 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v6 11/13] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-02-27 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v6 10/13] ffmpeg: pass first video AVFrame's side data to encoder

2024-02-27 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v6 08/13] avcodec: add frame side data array to AVCodecContext

2024-02-27 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 43859251cc..411f4caad3 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH v6 09/13] avcodec: add helper for configuring AVCodecContext's frame side data

2024-02-27 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 30 ++ libavcodec/avcodec.h | 20 2 files changed, 50 insertions(+) diff --git

[FFmpeg-devel] [PATCH v6 07/13] avutil/frame: add helper for getting side data from array

2024-02-27 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 99c9ce4119..e7679bf34d 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -921,16 +921,26 @@

[FFmpeg-devel] [PATCH v6 06/13] avutil/frame: add helper for adding existing side data to set

2024-02-27 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 19 ++ 2 files changed, 68 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d9741240e7..99c9ce4119 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v6 05/13] avutil/frame: add helper for adding side data to array

2024-02-27 Thread Jan Ekström
0644 index 00..7ef99db3d2 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser Gene

[FFmpeg-devel] [PATCH v6 04/13] avutil/frame: split side data removal out to non-AVFrame function

2024-02-27 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 5d30887ec9..788999bdeb 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v6 03/13] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-02-27 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 615dcb1b83..5d30887ec9 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -787,23 +787,23 @@ FF_ENABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] [PATCH v6 02/13] avutil/frame: add helper for freeing arrays of side data

2024-02-27 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d94710687b..615dcb1b83 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -90,6 +90,11 @@ static void

[FFmpeg-devel] [PATCH v6 01/13] avutil/frame: split side data list wiping out to non-AVFrame function

2024-02-27 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index a3f07ca089..d94710687b 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v6 00/13] encoder AVCodecContext configuration side data

2024-02-27 Thread Jan Ekström
this side data? This could also be utilized to list handled side data from f.ex. `ffmpeg -h encoder=libsvtav1`. Jan Jan Ekström (13): avutil/frame: split side data list wiping out to non-AVFrame function avutil/frame: add helper for freeing arrays of side data avutil/frame: split

Re: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-26 Thread Jan Ekström
On Wed, Feb 21, 2024 at 1:34 PM J. Dekker wrote: > > Signed-off-by: J. Dekker > --- > doc/outdevs.texi| 2 +- > libavdevice/opengl_enc.c| 11 +++ > libavdevice/version_major.h | 2 ++ > 3 files changed, 14 insertions(+), 1 deletion(-) As during FOSDEM there seemed to

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context

2024-02-20 Thread Jan Ekström
On Tue, Feb 20, 2024 at 8:58 PM Jan Ekström wrote: > > On Tue, Feb 20, 2024 at 8:30 PM James Almer wrote: > > > > On 2/20/2024 3:28 PM, Jan Ekström wrote: > > > `colorspace` in avcodec terms means `matrix coefficients`. > > > --- > > > libavco

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context

2024-02-20 Thread Jan Ekström
On Tue, Feb 20, 2024 at 8:30 PM James Almer wrote: > > On 2/20/2024 3:28 PM, Jan Ekström wrote: > > `colorspace` in avcodec terms means `matrix coefficients`. > > --- > > libavcodec/av1dec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > &g

Re: [FFmpeg-devel] [RFC] fate rsync switch to git

2024-02-20 Thread Jan Ekström
On Tue, Feb 20, 2024 at 4:31 PM Michael Niedermayer wrote: > > Hi all > > I did hear (at fosdem?) > about the idea to switch from rsync to git for managing the fate samples > i thought the idea sounds interresting but isnt rsync more efficient ? > Do note that the idea was that this would only

[FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context

2024-02-20 Thread Jan Ekström
`colorspace` in avcodec terms means `matrix coefficients`. --- libavcodec/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 7ffa7821e9..7debc4deda 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -743,7 +743,7

Re: [FFmpeg-devel] [PATCH v2] {avcodec, tests}: rename the bundled Mesa AV1 vulkan video headers

2024-02-19 Thread Jan Ekström
On Sun, Feb 18, 2024 at 2:16 PM Jan Ekström wrote: > > On Thu, Feb 15, 2024 at 9:21 PM Lynne wrote: > > > > Feb 15, 2024, 20:18 by jee...@gmail.com: > > > > > This together with adjusting the inclusion define allows for the > > > build to not fa

Re: [FFmpeg-devel] [PATCH v2] {avcodec, tests}: rename the bundled Mesa AV1 vulkan video headers

2024-02-18 Thread Jan Ekström
On Thu, Feb 15, 2024 at 9:21 PM Lynne wrote: > > Feb 15, 2024, 20:18 by jee...@gmail.com: > > > This together with adjusting the inclusion define allows for the > > build to not fail with latest Vulkan-Headers that contain the > > stabilized Vulkan AV1 decoding definitions. > > > > Compilation

[FFmpeg-devel] [PATCH v2] {avcodec, tests}: rename the bundled Mesa AV1 vulkan video headers

2024-02-15 Thread Jan Ekström
This together with adjusting the inclusion define allows for the build to not fail with latest Vulkan-Headers that contain the stabilized Vulkan AV1 decoding definitions. Compilation fails currently as the AV1 header is getting included via hwcontext_vulkan.h -> -> vulkan_core.h, which finally

  1   2   3   4   5   6   7   8   9   10   >