> Looks mostly good to me now, thanks. I guess I can clean up the remaining
> few nitpicks without you having to resubmit the patch. So unless you
> disagree with the comments, I can push it with the minor touch-ups.
>
> // Martin
>
Sounds good to me. No disagreements here. Thank you for going
> On Fri, Feb 24, 2023 at 3:14 PM JonHGee wrote:
> ---
> libavcodec/libfdk-aacenc.c | 27 ++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
> diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c
> index 54549de473..55d10990e4 100644
> ---
I had noticed fdk is specifically looking for the qscale flag, and
otherwise does not do anything with global_quality. I suppose the change
is risky for anyone who is setting both global quality and qscale, but with
the current code, it seems incorrect to have a conditional based on the
scaled
