Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-05 Thread Kacper Michajlow
On Mon, 3 Jun 2024 at 23:41, James Almer wrote: > > On 6/3/2024 6:32 PM, Michael Niedermayer wrote: > > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > >> On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > >>> On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread Kacper Michajlow
On Sun, 2 Jun 2024 at 23:17, Ronald S. Bultje wrote: > > Hi, > > On Sun, Jun 2, 2024 at 9:12 AM James Almer wrote: > > > On 6/2/2024 10:06 AM, James Almer wrote: > > > On 6/2/2024 9:14 AM, Kacper Michajłow wrote: > > >> Fixes runtime error: member access within misaligned address > > >> for

Re: [FFmpeg-devel] [PATCH 3/6] avformat/matroskadec: export cropping values

2024-06-01 Thread Kacper Michajlow
On Wed, 29 May 2024 at 23:47, James Almer wrote: > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 53 +++ > 1 file changed, 43 insertions(+), 10 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_sei: loosen up min luminance requirements

2024-05-25 Thread Kacper Michajlow
On Sat, 25 May 2024 at 13:36, Niklas Haas wrote: > > From: Niklas Haas > > The H.265 specification is quite clear on this case: > > > When min_display_mastering_luminance is not in the range of 1 to > > 5, the nominal maximum display luminance of the mastering display > > is unknown or

Re: [FFmpeg-devel] [PATCH] avformat/data_uri: Fix base64 decode buffer size calculation

2024-05-13 Thread Kacper Michajlow
On Sat, 11 May 2024 at 03:45, Michael Niedermayer wrote: > > On Thu, May 09, 2024 at 04:02:09PM +0200, Kacper Michajłow wrote: > > Also reject input if it is too short. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavformat/data_uri.c | 4 ++-- > > 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs

2024-02-07 Thread Kacper Michajlow
On Wed, 7 Feb 2024 at 03:47, Lynne wrote: > > Feb 7, 2024, 03:11 by kaspe...@gmail.com: > > > Drop per frame decode messages to AV_LOG_TRACE level. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavcodec/vulkan_av1.c | 2 +- > > libavcodec/vulkan_h264.c | 2 +- > >

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-27 Thread Kacper Michajlow
On Mon, 25 Dec 2023 at 11:48, Zhao Zhili wrote: > > > > > On Dec 25, 2023, at 18:21, Anton Khirnov wrote: > > > > Quoting Zhao Zhili (2023-12-25 10:27:59) > >> > >> > >>> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > >>> &

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-24 Thread Kacper Michajlow
On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > > Avoids relocations. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > Maybe mention that it's not needed after > acf63d5350adeae551d412db699f8ca03f7e76b9. This is not the only user of

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-12-10 Thread Kacper Michajlow
On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: > > On 2/27/23 11:34, Leo Izen wrote: > > On 2/21/23 17:35, Leo Izen wrote: > >> These chunks are lightweight and it's useful information to have when > >> running ffmpeg -i or ffprobe, for example. > >> --- > >> libavcodec/pngdec.c | 136

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix for windows imprecise sleep

2023-10-17 Thread Kacper Michajlow
On Tue, 17 Oct 2023 at 19:34, Evgeny Pavlov wrote: > > The reason for using av_usleep() here is that AMF API doesn’t provide an > API for explicit wait. There are two modes to get output from encoder: > > 1. Polling with some sleep to avoid CPU thrashing – currently used in FFmpeg > > 2. Set

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Kacper Michajlow
On Fri, 8 Sept 2023 at 20:46, Kieran Kunhya wrote: > > On Fri, 8 Sept 2023 at 19:42, Kacper Michajlow wrote: > > > On Fri, 8 Sept 2023 at 00:11, Kieran Kunhya wrote: > > > > > > On Thu, 7 Sept 2023 at 22:39, Kacper Michajlow > > wrote: > >

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Kacper Michajlow
On Fri, 8 Sept 2023 at 01:35, Timo Rothenpieler via ffmpeg-devel wrote: > > On 07.09.2023 23:38, Kacper Michajlow wrote: > > On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis > > wrote: > >> > >> On 9/6/2023 6:31 PM, Kacper Michajlow wrote: > >>> W

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Kacper Michajlow
On Fri, 8 Sept 2023 at 00:11, Kieran Kunhya wrote: > > On Thu, 7 Sept 2023 at 22:39, Kacper Michajlow wrote: > > > On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis > > wrote: > > > > > > On 9/6/2023 6:31 PM, Kacper Michajlow wrote: > > > >

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-07 Thread Kacper Michajlow
On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis wrote: > > On 9/6/2023 6:31 PM, Kacper Michajlow wrote: > > What would be a downside of preferring CXX always if it exists? > > FFmpeg runs in a multitude of environments with a multitude of portability > requirements. N

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-06 Thread Kacper Michajlow
On Wed, 6 Sept 2023 at 19:09, Timo Rothenpieler wrote: > > On 06.09.2023 18:54, Kacper Michajlow wrote: > > On Wed, 6 Sept 2023 at 12:15, Timo Rothenpieler > > wrote: > >> > >> On 06/09/2023 01:26, Kacper Michajłow wrote: > >>> Other C++ standard

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-06 Thread Kacper Michajlow
On Wed, 6 Sept 2023 at 12:15, Timo Rothenpieler wrote: > > On 06/09/2023 01:26, Kacper Michajłow wrote: > > Other C++ standard libraries exist. Also, this is not a proper way to > > link the standard library anyway. Instead when a C++ dependency is > > detected, switch to the C++ compiler driver

Re: [FFmpeg-devel] [PATCH 1/2] configure: don't force specific C++ standard library linking

2023-09-05 Thread Kacper Michajlow
On Wed, 6 Sept 2023 at 00:17, Hendrik Leppkes wrote: > > On Wed, Sep 6, 2023 at 12:14 AM Kacper Michajłow wrote: > > > > Other C++ standard libraries exist. Also, this is not a proper way to > > link the standard library anyway. Instead when a C++ dependency is > > detected, switch to the C++

Re: [FFmpeg-devel] [PATCH] vulkan: enable VK_KHR_cooperative_matrix

2023-08-26 Thread Kacper Michajlow
On Sat, 26 Aug 2023 at 23:19, Lynne wrote: > > Aug 13, 2023, 00:15 by kaspe...@gmail.com: > > > On Sat, 12 Aug 2023 at 16:45, Lynne wrote: > > > >> > >> It's of interest to API users, and of interest to us, > >> as a DCT/DST can be implemented via matrix multiplies. > >> > >> Bumps up the

Re: [FFmpeg-devel] [PATCH] vulkan: enable VK_KHR_cooperative_matrix

2023-08-12 Thread Kacper Michajlow
On Sat, 12 Aug 2023 at 16:45, Lynne wrote: > > It's of interest to API users, and of interest to us, > as a DCT/DST can be implemented via matrix multiplies. > > Bumps up the required header version to 1.3.255, released > 2 months ago, so it's had time to propagate. I would disagree, considering

Re: [FFmpeg-devel] [PATCH v2] avformat/http: copy only mime type from Content-Type

2023-06-16 Thread Kacper Michajlow
On Thu, 1 Jun 2023 at 21:44, Kacper Michajłow wrote: > > Content-Type can include charset and boundary which is not a part of > mime type and shouldn't be copied as such. > > Fixes HLS playback when the Content-Type includes additional fields. > > Signed-off-by: Kacper Michajłow > --- >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: Try to implement RFC8216 playlist refusal

2023-05-15 Thread Kacper Michajlow
On Mon, 15 May 2023 at 02:06, Michael Niedermayer wrote: > > This is not well tested and can likely be improved, just a > hotfix for hls probe failures since 6b1f68ccb04d791f0250e05687c346a99ff47ea1 > > Should fix Ticket10353 (please test and report cases that still fail) > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"

2023-05-14 Thread Kacper Michajlow
On Mon, 15 May 2023 at 01:06, Michael Niedermayer wrote: > > On Mon, May 15, 2023 at 12:40:50AM +0200, Kacper Michajlow wrote: > > On Sun, 14 May 2023 at 23:39, Michael Niedermayer > > wrote: > > > > > > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirno

Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"

2023-05-14 Thread Kacper Michajlow
On Sun, 14 May 2023 at 23:39, Michael Niedermayer wrote: > > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote: > > This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which > > broke many streams in the wild > > > > Fixes #10353. > > This change violates a SHOULD in rfc8216

Re: [FFmpeg-devel] [PATCH] lavu/vulkan: fix handle type for 32-bit targets

2023-03-07 Thread Kacper Michajlow
On Mon, 6 Mar 2023 at 10:00, Martin Storsjö wrote: > > On Thu, 2 Mar 2023, Kacper Michajłow wrote: > > > Fixes compilation with clang which errors out on Wint-conversion. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavutil/hwcontext_vulkan.c | 2 +- > > libavutil/vulkan.h | 4

Re: [FFmpeg-devel] [PATCH] configure: Fix Microsoft tools detection

2022-02-02 Thread Kacper Michajlow
On Wed, 26 Jan 2022 at 15:00, Martin Storsjö wrote: > > Hi, > > On Sat, 22 Jan 2022, Kacper Michajłow wrote: > > > LLVM tools print installation path upon execution. If one uses LLVM > > tools bundled with Microsoft Visual Studio installation, they would be > > incorrectly detected as Microsoft's

Re: [FFmpeg-devel] [PATCH] avfilter/[vf_nnedi, vf_estdif]: Check interlaced flag on correct frame

2021-05-04 Thread Kacper Michajlow
On Tue, 4 May 2021 at 21:05, Kacper Michajłow wrote: > Fixes regression in vf_nnedi after > 24dc6d386c6f7edb8f6945319f53a7f0b1642bb8 and vf_estdif while at it. > > Signed-off-by: Kacper Michajłow > --- > libavfilter/vf_estdif.c | 2 +- > libavfilter/vf_nnedi.c | 2 +- > 2 files changed, 2

Re: [FFmpeg-devel] [PATCH] configure: Fix DEF file post-processing with LTO enabled.

2017-09-23 Thread Kacper Michajlow
2017-09-08 2:52 GMT+02:00 Michael Niedermayer <mich...@niedermayer.cc>: > On Wed, Sep 06, 2017 at 08:03:18PM +0200, Kacper Michajlow wrote: > > 2017-08-22 21:26 GMT+02:00 Kacper Michajłow <kaspe...@gmail.com>: > > > > > With LTO enabled exported symbol entry l

Re: [FFmpeg-devel] [PATCH] configure: Fix DEF file post-processing with LTO enabled.

2017-09-06 Thread Kacper Michajlow
2017-08-22 21:26 GMT+02:00 Kacper Michajłow : > With LTO enabled exported symbol entry looks like: > av_audio_convert @3 DATA > > In order to maintain valid format we need to strip everything after @. > > This patch fixes linking libraries compiled with MinGW toolchain with

Re: [FFmpeg-devel] [PATCH] configure: disable the new optimizer in Visual Studio 2015 Update 3

2017-01-05 Thread Kacper Michajlow
2016-07-04 3:53 GMT+02:00 Kacper Michajlow <kaspe...@gmail.com>: > 2016-07-03 23:39 GMT+02:00 Hendrik Leppkes <h.lepp...@gmail.com>: >> On Tue, Jun 28, 2016 at 12:01 PM, Hendrik Leppkes <h.lepp...@gmail.com> >> wrote: >>> On Tue, Jun 28, 2016 at 11:4

Re: [FFmpeg-devel] [PATCH] configure: disable the new optimizer in Visual Studio 2015 Update 3

2016-07-03 Thread Kacper Michajlow
2016-07-03 23:39 GMT+02:00 Hendrik Leppkes : > On Tue, Jun 28, 2016 at 12:01 PM, Hendrik Leppkes wrote: >> On Tue, Jun 28, 2016 at 11:48 AM, Hendrik Leppkes >> wrote: >>> Visual Studio 2015 Update 3 introduced a new SSA optimizer,

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. Anyway since it is already merged I guess take my reply as a hint for next time :)

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
18 gru 2015 10:06 AM "Kacper Michajlow" <kaspe...@gmail.com> napisał(a): > > One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So yo