Re: [FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-05-23 Thread Lynne via ffmpeg-devel
On 20/05/2024 16:52, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu Since VAAPI and future D3D12VA implementation may share some common parameters, a base layer encode context is introduced as vaapi context's base. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 56

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-22 Thread Lynne via ffmpeg-devel
On 22/05/2024 22:15, Marton Balint wrote: On Wed, 22 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 23:33, Hendrik Leppkes wrote:  On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel   wrote:  It should be the case here, we shouldn't need reordering as NATIVE just  lets you

Re: [FFmpeg-devel] [PATCH] lavc/vp9: set update_map to 0 when segmentation.enabled is 0

2024-05-22 Thread Lynne via ffmpeg-devel
On 22/05/2024 18:17, Philip Langdale via ffmpeg-devel wrote: On Wed, 22 May 2024 11:10:31 -0400 "Ronald S. Bultje" wrote: Hi, On Wed, May 22, 2024 at 10:36 AM Hendrik Leppkes wrote: On Thu, Feb 29, 2024 at 7:19 AM llyyr wrote: segmentation.update_map is never reset to 0 on a new frame,

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 23:33, Hendrik Leppkes wrote: On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel wrote: It should be the case here, we shouldn't need reordering as NATIVE just lets you specify what order the elements appear in the bitstream. NATIVE means "the FFmpeg native ord

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 21:40, Marton Balint wrote: On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 09:16, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  On 19/05/2024 21:39, Marton Balint wrote:   On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 09:16, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: On 19/05/2024 21:39, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  This commit adds a decoder for the frequency-domain part of USAC.  [...]  +/* Finish later

Re: [FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 17:07, J. Dekker wrote: Lynne via ffmpeg-devel writes: Helps make sense of the possible noise in the results. --- tests/checkasm/checkasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 669f2be9c1

[FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

2024-05-21 Thread Lynne via ffmpeg-devel
Helps make sense of the possible noise in the results. --- tests/checkasm/checkasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 669f2be9c1..b1c175b95d 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@

Re: [FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 15:51, J. Dekker wrote: Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples by an

Re: [FFmpeg-devel] [PATCH v2] checkasm: add sample argument to adjust during bench

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 14:32, J. Dekker wrote: Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples

Re: [FFmpeg-devel] [PATCH] fate: add tests for xHE-AAC

2024-05-21 Thread Lynne via ffmpeg-devel
On 21/05/2024 09:18, Paul B Mahol wrote: On Tue, May 21, 2024 at 4:05 AM Lynne via ffmpeg-devel mailto:ffmpeg-devel@ffmpeg.org>> wrote: Starting off small with a few features. Samples and reference decoded files copied from the official ISO reference suite. Sorry

[FFmpeg-devel] [PATCH] fate: add tests for xHE-AAC

2024-05-20 Thread Lynne via ffmpeg-devel
Starting off small with a few features. Samples and reference decoded files copied from the official ISO reference suite. --- Samples and references: https://files.lynne.ee/xhe_refs/ tests/fate/aac.mak | 8 1 file changed, 8 insertions(+) diff --git a/tests/fate/aac.mak

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Lynne via ffmpeg-devel
On 20/05/2024 01:19, Michael Niedermayer wrote: On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. What works: - Mono - Stereo (no prediction) - Stereo (mid/side coding) - Stereo (complex prediction

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Lynne via ffmpeg-devel
On 19/05/2024 21:39, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. [...] +/* Finish later */ +static const enum AVChannel usac_ch_pos_to_av[64] = { +    [0] = AV_CHAN_FRONT_LEFT, +    [1

[FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Lynne via ffmpeg-devel
coreSbrFrameLengthIndex */ +uint8_t rate_idx; +uint16_t core_frame_len; +uint16_t stream_identifier; + +AACUsacElemConfig elems[64]; +int nb_elems; + + struct { +uint8_t nb_album; +AACUSACLoudnessInfo album_info[64]; +uint8_t nb_info; +AACUSACLo

[FFmpeg-devel] [PATCH v2 6/8] aactab: add tables for the new USAC arithmetic coder

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 376 libavcodec/aactab.h | 6 + 2 files changed, 382 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 8ce5e43974..dfb2dfd98d 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -1193,6

[FFmpeg-devel] [PATCH v2 7/8] aactab: add new scalefactor offset tables for 96/768pt windows

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 117 libavcodec/aactab.h | 4 ++ 2 files changed, 121 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index dfb2dfd98d..18afa69bad 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -154,6

[FFmpeg-devel] [PATCH v2 5/8] aactab: add deemphasis tables for USAC

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 25 + libavcodec/aactab.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 3718b81a07..8ce5e43974 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -3377,3 +3377,28 @@ const

[FFmpeg-devel] [PATCH v2 4/8] aacdec_dsp: implement 768-point transform and windowing

2024-05-19 Thread Lynne via ffmpeg-devel
Required for USAC --- libavcodec/aac/aacdec.c | 4 ++ libavcodec/aac/aacdec.h | 5 +++ libavcodec/aac/aacdec_dsp_template.c | 67 libavcodec/aac/aacdec_fixed.c| 2 + libavcodec/aac/aacdec_float.c| 4 ++

[FFmpeg-devel] [PATCH v2 3/8] aacdec: expose decode_tns

2024-05-19 Thread Lynne via ffmpeg-devel
USAC has the same syntax, with one minor change we can check for. --- libavcodec/aac/aacdec.c | 6 +++--- libavcodec/aac/aacdec.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 40554ff9e4..a7e5b2a369 100644 ---

[FFmpeg-devel] [PATCH v2 2/8] aacdec: expose channel layout related functions

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec.c | 73 - libavcodec/aac/aacdec.h | 19 +-- 2 files changed, 51 insertions(+), 41 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 35722f9b9b..40554ff9e4 100644 ---

[FFmpeg-devel] [PATCH v2 1/8] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-19 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors

[FFmpeg-devel] [PATCH v2 0/8] aacdec: add a native xHE-AAC decoder

2024-05-19 Thread Lynne via ffmpeg-devel
validation - Surround/multichannel support - Desync fixes Lynne (8): aacdec: move from scalefactor ranged arrays to flat arrays aacdec: expose channel layout related functions aacdec: expose decode_tns aacdec_dsp: implement 768-point transform and windowing aactab: add deemphasis tables

Re: [FFmpeg-devel] [PATCH 1/8] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-16 Thread Lynne via ffmpeg-devel
On 16/05/2024 20:30, Michael Niedermayer wrote: On Thu, May 16, 2024 at 12:08:11PM +0200, Lynne via ffmpeg-devel wrote: AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short

Re: [FFmpeg-devel] [PATCH 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-16 Thread Lynne via ffmpeg-devel
On 16/05/2024 12:26, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: This commit adds a decoder for the frequency-domain part of USAC. What works: - Mono - Stereo (no prediction) - Stereo (mid/side coding) What doesn't: - Preroll decoding (every single decoder seems faulty or weird

[FFmpeg-devel] [PATCH 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-16 Thread Lynne via ffmpeg-devel
; + +AACUsacElemConfig elems[64]; +int nb_elems; + +struct { +uint8_t nb_album; +AACUSACLoudnessInfo album_info[64]; +uint8_t nb_info; +AACUSACLoudnessInfo info[64]; +} loudness; +} AACUSACConfig; + typedef struct OutputConfiguration { MPEG4Audi

[FFmpeg-devel] [PATCH 7/8] aactab: add new scalefactor offset tables for 96/768pt windows

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 117 libavcodec/aactab.h | 4 ++ 2 files changed, 121 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index dfb2dfd98d..18afa69bad 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -154,6

[FFmpeg-devel] [PATCH 6/8] aactab: add tables for the new USAC arithmetic coder

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 376 libavcodec/aactab.h | 6 + 2 files changed, 382 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 8ce5e43974..dfb2dfd98d 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -1193,6

[FFmpeg-devel] [PATCH 5/8] aactab: add deemphasis tables for USAC

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 25 + libavcodec/aactab.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 3718b81a07..8ce5e43974 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -3377,3 +3377,28 @@ const

[FFmpeg-devel] [PATCH 4/8] aacdec_dsp: implement 768-point transform and windowing

2024-05-16 Thread Lynne via ffmpeg-devel
Required for USAC --- libavcodec/aac/aacdec.c | 4 ++ libavcodec/aac/aacdec.h | 5 +++ libavcodec/aac/aacdec_dsp_template.c | 67 libavcodec/aac/aacdec_fixed.c| 2 + libavcodec/aac/aacdec_float.c| 4 ++

[FFmpeg-devel] [PATCH 2/8] aacdec: expose channel layout related functions

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec.c | 73 - libavcodec/aac/aacdec.h | 19 +-- 2 files changed, 51 insertions(+), 41 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 35722f9b9b..40554ff9e4 100644 ---

[FFmpeg-devel] [PATCH 3/8] aacdec: expose decode_tns

2024-05-16 Thread Lynne via ffmpeg-devel
USAC has the same syntax, with one minor change we can check for. --- libavcodec/aac/aacdec.c | 6 +++--- libavcodec/aac/aacdec.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 40554ff9e4..a7e5b2a369 100644 ---

[FFmpeg-devel] [PATCH 1/8] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-16 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors

[FFmpeg-devel] [PATCH 0/8] aacdec: add a native xHE-AAC decoder

2024-05-16 Thread Lynne via ffmpeg-devel
it off for review ahead of spec issue clarification. Lynne (8): aacdec: move from scalefactor ranged arrays to flat arrays aacdec: expose channel layout related functions aacdec: expose decode_tns aacdec_dsp: implement 768-point transform and windowing aactab: add deemphasis tables for USAC

Re: [FFmpeg-devel] [PATCH v4 3/4] all: Link to "context" from all contexts with documentation

2024-05-15 Thread Lynne via ffmpeg-devel
On 15/05/2024 17:54, Andrew Sayers wrote: Some headings needed to be rewritten to accomodate the text, (hopefully) without changing the meaning. --- libavcodec/aac/aacdec.h| 2 +- libavcodec/aacenc.h| 2 +- libavcodec/ac3enc.h| 2 +-

[FFmpeg-devel] [PATCH] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-14 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-14 Thread Lynne via ffmpeg-devel
On 14/05/2024 17:09, Christian Bartnik wrote: From: Thomas Siedel Add external decoder VVdeC for H266/VVC decoding. Register new decoder libvvdec. Add libvvdec to wrap the vvdec interface. Enable decoder by adding --enable-libvvdec in configure step. Co-authored-by: Christian Bartnik

Re: [FFmpeg-devel] [PATCH] Revert "lavc/sbrdsp: R-V V neg_odd_64"

2024-05-13 Thread Lynne via ffmpeg-devel
On 13/05/2024 18:43, Rémi Denis-Courmont wrote: While this function can easily be written with vectors, it just fails to get any performance improvement. For reference, this is a simpler loop-free implementation that does get better performance than the current one depending on hardware, but

Re: [FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

2024-05-13 Thread Lynne via ffmpeg-devel
On 13/05/2024 12:13, Martin Storsjö wrote: On Sat, 11 May 2024, Lynne via ffmpeg-devel wrote: Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538. Untested, but its assumed that unlike most of the old ARM code, this one was still working. --- libavcodec/aac

Re: [FFmpeg-devel] [PATCH 6/8 v2] x86/flacdsp: add a SSE2 version of wasted32

2024-05-12 Thread Lynne via ffmpeg-devel
On 12/05/2024 20:51, James Almer wrote: flac_wasted_32_c: 851.3 flac_wasted_32_sse2: 41.3 Signed-off-by: James Almer --- libavcodec/x86/flacdsp.asm| 24 libavcodec/x86/flacdsp_init.c | 3 +++ 2 files changed, 27 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/aacenc_tns: remove unreachable code branch

2024-05-12 Thread Lynne via ffmpeg-devel
On 12/05/2024 14:24, Yotam Ofek wrote: Nope :) Last commit that touched this was 9 years ago, seems like it's an oversight that was never noticed/fixed. The native AAC encoder is stable, even if this code was supposed to behave differently, it's probably good enough as is, and I think that

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

2024-05-11 Thread Lynne via ffmpeg-devel
On 12/05/2024 02:18, Michael Niedermayer wrote: On Sun, May 12, 2024 at 02:13:06AM +0200, Lynne via ffmpeg-devel wrote: On 12/05/2024 02:03, Michael Niedermayer wrote: Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

2024-05-11 Thread Lynne via ffmpeg-devel
On 12/05/2024 02:03, Michael Niedermayer wrote: Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/lpc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/lpc.c

[FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

2024-05-11 Thread Lynne via ffmpeg-devel
Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538. Untested, but its assumed that unlike most of the old ARM code, this one was still working. --- libavcodec/aac/aacdec_float.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/aac/aacdec_float.c

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/vp8dsp: R-V put_vp8_pixels

2024-05-07 Thread Lynne
May 7, 2024, 20:25 by r...@remlab.net: > Le tiistaina 7. toukokuuta 2024, 20.41.30 EEST Lynne a écrit : > >> May 7, 2024, 18:54 by u...@foxmail.com: >> > From: sunyuechi >> > >> > C908: >> > vp8_put_pixels4_c: 78.0 >> >

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/vp8dsp: R-V put_vp8_pixels

2024-05-07 Thread Lynne
May 7, 2024, 18:54 by u...@foxmail.com: > From: sunyuechi > > C908: > vp8_put_pixels4_c: 78.0 > vp8_put_pixels4_rvi: 33.7 > vp8_put_pixels8_c: 278.0 > vp8_put_pixels8_rvi: 55.0 > vp8_put_pixels16_c: 999.0 > vp8_put_pixels16_rvi: 86.7 > --- > libavcodec/riscv/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH 26/28] avcodec/mpegvideoencdsp: Factor draw_edges out in its own context

2024-05-06 Thread Lynne
May 6, 2024, 23:53 by andreas.rheinha...@outlook.com: > This allows to remove a dependency of the dirac decoder (!) > on mpegvideoenc. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 7 +- > libavcodec/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH v3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Lynne
May 7, 2024, 00:38 by andreas.rheinha...@outlook.com: > This is achieved by using function pointers for AAC SBR functions. > This unfortunately necessitated to use void* in > ff_aac_sbr_apply(_fixed). > Fixes ticket #10999. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aac/aacdec.c

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Lynne
May 6, 2024, 21:39 by andreas.rheinha...@outlook.com: > Lynne: > >> May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: >> >>> The approach used here has the advantage not to rely >>> on any DCE. >>> Also improve certain the checks from >&

Re: [FFmpeg-devel] [PATCH 12/12] avcodec/aac/aacdec_(fixed|float): Set AACDecDSP, AACDecProc directly

2024-05-06 Thread Lynne
May 6, 2024, 14:16 by andreas.rheinha...@outlook.com: > This is more in line with how we initialize DSP functions > and avoids tables of function pointers as well as relocations > for these. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aac/aacdec_dsp_template.c | 43

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Fix type mismatch

2024-05-06 Thread Lynne
May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: > ff_aac_sbr_apply() and ff_aac_sbr_apply_fixed() still used > pointers to INTFLOAT which is float or int depending upon > whether USE_FIXED is set or not; in particular, according > to these declarations both functions have the same type. >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Lynne
May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: > The approach used here has the advantage not to rely > on any DCE. > Also improve certain the checks from > 3390693bfb907765f833766f370e0ba8c7894f44 a bit. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aac/aacdec.c | 62

Re: [FFmpeg-devel] [PATCH v4 3/4] all: Link to "context" from all contexts with documentation

2024-05-02 Thread Lynne
Apr 29, 2024, 11:24 by ffmpeg-de...@pileofstuff.org: > Some headings needed to be rewritten to accomodate the text, > (hopefully) without changing the meaning. > --- > libavcodec/aac/aacdec.h| 2 +- > libavcodec/aacenc.h| 2 +- > libavcodec/ac3enc.h|

Re: [FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf.

2024-05-02 Thread Lynne
May 2, 2024, 10:04 by ovchinnikov.dmit...@gmail.com: > >>Is there a reason to add this code in now? > DX12 and Vulkan native encoders will expose less features compare to AMF, > at least in foreseeable feature. The missing features include low latency, > PreAnalysis including look-ahead etc. >

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/avfft: Remove dead code

2024-05-01 Thread Lynne
May 2, 2024, 02:42 by mich...@niedermayer.cc: > Fixes: CID1543204 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/avfft.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avfft.c

Re: [FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf.

2024-05-01 Thread Lynne
May 1, 2024, 20:38 by ovchinnikov.dmit...@gmail.com: > Adds hwcontext_amf, which allows to use shared AMF > context for the encoder, decoder and AMF-based filters, > without copy to the host memory. > It will also allow you to use some optimizations in > the interaction of components (for

Re: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

2024-04-30 Thread Lynne
Apr 30, 2024, 20:05 by nuomi2...@gmail.com: > On Mon, Apr 29, 2024 at 11:38 PM Lynne wrote: > >> Apr 29, 2024, 17:25 by toq...@outlook.com: >> >> > From: Wu Jianhua >> > >> > Signed-off-by: Wu Jianhua >> > --- >> > tests/che

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

2024-04-29 Thread Lynne
Apr 29, 2024, 19:30 by gsean...@gmail.com: > Hi, > > On Mon, Apr 29, 2024 at 12:58 PM Michael Niedermayer > wrote: > >> >> Hi >> >> On Sat, Apr 27, 2024 at 02:16:36PM +0200, Lynne wrote: >> > Hi, >> > >> > I'm requesting a

Re: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

2024-04-29 Thread Lynne
Apr 29, 2024, 17:25 by toq...@outlook.com: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 3 +- > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vvc_alf.c | 133 ++ > 4 files

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-04-29 Thread Lynne
Apr 29, 2024, 13:34 by r...@remlab.net: > > > Le 29 avril 2024 13:32:41 GMT+03:00, Lynne a écrit : > >Apr 29, 2024, 11:56 by r...@remlab.net: > >>> >>> >>> Le 29 avril 2024 11:20:24 GMT+03:00, Lynne a écrit : >>> >>>>&g

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-04-29 Thread Lynne
Apr 29, 2024, 11:56 by r...@remlab.net: > > > Le 29 avril 2024 11:20:24 GMT+03:00, Lynne a écrit : > >>> >They were they deprecated? >>> >>> They caused more bugs than they solved problems (because what we need is to >>> add IPv6 to IPv4

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-04-29 Thread Lynne
Apr 29, 2024, 09:34 by r...@remlab.net: > > > Le 28 avril 2024 23:11:48 GMT+03:00, Lynne a écrit : > >Apr 28, 2024, 20:15 by r...@remlab.net: > >>> Le torstaina 11. huhtikuuta 2024, 10.50.01 EEST Lynne a écrit : >>> >>>> Is there a reason why we ca

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aaccoder: assert that escape case len is not causing issues

2024-04-28 Thread Lynne
Apr 28, 2024, 23:57 by mich...@niedermayer.cc: > On Sun, Apr 28, 2024 at 11:41:20PM +0200, Lynne wrote: > >> Apr 28, 2024, 23:31 by mich...@niedermayer.cc: >> >> > Inspired by CID1465483 Unintentional integer overflow >> > >> > Sponsored-by: So

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

2024-04-28 Thread Lynne
Apr 28, 2024, 23:31 by mich...@niedermayer.cc: > Fixes: CID1439569 Unchecked return value > Fixes: CID1439578 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/atrac9dec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aaccoder: assert that escape case len is not causing issues

2024-04-28 Thread Lynne
Apr 28, 2024, 23:31 by mich...@niedermayer.cc: > Inspired by CID1465483 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/aaccoder.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/aaccoder.c

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-04-28 Thread Lynne
Apr 28, 2024, 20:15 by r...@remlab.net: > Le torstaina 11. huhtikuuta 2024, 10.50.01 EEST Lynne a écrit : > >> Is there a reason why we can't switch to IPv4 addresses mapped >> in IPv6 and just use the IPv6 API everywhere? >> > > IPv6-mapped IPv4 addresses are pretty

Re: [FFmpeg-devel] [PATCH] avcodec/aacenc: don't redundantly re-compute max sfb

2024-04-28 Thread Lynne
Apr 28, 2024, 11:37 by yotam.o...@gmail.com: > Remove an unneeded inner loop in adjust_frame_information that > had no effect, the loop body can be run only once and will compute > the same max sfb. > --- > libavcodec/aacenc.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] vulkan_av1: Set force_integer_mv on intra frames

2024-04-27 Thread Lynne
Apr 27, 2024, 16:07 by s...@jkqxz.net: > On 27/04/2024 14:58, Mark Thompson wrote: > >> On 27/04/2024 14:47, Ronald S. Bultje wrote: >> >>> Hi, >>> >>> On Sat, Apr 27, 2024 at 9:40 AM Mark Thompson wrote: >>> The flag in CBS is the value read from the bitstream (as required for

[FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

2024-04-27 Thread Lynne
Hi, I'm requesting a reimbursement for attending the Khronos F2F event in Brussels on 2024-04-26, where I gave a talk about the current status of Vulkan Video integration into FFmpeg:  - Currently implemented decoding features  - What we would like to be improved (stability, speed and testing

Re: [FFmpeg-devel] [PATCH v2] opusdsp: add ability to modify deemphasis constant

2024-04-25 Thread Lynne
Apr 25, 2024, 02:08 by mich...@niedermayer.cc: > On Wed, Apr 24, 2024 at 12:58:54PM +0200, Lynne wrote: > >> Apr 24, 2024, 10:54 by d...@lynne.ee: >> >> > xHE-AAC relies on the same postfilter mechanism >> > that Opus uses to improve clarity (albeit w

[FFmpeg-devel] [PATCH] aacdec: avoid generating unused code when either implementation is disabled

2024-04-24 Thread Lynne
Minor optimization to remove extra branches. We need to include the header for xHE anyway, which is float-only. >From 54f53fb1c0694bf2777a1eefb1f585a804d56978 Mon Sep 17 00:00:00 2001 From: Lynne Date: Wed, 24 Apr 2024 13:01:14 +0200 Subject: [PATCH] aacdec: avoid generating unused code w

Re: [FFmpeg-devel] [PATCH v2] opusdsp: add ability to modify deemphasis constant

2024-04-24 Thread Lynne
possible > to use alternative constants. > > Version 2 changes: > Move the deemphasis constant table to opustab.c and > document its values better. > v3 attached, forgot to port the native opus encoder. >From 22fa7632e843785600b3ba3f56e476eed65e42f0 Mon Sep 17 00:00:00 2001 From:

[FFmpeg-devel] [PATCH v2] opusdsp: add ability to modify deemphasis constant

2024-04-24 Thread Lynne
the deemphasis constant table to opustab.c and document its values better. >From e6d0621f61bb39929548cab5fa047c1827e1ab8c Mon Sep 17 00:00:00 2001 From: Lynne Date: Mon, 29 Jan 2024 04:31:43 +0100 Subject: [PATCH v2] opusdsp: add ability to modify deemphasis constant xHE-AAC relies on the s

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-23 Thread Lynne
Apr 23, 2024, 09:47 by ffmpeg-de...@pileofstuff.org: > On Tue, Apr 23, 2024 at 02:20:51AM +0200, Michael Niedermayer wrote: > >> On Thu, Apr 18, 2024 at 10:46:35AM +0200, Stefano Sabatini wrote: >> > On date Wednesday 2024-04-17 15:58:32 +0200, Michael Niedermayer wrote: >> > > Hi all >> > > >>

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-23 Thread Lynne
Apr 22, 2024, 09:20 by d...@lynne.ee: > Apr 22, 2024, 00:19 by mich...@niedermayer.cc: > >> On Fri, Apr 12, 2024 at 11:11:53AM +0200, Lynne wrote: >> >>> Apr 12, 2024, 00:45 by mich...@niedermayer.cc: >>> >>> > On Thu, Apr 11, 2024 at 07:42:37AM +

Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation

2024-04-22 Thread Lynne
Apr 22, 2024, 22:31 by s...@jkqxz.net: > --- > Actually match the specification. (Though I'm guessing this field isn't > actually used if things pass anyway?) > > libavcodec/av1dec.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/av1dec.c

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-22 Thread Lynne
Apr 22, 2024, 13:07 by stefa...@gmail.com: > On date Sunday 2024-04-21 22:12:56 -0300, James Almer wrote: > >> On 4/17/2024 10:58 AM, Michael Niedermayer wrote: >> > [...] > >> A full rewrite of ffserver, using only public API, and with modern streaming >> in mind. It would give a lot of code in

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-22 Thread Lynne
Apr 22, 2024, 00:19 by mich...@niedermayer.cc: > On Fri, Apr 12, 2024 at 11:11:53AM +0200, Lynne wrote: > >> Apr 12, 2024, 00:45 by mich...@niedermayer.cc: >> >> > On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: >> > >> >> Apr 10, 2024, 23:57

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-21 Thread Lynne
Apr 12, 2024, 11:12 by d...@lynne.ee: > Apr 12, 2024, 00:45 by mich...@niedermayer.cc: > >> On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: >> >>> Apr 10, 2024, 23:57 by mich...@niedermayer.cc: >>> >>> > On Wed, Apr 10, 202

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: High bit depth encoding for HEVC

2024-04-19 Thread Lynne
Apr 19, 2024, 10:39 by ffmpeg-devel@ffmpeg.org: > From: Diego Felix de Souza > > Adding 10-bit encoding support for HEVC if the input is 8-bit. In > case of 8-bit input content, NVENC performs an internal CUDA 8 to > 10-bit conversion of the input prior to encoding. Currently, only > AV1

Re: [FFmpeg-devel] [PATCH] avcodec/ac3: Remove unused fixed-point ARMv7 DSP

2024-04-18 Thread Lynne
Apr 18, 2024, 07:42 by ge...@geoffhill.org: > This diff removes 4 unused ARMv7 NEON fixed-point DSP functions. > > The function were originally moved here by 4958f35a2 (Dec 2013). > > After 9e05421db (Jan 2021), as part of the refactor of the AC3 > DSP to consistently use 32-bit sample format in

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-17 Thread Lynne
Apr 17, 2024, 16:34 by jamr...@gmail.com: > On 4/17/2024 11:22 AM, Lynne wrote: > >> Apr 17, 2024, 15:58 by mich...@niedermayer.cc: >> >>> Hi all >>> >>> The pace of inovation in FFmpeg has been slowing down. >>> Most work is concentarte

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-17 Thread Lynne
Apr 17, 2024, 15:58 by mich...@niedermayer.cc: > Hi all > > The pace of inovation in FFmpeg has been slowing down. > Most work is concentarted nowadays on code refactoring, and adding > support for new codecs and formats. > > Should we > * make a list of longer term goals > * vote on them > * and

Re: [FFmpeg-devel] [PATCH] Remove .travis.yml

2024-04-17 Thread Lynne
Apr 17, 2024, 13:46 by mar...@martin.st: > Travis is no longer relevant for attempting to run CI jobs in our > setup. > --- > .travis.yml | 30 -- > 1 file changed, 30 deletions(-) > delete mode 100644 .travis.yml > > diff --git a/.travis.yml b/.travis.yml > deleted

[FFmpeg-devel] [PATCH] opusdsp: add ability to modify deemphasis constant

2024-04-15 Thread Lynne
. >From c4ad107076970a555ed838a75c0343dffe0cad36 Mon Sep 17 00:00:00 2001 From: Lynne Date: Mon, 29 Jan 2024 04:31:43 +0100 Subject: [PATCH] opusdsp: add ability to modify deemphasis constant xHE-AAC relies on the same postfilter mechanism that Opus uses to improve clarity (albeit with a stee

Re: [FFmpeg-devel] [PATCH] vulkan_av1: add workaround for NVIDIA drivers tested on broken CTS

2024-04-14 Thread Lynne
Apr 14, 2024, 14:49 by d...@lynne.ee: > The first release of the CTS for AV1 decoding had incorrect > offsets for the OrderHints values. > The CTS will be fixed, and eventually, the drivers will be > updated to the proper spec-conforming behaviour, but we still > need to add a workaround as this

[FFmpeg-devel] [PATCH] vulkan_av1: add workaround for NVIDIA drivers tested on broken CTS

2024-04-14 Thread Lynne
at all, so limit the workaround to only NVIDIA. Meant to be applied on top of jkqxz's previous 2 patches. Patch attached. >From bbd2cc90206e59098accced3ff3a8896e0bfa269 Mon Sep 17 00:00:00 2001 From: Lynne Date: Sun, 14 Apr 2024 14:41:26 +0200 Subject: [PATCH] vulkan_av1: add workaround for NVI

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-12 Thread Lynne
Apr 12, 2024, 00:45 by mich...@niedermayer.cc: > On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: > >> Apr 10, 2024, 23:57 by mich...@niedermayer.cc: >> >> > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: >> > >> >> On We

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-04-11 Thread Lynne
Apr 11, 2024, 09:45 by lazar.ignjato...@cubic.com: > avformat: enable UDP IPv6 multicast interface selection using zone index > > Enabled IPv6 interface selection using zone index. Properly resolved > interface index in places where default 0 interface index is used > (marked with TODO: within

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Lynne
Apr 10, 2024, 23:57 by mich...@niedermayer.cc: > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > >> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: >> > Apr 8, 2024, 09:36 by d...@lynne.ee: >> > >> > > The following patch

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Lynne
Apr 8, 2024, 09:36 by d...@lynne.ee: > The following patchset refactors the AAC decoder step by step, > removing all large-scale templating and abstracting away typed > DSP functions from symbol parsing. > > This series saves 110Kib of binary data from libavcodec.so > when compiled with Clang 18

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-10 Thread Lynne
Apr 10, 2024, 06:54 by an...@khirnov.net: > Quoting James Almer (2024-04-10 03:23:46) > >> On 4/9/2024 10:11 PM, Andrew Kelley wrote: >> > On 4/9/24 17:04, Lynne wrote: >> >> LGTM. >> >> That's how I wrote the AAC patchset as well. >> >

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-09 Thread Lynne
Apr 9, 2024, 23:24 by and...@ziglang.org: > Removes the special -I flag specified in the avcodec/bsf/ subdirectory. > > This makes code copy-pastable to other parts of the ffmpeg codebase, as > well as simplifying the build script. > > It also reduces ambiguity, since there are many instances of

Re: [FFmpeg-devel] [PATCH 2/2] swscale/ppc/swscale_ppc_template: Reindent after the previous commit

2024-04-03 Thread Lynne
Apr 4, 2024, 04:58 by andreas.rheinha...@outlook.com: > Signed-off-by: Andreas Rheinhardt > --- > libswscale/ppc/swscale_ppc_template.c | 107 +- > 1 file changed, 53 insertions(+), 54 deletions(-) > > diff --git a/libswscale/ppc/swscale_ppc_template.c >

Re: [FFmpeg-devel] [PATCH] Add AAC_xHE case to aacdec_template.c for demuxing

2024-04-02 Thread Lynne
Apr 2, 2024, 23:45 by ffmpeg-devel@ffmpeg.org: > From: Ted Meyer > > The parser needs to be able to be created when demuxing, otherwise the > channel count and layout can't be successfully generated. > > Signed-off-by: Ted Meyer > --- > libavcodec/aacdec_template.c | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] 7.0 Name

2024-04-01 Thread Lynne
Apr 1, 2024, 22:01 by mich...@niedermayer.cc: > Hi all > > I think we didnt decide on a name for 7.0 yet > > Previously suggested names: > Darwin, > De broglie, > Dijkstra, > Galois, > Gauss, > Jacobi, > Jemison > Johnson > Leavitt > Maxwell, > Mellin, > Perelman, > Poincaré, > Ramanujan, >

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-25 Thread Lynne
Mar 25, 2024, 14:50 by ffm...@haasn.xyz: > On Mon, 25 Mar 2024 07:20:56 +0100 "Jean-Baptiste Kempf" > wrote: > >> Hello, >> >> On Mon, 25 Mar 2024, at 01:03, Michael Niedermayer wrote: >> > Should i wait till all issues marked as blocking 7.0 on trac are fixed >> > before branching ? >> >> I

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

2024-03-25 Thread Lynne
Mar 20, 2024, 00:33 by s...@jkqxz.net: > On 18/03/2024 05:33, Lynne wrote: > >> Mar 17, 2024, 16:36 by s...@jkqxz.net: >> >>> On 13/03/2024 16:38, Lynne wrote: >>> >>>> Tested by multiple users on multiple operating systems, >>>> d

Re: [FFmpeg-devel] [PATCH 6/6] MAINTAINERS: Add maintainer for LC3 audio codec wrapper

2024-03-22 Thread Lynne
Mar 22, 2024, 18:02 by ffmpeg-devel@ffmpeg.org: > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index dd633f37e8..d07512fc0c 100644 > --- a/MAINTAINERS > +++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: fix setting HEVCHdrParams fields

2024-03-21 Thread Lynne
Mar 21, 2024, 00:17 by jamr...@gmail.com: > These were defined in a way compatible with the Vulkan HEVC acceleration, > which > expects bitmasks, yet the fields were being overwritting on each loop with the > latest read value. > > Signed-off-by: James Almer > --- > libavcodec/hevc_ps.c |

  1   2   3   4   5   6   7   8   9   10   >