Re: [FFmpeg-devel] [PATCH v2] avformat/http: Add max_request_size option

On 02/01/2025 06:52, Nicolas Frattaroli wrote: In some cases, webservers may return content more quickly if one sends many small requests rather than one big request. Clients may wish to opt-in to this workaround. For this purpose, add a max_request_size AVOption, which returns EOF if max_reques

[FFmpeg-devel] [PATCH 3/3] vulkan_decode: remove informative queries

We queried the decoder whether it was able to decode sucessfully, but since we operated asynchronously, we weren't able to do anything with this information but let the user know decoding failed for the previous frame(s). Since we parse the slice headers ourselves and we're reasonably sure we can

[FFmpeg-devel] [PATCH 2/3] ffv1enc_vulkan: allow setting the number of slices via -slices

Falls back to the exact same code the software encoder uses. --- libavcodec/ffv1enc.c| 4 ++-- libavcodec/ffv1enc.h| 1 + libavcodec/ffv1enc_vulkan.c | 10 -- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index

[FFmpeg-devel] [PATCH 1/3] hwcontext_vulkan: add VK_EXT_layer_settings to optional instance extensions

The issue is that some compilers complain if a struct or array is empty. This extension does nothing by default, and can be useful, so just add it to keep the array non-empty. --- libavutil/hwcontext_vulkan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_vulkan.c b/libav

Re: [FFmpeg-devel] [PATCH] configure: update copyright year

On 01/01/2025 19:05, Peter Ross wrote: On Wed, Jan 01, 2025 at 06:03:51PM +0900, Lynne via ffmpeg-devel wrote: --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0a7ce31e09..6c1829ab8e 100755 --- a/configure +++ b/configure

[FFmpeg-devel] [PATCH] configure: update copyright year

--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0a7ce31e09..6c1829ab8e 100755 --- a/configure +++ b/configure @@ -8230,7 +8230,7 @@ cat > $TMPH

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aac/aacdec: Free channel layout

On 25/12/2024 13:26, Michael Niedermayer wrote: Fixes: 371445194/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5981081124274176 Fixes: memleak Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederma

Re: [FFmpeg-devel] [PATCH 5/5] vulkan_decode: add queue_flags field to specify queue used

On 18/12/2024 17:16, Lynne wrote: --- libavcodec/vulkan_av1.c| 1 + libavcodec/vulkan_decode.c | 2 +- libavcodec/vulkan_decode.h | 1 + libavcodec/vulkan_h264.c | 1 + libavcodec/vulkan_hevc.c | 1 + 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_a

Re: [FFmpeg-devel] [PATCH v2] avcodec/hw_base_encode: restrict size of next_prev

On 22/12/2024 17:24, Lynne via ffmpeg-devel wrote: On 22/12/2024 05:25, Benjamin Cheng via ffmpeg-devel wrote: Some drivers are more strict about the size of the reference lists given (i.e. VAOn12 [1]). The next_prev list is used to handle multiple "L0" references in AV1 encode. Re

Re: [FFmpeg-devel] [PATCH v2] avcodec/hw_base_encode: restrict size of next_prev

On 22/12/2024 05:25, Benjamin Cheng via ffmpeg-devel wrote: Some drivers are more strict about the size of the reference lists given (i.e. VAOn12 [1]). The next_prev list is used to handle multiple "L0" references in AV1 encode. Restrict the size of next_prev based on the value of ref_l0 when the

[FFmpeg-devel] [PATCH] ffv1dec: add support for hardware acceleration

--- libavcodec/ffv1.h| 2 + libavcodec/ffv1dec.c | 451 +-- 2 files changed, 268 insertions(+), 185 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index ca03fd2b10..93174bd45e 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@

Re: [FFmpeg-devel] [PATCH] configure: add option to statically link to libvulkan

On 19/12/2024 00:05, Leo Izen wrote: On 12/18/24 3:46 AM, Lynne via ffmpeg-devel wrote: This may be useful in weird setups and on platforms where static linking to libvulkan is supported. libplacebo also has this fallback. --- I'm going to ask the classic "Why would you want

Re: [FFmpeg-devel] [PATCH] vulkan_decode: support software-defined decoders

On 18/12/2024 20:13, Anton Khirnov wrote: Quoting Lynne via ffmpeg-devel (2024-12-18 10:07:51) vulkan_decode: support software-defined decoders --- libavcodec/vulkan_decode.c | 118 +++-- libavcodec/vulkan_decode.h | 8 +++ 2 files changed, 83 insertions

[FFmpeg-devel] [PATCH] vulkan_decode: support software-defined decoders

--- libavcodec/vulkan_decode.c | 118 +++-- libavcodec/vulkan_decode.h | 8 +++ 2 files changed, 83 insertions(+), 43 deletions(-) diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c index 4665a330ef..60ffdf7b38 100644 --- a/libavcodec/vulkan_dec

[FFmpeg-devel] [PATCH] configure: add option to statically link to libvulkan

This may be useful in weird setups and on platforms where static linking to libvulkan is supported. libplacebo also has this fallback. --- configure| 7 ++- libavutil/hwcontext_vulkan.c | 9 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/configure

[FFmpeg-devel] [PATCH 5/5] vulkan_decode: add queue_flags field to specify queue used

--- libavcodec/vulkan_av1.c| 1 + libavcodec/vulkan_decode.c | 2 +- libavcodec/vulkan_decode.h | 1 + libavcodec/vulkan_h264.c | 1 + libavcodec/vulkan_hevc.c | 1 + 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c index 29060

[FFmpeg-devel] [PATCH 4/5] vulkan: do not NIH a queue context

We recently introduced a public field which was a superset of the queue context we used to have. Switch to using it entirely. This also allows us to get rid of the NIH function just for video implementations. --- libavcodec/ffv1enc_vulkan.c | 18 libavcodec/vulkan_decode.c

[FFmpeg-devel] [PATCH 3/5] vulkan: remove pointless mutex locks

This code was simply incorrect through and through. It did not protect what actually has to be protected in a multi-threaded setup. Perhaps it was used to silence threading errors? Either way, remove it, and document the correct way to use execution pools in a threaded environment. --- libavutil/

[FFmpeg-devel] [PATCH 2/5] vulkan_decode: use a single execution pool

Originally, the decoder had a single execution pool, with one execution context per thread. Execution pools were always intended to be thread-safe, as long as there were enough execution contexts in the pool to satisfy all threads. Due to synchronization issues, the threading part was removed at s

[FFmpeg-devel] [PATCH 1/5] hwcontext_vulkan: disable validation layer threading warnings

The layer is buggy currently: https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/9045 --- libavutil/hwcontext_vulkan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 5601ef4d9e..6eca097ea3 100644 --- a/libavutil/hwc

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

On 18/12/2024 14:40, Peter Ross wrote: On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: On 16/12/2024 20:00, Peter Ross wrote: since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

On 16/12/2024 20:00, Peter Ross wrote: since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all and only turn on the components that i am working on. this dependency would otherwise go unnoticed since many codec

Re: [FFmpeg-devel] [PATCH v2] avutil/vulkan_glslang: Fix build failure

On 17/12/2024 15:55, Zhao Zhili wrote: From: Zhao Zhili compile_only isn't available until 13.1.0. Let default initialization set it to zero, so the code works with version before and after 13.1.0. --- libavutil/vulkan_glslang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [FFmpeg-devel] [PATCH] avutil/vulkan_glslang: Fix build failure

On 17/12/2024 12:04, Lynne via ffmpeg-devel wrote: On 17/12/2024 11:42, Zhao Zhili wrote: On Dec 17, 2024, at 09:12, Lynne via ffmpeg-devel de...@ffmpeg.org> wrote: On 16/12/2024 20:55, Zhao Zhili wrote: From: Zhao Zhili compile_only was added since glslang 13.1.0. ---   libavu

Re: [FFmpeg-devel] [PATCH] avutil/vulkan_glslang: Fix build failure

On 17/12/2024 11:42, Zhao Zhili wrote: On Dec 17, 2024, at 09:12, Lynne via ffmpeg-devel wrote: On 16/12/2024 20:55, Zhao Zhili wrote: From: Zhao Zhili compile_only was added since glslang 13.1.0. --- libavutil/vulkan_glslang.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [FFmpeg-devel] [PATCH] avutil/vulkan_glslang: Fix build failure

On 16/12/2024 20:55, Zhao Zhili wrote: From: Zhao Zhili compile_only was added since glslang 13.1.0. --- libavutil/vulkan_glslang.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/vulkan_glslang.c b/libavutil/vulkan_glslang.c index 9e1b8f4d8d..9e7a33223b 100644 --- a/libavuti

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

On 06/12/2024 02:01, Lynne via ffmpeg-devel wrote: On 28/11/2024 23:29, Anton Khirnov wrote: Hi all, the current Technical Committee (TC) was elected on 2023-12-05 and its mandate lasts for one year, so we should hold a new election soon. If there are no unforeseen circumstances, I would like

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

On 28/11/2024 23:29, Anton Khirnov wrote: Hi all, the current Technical Committee (TC) was elected on 2023-12-05 and its mandate lasts for one year, so we should hold a new election soon. If there are no unforeseen circumstances, I would like to start the vote on Monday 2024-12-09. As a reminder

Re: [FFmpeg-devel] [PATCH 0/7] RFC: complete rework of s337m support

On 04/12/2024 23:14, ffnicol...@sfr.fr wrote: From: Nicolas Gaullier I would like to have some feedback on this work before going on... I send this as an RFC, and so, I have not considered versioning, changelog, doc, deprecation schemes. More testing and testing by other people is also obviou

Re: [FFmpeg-devel] [PATCH v2] avcodec/ffv1enc: Add enum for qtable

On 02/12/2024 11:15, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c| 8 +++- libavcodec/ffv1enc.h| 6 ++ libavcodec/ffv1enc_vulkan.c | 8 +++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/libavcodec/ffv1

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: Add enum for qtable

On 30/11/2024 04:33, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index c96c71b1096..742db549e5f 100644 --- a/libavcodec/ff

Re: [FFmpeg-devel] [PATCH] avcodec/vc2enc: Initial vulkan VC2 encoder

On 30/11/2024 05:09, IndecisiveTurtle wrote: Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths. Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H

Re: [FFmpeg-devel] [PATCH 6/6] ffv1enc_vulkan: switch to receive_packet

On 11/24/24 16:51, Jerome Martinez wrote: Le 24/11/2024 à 04:41, Lynne via ffmpeg-devel a écrit : On 11/23/24 23:10, Jerome Martinez wrote: Le 23/11/2024 à 20:58, Lynne via ffmpeg-devel a écrit : This allows the encoder to fully saturate all queues the GPU has, giving a good 10% in certain

Re: [FFmpeg-devel] [PATCH 6/6] ffv1enc_vulkan: switch to receive_packet

On 11/23/24 23:10, Jerome Martinez wrote: Le 23/11/2024 à 20:58, Lynne via ffmpeg-devel a écrit : This allows the encoder to fully saturate all queues the GPU has, giving a good 10% in certain cases and resolutions. Using a RTX 4070: +50% (!!!) with 2K 10-bit content. +17% with 4K 16-bit

[FFmpeg-devel] [PATCH 5/6] ffv1enc_vulkan: remove arbitrary limitation of the number of slices

--- libavcodec/ffv1enc_vulkan.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1enc_vulkan.c b/libavcodec/ffv1enc_vulkan.c index 7021f27572..12e95d1cb5 100644 --- a/libavcodec/ffv1enc_vulkan.c +++ b/libavcodec/ffv1enc_vulkan.c @@ -1388,13 +13

[FFmpeg-devel] [PATCH 6/6] ffv1enc_vulkan: switch to receive_packet

This allows the encoder to fully saturate all queues the GPU has, giving a good 10% in certain cases and resolutions. This also improves error resilience if an allocation fails, and properly cleans up after itself if it does. --- libavcodec/ffv1enc_vulkan.c | 421 ++--

[FFmpeg-devel] [PATCH 4/6] vulkan: only apply shortcut for next context selection if selection has a submission

--- libavutil/vulkan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index 790f2e5aa4..591f85bbf1 100644 --- a/libavutil/vulkan.c +++ b/libavutil/vulkan.c @@ -494,7 +494,8 @@ FFVkExecContext *ff_vk_exec_get(FFVulkanContext *s, FFVkEx

[FFmpeg-devel] [PATCH 3/6] vulkan: add opaque field to execution contexts

Helps keep track of what dispatch happened where. --- libavutil/vulkan.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/vulkan.h b/libavutil/vulkan.h index 9b46a279ca..ec20d1ef56 100644 --- a/libavutil/vulkan.h +++ b/libavutil/vulkan.h @@ -121,6 +121,9 @@ typedef struct FFVkExecC

[FFmpeg-devel] [PATCH 1/6] hwcontext_vulkan: add support for AV_PIX_FMT_GBRP12/14/16

--- libavcodec/ffv1enc_vulkan.c | 7 +-- libavcodec/vulkan/ffv1_enc_rct.comp | 6 +++--- libavutil/hwcontext_vulkan.c| 9 +++-- libavutil/vulkan.c | 6 +- 4 files changed, 20 insertions(+), 8 deletions(-) diff --git a/libavcodec/ffv1enc_vulkan.c b/liba

[FFmpeg-devel] [PATCH 2/6] hwcontext_vulkan: add support for AV_PIX_FMT_GRAY10/12/14

--- libavutil/hwcontext_vulkan.c | 3 +++ libavutil/vulkan.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 539b83cc91..7f5a74dd38 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -3

Re: [FFmpeg-devel] [PATCH] ffv1enc_vulkan: remove arbitrary limitation of the number of slices

On 11/21/24 23:13, Jerome Martinez wrote: Le 21/11/2024 à 20:02, Lynne via ffmpeg-devel a écrit : +    if (f->num_h_slices <= 0 && f->num_v_slices <= 0) {   f->num_h_slices = 32; -    if (f->num_v_slices <= 0)   f->num_v_sl

[FFmpeg-devel] [PATCH] ffv1enc_vulkan: remove arbitrary limitation of the number of slices

--- libavcodec/ffv1enc_vulkan.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/libavcodec/ffv1enc_vulkan.c b/libavcodec/ffv1enc_vulkan.c index a3c10524fe..b37c24484f 100644 --- a/libavcodec/ffv1enc_vulkan.c +++ b/libavcodec/ffv1enc_vulkan.c @@ -1437,13

[FFmpeg-devel] [PATCH] hwcontext_vulkan: add support for AV_PIX_FMT_GBRP16

--- libavcodec/ffv1enc_vulkan.c | 5 - libavcodec/vulkan/ffv1_enc_rct.comp | 6 +++--- libavutil/hwcontext_vulkan.c| 7 +-- libavutil/vulkan.c | 3 ++- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/libavcodec/ffv1enc_vulkan.c b/libavcodec/

[FFmpeg-devel] [PATCH 2/2] ffv1enc_vulkan: add support for RCT coefficient searching

--- libavcodec/ffv1enc_vulkan.c| 268 - libavcodec/vulkan/Makefile | 4 +- libavcodec/vulkan/ffv1_enc_rct_search.comp | 139 +++ libavcodec/vulkan/ffv1_enc_setup.comp | 16 ++ 4 files changed, 422 insertions(+), 5 deletions(-) cr

[FFmpeg-devel] [PATCH 1/2] ffv1enc_vulkan: switch to out of place encoding

The issue is that the trial buffer for encoding needs to be really huge due to the possibility that encoding will require more space than it would take for the raw image data. Giving the framework the buffer directly is what we'd like, since the first slice is already in place, but the issue is th

Re: [FFmpeg-devel] [PATCH v3 10/10] ffv1enc: add a Vulkan encoder

On 11/17/24 13:38, Jerome Martinez wrote: Le 17/11/2024 à 01:19, Lynne via ffmpeg-devel a écrit : I'll push the patchset tomorrow if there are no more comments to fix. As it silently creates bad streams with some pix_fmts, please mandate -strict -2 for the moment. I would like to

Re: [FFmpeg-devel] [PATCH v3 10/10] ffv1enc: add a Vulkan encoder

On 11/15/24 05:50, Lynne wrote: This commit implements a standard, compliant, version 3 and version 4 FFv1 encoder, entirely in Vulkan. The encoder is written in standard GLSL and requires a Vulkan 1.3 supporting GPU with the BDA extension. The encoder can use any amount of slices, but nominally

[FFmpeg-devel] [PATCH v3 02/10] hwcontext_vulkan: fix planar RGB images

They were non-working for quite a while. --- libavutil/hwcontext_vulkan.c | 25 + libavutil/vulkan.c | 27 --- libavutil/vulkan.h | 5 + 3 files changed, 38 insertions(+), 19 deletions(-) diff --git a/libavutil/hwcontext_vul

[FFmpeg-devel] [PATCH v3 04/10] vulkan: fix printing descriptors to shader for shaders with no descriptors

--- libavutil/vulkan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index 159165a19d..2813bc1af9 100644 --- a/libavutil/vulkan.c +++ b/libavutil/vulkan.c @@ -2135,7 +2135,7 @@ print: /* Write shader info */ for (int i = 0; i

[FFmpeg-devel] [PATCH v3 07/10] ffv1enc: expose ff_ffv1_write_extradata

--- libavcodec/ffv1enc.c | 6 -- libavcodec/ffv1enc.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 0ef26db30a..8c0f649b8d 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -393,8 +393,10 @@ static void wri

[FFmpeg-devel] [PATCH v3 10/10] ffv1enc: add a Vulkan encoder

This commit implements a standard, compliant, version 3 and version 4 FFv1 encoder, entirely in Vulkan. The encoder is written in standard GLSL and requires a Vulkan 1.3 supporting GPU with the BDA extension. The encoder can use any amount of slices, but nominally, should use 32x32 slices (1024 in

[FFmpeg-devel] [PATCH v3 01/10] hwcontext_vulkan: explicitly wait when uploading

--- libavutil/hwcontext_vulkan.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 0b52ad5112..0c9047f4c6 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -4200,13 +4200,1

[FFmpeg-devel] [PATCH v3 09/10] ffv1enc: move slice allocation out of generic encode init

--- libavcodec/ffv1enc.c | 48 ++-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index f8fbcb7486..032c69a060 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -739,32 +739,8 @@ av_

[FFmpeg-devel] [PATCH v3 06/10] ffv1enc: split off encoder initialization into a separate function

--- libavcodec/ffv1enc.c | 401 ++- libavcodec/ffv1enc.h | 30 2 files changed, 240 insertions(+), 191 deletions(-) create mode 100644 libavcodec/ffv1enc.h diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 7a6c718b41..0ef26db30a 100644 -

[FFmpeg-devel] [PATCH v3 08/10] ffv1enc: move plane info init into a separate function

--- libavcodec/ffv1enc.c | 39 ++- libavcodec/ffv1enc.h | 2 ++ 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 8c0f649b8d..f8fbcb7486 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.

[FFmpeg-devel] [PATCH v3 05/10] .gitignore: add exclusions for shader .c files

--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e810d11107..9cfc78b414 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,5 @@ /src /mapfile /tools/python/__pycache__/ +/libavcodec/vulkan/*.c +/libavfilter/vulkan/*.c -- 2.45.2.753.g447d99e1

[FFmpeg-devel] [PATCH v3 03/10] vulkan: add support for 10-bit planar RGB

--- libavutil/hwcontext_vulkan.c | 1 + libavutil/vulkan.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index c4704a3402..0a176a7058 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -327,

Re: [FFmpeg-devel] [PATCH v2 3/6] ffv1enc: split off encoder initialization into a separate function

On 11/14/24 00:46, Michael Niedermayer wrote: On Mon, Nov 11, 2024 at 04:40:15AM +0100, Lynne via ffmpeg-devel wrote: --- libavcodec/ffv1enc.c | 354 +++ libavcodec/ffv1enc.h | 30 2 files changed, 217 insertions(+), 167 deletions(-) create

[FFmpeg-devel] [PATCH v2 6/6] ffv1enc: add a Vulkan encoder

This commit implements a standard, compliant, version 3 and version 4 FFv1 encoder, entirely in Vulkan. The encoder is written in standard GLSL and requires a Vulkan 1.3 supporting GPU with the BDA extension. The encoder can use any amount of slices, but nominally, should use 32x32 slices (1024 in

[FFmpeg-devel] [PATCH v2 5/6] ffv1enc: move slice allocation out of generic encode init

--- libavcodec/ffv1enc.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index a106e2130a..7572594f3e 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -710,24 +710,6 @@ av_cold int

[FFmpeg-devel] [PATCH v2 3/6] ffv1enc: split off encoder initialization into a separate function

--- libavcodec/ffv1enc.c | 354 +++ libavcodec/ffv1enc.h | 30 2 files changed, 217 insertions(+), 167 deletions(-) create mode 100644 libavcodec/ffv1enc.h diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 7a6c718b41..ca2c9f32e2 100644 -

[FFmpeg-devel] [PATCH v2 4/6] ffv1enc: move plane info init into a separate function

--- libavcodec/ffv1enc.c | 40 libavcodec/ffv1enc.h | 2 ++ 2 files changed, 26 insertions(+), 16 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index ca2c9f32e2..a106e2130a 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc

[FFmpeg-devel] [PATCH v2 2/6] .gitignore: add exclusions for shader .c files

--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e810d11107..9cfc78b414 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,5 @@ /src /mapfile /tools/python/__pycache__/ +/libavcodec/vulkan/*.c +/libavfilter/vulkan/*.c -- 2.45.2.753.g447d99e1

[FFmpeg-devel] [PATCH v2 1/6] hwcontext_vulkan: explicitly wait when uploading

--- libavutil/hwcontext_vulkan.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 0b52ad5112..0c9047f4c6 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -4200,13 +4200,1

Re: [FFmpeg-devel] [PATCH 6/7] ffv1: use standard syntax for indexing state

On 11/10/24 02:36, Michael Niedermayer wrote: On Sat, Nov 09, 2024 at 08:22:25AM +0100, Lynne via ffmpeg-devel wrote: It isn't immediately obvious what indexing this array does. Use standard syntax instead. --- libavcodec/ffv1.h | 2 +- libavcodec/ffv1dec_template.

[FFmpeg-devel] [PATCH 7/7] ffv1enc: add a Vulkan encoder

This commit implements a standard, compliant, version 3 and version 4 FFv1 encoder, entirely in Vulkan. The encoder is written in standard GLSL and requires a Vulkan 1.3 supporting GPU with the BDA extension. The encoder can use any amount of slices, but nominally, should use 32x32 slices (1024 in

[FFmpeg-devel] [PATCH 5/7] ffv1enc: move slice allocation out of generic encode init

--- libavcodec/ffv1enc.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 023b32e10c..36db135f49 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -710,24 +710,6 @@ av_cold int

[FFmpeg-devel] [PATCH 6/7] ffv1: use standard syntax for indexing state

It isn't immediately obvious what indexing this array does. Use standard syntax instead. --- libavcodec/ffv1.h | 2 +- libavcodec/ffv1dec_template.c | 2 +- libavcodec/ffv1enc_template.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1.h b/libavc

[FFmpeg-devel] [PATCH 4/7] ffv1enc: move plane info init into a separate function

--- libavcodec/ffv1enc.c | 40 libavcodec/ffv1enc.h | 2 ++ 2 files changed, 26 insertions(+), 16 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 10103f129b..023b32e10c 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc

[FFmpeg-devel] [PATCH 3/7] ffv1enc: split off encoder initialization into a separate function

--- libavcodec/ffv1enc.c | 352 +++ libavcodec/ffv1enc.h | 30 2 files changed, 216 insertions(+), 166 deletions(-) create mode 100644 libavcodec/ffv1enc.h diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 7a6c718b41..10103f129b 100644 -

[FFmpeg-devel] [PATCH 2/7] .gitignore: add exclusions for shader .c files

--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e810d11107..9cfc78b414 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,5 @@ /src /mapfile /tools/python/__pycache__/ +/libavcodec/vulkan/*.c +/libavfilter/vulkan/*.c -- 2.45.2.753.g447d99e1

[FFmpeg-devel] [PATCH 1/7] hwcontext_vulkan: explicitly wait when uploading

--- libavutil/hwcontext_vulkan.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 0b52ad5112..0c9047f4c6 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -4200,13 +4200,1

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Support slice coding mode 1 with golomb rice

On 25/10/2024 03:57, Michael Niedermayer wrote: Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 20 ++-- libavcodec/ffv1dec_template.c | 3 +++ libavcodec/ffv1enc.c | 23 --- 3 files chang

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_video: add mapping for AV_PIX_FMT_Y216

On 24/10/2024 01:03, James Almer wrote: Signed-off-by: James Almer --- libavcodec/vulkan_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_video.c b/libavcodec/vulkan_video.c index a97d224d55..c58353246c 100644 --- a/libavcodec/vulkan_video.c +++

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

On 16/10/2024 15:26, Michael Niedermayer wrote: This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with rawlsb=4 Please test and comment This stores the LSB through non binary range coding, this is simpler than using a separate coder For cases where range coding is not w

Re: [FFmpeg-devel] [RFC PATCH 2/2] fate: Make it possible to have alternative reference files

On 18/10/2024 14:41, Hendrik Leppkes wrote: On Fri, Oct 18, 2024 at 2:09 PM Alexander Strasser via ffmpeg-devel wrote: This caused differences with 2 fate tests depending on the zlib version used. 2 fate tests? https://fate.ffmpeg.org/report.cgi?time=20241016173824&slot=x86_32-msvc14-dll-md-w

Re: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: fix use after free on close

On 17/10/2024 20:23, Marvin Scholz wrote: The way the linked list of images was freed caused a use after free, by accessing pic->next after pic was already freed. Regression from 48a1a12968345bf673db1e1cbb5c64bd3529c50c Fix CID1633236 --- libavcodec/hw_base_encode.c | 6 +++--- 1 file change

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

On 16/10/2024 14:06, Niklas Haas wrote: On Mon, 14 Oct 2024 11:03:49 -0700 Dale Curtis wrote: Any issues remaining with this patch? Thanks in advance for applying. - dale I guess I'll apply it in 24h if there are no objections. The dynamically allocated version, right? OpenPGP_0xA2FEA5F0

Re: [FFmpeg-devel] [PATCH 2/2] vulkan: enable selecting a compatible representation of format

On 16/10/2024 11:56, emufan 4568 wrote: This works okay on the VC2 vulkan encoder patch Στις Τετ 16 Οκτ 2024 στις 10:21 π.μ., ο/η Lynne via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> έγραψε: When using **integer** images inside shaders, it turns out that conversion doesn't automatic

Re: [FFmpeg-devel] [PATCH] hw_base_encode: Free pictures on close

On 15/10/2024 17:51, Lynne via ffmpeg-devel wrote: On 15/10/2024 16:49, David Rosca wrote: Fixes leaking recon surfaces with VAAPI. ---   libavcodec/hw_base_encode.c | 5 +   1 file changed, 5 insertions(+) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index

[FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: always enable MUTABLE creation flag

We need it even for something as simple as bitexact opening of images. --- libavutil/hwcontext_vulkan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 6a5f1325ac..dec5fdaa46 100644 --- a/libavutil/hwcontex

[FFmpeg-devel] [PATCH 2/2] vulkan: enable selecting a compatible representation of format

When using **integer** images inside shaders, it turns out that conversion doesn't automatically happen, but we need to explicitly use the imageviews to get the image exposed as a suitable representation for the shader. Finally enables bitexact image representations. --- libavfilter/vf_nlmeans_vu

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ffv1: Support storing LSB raw

On 16/10/2024 01:17, Michael Niedermayer wrote: This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with rawlsb=4 Please test and comment This stores the LSB through non binary range coding, this is simpler than using a separate coder For cases where range coding is not w

Re: [FFmpeg-devel] [PATCH] hw_base_encode: Free pictures on close

On 15/10/2024 16:49, David Rosca wrote: Fixes leaking recon surfaces with VAAPI. --- libavcodec/hw_base_encode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index 7b6ec97d3b..912c707a68 100644 --- a/libavcodec/hw_base_encod

Re: [FFmpeg-devel] [PATCH 1/4] lavu/pixfmt: add AV_PIX_FMT_RGBA128

On 15/10/2024 03:50, James Almer wrote: On 10/14/2024 10:41 PM, Lynne via ffmpeg-devel wrote: On 14/10/2024 17:24, James Almer wrote: On 10/14/2024 12:11 PM, Lynne via ffmpeg-devel wrote: On 12/10/2024 01:01, Lynne wrote: This format is useful for doing certain lossless transforms on images

Re: [FFmpeg-devel] [PATCH 1/4] lavu/pixfmt: add AV_PIX_FMT_RGBA128

On 14/10/2024 17:24, James Almer wrote: On 10/14/2024 12:11 PM, Lynne via ffmpeg-devel wrote: On 12/10/2024 01:01, Lynne wrote: This format is useful for doing certain lossless transforms on images, RCT in particular, which require you to escalate the size from 16 to 32 bits to avoid overflows

Re: [FFmpeg-devel] [PATCH 1/4] lavu/pixfmt: add AV_PIX_FMT_RGBA128

On 12/10/2024 01:01, Lynne wrote: This format is useful for doing certain lossless transforms on images, RCT in particular, which require you to escalate the size from 16 to 32 bits to avoid overflows. APIchanges will be done alongside when comitting. --- libavutil/pixdesc.c | 27 +

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: add proper maps for XV3{0, 6}

On 14/10/2024 16:50, James Almer wrote: Signed-off-by: James Almer --- libavutil/hwcontext_vulkan.c | 9 - libavutil/vulkan.c | 3 ++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 47e21fda83

Re: [FFmpeg-devel] [PATCH 4/7] hwcontext_vulkan: add support for AV_PIX_FMT_RGBA32

On 12/10/2024 00:11, James Almer wrote: On 10/10/2024 2:32 AM, Lynne via ffmpeg-devel wrote: ---   libavutil/hwcontext_vulkan.c |  1 +   libavutil/vulkan.c   | 11 ++-   2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil

[FFmpeg-devel] [PATCH 4/4] vulkan: add support for AV_PIX_FMT_RGB96

--- libavutil/hwcontext_vulkan.c | 1 + libavutil/vulkan.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 98c25da1c1..0555f0e670 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_v

[FFmpeg-devel] [PATCH 2/4] lavu/pixfmt: add AV_PIX_FMT_RGB96

--- libavutil/pixdesc.c | 24 libavutil/pixfmt.h | 4 2 files changed, 28 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 8736e4f47d..26ed941aea 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -2775,6 +2775,30 @@ static cons

[FFmpeg-devel] [PATCH 3/4] vulkan: add support for AV_PIX_FMT_RGBA128

--- libavutil/hwcontext_vulkan.c | 1 + libavutil/vulkan.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 47e21fda83..98c25da1c1 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil

[FFmpeg-devel] [PATCH 1/4] lavu/pixfmt: add AV_PIX_FMT_RGBA128

This format is useful for doing certain lossless transforms on images, RCT in particular, which require you to escalate the size from 16 to 32 bits to avoid overflows. APIchanges will be done alongside when comitting. --- libavutil/pixdesc.c | 27 +++ libavutil/pixfmt.h |

Re: [FFmpeg-devel] [PATCH 1/7] lavu/pixfmt: add AV_PIX_FMT_RGBA32

On 11/10/2024 23:06, Michael Niedermayer wrote: On Thu, Oct 10, 2024 at 07:32:45AM +0200, Lynne via ffmpeg-devel wrote: This format is useful for doing certain lossless transforms on images, RCT in particular, which require you to escalate the size from 16 to 32 bits to avoid overflows

[FFmpeg-devel] [PATCH] libavcodec/Makefile: add a makefile for Vulkan shaders

--- libavcodec/Makefile| 10 +- libavcodec/vulkan/Makefile | 10 ++ 2 files changed, 11 insertions(+), 9 deletions(-) create mode 100644 libavcodec/vulkan/Makefile diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 5df4b7cfc3..dd5d0de898 100644 --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/ffv1enc: Prevent generation of files with broken slices

On 01/10/2024 22:31, Michael Niedermayer wrote: Fixes: Ticket5548 Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.c| 7 +++ libavcodec/ffv1.h| 1 + libavcodec/ffv1enc.c | 4 3 files changed, 12 insertions(+) diff --git a/libavcodec

Re: [FFmpeg-devel] Howto utilize GPU acceleration outside expected places?

On 10/10/2024 10:50, martin schitter wrote: On 10.10.24 08:06, Lynne via ffmpeg-devel wrote: You can copy libavutil/vulkan* into whatever project you want, and change 4 #include lines to make it compile. This lets you use the same API to construct and execute shaders as you would within lavc

Re: [FFmpeg-devel] [PATCH 2/7] lavu/pixfmt: add AV_PIX_FMT_RGB32

On 10/10/2024 07:32, Lynne wrote: --- libavutil/pixdesc.c | 24 libavutil/pixfmt.h | 4 2 files changed, 28 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 7174989072..a741d9bcb7 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixde

Re: [FFmpeg-devel] Howto utilize GPU acceleration outside expected places?

On 10/10/2024 06:05, martin schitter wrote: Can someone here point me to an example, how to use GPU acceleration outside of external hw_decode/encode facilities or vulkan_filters, just as more suitable compute mechanism and for better float image data support in ordinary ffmpeg code modules?

[FFmpeg-devel] [PATCH 7/7] hwcontext_vulkan: enable shaderBufferInt64Atomics if supported

--- libavutil/hwcontext_vulkan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 3bb6d838f6..3be29a20f7 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -256,6 +256,7 @@ static void device_feature

  1   2   3   4   5   >