Re: [FFmpeg-devel] [PATCH] swresample/swresample: Fix input channel count in resample_first computation

2018-07-24 Thread Marcin Gorzel
Looks good, thanks Michael! On Tue, Jul 24, 2018 at 6:15 PM Michael Niedermayer wrote: > Found-by: Marcin Gorzel > Signed-off-by: Michael Niedermayer > --- > libswresample/swresample.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libswre

Re: [FFmpeg-devel] [PATCH] swresample: Use channel count in rematrix initialization

2018-07-24 Thread Marcin Gorzel
On Mon, Jul 23, 2018 at 7:52 AM Michael Niedermayer wrote: > On Sat, Jul 21, 2018 at 07:31:12PM +0100, Marcin Gorzel wrote: > > Rematrixing supports up to 64 channels. However, there is only a limited > number of channel layouts defined. Since the in/out channel count is > cur

[FFmpeg-devel] [PATCH] swresample: Use channel count in rematrix initialization

2018-07-24 Thread Marcin Gorzel
Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is currently obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fails. This patch changes rematrix

[FFmpeg-devel] [PATCH] swresample: Use channel count in rematrix initialization

2018-07-21 Thread Marcin Gorzel
Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is currently obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fails. This patch changes rematrix

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-21 Thread Marcin Gorzel
9AM +0200, Tobias Rapp wrote: > > On 19.07.2018 23:37, Michael Niedermayer wrote: > > >On Thu, Jul 19, 2018 at 01:53:09PM +0200, Tobias Rapp wrote: > > >>On 18.07.2018 19:31, Marcin Gorzel wrote: > > >>>Rematrixing supports up to 64 channels. However, there

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-19 Thread Marcin Gorzel
Hi Tobias, Sounds good, thanks a lot! Regards, Marcin On Thu, Jul 19, 2018 at 12:53 PM Tobias Rapp wrote: > On 18.07.2018 19:31, Marcin Gorzel wrote: > > Rematrixing supports up to 64 channels. However, there is only a limited > number of channel layouts defined. Since the in

[FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-18 Thread Marcin Gorzel
Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fails. In ticket #6790 the problem has been

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-18 Thread Marcin Gorzel
Thanks for your input Tobias! On Wed, Jul 18, 2018 at 3:23 PM Tobias Rapp wrote: > On 13.07.2018 13:43, Marcin Gorzel wrote: > > Rematrixing supports up to 64 channels. However, there is only a limited > number of channel layouts defined. Since the in/out channel count is >

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-17 Thread Marcin Gorzel
ould love to improve it by eliminating the problem I've experienced. Marcin On Mon, Jul 16, 2018 at 9:23 PM Michael Niedermayer wrote: > On Mon, Jul 16, 2018 at 03:37:15PM +0100, Marcin Gorzel wrote: > > Hi Michael, > > > > On Sat, Jul 14, 2018 at 4:01 PM Michael Niederma

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-16 Thread Marcin Gorzel
Hi Michael, On Sat, Jul 14, 2018 at 4:01 PM Michael Niedermayer wrote: > On Fri, Jul 13, 2018 at 12:43:36PM +0100, Marcin Gorzel wrote: > > Rematrixing supports up to 64 channels. However, there is only a limited > number of channel layouts defined. Since the in/out channel count i

[FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-13 Thread Marcin Gorzel
Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fails. In ticket #6790 the problem has been

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-11 Thread Marcin Gorzel
Michael, Nicolas, Do you think this patch is now ready to be applied? Or would you like me to make any further changes? Thanks, Marcin On Tue, Jul 10, 2018 at 10:34 AM Marcin Gorzel wrote: > Hi Michael, > > I think I know where the misunderstanding could be. > > The main chan

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-10 Thread Marcin Gorzel
ks in the swresample.c, if you think they are unnecessary, I will happily remove them from this patch. Please let me know! Regards, Marcin On Mon, Jul 9, 2018 at 9:11 PM Michael Niedermayer wrote: > On Mon, Jul 09, 2018 at 01:55:37PM +0100, Marcin Gorzel wrote: > > Thank you for your commen

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-10 Thread Marcin Gorzel
me know if you still have concerns. Regards, -- Marcin Gorzel | Software Engineer | gor...@google.com | ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-09 Thread Marcin Gorzel
, wav, to 'output_6ch.wav': Metadata: ISFT: Lavf58.17.101 Stream #0:0, 0, 1/48000: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 48000 Hz, 5.1, s16, 4608 kb/s Regards, Marcin -- Marcin Gorzel | Software Engineer | gor...@google.com | ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-09 Thread Marcin Gorzel
Rematrixing supports up to 64 channels but there is only a limited number of channel layouts defined. Currently, in/out channel count is obtained from the channel layout so if the channel layout is undefined (e.g. for 9, 10, 11 channels etc.) the in/out channel count will be 0 and the

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-09 Thread Marcin Gorzel
, Jul 06, 2018 at 03:15:58PM +0100, Marcin Gorzel wrote: > > Rematrixing supports up to 64 channels but there is only a limited > number of channel layouts defined. Currently, in/out channel count is > obtained from the channel layout so if the channel layout is undefined > (e.g. for

[FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-06 Thread Marcin Gorzel
Rematrixing supports up to 64 channels but there is only a limited number of channel layouts defined. Currently, in/out channel count is obtained from the channel layout so if the channel layout is undefined (e.g. for 9, 10, 11 channels etc.) the in/out channel count will be 0 and the