Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

On Tue, Aug 31, 2021 at 22:49:12 +, Soft Works wrote: > As for the "sleet" filter: Yes - it is totally useless for practical > use. I had explained why I added it in the 0/8 message: > > > Why leet? Real world use is surely questionable, but it has two advantages > > that make it a great

Re: [FFmpeg-devel] [PATCH] avcodec/truemotion1: Cleanup prediction code in truemotion1_decode_16bit and truemotion1_decode_24bit

On Sat, Aug 14, 2021 at 11:29:40 +, ffmpegandmahanstreamer@e.email wrote: Just formal stuff: > /* if macroblock width is 2, apply C-Y-C-Y; else > * apply C-Y-Y */ > +APPLY_C_PREDICTOR(); > +

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

Hi, > -enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 1.5.2" > libvmaf.h compute_vmaf > +enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 2.0.0" > libvmaf.h vmaf_init General question: Is it acceptable to drop support for libvmaf 1.x? I saw that Fedora

[FFmpeg-devel] git send-email and SMTP (Was: Re: pixfmt: fixed wrong fix of comment)

Hi Валерий, On Mon, May 31, 2021 at 15:12:12 +0300, Валерий Заподовников wrote: > BTW, who knows how can I use git send-(gmail)email script to NOT use SMTP? > I do not want my ipv6 address revealed, that is how it works on gmail for > Android (that I am using RIGHT now) and on mail. google. com.

Re: [FFmpeg-devel] libavcodec: r12b decoder + r12b fourcc

On Wed, Jun 09, 2021 at 19:25:41 +0200, Dennis Fleurbaaij wrote: > OBJS-$(CONFIG_R10K_ENCODER)+= r210enc.o > OBJS-$(CONFIG_R210_DECODER)+= r210dec.o > +OBJS-$(CONFIG_R12B_DECODER)+= r12bdec.o > OBJS-$(CONFIG_R210_ENCODER)+= r210enc.o I'm sure

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

On Tue, May 25, 2021 at 18:53:11 -0700, Mohammad Izadi wrote: > Subject: Pass the HDR10+ metadata to the packet side data in VP9 encoder You should prefix this with "avcodec: ". > API changes, most recent first: > +2021-05-25 - xx - lavc 58.137.101 - packet.h > + Add

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

On Tue, May 25, 2021 at 20:16:29 -0600, Pavel Koshevoy wrote: > -sub->pts > ctx->last_real_time + av_rescale_q(200, ms_tb, > AV_TIME_BASE_Q)) { > +sub->pts >= ctx->last_real_time + > av_rescale_q(ctx->real_time_latency_msec, ms_tb, AV_TIME_BASE_Q)) { [...] > +{

Re: [FFmpeg-devel] [PATCH] fix broken links to msdn documentation

On Mon, May 10, 2021 at 11:58:23 +1000, Peter Ross wrote: > * _snprintf/_vsnprintf() to workaround this problem. > - * See http://msdn.microsoft.com/en-us/library/1kt27hek(v=vs.80).aspx */ > + * See >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc: Actually zero padding

On Tue, Apr 27, 2021 at 16:17:55 +0200, Andreas Rheinhardt wrote: > Moritz Barsnick: > > In other words: I think you meant to write: "Actually apply zero > > padding". > zero is the verb. Ouch. Touché and thanks. Moritz _

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc: Actually zero padding

On Mon, Apr 26, 2021 at 19:15:10 +0200, Andreas Rheinhardt wrote: > Subject: [PATCH 1/2] avcodec/vc2enc: Actually zero padding Dieser Satz kein Verb. In other words: I think you meant to write: "Actually apply zero padding". Cheers, Moritz ___

Re: [FFmpeg-devel] [PATCH v1 1/3] libavformat/rtsp.h : Add member ignore_rtcp to RTSPState

On Sun, Apr 18, 2021 at 00:55:26 +0800, su...@epoint.com.cn wrote: > From: Minlei Sun > > Signed-off-by: Minlei Sun These three patches can certainly be squashed - they are of no use individually. And you need to amend the documentation (doc/protocols.texi). Also, I'm not sure whether

Re: [FFmpeg-devel] [PATCH] vf_v360: fix visibility test for fisheye projection

On Fri, Mar 19, 2021 at 20:42:04 +1100, Daniel Playfair Cal wrote: > -const int visible = hypotf(uf, vf) <= 0.5f; > +const int visible = -0.5 < uf && uf < 0.5 && -0.5 < vf && vf < 0.5; Please avoid double constants in float expressions, they propagate the whole calculation to a double.

Re: [FFmpeg-devel] Patch for ticket #9151

Hi Dominic, On Thu, Mar 18, 2021 at 16:15:59 -0400, Dominic Mayers wrote: > Hello, > > Ticket #9151 > Applies to: > > ffmpeg version N-101612-gda12d600ea Copyright (c) 2000-2021 the FFmpeg > developers > built with gcc 9 (Ubuntu 9.3.0-17ubuntu1~20.04) > > Compiled ffmpeg to include

Re: [FFmpeg-devel] [PATCH v2] avformat/pp_bnk: treat music files are stereo

On Tue, Mar 16, 2021 at 18:30:19 +1000, Zane van Iperen wrote: Nit: > Subject: avformat/pp_bnk: treat music files are stereo ^ as Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

On Sun, Aug 23, 2020 at 22:50:18 +0300, Martin Storsjö wrote: > > On Fri, Aug 21, 2020 at 12:19:06 +0300, Martin Storsjö wrote: > > > LGTM, with one small nit: > > [...] > > > > {"listen", "Listen for incoming connections", > > > > offsetof(pstruct, options_field . listen),

Re: [FFmpeg-devel] [PATCH v4] libsvtav1: Add logical_processors option

On Wed, Mar 10, 2021 at 00:12:34 -0600, Christopher Degawa wrote: > +@item logical_processors > +Number of logical processors to run the encoder on, threads are managed by > the OS scheduler. > +Used for limiting the size of memory buffers and threads for a target > logical processor count. >

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

On Thu, Mar 04, 2021 at 22:47:57 +0100, Carl Eugen Hoyos wrote: > > #include > > It is included through common.h - do we add it to every C file > that would need it if common.h were not included? Okay, that's quite indirectly and implicitly via libavutil/internal.h. I don't know the policy on

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

On Thu, Mar 04, 2021 at 20:37:26 +0100, Carl Eugen Hoyos wrote: > attached patch fixes a few warnings when compiling for 32bit. > av_log(s, AV_LOG_DEBUG, "START %s\n", where); > -av_log(s, AV_LOG_DEBUG, "pos: %lX\n", avio_tell(s->pb)); > +av_log(s, AV_LOG_DEBUG, "pos: %"PRIX64"\n",

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: > I... just am not so sure in this case splitting the TTML writer and > the TTML encoder from each other makes sense. I agree. In very many cases, muxer and encoder, or demuxer and decoder are only useful together. Yet I have observed

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: fix https://trac.ffmpeg.org/ticket/7517

On Thu, Mar 04, 2021 at 15:38:56 +0800, gaojiang...@live.com wrote: > Subject: avformat/rtsp: fix https://trac.ffmpeg.org/ticket/7517 Please write what you actually do in the first line summary of the commit message, and mention the trac ticket in the body. > +AVDictionary *opts =

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

On Wed, Mar 03, 2021 at 22:09:12 +0200, Jan Ekström wrote: > Thus, I will be pulling this set in Soon (probably tomorrow). Thus if > anyone still wishes to have a say, I recommend doing it earlier than > later. > + * Copyright (c) 2020 24i Is 24i a company? Just wondering. Also, I'm not sure

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/xpm: Minor speed increase for mod_strcspn() {string, reject}==0

On Mon, Feb 22, 2021 at 20:32:14 -0800, Jose Da Silva wrote: > -for (i = 0; string && string[i]; i++) { > +if (string == 0) "if (!string)" is the preferred style for pointers. But I don't see the advantage - isn't the loop interrupted immediately anyway if string == NULL? (Same for the

Re: [FFmpeg-devel] [PATCH 3/2] doc/encoders: Add documentation for the GIF encoder

On Sun, Feb 21, 2021 at 13:12:27 +, Derek Buitenhuis wrote: > +@item global_palette @var{integer} > +Writes a palette to the global GIF header whee feasible. ^ where Moritz ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2] avformat/concatdec: add support for setting input options

On Wed, Feb 03, 2021 at 20:37:35 +0200, Jan Ekström wrote: > > +@item @code{input_options @var{key=value:key2=value2}} > +Input options passed on when reading a specific file, using a :-separated > list > +of key=value pairs. Requires @code{safe} to be non-positive. Global options > for > +all

Re: [FFmpeg-devel] [PATCH v4 7/9] avformat: add h266/vvc muxer

On Mon, Jan 25, 2021 at 22:15:05 +0800, Nuo Mi wrote: > +.extensions= "hevc,h266,266", Is ".hevc" a valid extension for H.266/VVC? Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

On Wed, Nov 25, 2020 at 00:47:46 +0100, Andreas Rheinhardt wrote: > and therefore concluded that adding an APIChanges entry is appropriate; > but I can of course also omit it. > Is a version bump necessary? If yes, minor or micro? I would say so - a change in options (and/or feature set) should

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: fix code style in is_common_init_section_exist

On Fri, Jan 15, 2021 at 20:13:44 +0800, Steven Liu wrote: > > Good idea, but the indentation is incorrect. The subsequent lines are > > not arguments to av_strcasecmp(), but further clauses for if(). > > > > Also, you should make this change the first commit of your series which > Hi Moritz, > >

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: Fix WebVTT decoder truncating files at first STYLE block

On Tue, Jan 12, 2021 at 17:40:06 +, Dave Evans wrote: > Hijacking with related, similar patch from a few months ago: > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2538 ... which even includes a fate test, which is what I was about to request from the newly submitted patch.

Re: [FFmpeg-devel] [PATCH 5/5] avformat/hlsenc: use AV_OPT_TYPE_DURATION

On Wed, Jan 06, 2021 at 23:35:31 +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/muxers.texi | 4 ++-- > libavformat/hlsenc.c | 18 +- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: fix code style in is_common_init_section_exist

On Tue, Jan 12, 2021 at 21:20:03 +0800, liuqi05 wrote: > -if (av_strcasecmp(pls[i]->init_section->url, url) || > pls[i]->init_section->url_offset != url_offset || pls[i]->init_section->size > != size) { > +if (av_strcasecmp(pls[i]->init_section->url, url) || > +

Re: [FFmpeg-devel] [PATCH] avfilter: add asupcut filter

On Mon, Nov 23, 2020 at 19:52:23 +0100, Paul B Mahol wrote: > +@item cutoff > +Set cutoff frequency in herz. Allowed range is 2 to 192000. Nit: Hertz (with "tz" and capitalized). Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 030/162] avcodec/rv10: Make initializing static RV10 VLCs thread-safe

On Fri, Nov 20, 2020 at 08:19:03 +0100, Andreas Rheinhardt wrote: > +static av_cold void rv10_init_static(void) > +{ > +INIT_VLC_STATIC(_dc_lum, DC_VLC_BITS, 256, > +rv_lum_bits, 1, 1, > +rv_lum_code, 2, 2, 16384); > +

Re: [FFmpeg-devel] [PATCH] avfilter: add speechnorm filter

Hi Paul, On Sat, Nov 07, 2020 at 00:27:15 +0100, Paul B Mahol wrote: Just some minor grammar/spelling corrections: > +This filter expands or compress each half-cycle of audio samples compresses > +(local set of samples all above or all bellow zero) depending on threshold > value, > +so audio

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

On Wed, Nov 04, 2020 at 14:08:23 +, Joakim Tjernlund wrote: > > No it doesn't. It forces them to upgrade away from a known vulnerable > > old Chromium version to one that does not have the issue. > > I was referring to what is out/released now. Eventually all SW will upgrade > for one reason

Re: [FFmpeg-devel] [PATCH] avformat/dhav: also support ZLAV packets

On Sat, Oct 24, 2020 at 13:32:25 +1300, Michael Keeley wrote: > -if (memcmp(p->buf, "DHAV", 4)) > +if (memcmp(p->buf, "DHAV", 4) != 0 && memcmp(p->buf, "ZLAV", 4) != 0) The "!= 0" isn't necessary. > -if (!memcmp(signature, "DHAV", 4)) { > +if (memcmp(signature, "DHAV", 4)

Re: [FFmpeg-devel] about mpeg-2 audio (note - NOT AAC)

Hi Amon, these are actually good questions for the ffmpeg-user mailing list. (ffmpeg-devel is for discussion about the actual development of ffmpeg.) On Fri, Oct 23, 2020 at 19:09:18 +, Amon Gibson Albuquerque Nunes wrote: > i wondered what would happen if ffmpeg had actual decoding (and >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mspdec: Microsoft Paint (MSP) demuxer

On Thu, Oct 08, 2020 at 22:02:02 +1100, Peter Ross wrote: > Week nine or so of lockdown... What, wait. I'm like week thirty or so. ;) > OBJS-$(CONFIG_MPJPEG_DEMUXER)+= mpjpegdec.o > OBJS-$(CONFIG_MPJPEG_MUXER) += mpjpeg.o > OBJS-$(CONFIG_MPL2_DEMUXER) +=

Re: [FFmpeg-devel] [WIP] Organisation process

Hi Jean-Baptiste, On Fri, Oct 02, 2020 at 00:41:34 +0200, Jean-Baptiste Kempf wrote: > Hello folks, Nit: > The TC is resolving technical conflicts but is not a technical steering > committee. If it's not only happening right now, but happens in general, you write: The TC resolves

Re: [FFmpeg-devel] [PATCH v2] avformat/libsrt: print streamid at client

On Thu, Oct 01, 2020 at 14:13:14 +0530, raghavendra wrote: > Print the SRT streamid at the client. > Logged to the context and changed info to verbose. No, this is a patch on top of your original patch. That is not acceptable. You need to change the original commit and resubmit that. >

Re: [FFmpeg-devel] Example filter that process video and audio

On Sun, Sep 27, 2020 at 14:03:52 +0100, da...@3adesign.co.uk wrote: > Was looking to create a filter to process video and audio in a filter graph, > can find examples in movie or a source that has both video and audio but not > anything that takes both, any pointers to something to use as a

Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_commoh.h: remove unsupported decklink version ifdef

On Tue, Sep 08, 2020 at 19:52:29 +0200, Marton Balint wrote: > Subject: Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_commoh.h: remove Nit: typo^ Moritz ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

On Wed, Sep 09, 2020 at 09:57:24 +0200, Zlomek, Josef wrote: > On Tue, Sep 8, 2020 at 3:19 PM Moritz Barsnick wrote: > > Missing version bumps. > There is a version bump for libavformat, as new demuxer was added. I didn't see that in v4. > I did not know that version should be

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

On Fri, Sep 04, 2020 at 00:59:46 +0200, Lynne wrote: > > Fixes: 4907 > > > > Adds support for decoding of animated WebP. > Sorry it took me so long to get to this. > Took a look and the patch looks fine to me. > Will apply in a few days unless someone else has comments or I find something > I >

Re: [FFmpeg-devel] [PATCH v3 3/4] lavfi: check the validity of formats lists.

On Mon, Aug 24, 2020 at 13:36:50 +0200, Nicolas George wrote: > +switch (link->type) { > + > +case AVMEDIA_TYPE_VIDEO: > +if ((ret = ff_formats_check_pixel_formats(log, cfg->formats)) < > 0) > +return ret; > +break; > + > +case

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/allfilters: Don't cast const away

On Sun, Aug 23, 2020 at 23:31:45 +0800, Zhao Zhili wrote: > >> I have a same patch long time ago. > >> > >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/252193.html > >> > >>

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

On Wed, Aug 26, 2020 at 23:52:58 -0700, Jim DeLaHunt wrote: > Earlier this year, there were patches[3] which aimed to put linear > timecodes in a format related to SMPTE 12M into a structure marked by a > `AV_FRAME_DATA_S12M_TIMECODE` value. Maybe that refers to a location > where you could store

Re: [FFmpeg-devel] [RFC PATCH v6 3/4] libavcodec/j2kenc: Support for multiple layers

On Wed, Aug 26, 2020 at 21:28:17 +0530, gautamr...@gmail.com wrote: > +@item layer_rates @var{string} > +By default, compression is done using the quality metric. This option allows > for > +compression using compression ratio. The compression ratio for each level > could > +be specified. The

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

On Wed, Aug 26, 2020 at 16:31:46 +, Anamitra Ghorui wrote: > >> +uint8_t ff_flif16_rac_read_bit(FLIF16RangeCoder *rc, > >> + uint8_t *target) > >> +{ > >> +return ff_flif16_rac_get(rc, rc->range >> 1, target); > >> +} > > > > If this is called often, you may

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

On Sat, Aug 22, 2020 at 21:55:21 +0100, Mark Thompson wrote: > > Without checking in more detail: Wouldn't this break the > > "-noise_reduction", "-non_deterministic" and "-non_linear_quant" > > options? > > The intent is to extend what already happens - given an argument like > "-nougat", it

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

On Sun, Aug 23, 2020 at 00:09:32 +0530, Anamitra Ghorui wrote: > v2: Fix faulty patch > v3: Fix addressed errors, Add interlaced decoding support > v4: Fix Further cosmetics, C.Bucket Transform reading errors, Atomise patch > v5: Fix faulty patch > v6: Address pointed out errors, use av_freep

Re: [FFmpeg-devel] [PATCH v6 4/4] doc: add documentation entries for FLIF

On Sun, Aug 23, 2020 at 00:09:35 +0530, Anamitra Ghorui wrote: > - RPZA video encoder > - > +- FLIF16 decoder > +- FLIF16 demuxer This should be part of the corresponding commits. And don't drop the empty line. > @tab Sorenson H.263 used in Flash > +@item FLIF (Free Lossless Image Format

Re: [FFmpeg-devel] [PATCH v6 3/4] configure: add FLIF dependencies

On Sun, Aug 23, 2020 at 00:09:34 +0530, Anamitra Ghorui wrote: > --- a/configure > +++ b/configure > @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" > flac_demuxer_select="flac_parser" > flv_muxer_select="aac_adtstoasc_bsf" > gxf_muxer_select="pcm_rechunk_bsf" > +flif_demuxer_select="zlib exif"

Re: [FFmpeg-devel] [PATCH v6 2/4] lavfmt: add FLIF demuxing support

On Sun, Aug 23, 2020 at 00:09:33 +0530, Anamitra Ghorui wrote: > Subject: Re: [FFmpeg-devel] [PATCH v6 2/4] lavfmt: add FLIF demuxing support ffmpeg usually uses "lavf" (or "avformat"). Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

On Thu, Aug 20, 2020 at 13:31:12 +0800, hwren wrote: > At 2020-08-19 22:14:04, "Moritz Barsnick" wrote: > >ffmpeg prefers the "cur++" style (twice in this block, and elsewhere). > > Will be corrected. Thanks. > >Is "low_delay" part of

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

On Thu, Aug 20, 2020 at 13:24:44 +0800, hwren wrote: > At 2020-08-19 22:18:52, "Moritz Barsnick" wrote: > >On Wed, Aug 19, 2020 at 14:25:53 +0800, hwr...@126.com wrote: > >> + * AVS3 related definition > > > >definitions? > >> +}; > >>

Re: [FFmpeg-devel] [PATCH] configure: Add additional glslang libraries to make linking work

On Mon, Aug 17, 2020 at 16:21:23 -0700, Philip Langdale wrote: > The latest builds of glslang introduce new libraries that need to be > linked for all symbols to be fully resolved. > > Presumably, requiring these new libraries breaks building against > older glslang releases? What range are we

[FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

down, as "verifyhost" is related to the certificate options (and should thus perhaps even be above "listen"). I have come to realize that the httpproxy protocol could apply to any protocol with underlying tcp, but that's a different story. Thanks, Moritz From e2d93c4f5ad186a5277c8ae346948c588f

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

On Fri, Aug 21, 2020 at 15:10:09 +0200, Moritz Barsnick wrote: > Let me add my promised benchmarks. I have nothing modern here (these > CPUs are 10, 18 and 6 years old), but I can confirm the impressive > improvements: > > Intel Atom D525 Intel Pentium 4

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

On Fri, Aug 21, 2020 at 13:13:29 +0200, Paul B Mahol wrote: > Overall speed changes for 1920x1080, yuv422p10le, 60fps from: 0.19x to 0.343x Let me add my promised benchmarks. I have nothing modern here (these CPUs are 10, 18 and 6 years old), but I can confirm the impressive improvements:

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

On Thu, Aug 20, 2020 at 12:53:05 +0200, Moritz Barsnick wrote: > Alas, with the patchset, the following command quickly terminates with > Illegal instruction in ff_cfhd_horiz_filter_clip10_sse2 (): The same on this CPU, obviously, because it also doesn't support SSE4.1: [barsnick@pa

[FFmpeg-devel] [PATCH v2] avformat/http, tls: honor http_proxy command line variable for HTTPS

Patch version 2 attached, with added documentation. Moritz From 2f2a43e4c684cd4bfda420bbedf5125dd78b3b34 Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Thu, 20 Aug 2020 17:49:14 +0200 Subject: [PATCH] avformat/http,tls: honor http_proxy command line variable for HTTPS Add the "http_

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: > With this patch, -disable_auto_conversion_filters does what you want. [...] > +if (!po->name) { > +/* Try to match a boolean option with a negative prefix. */ > +for (int i = 0; i <

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

Hej Martin, On Thu, Aug 20, 2020 at 22:05:39 +0300, Martin Storsjö wrote: > Even if you do e.g. a plain tls socket (or rtmps, or whatever), you may > want to do the tls connection through a proxy server (be that a socks > proxy or http proxy). Actually, I forget that an HTTP proxy with CONNECT

[FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

on of tinyproxy. Please review. Thanks, Moritz From 095bb727b2400a75d6bf8c74ab90831aaefbc5aa Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Thu, 20 Aug 2020 17:49:14 +0200 Subject: [PATCH] libavformat/http,tls: honor http_proxy command line variable for HTTPS Add the "http_proxy" o

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

On Thu, Aug 20, 2020 at 20:02:32 +0530, Gautam Ramakrishnan wrote: > On Thu, Aug 20, 2020 at 3:02 PM Moritz Barsnick wrote: > > ... and what it does with this change. Looks like an NOP from the patch > > file alone. > It was done to provide functionality for the next patch

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

On Sun, Aug 16, 2020 at 18:25:12 +0200, Paul B Mahol wrote: > On 8/16/20, Paul B Mahol wrote: > > Please help porting this to linux and 64bit calling convention. > > New patch attached. > > This one does not allocate stack on x32. I wanted to benchmark on several machines (newest I have is a

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

On Wed, Aug 19, 2020 at 17:51:02 +0530, gautamr...@gmail.com wrote: Minor nits: > +static void compute_rates(Jpeg2000EncoderContext* s) > +{ > +int i, j; > +int layno, compno; > +for (i = 0; i < s->numYtiles; i++) { > +for (j = 0; j < s->numXtiles; j++) { > +

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch makes the ff_jpeg2000_cleanup > function take in an extra parameter which > indicates whether it is called from the > encoder or decoder. I fail to see an explanation why, ... > -void

Re: [FFmpeg-devel] [PATCH v5 5/5] lavc, doc: add libuavs3d video decoder wrapper

On Wed, Aug 19, 2020 at 14:25:56 +0800, hwr...@126.com wrote: > - AV1 Low overhead bitstream format demuxer > +- AVS3 video decoder via libuavs3d I wonder whether the raw demuxer should have been mentioned in its respective patch. Moritz ___

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

On Wed, Aug 19, 2020 at 14:25:53 +0800, hwr...@126.com wrote: > + * AVS3 related definition definitions? > +}; > \ No newline at end of file Please amend a carriage return to the last line. > + * AVS3 related definition definitions? Moritz ___

Re: [FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

On Wed, Aug 19, 2020 at 14:25:54 +0800, hwr...@126.com wrote: > +for (; cur < buf_size; ++cur) { > +state = (state << 8) | buf[cur]; > +if (ISPIC(buf[cur])){ > +++cur; ffmpeg prefers the "cur++" style (twice in this block, and elsewhere). > +

Re: [FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

On Tue, Aug 04, 2020 at 13:59:42 +0200, Anton Khirnov wrote: > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -2883,7 +2883,9 @@ static int init_input_stream(int ist_index, char > *error, int error_len) > ist->dec_ctx->opaque= ist; >

Re: [FFmpeg-devel] how to use http proxy in ffmpeg-devel

On Wed, Aug 05, 2020 at 20:48:20 +0800, 486179 wrote: > for example > avformat_alloc_output_context2(putFmtCtx, NULL, "rtmp", > "rtmp://1.1.1.1/live"); > or > avformat_open_input(InputFmtCtx, "rtmp://1.1.1.1/live", 0, 0) Wrong mailing list. For questions regarding the development with the ffmpeg

Re: [FFmpeg-devel] [PATCH v2 5/5] avformat/mpegtsenc: support 0x6a descriptor for AC-3 by side data if have

On Thu, Jul 30, 2020 at 22:58:58 +0800, lance.lmw...@gmail.com wrote: > if (codec_id == AV_CODEC_ID_AC3) { > +int len = 1; > + > +if (ts_st->desc6a.component_type_flag) len++; > +if (ts_st->desc6a.bsid_flag)

Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

On Thu, Jul 30, 2020 at 22:58:56 +0800, lance.lmw...@gmail.com wrote: > #include "libavutil/dovi_meta.h" > +#include "libavutil//mpegts_audio_desc_metadata.h" ^^ A duplicate slash slipped in there. > +av_log(ctx, AV_LOG_INFO, "component_type_flag: %u, bsid_flag: %u, " >

[FFmpeg-devel] [PATCH v6] avdevice/xcbgrab: check return values of xcb query functions

y, so I "fixed" dead code. You guys can remove the dead code yourselves then, if you like. ;-) New patch for the original issue attached, not touching the dead code. Thanks, Moritz From e44b7f03354add2272a2739e04aafb38b7ce027f Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Wed, 5 A

Re: [FFmpeg-devel] Ticket 5012

On Thu, Jul 16, 2020 at 17:10:06 +0530, Gautam Ramakrishnan wrote: > I was going through the bug tracker for a list of bugs associated with > jpeg2000. Looking at issue 5012, is there a good utility for solving > this issue? What do you mean with utility? I suppose you just need to implement

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

On Sun, Jul 12, 2020 at 22:44:46 +0800, myp...@gmail.com wrote: > Maybe I give an inaccurate description in the commit message, in fact, > libsrt 1.4.1 remove the SRTO_STRICTENC/SRTO_SMOOTHER option, it's will > lead to FFmpeg build fail when using libsrt version >= 1.4.1 I don't mind you

Re: [FFmpeg-devel] [PATCH 1/2] mpeg2: Renaming functions around init_uni_ac_vlc

On Mon, Jul 13, 2020 at 13:16:18 +0200, Jean-Baptiste Kempf wrote: > We need to export init_uni_ac_vlc to init_uni_ac_vlc and therefore need "to ff_init_uni_ac_vlc"? Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH v5] avdevice/xcbgrab: check return values of xcb query functions

On Sun, Jul 12, 2020 at 10:54:45 -0400, Andriy Gelman wrote: > On Fri, 10. Jul 21:13, Moritz Barsnick wrote: > > Since xcbgrab is getting some attention recently... > > > > Fixes a segfault, as reported in #7312. > > > > To reproduce: > > Terminal 1

Re: [FFmpeg-devel] [PATCH v08 2/3] fbtile tile/detile, hwcontext_drm detile NonLinear

On Sat, Jul 11, 2020 at 20:31:40 +0530, C Hanish Menon wrote: > > Also fix the changelog. > > Sorry I didn't understand this fully. Can I assume that you don't want to > mention about the fbtile helpers as an entry in the changelog, because its > not a public api? I believe what Lynne meant is:

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

On Sun, Jul 12, 2020 at 14:03:03 +0800, Jun Zhao wrote: > From: Jun Zhao (Which thread are you replying to?) > libsrt 1.4.1 changed the: > SRTO_SMOOTHER -> SRTO_CONGESTION AFAICT, this was changed in 1.3.3 (even though the commit doesn't change the doc/API.md where it states 1.3.0):

[FFmpeg-devel] [PATCH v4] avdevice/xcbgrab: check return values of xcb query functions

while ffmpeg is running. Cheers, Moritz From 3bbf40dd08bb67e993cca97880aec032644fd02b Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Fri, 10 Jul 2020 13:26:55 +0200 Subject: [PATCH] avdevice/xcbgrab: check return values of xcb query functions Fixes #7312, segmentation fault on close of X11

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix missing line break in messages

On Thu, Jun 25, 2020 at 18:59:58 +0800, myp...@gmail.com wrote: > On Thu, Jun 25, 2020 at 6:46 PM Moritz Barsnick wrote: > > > > One of them can be triggered by > > https://samples.ffmpeg.org/F4V/H263_NM_f.mp4. > > > > Signed-off-by: Moritz Barsnick &

Re: [FFmpeg-devel] Project orientation

On Tue, Jul 07, 2020 at 10:03:34 -0300, James Almer wrote: > On 7/7/2020 8:33 AM, Steinar H. Gunderson wrote: > > FWIW, the “less secure” part is about not supporting 2FA (POP/IMAP has no > > OAuth-like authentication methods). > > This is not true. Thunderbird and i assume any modern IMAP/SMTP

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

On Sun, Jul 05, 2020 at 19:34:54 +0800, Hongcheng Zhong wrote: > +static int abr_rule(ABRContext *c, float bw_estimate) > +{ > +int ret = -1; > + > +if (c->n_throughputs > 6) { > +if (bw_estimate < c->variants_bitrate[c->cur_pls].value / 1000 * 1.2 > && > +bw_estimate

Re: [FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

On Wed, Jul 01, 2020 at 11:30:33 +0200, Omar Emara wrote: > { "region_border", "Set the region border thickness.", > OFFSET(region_border), AV_OPT_TYPE_INT, { .i64 = 3 }, 1, 128, D }, > +{ "select_region", "Select the grabbing region graphically using the > pointer.",

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/nvenc_hevc: add a53cc option for nvenc hevc

On Mon, Jun 29, 2020 at 23:21:03 +0800, lance.lmw...@gmail.com wrote: > diff --git a/libavcodec/nvenc_hevc.c b/libavcodec/nvenc_hevc.c > index 45dda3d..6153f9a 100644 > --- a/libavcodec/nvenc_hevc.c > +++ b/libavcodec/nvenc_hevc.c > @@ -132,6 +132,8 @@ static const AVOption options[] = { > {

Re: [FFmpeg-devel] [PATCH]libavfilter/asrc_atone.c : generate algorithmic music

On Thu, Jun 25, 2020 at 21:15:06 +0530, Ashutosh Pradhan wrote: > Generate algorithmic riff music. Changed to activate api. This commit doesn't change to activate API, as it introduces this filter. So that sentence doesn't belong here. > - Real War KVAG muxer > - > +- atone filter Don't remove

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

On Thu, Jun 18, 2020 at 19:22:56 +0530, Yatendra Singh wrote: > +for(int h = slice_start; h < slice_end; h++) > +{ Space between "for" and "(", and the opening bracket '{' goes on the same line. > +for(int w = 0; w < width; w++) > +{ Same here, and elsewhere (also for

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/vf_colorconstancy.c : Cleanup code for new filter

On Thu, Jun 18, 2020 at 19:22:55 +0530, Yatendra Singh wrote: > +if(!strcmp(ctx->filter->name, GREY_EDGE)) > +{ Code style. => if (! .) { Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/internal: fix the outdating comments for ff_add_cpb_side_data()

On Sun, Jun 28, 2020 at 20:55:08 +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > Subject: avcodec/internal: fix the outdating comments for > ff_add_cpb_side_data() "outdated" > - * Add a CPB properties side data to an encoding context. > + * Add a CPB properties side data to an codec

Re: [FFmpeg-devel] [PATCH v3 1/2] libavcodec/pgxdec: Add PGX decoder

On Sun, Jun 28, 2020 at 20:13:28 +0530, gautamr...@gmail.com wrote: > +int val; > +if (bytestream2_get_bytes_left(>g) < 1) > +return AVERROR_INVALIDDATA; > +if (sign) { > +val = bytestream2_get_byte(>g) + (1 << (depth - 1)); > +

Re: [FFmpeg-devel] FFMPEG convert keeping metadata

Hi Luys On Sat, Jun 27, 2020 at 00:25:38 +0800, Luys8611 wrote: > I'm luys and I need a help for ffmpeg converting. > I have a .m4a file which has metadata such as speaker channel data. > I need a command line to convert it to .wav file preserving all metadata. > Or, it's also good that I can

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

On Fri, Jun 26, 2020 at 17:31:36 +0800, lance.lmw...@gmail.com wrote: > On Fri, Jun 26, 2020 at 11:15:15AM +0200, Moritz Barsnick wrote: > > On Fri, Jun 12, 2020 at 07:54:28 +0800, lance.lmw...@gmail.com wrote: > > > +if (sd->size < uuid_size) { > > >

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

On Fri, Jun 12, 2020 at 07:54:28 +0800, lance.lmw...@gmail.com wrote: > +if (sd->size < uuid_size) { > +av_log(ctx, AV_LOG_ERROR, "invalid data(%d < UUID(%d-bytes))", > sd->size, uuid_size); ... \n Moritz ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/dvbsubdec: Cosmetics

On Fri, Jun 26, 2020 at 08:47:23 +0800, lance.lmw...@gmail.com wrote: > region->depth = 1 << (((*buf++) >> 2) & 7); > -if(region->depth<2 || region->depth>8){ > +if (region->depth<2 || region->depth>8){ ^^ You might as well fix this as well

[FFmpeg-devel] [PATCH] avformat/mov: fix missing line break in messages

One of them can be triggered by https://samples.ffmpeg.org/F4V/H263_NM_f.mp4. Signed-off-by: Moritz Barsnick --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index adc52de947..40fff5dd7d 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

On Thu, Jun 25, 2020 at 00:52:57 +0200, Carl Eugen Hoyos wrote: > Am Do., 25. Juni 2020 um 00:12 Uhr schrieb Moritz Barsnick : > > What about LM? Or do little-endian samples not exist? > There are only 78 known samples, all from the jpeg2000 test suite. Okay, that makes this a fringe

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

On Wed, Jun 24, 2020 at 23:57:10 +0530, gautamr...@gmail.com wrote: > +const char *header_start = "PG ML "; What about LM? Or do little-endian samples not exist? > +if (bytestream2_peek_byte(>g) == ' ') > +bytestream2_skip(>g, 1); I understand the separators can also be tabs,

  1   2   3   4   5   6   7   8   9   10   >