[FFmpeg-devel] Re: [POLL] [VOTE] code.ffmpeg.org vs. ML

2025-09-20 Thread Nicolas George via ffmpeg-devel
cceptable spam threshold. Regards, -- Nicolas George ___ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-le...@ffmpeg.org

[FFmpeg-devel] Re: [POLL] [VOTE] code.ffmpeg.org vs. ML

2025-09-18 Thread Nicolas George via ffmpeg-devel
t; it from a different computer or just see if CI passes or something. If this web monster does not let you push code in your private fork without asking to include it upstream, it is one more reason not to use that thing. PS: please do not bypass

[FFmpeg-devel] Re: [POLL] [VOTE] code.ffmpeg.org vs. ML

2025-09-17 Thread Nicolas George via ffmpeg-devel
egards, -- Nicolas George ___ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-le...@ffmpeg.org

[FFmpeg-devel] Re: [POLL] [VOTE] code.ffmpeg.org vs. ML

2025-09-17 Thread Nicolas George via ffmpeg-devel
a perfectly normal way of managing the project. -- Nicolas George ___ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-le...@ffmpeg.org

[FFmpeg-devel] Re: [PATCH] avutil/bprint: fix av_bprint_strftime with %p format string reporting truncated output (PR #20330)

2025-09-12 Thread Nicolas George via ffmpeg-devel
> There is one, but OK, I will make the existing comment a bit more verbose. Thanks. Regards, -- Nicolas George ___ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-le...@ffmpeg.org

[FFmpeg-devel] Re: [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-09-02 Thread Nicolas George via ffmpeg-devel
the users. If a filter is wrongly assumed to not work, the system will just insert conversion filters and waste a few cycles. One is unacceptable, the other is negligible. The default should be to choose the issue with negligible drawbacks. Regards, -- Nicolas George

[FFmpeg-devel] Re: [PATCH] avutil/bprint: fix av_bprint_strftime with %p format string reporting truncated output (PR #20330)

2025-08-26 Thread Nicolas George via ffmpeg-devel
-142,6 +119,14 @@ void av_vbprintf(AVBPrint *buf, const char *fmt, va_list > vl_arg) > av_bprint_grow(buf, extra_len); > } > > +void av_bprintf(AVBPrint *buf, const char *fmt, ...) > +{ > +va_list vl; > + va_start(vl, fmt); > +av_vbprintf(buf, fmt, vl); > +va_end(

[FFmpeg-devel] Re: [PATCH] avutil/bprint: fix av_bprint_strftime with %p format string reporting truncated output (PR #20330)

2025-08-26 Thread Nicolas George via ffmpeg-devel
es not tell us how much room it would need: let us > retry with twice as much until the buffer is large enough */ > -room = !room ? strlen(fmt) + 1 : > +room = !room ? fmt_len + 1 : > room <= INT_MAX / 2 ? room * 2 : INT_MAX; > if (av_bpri

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-22 Thread Nicolas George via ffmpeg-devel
there is no doubt about, and much better than the quick and dirty version I sent, and it is a good thing you did it. But it was not on my demand and it does not change the fact that support must be opt-in.) Regards, -- Nicolas George ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH] vf_colordetect: add ability to detect fully opaque alpha planes (PR #20257)

2025-08-18 Thread Nicolas George via ffmpeg-devel
I do not know the code and my assembly is very rusty. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@f

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Add an option to clamp trc LUT output

2025-08-14 Thread Nicolas George
t values to the range [0, > 1].", > + OFFSET(clamplutoutput), AV_OPT_TYPE_BOOL, { .i64 = 0}, > + 0, 1, FLAGS }, > + > { "iall", "Set all input color properties together", >OFFSET(user_iall), AV_OPT_TYPE_INT, { .i64 = CS_UNSPECIFIE

Re: [FFmpeg-devel] [PATCH] avutil/timecode: Check for integer overflow in av_timecode_init_from_components() (PR #20236)

2025-08-14 Thread Nicolas George
kind of “bugs” too. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-14 Thread Nicolas George
dded support for unknown channel layouts while keeping API compatibility with the forks: filters that had not been explicitly vetted for support were assumed to not support them. Now like before, it is the only reasonable way to do things. -- Nicolas George

Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread Nicolas George
knows the code only tangentially and could have missed subtle issues (⇒ basis for waiting a little less before pushing, but not immediate) from an approval by a newbie who overestimate their own competence (we had a few of those in the past). -- Nicolas

Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread Nicolas George
ave, or for somebody who exchanged mails with me recently on the very subject of libavfilter. > Having a clearly defined process is a human solution to a human problem. A bot is not a human solution. -- Nicolas George ___ ffmpeg-devel maili

Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread Nicolas George
ay, and will therefore forgive the ad-hominem attacks at the end of this mail. I will not apologize for the miscommunication caused by the awful tool that is being pushed on us. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [RFC] Advanced Error Codes

2025-08-12 Thread Nicolas George
it is not the main objective, and chasing two hares is a recipe for catching zero. I have quite a lot to answer to the technical points you made below and that I will now snip, but before that I think it is important we check we are on the same page about the goals. Regards, -- Nicolas George ___

Re: [FFmpeg-devel] [PATCH] bugfix and split of source plugin list (PR #20225)

2025-08-12 Thread Nicolas George
t; fi git pull --no-rebase --log --stat --commit --no-edit "$1" "$branch" Also, better not forget quoting shell variables, even if you trust the caller to avoid dangerous characters. > } > > unset succeeded failed version Not judging on the merits of havi

[FFmpeg-devel] Global state and mutable component lists (was: Plugins architecture)

2025-08-12 Thread Nicolas George
r all. With this system, we would implement whitelists by adding only trusted components to the AVLibrary instance. And people can add custom components because the lists are mutable. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] Plugins architecture

2025-08-12 Thread Nicolas George
ion 1. The difference between options 2-5 is just window dressing: the code is the same, the only difference is whether the plugins are listed on the static website, the wiki or nowhere under our control. Regards, -- Nicolas George ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for libavfilter

2025-08-12 Thread Nicolas George
Jacob Lifshay (HE12025-08-12): > framework is misspelled here Thanks, locally fixed. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link ab

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself for libavfilter

2025-08-12 Thread Nicolas George
I have been maintaining the framework and orphaned filters for ages but apparently it was never recorded in this file. Signed-off-by: Nicolas George --- MAINTAINERS | 4 1 file changed, 4 insertions(+) … but it was common knowledge. diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread Nicolas George
will not solve human problems. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread Nicolas George
t. The only approval worth something comes from somebody who knows the code. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg

[FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread Nicolas George
or no forge, and a spit in my face for the time I invested into starting to look at the code, thankfully limited. Never do that again. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH] Revert "doc/developer: Basic documentation for Source Plugins" (PR #20213)

2025-08-11 Thread Nicolas George
Nicolas George (HE12025-08-11): > I do not like it either, especially because it weakens the intent to > bring libpostproc back properly, but Michael made the decision and the > time to object it was before > “12b853530a Add tools/merge-all-source-plugins”. I see it has been pushed

Re: [FFmpeg-devel] [PATCH] Revert "doc/developer: Basic documentation for Source Plugins" (PR #20213)

2025-08-11 Thread Nicolas George
ks or features. I do not like it either, especially because it weakens the intent to bring libpostproc back properly, but Michael made the decision and the time to object it was before “12b853530a Add tools/merge-all-source-plugins”. Regards, -- Nicolas George _

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
ogus software. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
the format, then we should not either. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org w

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
e to specify “-f mp3”. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-11 Thread Nicolas George
users from creating invalid output. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
explain better what the commit does. What other software manages to recognize these files as valid? Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-09 Thread Nicolas George
atches because that's not what email was intended for. Git didn't > even exist then. Any skill need to be updated. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-d

Re: [FFmpeg-devel] [PATCH] avfilter/vf_extractplanes: use refcounting for planar formats

2025-08-09 Thread Nicolas George
t/ffmpeg/patch/20250807195800.77462-1-jestrada.l...@gmail.com/ > --- > libavfilter/vf_extractplanes.c | 41 +- > 1 file changed, 31 insertions(+), 10 deletions(-) Apart from that, LGTM, assuming it was tested. Thanks. Regards

Re: [FFmpeg-devel] [PATCH] avfilter/vf_alphamerge: use refcounting for planar formats

2025-08-09 Thread Nicolas George
; > @@ -212,4 +222,4 @@ const FFFilter ff_vf_alphamerge = { > FILTER_QUERY_FUNC2(query_formats), > .uninit = uninit, > .activate = activate, > -}; > +}; > \ No newline at end of file You really need to fix you editor to not have it remove the final n

Re: [FFmpeg-devel] [PATCH] tools/graph2dot: Add proper error handling to avoid potential memory leaks

2025-08-09 Thread Nicolas George
Jiasheng Jiang (HE12025-08-09): > Add proper error handling to release allocated memory to avoid potential > memory leaks. Once again, there are no leaks when the process exits. A short-lived tool like that does not need cleanup, especially when it makes the code longer. Regards, -- N

Re: [FFmpeg-devel] rebase bugs?

2025-08-09 Thread Nicolas George
onal inbox a mail from a member of one of the top computer science research teams in the world complaining that GitLab errors with an abstruse message about corrupted commits. Mature indeed. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] 回复: 回复: cvslog (was: [SCM] branch master updated. dff08a3d2a) fate/vvc: add vvc-conformance-FIELD_A_4

2025-08-08 Thread Nicolas George
re broken since about four days, and suddenly we got a new notification, and it was your patch. So I assumed somebody was working at fixing the issue, and I answered to give thanks but report it was still not perfect. Regards, -- Nicolas George ___ ffm

Re: [FFmpeg-devel] 回复: cvslog (was: [SCM] branch master updated. dff08a3d2a) fate/vvc: add vvc-conformance-FIELD_A_4

2025-08-08 Thread Nicolas George
Wu Jianhua (HE12025-08-08): > Yes I should separte them to different subjects. I will pay attention next > time. I do not understand: did you send this mail yourself manually? Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] cvslog (was: [SCM] branch master updated. dff08a3d2a) fate/vvc: add vvc-conformance-FIELD_A_4

2025-08-08 Thread Nicolas George
That is better, thanks, but the fact that it combines multiple completely unrelated commits in one mail with the subject of only one of the commit is still not good. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

[FFmpeg-devel] ffmpeg-cvslog broken

2025-08-08 Thread Nicolas George
, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: fix unbounded index when copying to fft_data

2025-08-08 Thread Nicolas George
Nicolas George (HE12025-08-08): > Sorry, I thought it was Paul's code and you were waiting for review. In > the process of applying. Pushed. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: fix unbounded index when copying to fft_data

2025-08-08 Thread Nicolas George
view. In the process of applying. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/whip: Add av_freep() to avoid potential memory leak

2025-08-08 Thread Nicolas George
. So no objection to the patch, just take half a second considering my suggestion. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH] libswscale/tests/colorspace: Add av_free() to avoid potential memory leak

2025-08-08 Thread Nicolas George
at patch is what introduced the issue. It is quite obvious in that case with a cosmetic commit. Regards, -- Nicolas George 1: Strange construction, but apparently idiomatic. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] libavformat/whip: Add av_freep() to avoid potential memory leak

2025-08-07 Thread Nicolas George
t; > rtp_ctx->pb = avio_alloc_context(buffer, buffer_size, 1, s, NULL, > on_rtp_write_packet, NULL); > if (!rtp_ctx->pb) { > +av_freep(&buffer); > ret = AVERROR(ENOMEM); > goto end; That belong to after end, otherwise yo

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Add check for av_mallocz() to avoid potential NULL pointer dereference

2025-08-07 Thread Nicolas George
Jiasheng Jiang (HE12025-08-07): > Add check for the return value of av_mallocz() to avoid potential NULL > pointer dereference. LGTM, thanks. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

Re: [FFmpeg-devel] [PATCH] Update README.md Contributing (PR #20160)

2025-08-07 Thread Nicolas George
s still in test. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-07 Thread Nicolas George
never spend five minutes learning how to use mail? -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with s

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: add include for boolean literals (PR #20155)

2025-08-07 Thread Nicolas George
; it to fail to compile on certain platforms with --assert-level=2. We > fix this by #including stdbool.h to declare false as a literal. Better replace the av_assert2() with av_unreachable(). Regards, -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avfilter: add alphamerge_cuda filter

2025-08-07 Thread Nicolas George
this one. These are rather low-hanging fruits. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-07 Thread Nicolas George
e Still that idiotic idea that attracting more newbies will solve the issue that we do not have enough senior developers. > to improve productivity. The current bullshit decreases the productivity of the most productive member of the project. -- Nicolas George __

Re: [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)

2025-08-07 Thread Nicolas George
blic headers and creates a binary-incompatible version of the library. And IIRC you cannot use CONFIG_SOMETHING in public headers anyway. Better leave the function as stubs in the libraries. Regards, -- Nicolas George ___ ffmpeg-devel mailing l

[FFmpeg-devel] Replies on the mailing-list (was: [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154))

2025-08-07 Thread Nicolas George
Nicolas George (HE12025-08-07): > > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154 > > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch > I do not like that it bloats the public headers and creates a > binary-incompatible version of the library. >

Re: [FFmpeg-devel] [PATCH] Revert "forgejo/lint_commit_msg: add script for commit message linting" (PR #20147)

2025-08-07 Thread Nicolas George
hing, saving him >time > > This reverts commit cc6ad703b41e318bd1e4cb6196defaf505dbfea3. LGTM. We certainly are not at the point where policies affecting the whole project can be enacted without discussion on the mailing-list. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH v3] examples: Add check and replace av_free() to avoid potential memory errors

2025-08-06 Thread Nicolas George
d, 5 insertions(+), 1 deletion(-) Still looks good to me, of course, thanks. I do not maintain the docs. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH v2] examples: Add check and replace av_free() to avoid potential memory errors

2025-08-06 Thread Nicolas George
This one looks good to me, thanks. > Fixes: f5df897c4b ("examples/avcodec: split audio decoding into a separate > example") ??? Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH] examples: Replace with proper error handling to avoid potential memory errors

2025-08-06 Thread Nicolas George
exit(1); /* or proper cleanup and returning */ And in any case, the commit message should inaccurately pretend to fix possible leaks. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-06 Thread Nicolas George
Rémi Denis-Courmont (HE12025-08-06): > But it is exclusionary, as not everyone can get a working reputable > outbound SMTP server. It has already been said time and again that it is not a requirement to participate. The only requirement is the ability to send and receive mail. -- N

Re: [FFmpeg-devel] [PATCH] examples: Replace with proper error handling to avoid potential memory errors

2025-08-05 Thread Nicolas George
Jiasheng Jiang (HE12025-08-05): > Moreover, replace with proper error handling to avoid potential memory leak. There is no potential memory leak with exit(). And it does not have to be a lesson in good C practices. Regards, -- Nicolas Geo

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-05 Thread Nicolas George
Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-05 Thread Nicolas George
Nicolas George (HE12025-08-04): > That was me. Whoever disabled the account: I went to just delete it, and now I cannot, so the joke is on you, you have to do it yourself. > Thank you for ensuring it went to the mailing-list. It seems to work randomly. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-05 Thread Nicolas George
Robert Nagy (HE12025-08-05): > On a side note. Shouldn't ffprobe also report the detect alpha mode if > the decoder/container supports it? You mean like [PATCH v2 02/18] fftools/ffprobe: add support for AVFrame.alpha_mode ? > On Tue, Aug 5, 2025 at 11:16 AM Nicolas George

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-05 Thread Nicolas George
Nicolas George (HE12025-08-05): > > I will repeat myself briefly here that such a flag should be an opt-out, not > > an opt-in. Supporting premultiplied alpha should be the default assumption > > unless provable otherwise. > > Absolutely not. > > Do you dereferenc

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-05 Thread Nicolas George
o have such flags for every other AVFrame property. It does not make it either harder nor easier. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-04 Thread Nicolas George
Hendrik Leppkes (HE12025-08-04): > Whats the barrier of entry to sending a patch to the ML right now? Being able to, which is strongly correlated to knowing good practices. > Does it quiz you on the guidelines? Do you have better to propose? -- Nicolas

[FFmpeg-devel] Forgejo entry threshold

2025-08-04 Thread Nicolas George
@param erbut useless + * @param ernut does nothing That is not good. If nothing better comes to mind to exclude crappy code, could we at least condition creating an account to answering a 10 questions quiz about our coding conventions? Regards,

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-08-04 Thread Nicolas George
ffers half the features required to do the same in order to attract more drive-by contributors who will never be able to review patches. But I am sure you were thinking of exactly the opposite. Regards, -- Nicolas George ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] FFmpeg 8.0 Release

2025-08-04 Thread Nicolas George
which was > introduced in 7.1). Dissenting opinion: non-trivial things that were just applied should not go into the release. They will go into the next, unless they get changed again. Regards, -- Nicolas George ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH] fftools/ffmpeg_sched: do not print error code

2025-08-03 Thread Nicolas George
The error codes are meaningless to users, especially the ones that do not come from standard errno codes. Signed-off-by: Nicolas George --- fftools/ffmpeg_sched.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c

[FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-03 Thread Nicolas George
Nicolas George (HE12025-08-03): > I will send the series here in a few hours. Here is a series of patch. I am absolutely not sure I found all the filters that could be flagged, but the rest can be done as the need arises. Not tested every filter, but it is pretty straightforward. I could

Re: [FFmpeg-devel] The patch series about premultiplied alpha

2025-08-03 Thread Nicolas George
Nicolas George (HE12025-08-03): > By the way, I am willing to put aside my reluctance of contributing with > all the bullshit going on in order to help implementing this flag > system. But I suspect it is so simple to implement that it is not worth > it. In fact, I have started doi

Re: [FFmpeg-devel] The patch series about premultiplied alpha

2025-08-03 Thread Nicolas George
; P.s. Out of curiosity, what happens if the remaining TC were to vote 2-2 on > the issue? Would my vote be taken as an implicit tiebreaker? I say: the leader decides. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-08-02 Thread Nicolas George
d contributors: two pairs of eyes are better than one to fix this kind of minor mistakes and keep our history as clean as possible. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] The patch series about premultiplied alpha

2025-08-02 Thread Nicolas George
Nicolas George (HE12025-08-02): > - The patch series lacks transverse user documentation. > > - The patch series increases the risk of data corruption due to user > negligence and should include at least some guardrails against that. Here is the situation before this patch series:

Re: [FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

2025-08-02 Thread Nicolas George
ontributions will be drowned in crappy contributions by people who just needed to click on “login with github” and “create a pull request” without even reading our guidelines. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.o

[FFmpeg-devel] The patch series about premultiplied alpha

2025-08-02 Thread Nicolas George
) the patch series cannot be pushed until the decision is made. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ

Re: [FFmpeg-devel] Again pre-multiplied alpha

2025-08-02 Thread Nicolas George
ocumentation. > Anways, unless you have more concrete feedback, I am going to consider the > current version of this series (on ForgeJo) as final and merge it in ~72H > if there is no further (legitimate) objection. > > If you disagree with that, I suggest we invo

Re: [FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

2025-08-02 Thread Nicolas George
Kacper Michajlow (HE12025-08-02): > It's trivial to automatically download/preview patches, similar to how > attachments can be previewed if a patcheset is sent as an attachment. Then document it. -- Nicolas George ___ ffmpeg-devel m

Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

2025-08-02 Thread Nicolas George
the fact that the commit message contains references to previous versions of the same patch. Let us revert that at once. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

2025-08-02 Thread Nicolas George
le who might review them? Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Again pre-multiplied alpha

2025-08-02 Thread Nicolas George
it also need a few paragraphs to explain to the user what premultiplied alpha is and what to do with it. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visi

Re: [FFmpeg-devel] FFmpeg 8.0 Release

2025-08-02 Thread Nicolas George
Niklas Haas (HE12025-08-02): > I would like to merge the AVFrame.alpha_mode series as well. Bad idea. This kind of feature affecting the whole code should stay in the master branch for a while before being enshrined in a release. Regards, -- Nicolas Geo

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-31 Thread Nicolas George
l client. It is even possible to use GMail's servers with Mutt. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
were right instead of admitting “my bad”? I doubt it, but you can try. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-30 Thread Nicolas George
eople who know the code well enough to review them. Making it easier to flood us with crappy patches written by AI will not make it better. > I understand fear of a change. Please keep this condescending bullshit to yourself. -- Nicolas George ___ ff

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-30 Thread Nicolas George
this patch when doing so does not require more work than it used to. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
Kacper Michajlow (HE12025-07-30): > Can we please find something more relevant to be upset about? Can you please stop behaving with such arrogance when somebody who has 30 times as much experience as you in the project points you you did something wrong? -- Nicolas Geo

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
appear in a commit message. And it is definitely not a matter of language, it is matter of attention. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
t; safely use BIO_TYPE_NONE. Documentation states: > > > type can be set to either BIO_TYPE_NONE or via BIO_get_new_index() if > > a unique type is required for searching (See BIO_find_type(3)) > > We don't use any search related functions. This should never h

Re: [FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

2025-07-29 Thread Nicolas George
il and command-lie are met, including specific documentation. And if a patch is pushed that affects the areas I am responsible of without me seeing it, I reserve the right to revert on the spot. Regards, -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-29 Thread Nicolas George
Kacper Michajlow (HE12025-07-29): > https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20055.patch You forgot to do a copy-paste. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-29 Thread Nicolas George
ht. This thing is looking more and more like a bad joke. How many clicks to achieve something that was done with a single key stroke? I will review the patch when I see it in diff format on the mailing-list. Regards, -- Nicolas George ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-29 Thread Nicolas George
rt the previous patch. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] Advanced Error Codes

2025-07-28 Thread Nicolas George
fail repeatedly, and > therefore should not waste time fiddling with strings; > > - do not have enough information to design a useful error message > anyway. > > The second group, is all the opposite. I do not think there is much in >

Re: [FFmpeg-devel] [RFC] Advanced Error Codes

2025-07-28 Thread Nicolas George
> > negative AVERROR code” to keep source compatibility, and use the best > > code we can find. > Then you no longer know which error relates to which message When “ret = av_do_something(ctx, …)” is negative, the error is in ctx and stays there until the applicati

Re: [FFmpeg-devel] Again pre-multiplied alpha

2025-07-28 Thread Nicolas George
in the framework, not in individual components, that the ABC of proper design. And this is only what I can think of right away. Every place that uses the alpha component for anything other than copying must be protected. Regards, -- Nicolas Geo

Re: [FFmpeg-devel] Again pre-multiplied alpha

2025-07-28 Thread Nicolas George
portantly not a maintenance nightmare. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-27 Thread Nicolas George
little for me these last few months. It has never been about forcing my choices on others, and always protecting the project from the dumb idea of making the life of experienced hackers harder to attract more newbies, dilettantes and vibe coders.) Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-27 Thread Nicolas George
on Forgejo, while allowing Forgejo to be fully operational. And, unless I am mistake, it lets us go back rather painlessly. Which raises the question: Why have you not done that BEFORE announcing the test? Let us pull the plug on this failed experiment and give you some more ti

  1   2   3   4   5   6   7   8   9   10   >