Hello here,
Just a mail to ping this patch
Have a nice day,
Olivier
On Thu, Jul 25, 2019 at 11:34 PM Michael Niedermayer
wrote:
> On Wed, Jul 24, 2019 at 10:20:14AM +0200, Olivier Maignial wrote:
> > === PROBLEM ===
> >
> > I was trying to record h264 + aac streams from
min and max values
I propose to introduce a range for each parameter.
For this patch I used RFC-3640 and ISO/IEC 14496-1 as reference for validity
ranges.
This patch fix my problem and I now can record my RTSP AAC stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-
ate on what happens.
On Wed, Jul 17, 2019 at 10:28 PM Michael Niedermayer
wrote:
> On Fri, Jul 12, 2019 at 08:40:40AM +0200, Olivier Maignial wrote:
> > === PROBLEM ===
> >
> > I was trying to record h264 + aac streams from an RTSP server to mp4
> file. using this comm
roblem and I now can record my RTSP AAC stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-by: Olivier Maignial
---
Changes V6 --> V7:
- Use long long int and strtoll. LLONG_MAX is always greather than
INT32_MIN while LONG_MAX can be equal to INT32_MAX. It allow
ble, and it is avoidable
> here by disallowing min/max int32 values themselves. Or using strtoll.
> I'm also rather sceptical about allowing negative values here, does that
> make sense?
> Admittedly the type is set to just "int", but maybe it should be unsigned
> instead?
>
> On 28.0
Hello here!
A simple ping about this patch
If you have any question, feel free to ask!
Regards,
Olivier
On Wed, Jun 19, 2019 at 3:38 PM Olivier Maignial
wrote:
> === PROBLEM ===
>
> I was trying to record h264 + aac streams from an RTSP server to mp4 file.
> using this
roblem and I now can record my RTSP AAC stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-by: Olivier Maignial
---
Changes V5 -> V6:
- Simplify code
libavformat/rtpdec_mpeg4.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/l
Hello,
Just a reminder about this patch
If you need something else to validate it, please let me know
Olivier
On Wed, May 22, 2019 at 6:10 PM Olivier Maignial
wrote:
> === PROBLEM ===
>
> I was trying to record h264 + aac streams from an RTSP server to mp4 file.
> using this
C stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-by: Olivier Maignial
---
Changes V4 -> V5:
- Check value against INT32_MAX/MIN instead of INT_MAX/MIN which can be
defferent depending on platform
libavformat/rtpdec_mpeg4.c | 28 +++-
1
I now can record my RTSP AAC stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-by: Olivier Maignial
---
Changes v3->v4
- Rebased my patch on master
- Updated comit log to provide better explanation of the problem
- Re-passed fate tests on master
lib
Hello,
Just a reminder about this patch :)
On Fri, Apr 19, 2019 at 3:00 PM Olivier Maignial
wrote:
> RFC-4566 do not give any limit of size on interger parameters given in
> fmtp line.
> By reading some more RFCs it is possible to find examples where some
> integers parameters are
and INT_MAX ensure that it will work whatever the size of int
given by compiler
Signed-off-by: Olivier Maignial
---
Changes v2 -> v3:
Fix over/underflow checking in case of sizeof(int) == sizeof(long)
If MAX/MIN_INT == MAX/MIN_LONG overflow would not be detected by just checking
va
Hello all
Just a reminder for this patch
On Mon, Apr 1, 2019 at 4:45 PM Olivier Maignial
wrote:
> RFC-4566 do not give any limit of size on interger parameters given in
> fmtp line.
> By reading some more RFCs it is possible to find examples where some
> integers parameters are gre
and INT_MAX ensure that it will work whatever the size of int
given by compiler
Signed-off-by: Olivier Maignial
---
Changes v1 -> v2:
- Removed line break at end of 'if' line before brace
- Added Signed-Off-By line
libavformat/rtpdec_mpeg4.c | 16
1 file changed,
RFC-4566 do not give any limit of size on interger parameters given in fmtp
line.
By reading some more RFCs it is possible to find examples where some integers
parameters are greater than 32 (see RFC-6416, 7.4)
Instead I propose to check just check the eventual integer overflow.
Using INT_MIN
RFC-4566 do not give any limit of size on interger parameters given in fmtp
line.
By reading some more RFCs it is possible to find examples where some integers
parameters are greater than 32 (see RFC-6416, 7.4)
---
libavformat/rtpdec_mpeg4.c | 17 +
1 file changed, 13
---
libavformat/rtpdec_mpeg4.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
index 4f70599..f632ebf 100644
--- a/libavformat/rtpdec_mpeg4.c
+++ b/libavformat/rtpdec_mpeg4.c
@@ -289,15 +289,15 @@ static int
17 matches
Mail list logo
