Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Check that codsty->log2_prec_widths/heights has been initialized

2017-09-04 Thread Ronald S. Bultje
Hi, On Mon, Sep 4, 2017 at 6:04 PM, Michael Niedermayer wrote: > Fixes: OOM > Fixes: 2225/clusterfuzz-testcase-minimized-5505632079708160 > > Found-by: continuous fuzzing process https://github.com/google/oss- > fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > liba

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread Ronald S. Bultje
Hi, On Mon, Sep 4, 2017 at 5:30 AM, Michael Niedermayer wrote: > But lets just assume for the sake of the argument, that it is useless, > can you take a look at these please: > (this is a uncut list of errors from vp9.c) > But mommy, he did it too. I veto your patch. If it makes you feel bett

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Ronald S. Bultje
Hi, On Sun, Sep 3, 2017 at 7:54 PM, Michael Niedermayer wrote: > Its unprofessional to fail decoding a file but not provide any > hint as to why a failure occured. > [..] > Our code is already quite terse and devoid of comments and > documentation, error messages do not seem a exception here

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Ronald S. Bultje
Hi, On Sun, Sep 3, 2017 at 6:23 AM, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3142/clusterfuzz-testcase-5007853163118592 > > Found-by: continuous fuzzing process https://github.com/google/oss- > fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec

Re: [FFmpeg-devel] [PATCH] avio: add a destructor for AVIOContext

2017-09-01 Thread Ronald S. Bultje
Hi, On Fri, Sep 1, 2017 at 12:53 AM, James Almer wrote: > On 8/27/2017 1:31 PM, James Almer wrote: > > From: Anton Khirnov > > > > Before this commit, AVIOContext is to be freed with a plain av_free(), > > which prevents us from adding any deeper structure to it. The docs for avio_alloc_conte

Re: [FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-08-31 Thread Ronald S. Bultje
Hi, On Thu, Aug 31, 2017 at 1:31 PM, Nicolas George wrote: > Le quartidi 14 fructidor, an CCXXV, Ashish Pratap Singh a écrit : > > From: Ashish Singh > > > > Hi, > > This patch changes adm filter from dualinput to framesync2. > > > > Signed-off-by: Ashish Singh > > --- > > Changelog

Re: [FFmpeg-devel] [PATCH 10/16] lavfi/vf_libvmaf: convert to framesync2.

2017-08-30 Thread Ronald S. Bultje
Hi, On Sun, Aug 20, 2017 at 5:52 AM, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Nicolas George a écrit : > > After this commit, the code compiles, but on my setup it > > segfaults before and after. It also prints the very worrying > > warning: > > > > src/libavfilter/vf_libvmaf.c:1

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix pre convert to framesync2 bugs

2017-08-30 Thread Ronald S. Bultje
Hi, On Thu, Aug 3, 2017 at 1:34 AM, Ashish Pratap Singh wrote: > From: Ashish Singh > > Hi, it fixes the errors while converting to framesync2. > libvmaf was changed recently, double *score variable is removed in the new > version since it's not used anywhere. This patch fixes all the warnings

Re: [FFmpeg-devel] [PATCH] configure: require pkg-config for libvmaf

2017-08-30 Thread Ronald S. Bultje
Hi, On Tue, Aug 1, 2017 at 11:14 AM, Ashish Pratap Singh wrote: > From: Ashish Singh > > This patch makes the libvmaf filter use pkg-config to detect > and link to libvmaf. > > Signed-off-by: Ashish Singh > --- > configure | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Pushed.

Re: [FFmpeg-devel] [PATCH] avcodec: make the avcodec_get_chroma_sub_sample deprecation effective

2017-08-25 Thread Ronald S. Bultje
Hi, On Fri, Aug 25, 2017 at 11:09 AM, James Almer wrote: > --- > libavcodec/avcodec.h | 16 > libavcodec/version.h | 6 +++--- > 2 files changed, 7 insertions(+), 15 deletions(-) Thanks :) Ronald ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread Ronald S. Bultje
Hi, On Fri, Aug 25, 2017 at 10:04 AM, James Almer wrote: > On 8/25/2017 8:10 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Aug 24, 2017 at 7:43 PM, James Almer wrote: > > > >> Signed-off-by: James Almer > >> --- > >> The deprecation

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread Ronald S. Bultje
Hi, On Thu, Aug 24, 2017 at 7:43 PM, James Almer wrote: > Signed-off-by: James Almer > --- > The deprecation seems to have been imported from libav but never made > effective. Hm, but do we really want this function? Shouldn't all users be ported to the function this wraps? Ronald __

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-23 Thread Ronald S. Bultje
Hi, On Tue, Aug 22, 2017 at 7:59 PM, Ilia Valiakhmetov wrote: > +if (s->td) > +av_free(s->td); > + > +s->td = av_mallocz_array(s->s.h.tiling.tile_cols, > sizeof(VP9TileData)); The free() leaks s->td[*].b/block_base if they were already allocated. Ronald ___

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-23 Thread Ronald S. Bultje
Hi, now for review of the vp9-specific bits. On Tue, Aug 22, 2017 at 7:59 PM, Ilia Valiakhmetov wrote: > +lflvl_len*sizeof(*s->lflvl) + 16 * > sizeof(*s->above_mv_ctx))); > lflvl_len * sizeof (space). > -// these will be re-allocated a little later > -

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-23 Thread Ronald S. Bultje
Hi, I would also recommend to split out the changes to add the mainfunc-aware slice threading implementation (execute3) into pthread_slice.c into its own patch, that way others can review that without being obstructed by the vp9 bits. On Tue, Aug 22, 2017 at 7:59 PM, Ilia Valiakhmetov wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-22 Thread Ronald S. Bultje
Hi, overall pretty good. Nice performance improvement. We typically note performance improvement as a/b-1, not 1-b/a, so if runtime with 2 threads is 6 seconds and with 1 thread is 10 seconds, the improvement is not 1-6/10=0.4=40%, but rather 10/6-1=0.67=67%. On Tue, Aug 22, 2017 at 7:59 PM, Ilia

Re: [FFmpeg-devel] [PATCH]lavc/put_bits: Remove usage of BITSTREAM_WRITER_LE.

2017-08-22 Thread Ronald S. Bultje
Hi, On Mon, Aug 21, 2017 at 11:16 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch tries to slightly simplify and clean up the usage of > put_bits* in libavcodec: put_bits_le() functions exist for the > little-endian G.726 encoder, so the define makes less sense now. > > Fate passes here, pl

Re: [FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-19 Thread Ronald S. Bultje
Hi, On Fri, Aug 18, 2017 at 11:31 PM, James Zern wrote: > this is undocumented in the vp9 bitstream and decoding specification > doc, but matches libvpx > > Signed-off-by: James Zern > --- > libavcodec/vp9.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vp

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/diracdec: Check perspective_exp and zrs_exp.

2017-08-16 Thread Ronald S. Bultje
Hi, On Aug 15, 2017 3:32 AM, "Michael Niedermayer" wrote: Fixes: undefined shift Fixes: runtime error: shift exponent 264 is too large for 32-bit type 'int' Fixes: 2860/clusterfuzz-testcase-minimized-4672811689836544 Found-by: continuous fuzzing process https://github.com/google/oss- fuzz/tree/

Re: [FFmpeg-devel] [DISCUSSION] Motion Estimation API/Library

2017-08-03 Thread Ronald S. Bultje
Hi, On Thu, Aug 3, 2017 at 5:32 PM, Davinder Singh wrote: > On Tue, Aug 1, 2017 at 7:40 AM Davinder Singh wrote: > > > [...] > > > > Keeping where the code lives, aside, > > main thing is API, so we need to talk about it. You're assuming that we know in advance what the API will have to do. I

Re: [FFmpeg-devel] [PATCH] avfilter/vf_ssim: align temp size

2017-08-02 Thread Ronald S. Bultje
Hi, On Wed, Aug 2, 2017 at 8:45 AM, Tobias Rapp wrote: > On 02.08.2017 14:04, Ronald S. Bultje wrote: > >> On Wed, Aug 2, 2017 at 3:10 AM, Tobias Rapp >> wrote: >> >>> On 01.08.2017 17:01, Muhammad Faiz wrote: >>> >>>>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_ssim: align temp size

2017-08-02 Thread Ronald S. Bultje
Hi, On Wed, Aug 2, 2017 at 3:10 AM, Tobias Rapp wrote: > On 01.08.2017 17:01, Muhammad Faiz wrote: > >> Fix Ticket6519. >> >> Signed-off-by: Muhammad Faiz >> --- >> libavfilter/vf_ssim.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavfilter/vf_ssim.c b/libavfi

Re: [FFmpeg-devel] [PATCH] configure: require pkg-config for libvmaf

2017-08-01 Thread Ronald S. Bultje
Hi, On Fri, Jul 21, 2017 at 6:48 AM, Ashish Pratap Singh wrote: > From: Ashish Singh > > Hi, libvmaf now has a pkg-config file. This patch makes libvmaf filter > link to > pkg-config of libvmaf. "This patch makes the libvmaf filter use pkg-config to detect and link to libvmaf." I think? Ron

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread Ronald S. Bultje
Hi, On Mon, Jul 31, 2017 at 4:46 PM, foo86 wrote: > Oops, meant to include this comment in previous email: > > Improves code coverage: > old%new% > dca_core76.581.3 > dca_exss56.565.6 > dca_lbr 2.280.5 > dca_parser 86.298.6 > dca_xll 81.287.2

Re: [FFmpeg-devel] [PATCH] avfilter: add VIF filter

2017-07-30 Thread Ronald S. Bultje
Hi, On Sun, Jul 30, 2017 at 1:46 PM, Ashish Pratap Singh wrote: > On Sat, Jul 29, 2017 at 3:15 PM, Moritz Barsnick wrote: > > On Sat, Jul 29, 2017 at 14:16:29 +0530, Ashish Pratap Singh wrote: > > > +av_log(ctx, AV_LOG_ERROR, "error: av_malloc failed for > > data_buf.\n"); > > > > Are t

Re: [FFmpeg-devel] [PATCH] pthread_frame: revert 2e664b9c1e73c80aab91070c1eb7676f04bdd12d.

2017-07-27 Thread Ronald S. Bultje
Hi, On Tue, Jul 18, 2017 at 12:11 PM, Wan-Teh Chang < wtc-at-google@ffmpeg.org> wrote: > The patch does not fix the tsan warning it was intended to fix. > Reverting the patch moves the av_log() back to the outside of the lock. > > Signed-off-by: Wan-Teh Chang > --- > libavcodec/pthread_fram

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't sync default_ref[] between threads.

2017-07-27 Thread Ronald S. Bultje
Hi, On Tue, Jul 18, 2017 at 7:34 PM, Wan-Teh Chang wrote: > default_ref[] is unconditionally initialized in h264_initialise_ref_list() > (called from ff_h264_build_ref_list(), called from h264_slice_init()). > > This fixes the following tsan warning when running fate-h264: > > WARNING: ThreadSan

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 19, 2017 at 2:31 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the reply. > > On Wed, Jul 19, 2017 at 8:56 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < > > wtc-at-g

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Ronald S. Bultje
Hi, On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < wtc-at-google@ffmpeg.org> wrote: > WARNING: ThreadSanitizer: data race (pid=116081) > Read of size 4 at 0x7b720118 by thread T3 (mutexes: write M2239): > #0 pred_temp_direct_motion ffmpeg/libavcodec/h264_direct.c:505:9 > (ffmpeg+

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Ronald S. Bultje
Hi, On Wed, Jul 19, 2017 at 6:38 AM, Paul B Mahol wrote: > On 7/19/17, Ronald S. Bultje wrote: > > Hi Tobias, > > > > On Wed, Jul 19, 2017 at 5:40 AM, Tobias Rapp > wrote: > > > >> +# FIXME: override CPUFLAGS to avoid failure on x86 (issue #

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/scale: More descriptive in/ref/out logging

2017-07-19 Thread Ronald S. Bultje
Hi Kevin, On Wed, Jul 19, 2017 at 2:01 AM, Kevin Mark wrote: > Hello all, > > Just wondering if anyone had any thoughts on the grepability issue, > which I believe is the only potential issue/breaking change with this > patch. You wrote something like: "ffmpeg [...] scale2ref=0:0 [...] -v ver

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Ronald S. Bultje
Hi Tobias, On Wed, Jul 19, 2017 at 5:40 AM, Tobias Rapp wrote: > +# FIXME: override CPUFLAGS to avoid failure on x86 (issue #6519) I'm assuming this is because of floating point rounding differences. Is it possible to use a test similar to the floating-point codec tests that allows slight offs

Re: [FFmpeg-devel] tsan warning about data race in h264 decoder

2017-07-18 Thread Ronald S. Bultje
Hi Wah-Teng, On Tue, Jul 18, 2017 at 12:59 PM, Wan-Teh Chang < wtc-at-google@ffmpeg.org> wrote: > Hi, > > I'd like to report a tsan warning about a data race in the h264 decoder. > > 1. Steps to reproduce: > > ./configure --samples=~/fate-suite/ --toolchain=clang-tsan > --disable-stripping >

Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

2017-07-16 Thread Ronald S. Bultje
Hi, On Sun, Jul 16, 2017 at 8:45 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/14/2017 3:38 PM, Derek Buitenhuis wrote: > > Signed-off-by: Derek Buitenhuis > > --- > > libavformat/webmdashenc.c | 38 ++ > > 1 file changed, 30 insertions(+),

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ronald S. Bultje
Hi, On Sun, Jul 16, 2017 at 8:49 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > > Pushed. > > > > Ronald > > I am going to quote myself here, because it was never address, was not even > replied t

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ronald S. Bultje
Hi, On Sat, Jul 15, 2017 at 12:42 PM, Ashish Singh wrote: > This one changes the previous vmaf patch to libvmaf to keep it separate > from the > native implementation of vmaf inside ffmpeg later. > > Signed-off-by: Ashish Singh > --- > Changelog| 1 + > configure

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-14 Thread Ronald S. Bultje
Hi, On Fri, Jul 14, 2017 at 6:55 AM, Kieran Kunhya wrote: > On Thu, 13 Jul 2017 at 23:06 Michael Niedermayer > wrote: > > > On Wed, Jul 12, 2017 at 01:54:28PM +, Kieran Kunhya wrote: > > > > > > > > I actually would request a short note explaining the SUINTFLOAT type > > usage. > > > > Some

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in PerThreadContext.

2017-07-11 Thread Ronald S. Bultje
Hi, On Mon, Jul 10, 2017 at 5:51 PM, Ronald S. Bultje wrote: > On Mon, Jul 10, 2017 at 1:24 PM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> wrote: > >> Add the debug_threads boolean field to PerThreadContext. For >> PerThreadContext *p, p->deb

Re: [FFmpeg-devel] [PATCH] pthread_frame: allow per-field ThreadFrame owners.

2017-07-11 Thread Ronald S. Bultje
Hi Wan-Teh, On Tue, Jul 11, 2017 at 6:30 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the quick reply. > > On Tue, Jul 11, 2017 at 2:09 PM, Ronald S. Bultje > wrote: > > Hi Wan-Teh, > > > > On Tue, Jul 11, 2017 at 4:53 PM, Wan-Teh Chang wrote: &

Re: [FFmpeg-devel] [PATCH] pthread_frame: allow per-field ThreadFrame owners.

2017-07-11 Thread Ronald S. Bultje
Hi Wan-Teh, On Tue, Jul 11, 2017 at 4:53 PM, Wan-Teh Chang wrote: > Hi Ronald, > > I have a question about this patch. > > On Mon, Apr 3, 2017 at 7:24 AM, Ronald S. Bultje > wrote: > > This tries to handle cases where separate invocations of decode_frame() > > (ea

Re: [FFmpeg-devel] [PATCH] web/template_head2: Add net neutrality script

2017-07-11 Thread Ronald S. Bultje
Hi, On Tue, Jul 11, 2017 at 6:45 AM, Michael Niedermayer wrote: > On Mon, Jul 10, 2017 at 01:11:52AM +0200, Michael Niedermayer wrote: > > See: https://www.battleforthenet.com/july12/ > > > > Signed-off-by: Michael Niedermayer > > --- > > src/template_head2 | 1 + > > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in PerThreadContext.

2017-07-10 Thread Ronald S. Bultje
Hi, On Mon, Jul 10, 2017 at 1:24 PM, Wan-Teh Chang wrote: > Add the debug_threads boolean field to PerThreadContext. For > PerThreadContext *p, p->debug_threads records whether the > FF_DEBUG_THREADS bit is set in p->avctx->debug, and p->debug_threads and > p->avctx->debug are kept in sync. The

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Fix all but one tsan warning in fate-vsynth1-mpeg4

2017-07-10 Thread Ronald S. Bultje
Hi, On Mon, Jul 10, 2017 at 5:32 AM, wm4 wrote: > On Sun, 9 Jul 2017 22:37:46 -0400 > "Ronald S. Bultje" wrote: > > > Hi, > > > > On Sun, Jul 9, 2017 at 9:19 PM, Michael Niedermayer > > > wrote: > > > > > Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Fix all but one tsan warning in fate-vsynth1-mpeg4

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 9:19 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index e29558b3a2..574b38

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger wrote: > On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > > > wrote: > > > >> > >> Does anyone object to this patch ? >

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_slice: rewrite implementation

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 6:27 AM, Muhammad Faiz wrote: > Avoid pthread_cond_broadcast that wakes up all workers. Make each of them > uses distict mutex/cond. Also let main thread help running jobs. Hm... I'm not against this, but I actually had plans to write some extensions and allow the ma

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-08 Thread Ronald S. Bultje
Hi, On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer wrote: > On Mon, Jul 03, 2017 at 01:37:09AM +0200, Michael Niedermayer wrote: > > On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: > > > On 2 July 2017 at 03:28, Michael Niedermayer > wrote: > > > > > > > Fixes: runtim

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in FrameThreadContext.

2017-07-08 Thread Ronald S. Bultje
Hi, On Sat, Jul 8, 2017 at 5:28 PM, Wan-Teh Chang wrote: > Hi Ronald, > > On Sat, Jul 8, 2017 at 6:19 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Jul 7, 2017 at 5:02 PM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> > > wrote: > >

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in FrameThreadContext.

2017-07-08 Thread Ronald S. Bultje
Hi, On Fri, Jul 7, 2017 at 5:02 PM, Wan-Teh Chang wrote: > @@ -763,6 +764,7 @@ int ff_frame_thread_init(AVCodecContext *avctx) > > fctx->async_lock = 1; > fctx->delaying = 1; > +fctx->debug_threads = (avctx->debug & FF_DEBUG_THREADS) != 0; Shouldn't this be done in update_context

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in FrameThreadContext.

2017-07-08 Thread Ronald S. Bultje
Hi, On Fri, Jul 7, 2017 at 5:31 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jul 7, 2017 at 5:30 PM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> wrote: > >> Note: I suspect we can simply delete the following line from >> update_context_from_use

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in FrameThreadContext.

2017-07-07 Thread Ronald S. Bultje
Hi, On Fri, Jul 7, 2017 at 5:30 PM, Wan-Teh Chang wrote: > Note: I suspect we can simply delete the following line from > update_context_from_user() in libavcodec/pthread_frame.c: > > dst->debug= src->debug; > > That also fixes the tsan warning, but it'll take more time to > investigate

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

2017-07-07 Thread Ronald S. Bultje
Hi, On Fri, Jul 7, 2017 at 4:43 PM, Paul B Mahol wrote: > On 7/7/17, Ronald S. Bultje wrote: > > (I'm assuming the low-level interface no longer works with the cached > > reader, so can we prevent users from accessing these macros unless > > cached=1?) > > They

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

2017-07-07 Thread Ronald S. Bultje
Hi, On Fri, Jul 7, 2017 at 2:48 PM, Paul B Mahol wrote: > typedef struct GetBitContext { > const uint8_t *buffer, *buffer_end; > +#ifdef CACHED_BITSTREAM_READER > +uint64_t cache; > +unsigned bits_left; > +#endif > Can you post some stats (from relevant systems, ideally, e.g. 32-b

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 5, 2017 at 8:08 PM, Wan-Teh Chang wrote: > Hi Ronald, > > On Wed, Jul 5, 2017 at 3:31 PM, Ronald S. Bultje > wrote: > > Hi Wan-Teh, > > > > On Wed, Jul 5, 2017 at 6:12 PM, Wan-Teh Chang wrote: > >> > >> Thank you for

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 5, 2017 at 6:12 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the quick reply! > > On Wed, Jul 5, 2017 at 2:49 PM, Ronald S. Bultje > wrote: > > Hi Wan-Teh, > > > > On Wed, Jul 5, 2017 at 5:30 PM, Wan-Teh Chang wrote: >

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 5, 2017 at 5:30 PM, Wan-Teh Chang wrote: > Hi Ronald, > > A variant of this patch is committed as > 2e664b9c1e73c80aab91070c1eb7676f04bdd12d: > > http://ffmpeg.org/pipermail/ffmpeg-cvslog/2017-April/106577.html > > I believe it does not fix the tsan warning. I had notic

Re: [FFmpeg-devel] [PATCH] avfilter: add VMAF filter

2017-07-04 Thread Ronald S. Bultje
Hi, On Tue, Jul 4, 2017 at 6:07 PM, James Almer wrote: > On 7/4/2017 6:41 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Jul 4, 2017 at 5:29 PM, James Almer wrote: > > > >> On 7/3/2017 1:38 PM, Ashish Singh wrote: > >>> +{"disable a

Re: [FFmpeg-devel] [PATCH] avfilter: add VMAF filter

2017-07-04 Thread Ronald S. Bultje
Hi, On Tue, Jul 4, 2017 at 5:29 PM, James Almer wrote: > On 7/3/2017 1:38 PM, Ashish Singh wrote: > > +{"disable avx", "Disables avx for computing vmaf.", > OFFSET(disable_avx), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > Remove this option, and check for the AVX cpuflag instead. > > That

Re: [FFmpeg-devel] [PATCH] avfilter: add VMAF filter

2017-07-04 Thread Ronald S. Bultje
Hi, On Tue, Jul 4, 2017 at 11:21 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > At a glace am I correct in thinking that all this locking around calls is > because > libvmaf is not thread-safe? vmaf's interface is pull-based. Ronald ___

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: add 64-bit ipred_dr_32x32_16 avx2 implementation

2017-06-27 Thread Ronald S. Bultje
Hi, On Sun, Jun 25, 2017 at 10:42 AM, Ilia Valiakhmetov wrote: > vp9_diag_downright_32x32_12bpp_c: 429.7 > vp9_diag_downright_32x32_12bpp_sse2: 158.9 > vp9_diag_downright_32x32_12bpp_ssse3: 144.6 > vp9_diag_downright_32x32_12bpp_avx: 141.0 > vp9_diag_downright_32x32_12bpp_avx2: 73.8 > > Almost 5

Re: [FFmpeg-devel] How to create a Python AWS Lambda zip with OpenCV + FFmpeg?

2017-06-26 Thread Ronald S. Bultje
Hi Daniel, On Mon, Jun 26, 2017 at 10:02 AM, Daniel Lopes wrote: > I have this question on Stack overflow, someone here knows if with AWS > Lambda I can use FFmpeg + OpenCV, I talked with a guy from Amazon, he said > that I have to compile all environment in a Amazon Linux, I compile the > entir

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-26 Thread Ronald S. Bultje
Hi, On Sun, Jun 25, 2017 at 3:27 PM, Michael Niedermayer wrote: > On Sat, Jun 24, 2017 at 06:30:26PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sat, Jun 24, 2017 at 3:27 PM, Michael Niedermayer > > > wrote: > > > > > On Mon, Jun 19,

Re: [FFmpeg-devel] [PATCH 0/2] RFC: Generic hwaccel for cuvid v2

2017-06-24 Thread Ronald S. Bultje
Hi Philip, On Sat, Jun 24, 2017 at 7:40 PM, Philip Langdale wrote: > Feedback on first proposal was lack of interest in having default behaviour > vary between hwaccels, despite their other differences. I think that's because many of us - including me - don't really understand this. I, for on

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-24 Thread Ronald S. Bultje
Hi, On Sat, Jun 24, 2017 at 6:30 PM, Ronald S. Bultje wrote: > If the second, then simple is a superset of simplemmx. If the first, then > we should remove simplemmx from the list of "supported" idcts for the > sse2/avx functions. I have no preference (I assumed it meant th

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-24 Thread Ronald S. Bultje
Hi, On Sat, Jun 24, 2017 at 3:27 PM, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > Includes add/put functions > > > > Rounding contributed by Ronald S. Bultje > > --- > > libavcodec/tests/x86/dct.c

Re: [FFmpeg-devel] [PATCH] avfilter: add VMAF filter

2017-06-24 Thread Ronald S. Bultje
Hi, On Sat, Jun 24, 2017 at 3:50 PM, Ashish Singh wrote: > +typedef struct VMAFContext { > [..] > +double curr_vmaf_score; > Unused. > +uint64_t nb_frames; > Unused. > +pthread_attr_t attr; > This is essentially unused, so might just as well pass NULL into pthread_create().

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/x86: use new x86-64 functions for -idct simple

2017-06-24 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > They now match according to FATE, barring any further bugs with untested > parts > --- > libavcodec/x86/idctdsp_init.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) LGTM. Ronald _

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-24 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 7:13 PM, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > Includes add/put functions > > > > Rounding contributed by Ronald S. Bultje > > --- > > libavcodec/tests/x86/dct.c

Re: [FFmpeg-devel] [PATCH] vf_spp: only assign function pointers if permutation matches expectations.

2017-06-24 Thread Ronald S. Bultje
Hi, On Fri, Jun 23, 2017 at 9:16 PM, Michael Niedermayer wrote: > On Fri, Jun 23, 2017 at 11:02:07AM -0400, Ronald S. Bultje wrote: > > --- > > libavfilter/x86/vf_spp.c | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] vf_spp: only assign function pointers if permutation matches expectations.

2017-06-23 Thread Ronald S. Bultje
Hi, On Thu, Jun 22, 2017 at 4:28 PM, Michael Niedermayer wrote: > On Wed, Jun 21, 2017 at 09:03:11PM -0400, Ronald S. Bultje wrote: > > On Wed, Jun 21, 2017 at 8:42 PM, Michael Niedermayer > > also the memcmp() is a very ugly way to check the permutation > > > >

[FFmpeg-devel] [PATCH] vf_spp: only assign function pointers if permutation matches expectations.

2017-06-23 Thread Ronald S. Bultje
--- libavfilter/x86/vf_spp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/x86/vf_spp.c b/libavfilter/x86/vf_spp.c index 45a9eb0..7d5da61 100644 --- a/libavfilter/x86/vf_spp.c +++ b/libavfilter/x86/vf_spp.c @@ -21,6 +21,7 @@ #include "libavutil/attribute

Re: [FFmpeg-devel] [PATCH] vf_spp: only assign function pointers if permutation matches expectations.

2017-06-21 Thread Ronald S. Bultje
Hi, On Wed, Jun 21, 2017 at 8:42 PM, Michael Niedermayer wrote: > On Wed, Jun 21, 2017 at 09:46:58AM -0400, Ronald S. Bultje wrote: > > --- > > libavfilter/x86/vf_spp.c | 15 ++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff -

[FFmpeg-devel] [PATCH] vf_spp: only assign function pointers if permutation matches expectations.

2017-06-21 Thread Ronald S. Bultje
--- libavfilter/x86/vf_spp.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavfilter/x86/vf_spp.c b/libavfilter/x86/vf_spp.c index 45a9eb0..8e3c820 100644 --- a/libavfilter/x86/vf_spp.c +++ b/libavfilter/x86/vf_spp.c @@ -217,6 +217,17 @@ static void store_sl

Re: [FFmpeg-devel] [PATCH] Added VMAF filter linking to Netflix's vmaf library

2017-06-21 Thread Ronald S. Bultje
Hi, On Wed, Jun 21, 2017 at 8:16 AM, Ashish Singh wrote: > This is VMAF filter which requires Netflix's vmaf library Very cool! (For those not aware, this is a GSoC project, it's work-in-progress but it can already generate VMAF scores identical to what Netflix' command-line utility gives.)

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-21 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 8:45 PM, Michael Niedermayer wrote: > On Tue, Jun 20, 2017 at 08:18:20PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Jun 20, 2017 at 5:22 PM, Michael Niedermayer > > > wrote: > > > > > On Tue, Jun 20, 201

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 7:13 PM, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > Includes add/put functions > > > > Rounding contributed by Ronald S. Bultje > > --- > > libavcodec/tests/x86/dct.c

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 5:22 PM, Michael Niedermayer wrote: > On Tue, Jun 20, 2017 at 08:47:33AM -0400, Ronald S. Bultje wrote: > > This allows using non-simple (e.g. simplemmx) IDCT implementations. > > The result is not bitexact (which is why the fate test continues t

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 12:04 PM, James Darnley wrote: > On 2017-06-20 14:47, Ronald S. Bultje wrote: > > This allows using non-simple (e.g. simplemmx) IDCT implementations. > > The result is not bitexact (which is why the fate test continues to > > use -idct simple), b

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 4:32 PM, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > Includes add/put functions > > > > Rounding contributed by Ronald S. Bultje > > --- > > libavcodec/tests/x86/dct.c

[FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Ronald S. Bultje
This allows using non-simple (e.g. simplemmx) IDCT implementations. The result is not bitexact (which is why the fate test continues to use -idct simple), but the PSNR between C/MMX goes from ~35 to ~90. --- libavcodec/mdec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) d

Re: [FFmpeg-devel] [PATCH 03/11] avcodec/mdec: override IDCT choice before initing DSP structs

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 2:05 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > >> --- >> libavcodec/mdec.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/liba

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/x86: allow future 8-bit simple idct to have "DC only hack"

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > Created by Ronald S. Bultje > --- > libavcodec/x86/simple_idct10_template.asm | 38 > +++ > 1 file changed, 38 insertions(+) > > diff --git a/libavcodec/x86/simple_idct10_template.a

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/x86: allow future 8-bit simple idct to use slightly different coefficients

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > --- > libavcodec/x86/proresdsp.asm | 18 ++ > libavcodec/x86/simple_idct10.asm | 29 > + > libavcodec/x86/simple_idct10_template.asm | 19 +++ > 3 files

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_cabac: Fix CABAC+8x8dct in 4:4:4

2017-06-19 Thread Ronald S. Bultje
Hi, On Fri, Jun 16, 2017 at 12:46 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Thu, Jun 15, 2017 at 03:50:31PM -0400, Ronald S. Bultje wrote: > > From: Anton Mitrofanov > > > > Use the correct ctxIdxInc calculation for coded_block_flag. > > Keep

Re: [FFmpeg-devel] [PATCH 07/11] avcodec/x86: modify simple_idct10 macros to add an action paramter

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > --- > libavcodec/x86/proresdsp.asm | 2 +- > libavcodec/x86/simple_idct10.asm | 8 +++ > libavcodec/x86/simple_idct10_template.asm | 37 > +-- > 3 files changed, 25 insertions(+)

Re: [FFmpeg-devel] [PATCH 06/11] avcodec/x86: cleanup simple_idct10

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > Use named arguments for the functions so we can remove a define. The > stride/linesize argument is now ptrdiff_t type so we no longer need to > sign extend the register. > --- > libavcodec/x86/proresdsp.asm | 2 +- > li

Re: [FFmpeg-devel] [PATCH] libavfilter/scale: Populate ow/oh when using 0 as w/h

2017-06-19 Thread Ronald S. Bultje
Hi, On Wed, Jun 14, 2017 at 1:03 AM, Kevin Mark wrote: > The input width and height is known at parse time so there's no > reason ow/oh should not be usable when using 0 as the width or > height expression. > > Previously in "scale=0:ow" ow would be set to "0" which works, > conveniently, as "sc

Re: [FFmpeg-devel] [PATCH] doc/filters: Correct scale doc regarding w/h <= 0

2017-06-19 Thread Ronald S. Bultje
Hi, On Tue, Jun 13, 2017 at 7:42 AM, Moritz Barsnick wrote: > On Mon, Jun 12, 2017 at 01:59:05 -0400, Kevin Mark wrote: > > Signed-off-by: Kevin Mark > > --- > > doc/filters.texi | 39 --- > > 1 file changed, 20 insertions(+), 19 deletions(-) > > Yes, this t

Re: [FFmpeg-devel] [PATCH 04/11] avcodec/mdec: allow/use permuted IDCTs

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 12:39 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Jun 19, 2017 at 05:10:57PM +0200, James Darnley wrote: > > From: "Ronald S. Bultje" > > > > --- > > libavcodec/mdec.c | 6 +++--- > &

Re: [FFmpeg-devel] [PATCH 03/11] avcodec/mdec: override IDCT choice before initing DSP structs

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > --- > libavcodec/mdec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c > index 8e28aa04f0..97bfebbeb7 100644 > --- a/libavcodec/mdec.c > +++ b/libavcodec/mdec.c > @@

Re: [FFmpeg-devel] [PATCH] avcodec: Rename ff_mpv_decode_mb() to ff_mpv_reconstruct_mb

2017-06-19 Thread Ronald S. Bultje
Hi, On Sun, Jun 18, 2017 at 9:46 PM, Michael Niedermayer wrote: > The new name more accuratly describes what the function does > > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h| 2 +- > libavcodec/h261dec.c| 4 ++-- > libavcodec/h263dec.c| 4 ++-- >

[FFmpeg-devel] [PATCH 3/3] avcodec/h264: Fix mix of lossless and lossy MBs decoding

2017-06-15 Thread Ronald S. Bultje
From: Anton Mitrofanov Signed-off-by: Ronald S. Bultje --- libavcodec/h264_cabac.c | 16 libavcodec/h264_cavlc.c | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/h264_cabac.c b/libavcodec/h264_cabac.c index 28aacc5..0973e30

[FFmpeg-devel] [PATCH 2/3] avcodec/h264_mb: Fix 8x8dct in lossless for new versions of x264

2017-06-15 Thread Ronald S. Bultje
From: Anton Mitrofanov Signed-off-by: Ronald S. Bultje --- libavcodec/h264_mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_mb.c b/libavcodec/h264_mb.c index 638dcba..cb9fe85 100644 --- a/libavcodec/h264_mb.c +++ b/libavcodec/h264_mb.c @@ -637,7 +637,7

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_cabac: Fix CABAC+8x8dct in 4:4:4

2017-06-15 Thread Ronald S. Bultje
From: Anton Mitrofanov Use the correct ctxIdxInc calculation for coded_block_flag. Keep old behavior for old versions of x264 for backward compatibility. Signed-off-by: Ronald S. Bultje --- libavcodec/h264_cabac.c | 47 +-- 1 file changed, 33

Re: [FFmpeg-devel] [PATCH] vp9: fix overwrite in ff_vp9_ipred_dr_16x16_16_avx2.

2017-06-14 Thread Ronald S. Bultje
Hi, On Wed, Jun 14, 2017 at 11:34 AM, James Almer wrote: > On 6/14/2017 9:46 AM, Ronald S. Bultje wrote: > > Fixes trac issue 6459. > > --- > > libavcodec/x86/vp9intrapred_16bpp.asm | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/li

[FFmpeg-devel] [PATCH] vp9: fix overwrite in ff_vp9_ipred_dr_16x16_16_avx2.

2017-06-14 Thread Ronald S. Bultje
Fixes trac issue 6459. --- libavcodec/x86/vp9intrapred_16bpp.asm | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/x86/vp9intrapred_16bpp.asm b/libavcodec/x86/vp9intrapred_16bpp.asm index 764f704..c651c08 100644 --- a/libavcodec/x86/vp9intrapred_16bpp.asm +++ b/libavcodec/x86/vp9intra

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: ipred_dr_16x16_16 avx2 implementation

2017-06-12 Thread Ronald S. Bultje
Hi, On Sat, Jun 10, 2017 at 6:01 AM, Ilia Valiakhmetov wrote: > Signed-off-by: Ilia Valiakhmetov > --- > libavcodec/x86/vp9dsp_init_16bpp.c| 2 ++ > libavcodec/x86/vp9intrapred_16bpp.asm | 56 ++ > + > 2 files changed, 58 insertions(+) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/htmlsubtitles: Protect very slow redundant sscanf() calls by optimized use of strchr()

2017-06-10 Thread Ronald S. Bultje
Hi, On Fri, Jun 9, 2017 at 1:39 PM, Michael Niedermayer wrote: > If we want to make ff_htmlmarkup_to_ass() not go into near infinite > loops What's a near-infinite loop? Is it non-infinite loop, i.e. just a loop? Or is there special something special about it? :-). "Fix [..] near-infinite loop

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-06-09 Thread Ronald S. Bultje
Hi, On Thu, Jun 8, 2017 at 8:57 PM, Michael Niedermayer wrote: > On Thu, Jun 08, 2017 at 06:35:07PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Jun 8, 2017 at 6:10 PM, Michael Niedermayer > > > wrote: > > > > > Sign

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Add a pixdesc API alias name for bt2020nc color space

2017-06-09 Thread Ronald S. Bultje
Hi, On Thu, Jun 8, 2017 at 8:01 PM, Vittorio Giovara wrote: > --- > libavfilter/vf_colorspace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c > index d1e9a1c609..71ea08a20f 100644 > --- a/libavfilter/vf_colorspace.c > +++ b/li

<    1   2   3   4   5   6   7   8   9   10   >