Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-28 Thread Ronald S. Bultje
Hi, On Sat, Jan 28, 2017 at 7:25 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 27.01.2017 03:27, Michael Niedermayer wrote: > > On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >>

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

2017-01-26 Thread Ronald S. Bultje
Hi, On Wed, Jan 25, 2017 at 8:56 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 26.01.2017 02:26, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Jan 25, 2017 at 8:20 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrot

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

2017-01-25 Thread Ronald S. Bultje
Hi, On Wed, Jan 25, 2017 at 8:20 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 07.01.2017 13:44, Ronald S. Bultje wrote: > > On Fri, Jan 6, 2017 at 9:35 PM, Michael Niedermayer > <mich...@niedermayer.cc> > > wrote: > > > >

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-25 Thread Ronald S. Bultje
Hi, On Wed, Jan 25, 2017 at 8:12 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/nistspheredec.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git

Re: [FFmpeg-devel] GSoC 2017

2017-01-23 Thread Ronald S. Bultje
Hi, On Mon, Jan 23, 2017 at 9:39 AM, Michael Niedermayer wrote: > IIRC google suggests that ideas pages are writen and maintained > year round. Now we have a list but some develoeprs seem to oppose some > of these old ideas, I would expect that for each objection against an >

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pthread_frame: protect read state access in setup finish function

2017-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2017 at 9:39 AM, wm4 <nfx...@googlemail.com> wrote: > On Fri, 13 Jan 2017 09:07:48 -0500 > "Ronald S. Bultje" <rsbul...@gmail.com> wrote: > > > Hi, > > > > On Jan 13, 2017 6:40 AM, "Clément Bœsch" <u...

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pthread_frame: protect read state access in setup finish function

2017-01-13 Thread Ronald S. Bultje
Hi, On Jan 13, 2017 6:40 AM, "Clément Bœsch" wrote: From: Clément Bœsch --- libavcodec/pthread_frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 7ef5e9f6be..cb6d76284e

Re: [FFmpeg-devel] [PATCH] HTTP: optimize forward seek performance

2017-01-12 Thread Ronald S. Bultje
Hi Joel, On Wed, Jan 11, 2017 at 6:01 PM, Joel Cunningham wrote: > Hi, > > I’ve been working on optimizing HTTP forward seek performance for ffmpeg > and would like to contribute this patch into mainline ffmpeg. Please see > the below patch for an explanation of the

Re: [FFmpeg-devel] [PATCH] avutil/frame: Remove requirements to use accessors for AVFrame

2017-01-09 Thread Ronald S. Bultje
Hi, On Mon, Jan 9, 2017 at 8:48 AM, wm4 <nfx...@googlemail.com> wrote: > On Mon, 9 Jan 2017 08:17:08 -0500 > "Ronald S. Bultje" <rsbul...@gmail.com> wrote: > > > Hi, > > > > On Mon, Jan 9, 2017 at 7:15 AM, wm4 <nfx...@googlemail.com> w

Re: [FFmpeg-devel] [PATCH] avutil/frame: Remove requirements to use accessors for AVFrame

2017-01-09 Thread Ronald S. Bultje
Hi, On Mon, Jan 9, 2017 at 7:15 AM, wm4 wrote: > /** > * Not to be accessed directly from outside libavutil > */ > AVBufferRef *qp_table_buf; > > The comment should be adjusted and allow direct access. Also, > it should be moved out of the

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

2017-01-07 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 9:35 PM, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 09:43:24PM +0100, Andreas Cadhalpun wrote: > > On 23.12.2016 00:57, Andreas Cadhalpun wrote: > > > Signed-off-by: Andreas Cadhalpun > > > --- > > >

Re: [FFmpeg-devel] [PATCH 4/9] genh: prevent overflow during block alignment calculation

2017-01-07 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 8:43 PM, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 08:48:02PM +0100, Andreas Cadhalpun wrote: > > Signed-off-by: Andreas Cadhalpun > > --- > > libavformat/genh.c | 1 + > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 6/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-06 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 5:30 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 06.01.2017 22:30, Ronald S. Bultje wrote: > > On Fri, Jan 6, 2017 at 2:48 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > >

Re: [FFmpeg-devel] [PATCH 5/9] ircamdec: prevent overflow during block alignment calculation

2017-01-06 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 2:48 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/ircamdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/ircamdec.c

Re: [FFmpeg-devel] [PATCH 6/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-06 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 2:48 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/nistspheredec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/nistspheredec.c

Re: [FFmpeg-devel] [PATCH 2/9] 4xm: prevent overflow during block alignment calculation

2017-01-06 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 2:47 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/4xm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/4xm.c b/libavformat/4xm.c > index

Re: [FFmpeg-devel] libavcodec memory usage

2017-01-03 Thread Ronald S. Bultje
Hi, On Tue, Jan 3, 2017 at 4:35 PM, Matthieu Beghin < matthieu.beg...@garagecube.com> wrote: > Hi, > > > On 03 Jan 2017, at 18:26, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > > > Hi, > > > > On Tue, Jan 3, 2017 at 12:16 PM, Matthieu Be

Re: [FFmpeg-devel] libavcodec memory usage

2017-01-03 Thread Ronald S. Bultje
Hi, On Tue, Jan 3, 2017 at 12:16 PM, Matthieu Beghin < matthieu.beg...@garagecube.com> wrote: > > > On 03 Jan 2017, at 17:55, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > > > Hi, > > > > On Tue, Jan 3, 2017 at 11:44 AM, Matthieu Beghi

Re: [FFmpeg-devel] libavcodec memory usage

2017-01-03 Thread Ronald S. Bultje
Hi, On Tue, Jan 3, 2017 at 11:44 AM, Matthieu Beghin < matthieu.beg...@garagecube.com> wrote: > > I'm assuming that you're talking about 8K H264 with pixfmt=yuv420p10? 8K > yuv420p10 frames are 100MB > > Correct > > > 32 plus delayed output and current_pic gives H264_MAX_PICTURE_COUNT = 36 >

Re: [FFmpeg-devel] libavcodec memory usage

2017-01-03 Thread Ronald S. Bultje
Hi, On Tue, Jan 3, 2017 at 10:58 AM, Matthieu Beghin < matthieu.beg...@garagecube.com> wrote: > Hi, > > My application is using libavcodec etc. to playback movies. Everything is > ok with our 64 bits app. But I have a 32 bits app and there when playing a > 8k we reach 3 GB memory usage, so when

Re: [FFmpeg-devel] [PATCH] avcodec/x86/vc1dsp_mc: Fix build with NASM 2.09.10

2017-01-02 Thread Ronald S. Bultje
Hi, On Mon, Jan 2, 2017 at 3:35 PM, Michael Niedermayer wrote: > make fate passes > > Signed-off-by: Michael Niedermayer > --- > libavcodec/x86/vc1dsp_mc.asm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] PATCH for building with nasm

2017-01-02 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 8:36 PM, Michael Niedermayer wrote: > On Sun, Jan 01, 2017 at 08:16:00AM +, Rostislav Pehlivanov wrote: > > On 1 January 2017 at 07:52, John Comeau wrote: > > > > > fixes `operation size not specified` errors as

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:55 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 01.01.2017 23:27, Ronald S. Bultje wrote: > > On Sun, Jan 1, 2017 at 5:18 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com <mailto:andreas.cadhal...@

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:51 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 01.01.2017 23:23, Ronald S. Bultje wrote: > > On Sun, Jan 1, 2017 at 5:19 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com <mailto:andreas.cadhal...@

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:18 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > This fixes triggering the av_assert0(ret <= tmp.size). > > The problem was reintroduced by commit > 7b27dd5c16de785297ce4de4b88afa0b6685f61d and originally fixed by >

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:19 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > The problem was introduced by commit > 3deb4b54a24f8cddce463d9f5751b01efeb976af. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/wmavoice.c | 2 +- > 1

[FFmpeg-devel] [PATCH] wmavoice: remove unused or write-only variables.

2016-12-27 Thread Ronald S. Bultje
--- libavcodec/wmavoice.c | 44 +--- 1 file changed, 17 insertions(+), 27 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index cd5958c..4b283e3 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -104,26 +104,24 @@

Re: [FFmpeg-devel] [PATCH] checkasm/vp9: benchmark all sub-IDCTs (but not WHT or ADST).

2016-12-27 Thread Ronald S. Bultje
Hi, On Tue, Dec 20, 2016 at 7:10 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Mon, Dec 5, 2016 at 4:15 PM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > >> --- >> tests/checkasm/vp9dsp.c | 22 ++ >>

Re: [FFmpeg-devel] [PATCH] wmavoice: protect against zero-energy in adaptive gain control.

2016-12-27 Thread Ronald S. Bultje
Hi, On Wed, Dec 21, 2016 at 2:50 AM, Paul B Mahol <one...@gmail.com> wrote: > On 12/21/16, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > Otherwise the scale factor becomes NaN, resulting in corrupt output. > > Fixes #5426. > > --- > > libavcodec/wm

Re: [FFmpeg-devel] [libav-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

2016-12-26 Thread Ronald S. Bultje
Hi, On Mon, Dec 26, 2016 at 4:53 AM, Henrik Gramner <hen...@gramner.com> wrote: > On Mon, Dec 26, 2016 at 2:32 AM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > I know I'm terribly nitpicking here for the limited scope of the comment, > > but this only m

Re: [FFmpeg-devel] [libav-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

2016-12-25 Thread Ronald S. Bultje
Hi, On Sun, Dec 25, 2016 at 2:24 PM, Henrik Gramner wrote: > When allocating stack space with an alignment requirement that is larger > than the current stack alignment we need to store a copy of the original > stack pointer in order to be able to restore it later. > > If we

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

2016-12-25 Thread Ronald S. Bultje
Hi, On Sat, Dec 24, 2016 at 9:29 AM, Paul B Mahol <one...@gmail.com> wrote: > On 12/24/16, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > Hi, > > > > On Sat, Dec 24, 2016 at 6:09 AM, Paul B Mahol <one...@gmail.com> wrote: > > > >> On

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

2016-12-24 Thread Ronald S. Bultje
Hi, On Sat, Dec 24, 2016 at 6:09 AM, Paul B Mahol <one...@gmail.com> wrote: > On 12/24/16, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > Hi, > > > > On Fri, Dec 23, 2016 at 6:18 PM, James Almer <jamr...@gmail.com> wrote: > > > >> On

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

2016-12-23 Thread Ronald S. Bultje
Hi, On Fri, Dec 23, 2016 at 6:18 PM, James Almer <jamr...@gmail.com> wrote: > On 12/23/2016 8:00 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Dec 23, 2016 at 12:32 PM, Paul B Mahol <one...@gmail.com> wrote: > > > >> diff --git a/libav

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

2016-12-23 Thread Ronald S. Bultje
Hi, On Fri, Dec 23, 2016 at 12:32 PM, Paul B Mahol wrote: > diff --git a/libavcodec/lossless_videodsp.h b/libavcodec/lossless_ > videodsp.h > [..] > @@ -32,6 +32,7 @@ typedef struct LLVidDSPContext { > [..] > +void (*add_magy_median_pred_int16)(uint16_t *dst, const

Re: [FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

2016-12-20 Thread Ronald S. Bultje
Hi, On Tue, Dec 20, 2016 at 7:59 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Tue, Dec 20, 2016 at 07:51:05PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Dec 20, 2016 at 7:44 PM, Michael Niedermayer > <mich...@niedermayer.cc > >

Re: [FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

2016-12-20 Thread Ronald S. Bultje
Hi, On Tue, Dec 20, 2016 at 7:44 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Tue, Dec 20, 2016 at 05:23:06PM -0500, Ronald S. Bultje wrote: > > The checked bitstream reader does that already. To allow parsing of > > superframes split over a packet bound

Re: [FFmpeg-devel] [PATCH] checkasm/vp9: benchmark all sub-IDCTs (but not WHT or ADST).

2016-12-20 Thread Ronald S. Bultje
Hi, On Mon, Dec 5, 2016 at 4:15 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > --- > tests/checkasm/vp9dsp.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c > index

[FFmpeg-devel] [PATCH] wmavoice: protect against zero-energy in adaptive gain control.

2016-12-20 Thread Ronald S. Bultje
Otherwise the scale factor becomes NaN, resulting in corrupt output. Fixes #5426. --- libavcodec/wmavoice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index 90dfe20..cd5958c 100644 --- a/libavcodec/wmavoice.c +++

[FFmpeg-devel] [PATCH 4/4] wmavoice: move overflow handling to common code.

2016-12-20 Thread Ronald S. Bultje
--- libavcodec/wmavoice.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index f31c9d2..90dfe20 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -1800,6 +1800,11 @@ static int

[FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

2016-12-20 Thread Ronald S. Bultje
The checked bitstream reader does that already. To allow parsing of superframes split over a packet boundary, we always decode the last superframe in each packet at the start of the next packet, even if theoretically we could have decoded it. The last superframe in the last packet is decoded using

[FFmpeg-devel] [PATCH 1/4] wmavoice: move wmavoice_flush() up.

2016-12-20 Thread Ronald S. Bultje
--- libavcodec/wmavoice.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index ceac61f..4b3ab43 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -337,6 +337,34

[FFmpeg-devel] [PATCH 3/4] wmavoice: reindent.

2016-12-20 Thread Ronald S. Bultje
--- libavcodec/wmavoice.c | 72 +-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index ae100fb..f31c9d2 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -1915,29

[FFmpeg-devel] [PATCH 1/2] wmavoice: disable bitstream checking.

2016-12-20 Thread Ronald S. Bultje
The checked bitstream reader does that already. To allow parsing of superframes split over a packet boundary, we always decode the last superframe in each packet at the start of the next packet, even if theoretically we could have decoded it. The last superframe in the last packet is decoded using

[FFmpeg-devel] [PATCH 2/2] wmavoice: reindent.

2016-12-20 Thread Ronald S. Bultje
--- libavcodec/wmavoice.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index 5001b0b..5393003 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -1887,23 +1887,23 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: don't check if we have enough bits to read a superframe.

2016-12-16 Thread Ronald S. Bultje
Hi, On Fri, Dec 16, 2016 at 9:49 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Fri, Dec 16, 2016 at 08:19:44AM -0500, Ronald S. Bultje wrote: > > The checked bitstream reader makes this unnecessary. > > --- > >

[FFmpeg-devel] [PATCH] wmavoice: don't check if we have enough bits to read a superframe.

2016-12-16 Thread Ronald S. Bultje
The checked bitstream reader makes this unnecessary. --- libavcodec/wmavoice.c | 86 ++- 1 file changed, 2 insertions(+), 84 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index ba02c7d..e4ea128 100644 ---

[FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

2016-12-16 Thread Ronald S. Bultje
This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it correctly so streams actually decode the way the encoder intended them to. --- libavcodec/wmavoice.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/libavcodec/wmavoice.c

[FFmpeg-devel] [PATCH 1/2] wmavoice: don't check if we have enough bits to read a superframe.

2016-12-16 Thread Ronald S. Bultje
The checked bitstream reader makes this unnecessary. --- libavcodec/wmavoice.c | 83 --- 1 file changed, 83 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index ceac61f..0f29bdd 100644 --- a/libavcodec/wmavoice.c +++

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Ronald S. Bultje
Hi, On Thu, Dec 15, 2016 at 9:28 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Thu, Dec 15, 2016 at 08:02:52AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail

Re: [FFmpeg-devel] [PATCH 6/6] pvfdec: prevent overflow during block alignment, calculation

2016-12-15 Thread Ronald S. Bultje
Hi, On Wed, Dec 14, 2016 at 8:19 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/pvfdec.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/pvfdec.c

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Ronald S. Bultje
Hi, On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 14.12.2016 02:46, Ronald S. Bultje wrote: > > Not wanting to discourage you, but I wonder if there's really a point to > > this...? > > These patches are

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-13 Thread Ronald S. Bultje
Hi, On Tue, Dec 13, 2016 at 8:21 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 14.12.2016 02:01, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Dec 13, 2016 at 7:57 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com>

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-13 Thread Ronald S. Bultje
Hi, On Tue, Dec 13, 2016 at 7:57 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/4xm.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavformat/4xm.c

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-11 Thread Ronald S. Bultje
Hi, On Sun, Dec 11, 2016 at 1:41 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 10.12.2016 23:22, Carl Eugen Hoyos wrote: > > 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun < > andreas.cadhal...@googlemail.com>: > >> Suggested-by: Carl Eugen Hoyos > >>

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 7:17 PM, Carl Eugen Hoyos wrote: > 2016-12-10 23:59 GMT+01:00 James Almer : > > >>> Again, I'm against this. This is not news entry worthy. > >> > >> Then please revert the configure change: > >> This is (by far) the biggest

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 5:24 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-12-10 14:07 GMT+01:00 Ronald S. Bultje <rsbul...@gmail.com>: > > Hi, > > > > On Sat, Dec 10, 2016 at 7:11 AM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote:

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 1:53 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 10.12.2016 19:49, James Almer wrote: > > On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote: > >> Suggested-by: Carl Eugen Hoyos > >> Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 7:11 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-12-09 12:56 GMT+01:00 Ronald S. Bultje <rsbul...@gmail.com>: > > > On IRC, we discussed at what values OOM start occurring, which seems to > be > > around 30k-60k > >

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-09 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2016 at 7:03 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 08.12.2016 22:59, Carl Eugen Hoyos wrote: > > 2016-12-08 18:37 GMT+01:00 Michael Niedermayer : > > > >> -{"max_streams", "maximum number of streams", OFFSET(max_streams),

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2016 at 1:25 PM, James Almer <jamr...@gmail.com> wrote: > On 12/8/2016 2:44 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Dec 8, 2016 at 12:37 PM, Michael Niedermayer > <mich...@niedermayer.cc > >> wrote: > > >

Re: [FFmpeg-devel] [PATCH] aarch64: h264idct: Use the offset parameter to movrel

2016-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2016 at 12:14 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Thu, Dec 08, 2016 at 12:01:33PM -0500, Ronald S. Bultje wrote: > > From: Martin Storsjö <mar...@martin.st> > > > > Signed-off-by: Martin Storsjö <mar...@martin.st&

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2016 at 12:37 PM, Michael Niedermayer wrote: > Suggested-by: Andreas Cadhalpun > Signed-off-by: Michael Niedermayer > --- > libavformat/options_table.h | 2 +- > 1 file changed, 1

[FFmpeg-devel] [PATCH] aarch64: h264idct: Use the offset parameter to movrel

2016-12-08 Thread Ronald S. Bultje
From: Martin Storsjö <mar...@martin.st> Signed-off-by: Martin Storsjö <mar...@martin.st> Signed-off-by: Ronald S. Bultje <rsbul...@gmail.com> --- libavcodec/aarch64/h264idct_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/

Re: [FFmpeg-devel] [PATCH] remove news entry about ffserver

2016-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2016 at 10:04 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-12-08 16:02 GMT+01:00 Ronald S. Bultje <rsbul...@gmail.com>: > > Hi, > > > > On Thu, Dec 8, 2016 at 8:42 AM, Carl Eugen Hoyos <ceffm...@gmail.com> > wrote: >

Re: [FFmpeg-devel] [PATCH] remove news entry about ffserver

2016-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2016 at 8:42 AM, Carl Eugen Hoyos wrote: > 2016-12-08 14:36 GMT+01:00 compn : > > yeah. > > Instead I would suggest to clarify / correct the entry or write a new one. I agree with CE here, let's not rewrite history. My reading of the

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-07 Thread Ronald S. Bultje
Hi, On Wed, Dec 7, 2016 at 1:29 PM, Nicolas George wrote: > keepAndreas Cadhalpun > keepMarton Balint > keepMichael Niedermayer (slightly invalid) > keepNicolas George > keepReynaldo H. Verdejo Pinochet (slightly invalid) I believe you missed Carl Eugen's

Re: [FFmpeg-devel] [PATCH 0/4] More H.264 assembly (the sequel) [version 2]

2016-12-06 Thread Ronald S. Bultje
Hi, On Tue, Dec 6, 2016 at 7:04 AM, James Darnley wrote: > On 2016-12-05 19:32, James Darnley wrote: > > Fixed the problem Michael highlighted. Dropped the intra functions > until it > > becomes clear why their performance is unexpected. Updated the > benchmarks with > >

[FFmpeg-devel] [PATCH] checkasm/vp9: benchmark all sub-IDCTs (but not WHT or ADST).

2016-12-05 Thread Ronald S. Bultje
--- tests/checkasm/vp9dsp.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c index 441041c..f32b97c 100644 --- a/tests/checkasm/vp9dsp.c +++ b/tests/checkasm/vp9dsp.c @@ -331,15 +331,20 @@ static void

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-05 Thread Ronald S. Bultje
Hi, On Mon, Dec 5, 2016 at 9:45 AM, Carl Eugen Hoyos wrote: > 2016-12-05 15:23 GMT+01:00 James Almer : > > The technical reasons are there, described in the news entry you seem to > > not want to read, or at least properly parse. > > These past week

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-01 Thread Ronald S. Bultje
Hi, On Thu, Dec 1, 2016 at 6:35 PM, Carl Eugen Hoyos wrote: > 2016-12-01 22:26 GMT+01:00 Gregory J. Wolfe >: > > > +switch (avctx->color_primaries) { > > +case AVCOL_PRI_BT709:param.sSpatialLayers[0].uiColorPrimaries >

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-11-30 Thread Ronald S. Bultje
Hi, On Wed, Nov 30, 2016 at 5:26 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 30.11.2016 22:55, Ronald S. Bultje wrote: > > On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264: sse2 and avx 4:2:2 idct add8 10-bit functions

2016-11-30 Thread Ronald S. Bultje
Hi, On Wed, Nov 30, 2016 at 7:10 AM, James Darnley wrote: > On 2016-11-29 21:09, Carl Eugen Hoyos wrote: > > 2016-11-29 17:14 GMT+01:00 James Darnley : > >> On 2016-11-29 15:30, Carl Eugen Hoyos wrote: > >>> 2016-11-29 12:52 GMT+01:00 James Darnley

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-11-29 Thread Ronald S. Bultje
Hi Stefano, On Tue, Nov 29, 2016 at 1:46 PM, Stefano Sabatini wrote: > On date Monday 2016-11-28 19:15:28 +0100, Nicolas George encoded: > > Deadline: 2016-12-06 00:00 UTC. > > > > I propose, and put to the discussion, that the decision to drop ffserver > > is revoked,

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-11-29 Thread Ronald S. Bultje
Hi, On Mon, Nov 28, 2016 at 1:15 PM, Nicolas George wrote: > Deadline: 2016-12-06 00:00 UTC. > > I propose, and put to the discussion, that the decision to drop ffserver > is revoked, conditioned to the fixing of the technical issues that lead > to it. > > In other words, if

Re: [FFmpeg-devel] [PATCH] lavc/vaapi-vp9: add support for profile 2 (bpp > 8)

2016-11-28 Thread Ronald S. Bultje
Hi, On Mon, Nov 28, 2016 at 7:26 PM, Mark Thompson wrote: > On 28/11/16 21:22, Mathieu Velten wrote: > > --- > > libavcodec/vaapi_vp9.c | 1 + > > libavcodec/vp9.c | 32 +--- > > libavcodec/vp9.h | 1 + > > 3 files changed, 19

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-28 Thread Ronald S. Bultje
Hi, On Mon, Nov 28, 2016 at 10:25 AM, Nicolas George <geo...@nsup.org> wrote: > L'octidi 8 frimaire, an CCXXV, Ronald S. Bultje a écrit : > > The majority. > > Rational arguments first. To what end? Aren't we dug in, don't we need a decision and follow through wit

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-28 Thread Ronald S. Bultje
Hi, On Mon, Nov 28, 2016 at 10:17 AM, Nicolas George wrote: > L'octidi 8 frimaire, an CCXXV, compn a écrit : > > these developers feel very strongly about removing ffserver. > > I feel very strongly about keeping ffserver. Who is right? The majority. OK, so this is going

Re: [FFmpeg-devel] [PATCH] ffserver: Remove last use of AVStream size

2016-11-27 Thread Ronald S. Bultje
Hi, On Sun, Nov 27, 2016 at 1:26 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > ffserver.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/ffserver.c b/ffserver.c > index

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Ronald S. Bultje
Hi, On Sun, Nov 27, 2016 at 1:46 PM, Michael Niedermayer wrote: > On Sun, Nov 27, 2016 at 07:30:24PM +0100, Clément Bœsch wrote: > > On Sun, Nov 27, 2016 at 06:49:35PM +0100, Michael Niedermayer wrote: > > > On Sun, Nov 27, 2016 at 04:57:36PM +0100, Clément Bœsch wrote:

Re: [FFmpeg-devel] [PATCH 2/2] ffserver: Remove extract_mpeg4_header()

2016-11-23 Thread Ronald S. Bultje
Hi, On Wed, Nov 23, 2016 at 2:13 PM, Michael Niedermayer wrote: > This should not be needed, our AVParsers should do this > I do not have a testcase though, please help testing this and please > add fate tests if you can. I thought we were going to remove ffserver?

Re: [FFmpeg-devel] libavcodec : add psd image file decoder

2016-11-21 Thread Ronald S. Bultje
Hi, On Mon, Nov 21, 2016 at 4:40 PM, Rostislav Pehlivanov wrote: > On 21 November 2016 at 20:44, Martin Vignali > wrote: > > > Hello, > > > > New patchs in attach. > > Correction have been made followings comments from Andreas and Carl. > > > >

Re: [FFmpeg-devel] [PATCH] avutil: add P016 pixel format

2016-11-20 Thread Ronald S. Bultje
Hi, On Sun, Nov 20, 2016 at 4:59 PM, Philip Langdale wrote: > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h > index 96860ce..4cd3a77 100644 > --- a/libavutil/pixfmt.h > +++ b/libavutil/pixfmt.h > @@ -297,6 +297,8 @@ enum AVPixelFormat { > > AV_PIX_FMT_P010LE, ///<

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

2016-11-20 Thread Ronald S. Bultje
Hi, On Sun, Nov 20, 2016 at 9:16 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Sun, Nov 20, 2016 at 08:56:15AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Nov 20, 2016 at 6:57 AM, Michael Niedermayer > <mich...@niedermayer.cc > &g

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

2016-11-20 Thread Ronald S. Bultje
Hi, On Sun, Nov 20, 2016 at 6:57 AM, Michael Niedermayer wrote: > @@ -131,6 +132,20 @@ static int write_number(void *obj, const AVOption *o, > void *dst, double num, int > if (intnum == 1 && d == (double)INT64_MAX) *(int64_t *)dst = > INT64_MAX; > else

Re: [FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE

2016-11-19 Thread Ronald S. Bultje
Hi, On Sat, Nov 19, 2016 at 7:07 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > gcc before gcc-5 reserves a register on x86_32 for the GOT, when PIE is > enabled. > > This fixes build failures due to: > error: 'asm' operand has impossible constraints > > Signed-off-by:

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 5:02 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Thu, Nov 17, 2016 at 4:11 PM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > Hi, > > > > On Thu, Nov 17, 2016 at 4:09 PM, Vittorio Giovara &g

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 4:11 PM, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > > 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > > > On 16 November 2016 at 11:15, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 4:09 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > This prevents writing past bounds. > > Signed-off-by: Vittorio Giovara > --- > Updated according review. > Vittorio > > doc/filters.texi| 1 + >

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 3:53 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > This prevents writing past bounds. > > Signed-off-by: Vittorio Giovara > --- > Any opinions about this? Hm... I agree right now it's probably broken, but I'd argue that we

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi Carl, On Thu, Nov 17, 2016 at 3:10 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje <rsbul...@gmail.com>: > > Carl, the reason the patch is wrong is that luma range does not scale up > > from 16< > This is docum

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > > > On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > > > > It was lossless before and is lossless after the patch but it > >

Re: [FFmpeg-devel] [PATCH] doc/filters: adds recently added -vf colorspace options

2016-11-16 Thread Ronald S. Bultje
Hi Kieran, On Tue, Nov 15, 2016 at 7:18 PM, Kieran O Leary wrote: > From: kieranjol Is your name spelled like this intentionally? Maybe change your git config so this has your full name instead of what appears to be your login? Ronald

Re: [FFmpeg-devel] [PATCH 1/9] vp9dsp: Deduplicate the subpel filters

2016-11-15 Thread Ronald S. Bultje
Hi, On Mon, Nov 14, 2016 at 9:29 AM, Michael Niedermayer wrote: > On Mon, Nov 14, 2016 at 12:32:19PM +0200, Martin Storsjö wrote: > > Make them aligned, to allow efficient access to them from simd. > > > > This is an adapted cherry-pick from libav commit > >

Re: [FFmpeg-devel] [PATCH] vp9: add avx2 iadst16 implementations.

2016-11-15 Thread Ronald S. Bultje
Hi, On Mon, Nov 14, 2016 at 4:26 PM, James Almer <jamr...@gmail.com> wrote: > On 11/8/2016 1:22 PM, Ronald S. Bultje wrote: > > Also a small cosmetic change to the avx2 idct16 version to make it > > explicit that one of the arguments to the write-out macros is unused &g

Re: [FFmpeg-devel] [PATCH 1/9] vp9dsp: Deduplicate the subpel filters

2016-11-14 Thread Ronald S. Bultje
Hi, On Mon, Nov 14, 2016 at 5:32 AM, Martin Storsjö wrote: > Make them aligned, to allow efficient access to them from simd. > > This is an adapted cherry-pick from libav commit > a4cfcddcb0f76e837d5abc06840c2b26c0e8aefc. > --- > libavcodec/vp9dsp.c | 56

Re: [FFmpeg-devel] [PATCH 2/9] arm: Clear the gp register alias at the end of functions

2016-11-14 Thread Ronald S. Bultje
Hi, assume this is my reply on all patches in the range 2-9: On Mon, Nov 14, 2016 at 5:32 AM, Martin Storsjö wrote: > We reset .Lpic_gp to zero at the start of each function, which means > that the logic within movrelx for clearing gp when necessary will > be missed. > > This

Re: [FFmpeg-devel] [PATCH] vp9_mc_template: disable assert for SCALED == 0

2016-11-12 Thread Ronald S. Bultje
Hi Andreas, On Nov 12, 2016 5:52 PM, "Andreas Cadhalpun" < andreas.cadhal...@googlemail.com> wrote: > > The handling of the other block sizes was disabled for 'SCALED == 0' in > commit dc96c0f9fc96bf4167633befc074394062793322, so this assert should > be disabled, too, as it can now be triggered.

Re: [FFmpeg-devel] [PATCH] vp9: add avx2 iadst16 implementations.

2016-11-08 Thread Ronald S. Bultje
Hi, On Tue, Nov 8, 2016 at 6:33 PM, compn <te...@mi.rr.com> wrote: > On Tue, 8 Nov 2016 14:44:32 -0500 > "Ronald S. Bultje" <rsbul...@gmail.com> wrote: > > > >> x86-32 linux gets stomach ache from this: > > >> > > >> YASMli

Re: [FFmpeg-devel] [PATCH] vp9: add avx2 iadst16 implementations.

2016-11-08 Thread Ronald S. Bultje
Hi, On Tue, Nov 8, 2016 at 2:43 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Tue, Nov 8, 2016 at 2:39 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Tue, Nov 08, 2016 at 11:22:31AM -0500, Ronald S. Bultje wrote: >> >

<    3   4   5   6   7   8   9   10   11   12   >