Used libass to render text-based subtitles in the AVSubtitle structure during
transcoding.
This enables text to bitmap subtitle track conversion
This only works with --enable-libass. Otherwise, nothing should change.
Minor version bump required (field appended to AVCodecContext).
---
text subtitles and store the images in the AVSubtitle
structure.
Of course, this functionality will only work when ffmpeg is configured with
--enable-libass.
Traian Coza (1):
fftools: Implemented text to bitmap subtitles!
fftools/Makefile | 2 +
fftools/ffmpeg.c | 35
Thanks, I'll do that. I did read a bit of Contributing, but not entirely.
And I read after writing the code, so there are some things I wasn't aware
of at the time of writing the code.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
I already made the commits, tho, what do you suggest I do? Should I modify
the messages?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
Thanks, I finally managed to submit my patch with your instructions.
However, I see that the "Less secure apps" setting will no longer be
available in a month. What do you plan on doing then? (I see you also use
gmail)
On Tue, May 3, 2022 at 11:53 AM Leo Izen wrote:
> On 5/3/22
---
fftools/ffmpeg.c| 2 +-
libavcodec/avcodec.c| 9 +
libavcodec/text_to_bitmap.c | 13 +++--
libavcodec/text_to_bitmap.h | 8 +++-
4 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index
---
fftools/text_to_bitmap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fftools/text_to_bitmap.c b/fftools/text_to_bitmap.c
index 0f165e7722..e05e485713 100644
--- a/fftools/text_to_bitmap.c
+++ b/fftools/text_to_bitmap.c
@@ -122,7 +122,8 @@ void
---
libavcodec/text_to_bitmap.c | 9 ++---
libavcodec/text_to_bitmap.h | 6 +++---
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavcodec/text_to_bitmap.c b/libavcodec/text_to_bitmap.c
index 50c72afc55..273564cb67 100644
--- a/libavcodec/text_to_bitmap.c
+++
---
fftools/ffmpeg.c | 4 +++-
fftools/text_to_bitmap.c | 27 ++-
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 251a3ce427..b4d3d491de 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3244,7
---
fftools/ffmpeg.c| 50 ---
libavcodec/Makefile | 1 +
libavcodec/avcodec.h| 9 ++
libavcodec/text_to_bitmap.c | 170
libavcodec/text_to_bitmap.h | 18
libavfilter/vf_subtitles.c | 97
6
---
fftools/ffmpeg.c| 39 ++---
libavcodec/text_to_bitmap.c | 58 +++--
libavfilter/vf_subtitles.c | 18
3 files changed, 58 insertions(+), 57 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index
---
{libavcodec => fftools}/text_to_bitmap.c | 0
{libavcodec => fftools}/text_to_bitmap.h | 0
2 files changed, 0 insertions(+), 0 deletions(-)
rename {libavcodec => fftools}/text_to_bitmap.c (100%)
rename {libavcodec => fftools}/text_to_bitmap.h (100%)
diff --git
---
fftools/Makefile | 2 ++
fftools/ffmpeg.c | 6 --
fftools/text_to_bitmap.c | 14 +++---
fftools/text_to_bitmap.h | 14 --
libavcodec/Makefile | 1 -
libavcodec/avcodec.c | 9 -
6 files changed, 13 insertions(+), 33 deletions(-)
---
libavcodec/text_to_bitmap.c | 47 -
libavcodec/text_to_bitmap.h | 25 +---
2 files changed, 68 insertions(+), 4 deletions(-)
diff --git a/libavcodec/text_to_bitmap.c b/libavcodec/text_to_bitmap.c
index c419e89c20..52d161d7b1 100644
---
---
fftools/ffmpeg.c | 29 ++---
libavfilter/vf_subtitles.c | 9 -
2 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index dea2aec2ce..a74800bb68 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@
---
fftools/ffmpeg.c | 12 ++--
libavfilter/vf_subtitles.c | 1 -
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 53717d3ebb..dea2aec2ce 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -2422,9 +2422,8 @@ static
---
fftools/ffmpeg.c | 47 ++-
libavfilter/vf_subtitles.c | 117 +
2 files changed, 163 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index a85ed18b08..53717d3ebb 100644
--- a/fftools/ffmpeg.c
+++
structure.
Of course, this functionality will only work when ffmpeg is configured with
--enable-libass.
Traian Coza (12):
Implemented text to bitmap subtitles!
Render only when necessary
Retreive width and height from video stream!
Initialize ass library only once!
Cleaned up
Wrote
I know, but when I click on "New Pull Request" on ffstaging/FFmpeg, it
automatically sets the "base repository" to FFmpeg/FFmpeg, and I can't
change it to ffstaging/FFmpeg (see image). Am I doing something wrong,
perhaps?
[image: image.png]
___
Hey Softworks, when I try to open a pull request on that repo it says "An
owner of this repository has limited the ability to open a pull request to
users that are collaborators on this repository." So I am not a
collaborator, can you add me as a collaborator so I can do my pull request?
I've seen
Sorry about the "top posting" my client does it automatically.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
: Tuesday, May 3, 2022 3:31 PM
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] Need help submitting a patch
> >
> > Traian Coza (12022-05-03):
> > > Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know abo
George wrote:
> Traian Coza (12022-05-03):
> > Hi! I am new to contributing to FFmpeg, and I have a technical question.
> >
> > I'm trying to submit a patch, but it's a fairly large patch, which I've
> > made in multiple commits. I don't know how to generate t
Hi! I am new to contributing to FFmpeg, and I have a technical question.
I'm trying to submit a patch, but it's a fairly large patch, which I've
made in multiple commits. I don't know how to generate the email for this
patch. The example command given on the website (with format-patch) only
24 matches
Mail list logo
