[FFmpeg-devel] [PATCH] mpeg4videoenc: Don't crash with -fsanitize=bounds

2020-04-21 Thread Vitaly Buka
Also the patch makes this code consistent with mpeg4videodec.c --- libavcodec/mpeg4videoenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index f6a5992df7..2cd5a8c015 100644 --- a/libavcodec/mpeg4videoenc.c +++

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow in mov_write_single_packet Detected with clang and -fsanitize=signed-integer-overflow

2017-10-28 Thread Vitaly Buka
ping On Fri, Oct 6, 2017 at 4:20 PM, Vitaly Buka <vitalyb...@google.com> wrote: > Signed-off-by: Vitaly Buka <vitalyb...@google.com> > --- > libavformat/movenc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/movenc.c b/libavform

[FFmpeg-devel] [PATCH] Fix signed integer overflow in mov_write_single_packet Detected with clang and -fsanitize=signed-integer-overflow

2017-10-06 Thread Vitaly Buka
Signed-off-by: Vitaly Buka <vitalyb...@google.com> --- libavformat/movenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2838286141..e70500ae2c 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5354,6 +5354,10 @@

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Vitaly Buka
What else can I do yo make it accepted? On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka <vitalyb...@google.com> wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka <

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka <vitalyb...@google.com> --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 2 ++ libavformat/mov.c | 2 +- 3 files changed, 4 insertions(+), 2 del

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka <vitalyb...@google.com> --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 2 ++ libavformat/mov.c | 2 +- 3 files changed, 4 insertions(+), 2 del

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Looks like libavcodec/ has more LL or ll than INT64_C. Should I update the patch? On Sat, Aug 19, 2017 at 11:35 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Sun, Aug 20, 2017 at 3:19 AM, Vitaly Buka > <vitalybuka-at-google@ffmpeg.org> wrote: > > Signed integ

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-19 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka <vitalyb...@google.com> --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 3 +++ libavformat/mov.c | 2 +- 3 files changed, 5 insertions

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-19 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka <vitalyb...@google.com> --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 2 ++ libavformat/mov.c | 2 +- 3 files changed, 4 insertions(+), 2 del

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Vitaly Buka
ffm...@gmail.com> wrote: > 2017-08-18 8:14 GMT+02:00 Vitaly Buka <vitalybuka-at-google@ffmpeg.org > >: > > Signed integer overflow is undefined behavior. > > Detected with clang and -fsanitize=signed-integer-overflow > > > --- a/libavformat/mov.c > > +

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Vitaly Buka
On Fri, Aug 18, 2017 at 1:11 AM, Tomas Härdin <tjop...@acc.umu.se> wrote: > On 2017-08-18 08:14, Vitaly Buka wrote: > >> Signed integer overflow is undefined behavior. >> Detected with clang and -fsanitize=signed-integer-overflow >> >> Signed-off-by

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka <vitalyb...@google.com> --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 4 +++- libavformat/mov.c | 2 +- 3 files changed, 5 insertions