Re: [FFmpeg-devel] [PATCH 3/3] ffprobe: use av_spherical_projection_name() to print spherical projection names

2017-03-31 Thread Vittorio Giovara
On Wed, Mar 29, 2017 at 4:55 AM, James Almer wrote: > Signed-off-by: James Almer > --- > ffprobe.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/ffprobe.c b/ffprobe.c > index 67c4ed40fa..be5583aea2 100644 > --- a/ffprobe.c > +++ b/ffprobe.c > @@ -1872,22 +18

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dump: use av_spherical_projection_name() to print spherical projection names

2017-03-31 Thread Vittorio Giovara
On Wed, Mar 29, 2017 at 4:55 AM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/dump.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 3e6218303d..cb0468559e 100644 > --- a/libavformat/d

Re: [FFmpeg-devel] [PATCH 1/3] avutil/spherical: add av_spherical_projection_name()

2017-03-31 Thread Vittorio Giovara
On Wed, Mar 29, 2017 at 4:55 AM, James Almer wrote: > Signed-off-by: James Almer > --- > doc/APIchanges| 3 +++ > libavutil/spherical.c | 15 +++ > libavutil/spherical.h | 9 + > 3 files changed, 27 insertions(+) version bump > diff --git a/doc/APIchanges b/doc/AP

Re: [FFmpeg-devel] [PATCH][RFC] avutil/spherical: add a flag to signal tiled/padded projections

2017-03-31 Thread Vittorio Giovara
On Thu, Mar 30, 2017 at 9:52 PM, James Almer wrote: > On 3/30/2017 3:37 PM, Vittorio Giovara wrote: >> On Thu, Mar 30, 2017 at 4:16 PM, James Almer wrote: >>> On 3/30/2017 5:54 AM, Vittorio Giovara wrote: >>>> On Wed, Mar 29, 2017 at 8:01 PM, James Almer wrote:

Re: [FFmpeg-devel] [PATCH][RFC] avutil/spherical: add a flag to signal tiled/padded projections

2017-03-30 Thread Vittorio Giovara
On Thu, Mar 30, 2017 at 4:16 PM, James Almer wrote: > On 3/30/2017 5:54 AM, Vittorio Giovara wrote: >> On Wed, Mar 29, 2017 at 8:01 PM, James Almer wrote: >>> A new field is added to AVSphericalMapping for this purpose, >>> and is used by both Equirectangular and Cubem

Re: [FFmpeg-devel] [PATCH][RFC] avutil/spherical: add a flag to signal tiled/padded projections

2017-03-30 Thread Vittorio Giovara
On Wed, Mar 29, 2017 at 8:01 PM, James Almer wrote: > A new field is added to AVSphericalMapping for this purpose, > and is used by both Equirectangular and Cubemap projections. > This is a replacement for duplicate projection enums like > AV_SPHERICAL_EQUIRECTANGULAR_TILE, which are therefore > r

[FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-17 Thread Vittorio Giovara
These values are defined to be 32bit in the specification, so it makes more sense to store them as fixed width. Based on a patch by Micahel Niedermayer . Signed-off-by: Vittorio Giovara --- Hi, this is the version which applies cleanly to master and contains changes requested by James. Please

Re: [FFmpeg-devel] fate: Do not report side data size

2017-03-17 Thread Vittorio Giovara
On Tue, Mar 7, 2017 at 7:17 PM, Vittorio Giovara wrote: > This should address the mismatch between different archs > Please CC. > -- > Vittorio ping Please CC. -- Vittorio ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Vittorio Giovara
On Thu, Mar 16, 2017 at 4:16 PM, Lou Logan wrote: > On Wed, 15 Mar 2017 10:22:23 +0100 > Carl Eugen Hoyos wrote: > >> Sorry if I miss something but could you clarify who the author of this >> patch is? > > CC'ing as Vittorio is not subscribed to the mailing list. Not that you > should have to kno

Re: [FFmpeg-devel] [PATCH]lavu/spherical: Make first parameter const

2017-03-16 Thread Vittorio Giovara
On Thu, Mar 16, 2017 at 4:26 PM, James Almer wrote: > On 3/16/2017 5:23 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences a gcc warning when compiling ffprobe. >> >> Please comment, Carl Eugen >> >> >> 0001-lavu-spherical-Make-AVSphericalMapping-pointer-param.patch >> >> >> From 504

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Vittorio Giovara
On Wed, Mar 15, 2017 at 11:31 PM, James Almer wrote: > On 3/15/2017 6:39 PM, Vittorio Giovara wrote: >> These values are defined to be 32bit in the specification, >> so it makes more sense to store them as fixed width. >> >> Signed-off-by: Vittorio Giovara >&

[FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Vittorio Giovara
These values are defined to be 32bit in the specification, so it makes more sense to store them as fixed width. Signed-off-by: Vittorio Giovara --- Updated commit message, changed a couple of internal types. Please CC or I can't see replies. Vittorio libavformat/dump.c

[FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-14 Thread Vittorio Giovara
These types better reflect the ones described in the specification and avoid any platform-specific implementation issues. Signed-off-by: Vittorio Giovara --- libavformat/dump.c| 2 +- libavutil/spherical.h | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-14 Thread Vittorio Giovara
On Tue, Mar 14, 2017 at 5:27 PM, James Almer wrote: > On 3/14/2017 6:16 PM, Vittorio Giovara wrote: >> On Tue, Mar 14, 2017 at 4:41 PM, James Almer wrote: >>> On 3/14/2017 4:46 PM, Vittorio Giovara wrote: >>>> On Tue, Mar 14, 2017 at 12:12 PM, James Almer wrot

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-14 Thread Vittorio Giovara
On Tue, Mar 14, 2017 at 5:27 PM, James Almer wrote: > On 3/14/2017 6:16 PM, Vittorio Giovara wrote: >> On Tue, Mar 14, 2017 at 4:41 PM, James Almer wrote: >>> On 3/14/2017 4:46 PM, Vittorio Giovara wrote: >>>> On Tue, Mar 14, 2017 at 12:12 PM, James Almer wrot

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-14 Thread Vittorio Giovara
On Tue, Mar 14, 2017 at 4:41 PM, James Almer wrote: > On 3/14/2017 4:46 PM, Vittorio Giovara wrote: >> On Tue, Mar 14, 2017 at 12:12 PM, James Almer wrote: >>> On 3/14/2017 12:37 PM, Vittorio Giovara wrote: >>>> On Sun, Mar 12, 2017 at 11:21 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-14 Thread Vittorio Giovara
On Tue, Mar 14, 2017 at 12:12 PM, James Almer wrote: > On 3/14/2017 12:37 PM, Vittorio Giovara wrote: >> On Sun, Mar 12, 2017 at 11:21 PM, Michael Niedermayer >> wrote: >>> On Sun, Mar 12, 2017 at 08:54:07PM -0400, Ronald S. Bultje wrote: >>>> Hi, >>>

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-14 Thread Vittorio Giovara
On Sun, Mar 12, 2017 at 11:21 PM, Michael Niedermayer wrote: > On Sun, Mar 12, 2017 at 08:54:07PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Mar 12, 2017 at 7:32 PM, James Almer wrote: >> >> > On 3/12/2017 6:16 PM, Michael Niedermayer wrote: >> > > Using the same type across platforms is

Re: [FFmpeg-devel] fate: Do not report side data size

2017-03-08 Thread Vittorio Giovara
On Wed, Mar 8, 2017 at 8:15 PM, James Almer wrote: > On 3/8/2017 9:45 PM, Michael Niedermayer wrote: >> On Wed, Mar 08, 2017 at 11:54:59PM +0100, Hendrik Leppkes wrote: >>> On Wed, Mar 8, 2017 at 3:42 PM, Ronald S. Bultje wrote: Hi, On Wed, Mar 8, 2017 at 9:31 AM, wm4 wrote:

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add support for Spherical Video elements

2017-03-08 Thread Vittorio Giovara
On Wed, Mar 8, 2017 at 4:05 PM, James Almer wrote: > On 3/8/2017 5:08 PM, Vittorio Giovara wrote: >> On Wed, Mar 8, 2017 at 2:46 PM, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavformat/matroskaenc.c | 69 >>> ++

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add support for Spherical Video elements

2017-03-08 Thread Vittorio Giovara
On Wed, Mar 8, 2017 at 2:46 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 69 > +++ > 1 file changed, 69 insertions(+) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 1605f0cafe.

Re: [FFmpeg-devel] fate: Do not report side data size

2017-03-08 Thread Vittorio Giovara
On Wed, Mar 8, 2017 at 6:51 AM, Michael Niedermayer wrote: >> Removing the side_data_size from output should be fine, as its a >> implementation detail and as seen here can even vary between >> architecture or possibly even compiler. >> Maybe someone that uses that ffprobe output more often can co

[FFmpeg-devel] fate: Do not report side data size

2017-03-07 Thread Vittorio Giovara
This should address the mismatch between different archs Please CC. -- Vittorio 0001-fate-Do-not-report-side-data-size.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] mov: Fix checking layout and loading padding for cubemaps

2017-03-07 Thread Vittorio Giovara
--- I missed this chunk of review in this version of the set, sorry, here is the proper patch. Vittorio libavformat/mov.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index cc098cd977..d5c3949050 100644 --- a/libavformat/mov.c ++

[FFmpeg-devel] [PATCH] matroskadec: cosmetics: Rearrange checks for projection-depedendent properties

2017-03-07 Thread Vittorio Giovara
--- ... and this chunk for matroska too. Vittorio libavformat/matroskadec.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index fdc3f268aa..fdb23ab05e 100644 --- a/libavformat/matroskadec.c +++ b/li

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-28 Thread Vittorio Giovara
On Tue, Feb 28, 2017 at 1:15 PM, James Almer wrote: > On 2/28/2017 2:46 PM, Vittorio Giovara wrote: >> On Tue, Feb 28, 2017 at 11:00 AM, James Almer wrote: >>> On 2/22/2017 1:21 PM, James Almer wrote: >>>> On 2/21/2017 7:35 PM, Vittorio Giovara wrote:

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-28 Thread Vittorio Giovara
On Tue, Feb 28, 2017 at 12:46 PM, Vittorio Giovara wrote: >> >> I think this'll look better as >> >> >> case MATROSKA_VIDEO_PROJECTION_TYPE_EQUIRECTANGULAR: >> projection = AV_SPHERICAL_EQUIRECTANGULAR; >> >>

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-28 Thread Vittorio Giovara
On Tue, Feb 28, 2017 at 11:00 AM, James Almer wrote: > On 2/22/2017 1:21 PM, James Almer wrote: >> On 2/21/2017 7:35 PM, Vittorio Giovara wrote: > > CCing this one as well. > >>> --- >>> libavformat/matroskadec.c | 64 >>> +

Re: [FFmpeg-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

2017-02-28 Thread Vittorio Giovara
On Tue, Feb 28, 2017 at 10:58 AM, James Almer wrote: > On 2/21/2017 8:07 PM, James Almer wrote: >> On 2/21/2017 7:35 PM, Vittorio Giovara wrote: >>> Update the fate test as needed. >>> --- >>> libavformat/mov.c | 28 ++

[FFmpeg-devel] [PATCHv3 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-21 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- This leaves bounds unchanged, simplifying future muxing code. Add a convenience function where human-readable values are needed. Update mov and mkv in subsequent patches. Vittorio doc/APIchanges | 5 +++ ffprobe.c

[FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-21 Thread Vittorio Giovara
--- libavformat/matroskadec.c | 64 -- tests/ref/fate/matroska-spherical-mono | 6 +++- 2 files changed, 66 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 7223e94..0a02237 100644 --- a/libavforma

[FFmpeg-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

2017-02-21 Thread Vittorio Giovara
Update the fate test as needed. --- libavformat/mov.c | 28 +++- tests/ref/fate/mov-spherical-mono | 6 +- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 7b0bbcc..d798336 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-21 Thread Vittorio Giovara
On Thu, Feb 16, 2017 at 3:41 PM, Aaron Colwell wrote: > After sleeping on this, I think what you have will be fine. Resizing a > cubemap w/ padding is just going to have to be handled in a special way > because fractional pixel padding isn't going to work right on the GPU. You > really only want t

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-16 Thread Vittorio Giovara
On Wed, Feb 15, 2017 at 2:54 PM, Aaron Colwell wrote: > Hi Vittorio, > > This may not be a blocker for this patch, but one issue with converting the > bounds to pixels like you do here is that resizing a video could result in > incorrect metadata being generated when muxing. If you keep the bounds

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Vittorio Giovara
Hi Aaron, On Wed, Feb 15, 2017 at 11:48 AM, Aaron Colwell wrote: >> If the spec changes, it will be the contents of the equi/cbmp/mesh. >> By exporting them raw as extradata, said changes in the spec would >> require no changes to our implementation. > > > This is one of the main reasons I was su

[FFmpeg-devel] [PATCHv2 1/4] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Updated with fate changes and more consistent names. Please CC. Vittorio doc/APIchanges | 5 +++ ffprobe.c | 11 +-- libavformat/dump.c | 10 ++ libavutil/spherical.h

[FFmpeg-devel] [PATCHv2 3/4] mkv: Export bounds and padding from spherical metadata

2017-02-15 Thread Vittorio Giovara
--- Updated according to James' review. Please CC. Vittorio libavformat/matroskadec.c | 69 -- tests/ref/fate/matroska-spherical-mono | 6 ++- 2 files changed, 71 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matr

[FFmpeg-devel] [PATCHv2 2/4] mov: Export bounds and padding from spherical metadata

2017-02-15 Thread Vittorio Giovara
Update the fate test as needed. --- V2 bounds are validated and UINT32_MAX is used. Please CC. Vittorio libavformat/mov.c | 53 ++- tests/ref/fate/mov-spherical-mono | 6 - 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH 4/4] mov: Validate spherical metadata version

2017-02-15 Thread Vittorio Giovara
--- As suggested by James. Please CC. Vittorio libavformat/mov.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a1774b3..2efd51e 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4623,7 +4623,7 @

Re: [FFmpeg-devel] [PATCH] h264: Correctly initialize interlaced_frame if tff is set

2017-02-15 Thread Vittorio Giovara
On Tue, Feb 14, 2017 at 6:21 PM, Michael Niedermayer wrote: > On Sat, Feb 11, 2017 at 02:56:32AM +0100, Michael Niedermayer wrote: >> On Fri, Feb 10, 2017 at 05:21:00PM -0500, Vittorio Giovara wrote: >> > In particular cases, it is possible to initialize top_field_

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Vittorio Giovara
On Wed, Feb 15, 2017 at 8:52 AM, James Almer wrote: > On 2/14/2017 11:20 PM, Vittorio Giovara wrote: >> On Tue, Feb 14, 2017 at 6:54 PM, James Almer wrote: >>> On 2/14/2017 5:52 PM, Vittorio Giovara wrote: >>>> On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-14 Thread Vittorio Giovara
On Tue, Feb 14, 2017 at 6:54 PM, James Almer wrote: > On 2/14/2017 5:52 PM, Vittorio Giovara wrote: >> On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer >> wrote: >>> On Fri, Feb 10, 2017 at 04:11:43PM -0500, Vittorio Giovara wrote: >>>> Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-14 Thread Vittorio Giovara
On Tue, Feb 14, 2017 at 4:54 PM, Michael Niedermayer wrote: > On Tue, Feb 14, 2017 at 03:52:39PM -0500, Vittorio Giovara wrote: >> On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer >> wrote: >> > On Fri, Feb 10, 2017 at 04:11:43PM -0500, Vittorio Giovara wrote: >&

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-14 Thread Vittorio Giovara
On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer wrote: > On Fri, Feb 10, 2017 at 04:11:43PM -0500, Vittorio Giovara wrote: >> Signed-off-by: Vittorio Giovara >> --- >> This should help not losing details over muxing and allows >> callers to get additional in

[FFmpeg-devel] [PATCH] h264: Correctly initialize interlaced_frame if tff is set

2017-02-10 Thread Vittorio Giovara
In particular cases, it is possible to initialize top_field_first but not interlaced_frame. Make sure to correctly tag a frame as interlaced when this happens. Signed-off-by: Vittorio Giovara --- Please CC. Vittorio libavcodec/h264_slice.c | 13 - 1 file changed, 8 insertions(+), 5

[FFmpeg-devel] [PATCH 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-10 Thread Vittorio Giovara
--- Although quite math-heavy, I saw little value in having a single parsing function, and since it requires stream or demuxer specific information I preferred to keep the two separate. Please keep me in CC. Vittorio libavformat/matroskadec.c | 34 +- 1 file chang

[FFmpeg-devel] [PATCH 2/3] mov: Export bounds and padding from spherical metadata

2017-02-10 Thread Vittorio Giovara
Update the fate test as needed. --- Please keep me in CC. Vittorio libavformat/mov.c | 46 ++- tests/ref/fate/mov-spherical-mono | 8 +-- 2 files changed, 51 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c

[FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-10 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- This should help not losing details over muxing and allows callers to get additional information in a clean manner. Please keep me in CC. Vittorio doc/APIchanges| 5 + ffprobe.c | 11 -- libavformat/dump.c| 10

Re: [FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.

2017-02-08 Thread Vittorio Giovara
On Wed, Feb 8, 2017 at 9:35 AM, James Almer wrote: > On 2/8/2017 10:47 AM, Vittorio Giovara wrote: >> On Mon, Feb 6, 2017 at 4:59 PM, Aaron Colwell wrote: >>> - Extracts common spherical metadata parsing logic. >>> - Adds checks to enforce that only non-tiled equ

Re: [FFmpeg-devel] [PATCH] imgutils: Document av_image_get_buffer_size()

2017-02-08 Thread Vittorio Giovara
On Tue, Feb 7, 2017 at 5:30 PM, Michael Niedermayer wrote: > and the forgotten-CC mail > > On Tue, Feb 07, 2017 at 11:28:21PM +0100, Michael Niedermayer wrote: >> On Tue, Feb 07, 2017 at 10:01:52AM -0500, Vittorio Giovara wrote: >> > --- >> > libavutil/imgutils.h

Re: [FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.

2017-02-08 Thread Vittorio Giovara
On Mon, Feb 6, 2017 at 4:59 PM, Aaron Colwell wrote: > - Extracts common spherical metadata parsing logic. > - Adds checks to enforce that only non-tiled equirect & non-padded cubemaps > are accepted. Hi Aaron, this patch basically ignores all my comments, so I'm not very happy with it. I beli

[FFmpeg-devel] [PATCH] imgutils: Document av_image_get_buffer_size()

2017-02-07 Thread Vittorio Giovara
--- libavutil/imgutils.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h index 67063a2..ac1bcb8 100644 --- a/libavutil/imgutils.h +++ b/libavutil/imgutils.h @@ -169,7 +169,12 @@ int av_image_fill_arrays(uint8_t *dst_data[4], int

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-04 Thread Vittorio Giovara
On Fri, Feb 3, 2017 at 5:57 PM, Aaron Colwell wrote: > I still think you don't understand what these fields do given what you say > here. Yes there is a little more math. At the end of the day all these > fields do is specify a the min & max for the latitude & longitude. This > essentially transla

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

2017-02-03 Thread Vittorio Giovara
On Fri, Feb 3, 2017 at 2:10 PM, Kieran O Leary wrote: > Hi Vittorio! > > thanks for getting back to me. > > On Fri, Feb 3, 2017 at 12:57 PM, Vittorio Giovara > wrote: >> >> >> >> Hey Kieran, >> I think the code looks fine. I am just wondering i

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

2017-02-03 Thread Vittorio Giovara
On Wed, Feb 1, 2017 at 1:42 PM, Kieran O Leary wrote: > Hello, > > I'm cc'ing Vittorio as I don't think that he's subscribed to the list but > he's contributed to dpxenc.c and recent colorspace filters. The same with > Kate Murray from the Library of Congress who knows a lot more about DPX than >

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-03 Thread Vittorio Giovara
On Thu, Feb 2, 2017 at 9:34 PM, James Almer wrote: > On 1/31/2017 12:40 PM, Aaron Colwell wrote: >> >> >> On Tue, Jan 31, 2017 at 2:12 AM Vittorio Giovara > <mailto:vittorio.giov...@gmail.com>> wrote: >> >> On Sat, Jan 28, 2017 at 4:13 AM, James Almer

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-01-31 Thread Vittorio Giovara
On Sat, Jan 28, 2017 at 4:13 AM, James Almer wrote: > On 1/27/2017 11:21 PM, Aaron Colwell wrote: >> On Fri, Jan 27, 2017 at 5:46 PM James Almer wrote: >> >> yeah. I'm a little confused why the demuxing code didn't implement this to >> begin with. > > Vittorio (The one that implemented AVSpherica

Re: [FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination

2017-01-04 Thread Vittorio Giovara
On Wed, Jan 4, 2017 at 1:06 AM, Michael Niedermayer wrote: > On Tue, Jan 03, 2017 at 02:15:20PM +0100, Vittorio Giovara wrote: >> On Mon, Jan 2, 2017 at 2:00 AM, James Almer wrote: >> > On 1/1/2017 8:28 PM, Michael Niedermayer wrote: >> >> Fixes CID1396405 >>

Re: [FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination

2017-01-03 Thread Vittorio Giovara
On Mon, Jan 2, 2017 at 2:00 AM, James Almer wrote: > On 1/1/2017 8:28 PM, Michael Niedermayer wrote: >> Fixes CID1396405 What is the CID about? >> Untested except fate which does not test this, please someone test this > > The encoder seems to need libsnappy, so no FATE test can be added. Only

Re: [FFmpeg-devel] [PATCH] lavu: Add AVSphericalMapping type and frame side data

2016-12-06 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 10:46 AM, Vittorio Giovara wrote: > While no decoder currently exports spherical information, this type > represents a frame property that has to be passed through from container > to frames. > > Signed-off-by: Vittorio Giovara > --- > +/** &g

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-06 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 10:50 AM, James Almer wrote: > On 12/2/2016 5:17 PM, James Almer wrote: >> On 12/2/2016 5:00 PM, Vittorio Giovara wrote: >>> This will simplify identifying files that were generated with >>> unfinished/incomplete/non-standard specifications. >

Re: [FFmpeg-devel] [PATCH 3/4] mov: Export spherical information

2016-12-06 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 11:06 AM, James Almer wrote: > On 11/30/2016 9:12 PM, James Almer wrote: >> On 11/30/2016 8:36 PM, Vittorio Giovara wrote: >>> This implements Spherical Video V1 and V2, as described in the >>> spatial-media collection by Google. >>>

[FFmpeg-devel] [PATCH] lavu: Add AVSphericalMapping type and frame side data

2016-12-06 Thread Vittorio Giovara
While no decoder currently exports spherical information, this type represents a frame property that has to be passed through from container to frames. Signed-off-by: Vittorio Giovara --- The specification got updated while this was in the works. So I updated the description of yaw, pitch, roll

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-06 Thread Vittorio Giovara
On Fri, Dec 2, 2016 at 3:00 PM, Vittorio Giovara wrote: > This will simplify identifying files that were generated with > unfinished/incomplete/non-standard specifications. > > Signed-off-by: Vittorio Giovara > --- > libavformat/movenc.c | 2 ++ > 1 file changed, 2 inserti

[FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-02 Thread Vittorio Giovara
This will simplify identifying files that were generated with unfinished/incomplete/non-standard specifications. Signed-off-by: Vittorio Giovara --- libavformat/movenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index dc19838..c46bea9

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-12-01 Thread Vittorio Giovara
On Thu, Dec 1, 2016 at 3:01 PM, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXV, Vittorio Giovara a écrit : >> Actually we already do, theora, vp8, vp9 and a few others have >> completely different values for most color properties, and we just >> check before initia

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-12-01 Thread Vittorio Giovara
On Thu, Dec 1, 2016 at 2:22 PM, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXV, Rostislav Pehlivanov a écrit : >> Why do you insist on having a hole in the first place? > > Apparently, the values of the enum are used encode and decode > standardized values in standardized formats like MP

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-12-01 Thread Vittorio Giovara
adhal...@googlemail.com> wrote: >> > >> >> On 30.11.2016 19:16, Vittorio Giovara wrote: >> >> You can't just add a gap like that. >> >> The current code assumes that the numbers are consecutive, like e.g. >> >> the >> >> nam

[FFmpeg-devel] [PATCH 2/4] lavc: Add spherical packet side data API

2016-11-30 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- No particular change. Vittorio ffprobe.c | 13 + libavcodec/avcodec.h | 8 +++- libavcodec/avpacket.c | 1 + libavcodec/utils.c| 1 + libavformat/dump.c| 30 ++ 5 files changed, 52 insertions

[FFmpeg-devel] [PATCH] fate/mov: Rename a couple of entries to respect the file naming scheme

2016-11-30 Thread Vittorio Giovara
--- tests/fate/mov.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 71c9a1f..f642f1d 100644 --- a/tests/fate/mov.mak +++ b/tests/fate/mov.mak @@ -7,7 +7,7 @@ FATE_MOV = fate-mov-3elist \ fate-mov-2elist-elist1

[FFmpeg-devel] [PATCH 4/4] fate: Add a monoscopic spherical mov test

2016-11-30 Thread Vittorio Giovara
--- This needs https://www.dropbox.com/s/0lqxkzy16o7fihz/spherical.mov?dl=0 to be placed in $SAMPLES/mov. Vittorio tests/fate/mov.mak| 4 tests/ref/fate/mov-spherical-mono | 16 2 files changed, 20 insertions(+) create mode 100644 tests/ref/fate/mov-spheric

[FFmpeg-devel] [PATCH 3/4] mov: Export spherical information

2016-11-30 Thread Vittorio Giovara
This implements Spherical Video V1 and V2, as described in the spatial-media collection by Google. Signed-off-by: Vittorio Giovara --- This addresses all comments from James. Vittorio libavformat/isom.h | 7 ++ libavformat/mov.c | 239 - 2

[FFmpeg-devel] [PATCH 1/4 v4] lavu: Add AVSphericalMapping type and frame side data

2016-11-30 Thread Vittorio Giovara
While no decoder currently exports spherical information, this type represents a frame property that has to be passed through from container to frames. Signed-off-by: Vittorio Giovara --- Revised documentation of the new type, removed bounding rectangle values, as I misinterpreted what they

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-11-30 Thread Vittorio Giovara
On Wed, Nov 30, 2016 at 2:51 PM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : >> This is the value specified in the 23001-8_2013 document. > > This looks paywalled. Please give links to public versions of specs in > that kind of case. I

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-11-30 Thread Vittorio Giovara
On Wed, Nov 30, 2016 at 1:21 PM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : >> Signed-off-by: Vittorio Giovara >> --- > >> Please CC. > > You can achieve the same result more reliably by setting the reply-to > header. Oh,

[FFmpeg-devel] [PATCH 2/2] vf_colorspace: Add support for jedec p22 primaries

2016-11-30 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- (no I don't have samples, but the numbers should be correct) Please CC. Vittorio doc/filters.texi| 3 +++ libavfilter/vf_colorspace.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 4a4aeca..82

[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-11-30 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Please CC. Vittorio libavutil/pixdesc.c | 1 + libavutil/pixfmt.h | 1 + 2 files changed, 2 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 3b9c45d..04eab0b 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -2183,6

Re: [FFmpeg-devel] [PATCH 2/3] hevc: Support extradata changes

2016-11-29 Thread Vittorio Giovara
On Tue, Nov 29, 2016 at 7:20 AM, Michael Niedermayer wrote: > On Mon, Nov 28, 2016 at 10:03:37PM -0500, Vittorio Giovara wrote: >> On Mon, Nov 28, 2016 at 9:06 PM, Michael Niedermayer >> wrote: >> > On Tue, Nov 08, 2016 at 05:03:27PM -0500, Vittorio Giovara wrote: >&

Re: [FFmpeg-devel] [PATCH 2/3] hevc: Support extradata changes

2016-11-28 Thread Vittorio Giovara
On Mon, Nov 28, 2016 at 9:06 PM, Michael Niedermayer wrote: > On Tue, Nov 08, 2016 at 05:03:27PM -0500, Vittorio Giovara wrote: >> Signed-off-by: Vittorio Giovara >> --- >> Applied review. >> Please CC. >> Vittorio >> >> libavcodec/hevc

Re: [FFmpeg-devel] [PATCH 1/3] hevc: Allow parsing external extradata buffers

2016-11-28 Thread Vittorio Giovara
On Mon, Nov 28, 2016 at 9:07 PM, Michael Niedermayer wrote: > On Tue, Nov 29, 2016 at 03:01:28AM +0100, Michael Niedermayer wrote: >> On Tue, Nov 08, 2016 at 05:03:26PM -0500, Vittorio Giovara wrote: >> > --- >> > As mentioned in the discussion. >> > Please CC.

Re: [FFmpeg-devel] [PATCH 2/3] hevc: Support extradata changes

2016-11-28 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 10:38 AM, Vittorio Giovara wrote: > On Tue, Nov 8, 2016 at 5:03 PM, Vittorio Giovara > wrote: >> Signed-off-by: Vittorio Giovara >> --- Hi, if no further objections I'll push the set tomorrow. o hevc: Support extradata changes

Re: [FFmpeg-devel] [PATCH 1/3] mov: Evaluate the movie display matrix

2016-11-28 Thread Vittorio Giovara
On Fri, Nov 18, 2016 at 2:37 PM, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. So store it in main context, and apply > it when

[FFmpeg-devel] [PATCH 3/3] fate: Add test for mov displaymatrix

2016-11-18 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Updated according James' review. Vittorio tests/fate/mov.mak | 6 +- tests/ref/fate/mov-displaymatrix | 12 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/mov-displaymatrix diff --

[FFmpeg-devel] [PATCH 1/3] mov: Evaluate the movie display matrix

2016-11-18 Thread Vittorio Giovara
This matrix needs to be applied after all others have (currently only display matrix from trak), but cannot be handled in movie box, since streams are not allocated yet. So store it in main context, and apply it when appropriate, that is after parsing the tkhd one. Signed-off-by: Vittorio Giovara

[FFmpeg-devel] [PATCH 2/3] ffprobe: Fix displaying side data list only

2016-11-18 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Needed by the following commit. Please CC. Vittorio ffprobe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index 79fe296..4ed8e06 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -188,7 +188,7 @@ static struct

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 4:11 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 17, 2016 at 4:09 PM, Vittorio Giovara > wrote: >> >> This prevents writing past bounds. >> >> Signed-off-by: Vittorio Giovara >> --- >> Updated according review. &g

[FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
This prevents writing past bounds. Signed-off-by: Vittorio Giovara --- Updated according review. Vittorio doc/filters.texi| 1 + libavfilter/vf_colorspace.c | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index

[FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
This prevents writing past bounds. Signed-off-by: Vittorio Giovara --- Any opinions about this? Cheers, Vittorio (please cc) doc/filters.texi| 1 + libavfilter/vf_colorspace.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 3:58 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 17, 2016 at 3:53 PM, Vittorio Giovara > wrote: >> >> This prevents writing past bounds. >> >> Signed-off-by: Vittorio Giovara >> --- >> Any opinions about this? > &g

Re: [FFmpeg-devel] [PATCHv5] mov: Evaluate the movie display matrix

2016-11-17 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 1:02 PM, James Almer wrote: > On 11/15/2016 1:14 PM, Vittorio Giovara wrote: >> diff --git a/tests/ref/fate/mov-displaymatrix >> b/tests/ref/fate/mov-displaymatrix >> new file mode 100644 >> index 000..52528c1 >> --- /dev/null >>

[FFmpeg-devel] [PATCH v2] mov: Export spherical information

2016-11-17 Thread Vittorio Giovara
This implements Spherical Video V1 and V2, as described in the spatial-media collection by Google. Signed-off-by: Vittorio Giovara --- Updated following James' review. Please CC. Vittorio libavformat/isom.h | 7 ++ libavformat/mov.c

Re: [FFmpeg-devel] [PATCHv5] mov: Evaluate the movie display matrix

2016-11-17 Thread Vittorio Giovara
On Tue, Nov 15, 2016 at 11:14 AM, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. So store it in main context, and apply > it when

Re: [FFmpeg-devel] [PATCH 1/3] hevc: Allow parsing external extradata buffers

2016-11-17 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 5:03 PM, Vittorio Giovara wrote: > --- > As mentioned in the discussion. > Please CC. > Vittorio > > libavcodec/hevc.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/hevc.c b/libavcodec/hevc

Re: [FFmpeg-devel] [PATCH 2/3] hevc: Support extradata changes

2016-11-17 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 5:03 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Applied review. > Please CC. > Vittorio > > libavcodec/hevc.c | 10 ++ > libavformat/mov.c | 4 > 2 files changed, 10 insertions(+), 4 deletions(-) > &g

Re: [FFmpeg-devel] [PATCH 1/3 v2] lavu: Add AVSphericalMapping type and frame side data

2016-11-16 Thread Vittorio Giovara
On Wed, Nov 16, 2016 at 6:29 PM, Michael Niedermayer wrote: > On Wed, Nov 16, 2016 at 05:38:20PM -0500, Vittorio Giovara wrote: >> On Tue, Nov 15, 2016 at 8:52 PM, James Almer wrote: >> > On 11/15/2016 10:39 PM, Michael Niedermayer wrote: >> >> On Tue, Nov 15, 2016

Re: [FFmpeg-devel] [PATCH 3/3 v2] mov: Export spherical information

2016-11-16 Thread Vittorio Giovara
On Wed, Nov 16, 2016 at 5:57 PM, James Almer wrote: > On 11/16/2016 12:33 PM, Vittorio Giovara wrote: >> On Tue, Nov 15, 2016 at 10:09 PM, James Almer wrote: >>> On 11/15/2016 1:56 PM, Vittorio Giovara wrote: >>> >>> Does Google offer samples to confirm this?

Re: [FFmpeg-devel] [PATCH 1/3 v2] lavu: Add AVSphericalMapping type and frame side data

2016-11-16 Thread Vittorio Giovara
On Tue, Nov 15, 2016 at 8:52 PM, James Almer wrote: > On 11/15/2016 10:39 PM, Michael Niedermayer wrote: >> On Tue, Nov 15, 2016 at 11:56:48AM -0500, Vittorio Giovara wrote: >> [...] >>> +/** >>> + * This structure describes how to handle spherical videos, ou

Re: [FFmpeg-devel] [PATCH 3/3 v2] mov: Export spherical information

2016-11-16 Thread Vittorio Giovara
On Tue, Nov 15, 2016 at 10:09 PM, James Almer wrote: > On 11/15/2016 1:56 PM, Vittorio Giovara wrote: >> +static int mov_read_st3d(MOVContext *c, AVIOContext *pb, MOVAtom atom) >> +{ >> +AVStream *st; >> +MOVStreamContext *sc; >> +enum AVSt

Re: [FFmpeg-devel] [PATCH] fate: Add h264 extradata reload tests

2016-11-16 Thread Vittorio Giovara
On Tue, Nov 15, 2016 at 8:47 PM, Michael Niedermayer wrote: > On Tue, Nov 15, 2016 at 11:18:02AM -0500, Vittorio Giovara wrote: >> --- >> This is the version without hevc testing. >> Please CC. >> Vittorio >> >> tests/fate/h264.mak | 5

[FFmpeg-devel] [PATCH 3/3 v2] mov: Export spherical information

2016-11-15 Thread Vittorio Giovara
This implements Spherical Video V1 and V2, as described in the spatial-media collection by Google. Signed-off-by: Vittorio Giovara --- Updated to use int32 for rotation. Please CC. Vittorio libavformat/isom.h | 7 ++ libavformat/mov.c | 281

<    1   2   3   4   5   6   7   >