[FFmpeg-devel] Re: [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-10-18 Thread Yalda via ffmpeg-devel
Romain, Thank you for the clarity. I approved. Will push in ~48 hours if there is no more concerns here. ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-10-18 Thread Yalda via ffmpeg-devel
Hi Romain, My pleasure and thanks for contributing this change. I was just wanting to know on this line (tagged in PR comments), if there are scenarios where we may only get one of these blocks on segment change and if we need to also emit it to extradata. ``` if (priv->header && priv->comment &&

[FFmpeg-devel] Re: [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-10-01 Thread Yalda via ffmpeg-devel
20327 is merged, thanks. On Mon, Sep 29, 2025 at 1:24 PM Yalda wrote: > > Romain, > > Thank you for the clarity. > I approved. Will push in ~48 hours if there is no more concerns here. ___ ffmpeg-devel mailing list -- [email protected] To unsubscr

[FFmpeg-devel] Re: [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-09-27 Thread Yalda via ffmpeg-devel
Hello, Apologies for the delay. I have been testing #20327 today with various samples (local, online) and the api-dump-stream-meta-test tool to observe metadata changes while listening. Code looks good, and to me it seems Romain addressed concerns. I think it makes sense to drop the header packet

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-08-20 Thread Yalda via ffmpeg-devel
Thanks Romain. I am experimenting with this and trying the patches. On Wed, Aug 13, 2025 at 8:46 AM Romain Beauxis wrote: > > Le mer. 13 août 2025 à 08:44, Romain Beauxis > a écrit : > > > > Le mar. 12 août 2025 à 14:49, Romain Beauxis > > a écrit : > > > > > > Hi! > > > > > > Le mar. 12 août