Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-12 Thread asivery via ffmpeg-devel
he doc to > > provide some context (can be done as a separate patch), as this kind > > of info is very difficult to retrieve otherwise (and one of the goals > > of FFmpeg is digital preservation). > > > > > From e67d2df52c65528fbbfe8d5268661c88a7ad225e Mon Se

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-10 Thread asivery via ffmpeg-devel
e header - none of the modern software which > > uses AEA reads that field, but for the older software, it will now be > > truncated to UINT32_MAX if needed. > > Is there anything else that needs changes? > > > From ee1d4c93c66e729d9d0456b2e8e789f3f98389e3 Mon Sep 17 00:0

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-09 Thread asivery via ffmpeg-devel
I see, I've changed title_length to size_t, but left the warning as is to inform the user in case truncation needs to take place. On Saturday, March 9th, 2024 at 6:48 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > + const char *title_contents = title_

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-09 Thread asivery via ffmpeg-devel
to UINT32_MAX if needed. Is there anything else that needs changes? - asivery On Saturday, March 9th, 2024 at 1:06 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > +#include "libavutil/intreadwrite.h" > > +#include "libavutil/avstring.h"

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Thank you for your incredibly thorough and fast response. I've applied all the corrections you requested. Please let me know if there's anything else wrong with my patch, and thank you for your time. - asivery On Friday, March 8th, 2024 at 1:06 PM, Andreas Rheinhardt wrote: > asivery

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Apologies for my oversight. I've attached the new patch. - asivery On Friday, March 8th, 2024 at 12:22 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > diff --git a/libavformat/allformats.c b/libavformat/allformats.c > > index b04b43cab3.

[FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Empty MessageFrom 955fc035abbb5cfc1a52b1a5ea6900e4a21cef12 Mon Sep 17 00:00:00 2001 From: asivery Date: Fri, 8 Mar 2024 11:17:51 +0100 Subject: [PATCH] avformat/aea: Add aea muxer Signed-off-by: asivery --- libavformat/Makefile| 3 +- libavformat/{aea.c => aeadec.c} |

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2024-02-12 Thread asivery via ffmpeg-devel
I've attached the updated patch. Both new entries are now placed in an alphabetically correct way in their appropriate lists. On Monday, February 12th, 2024 at 11:53 AM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > I apologize for not having responded earli

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2024-02-11 Thread asivery via ffmpeg-devel
I apologize for not having responded earlier. I've attached the updated patch. >From 68c77320954e44a7f02e95537fc9a6436da7549c Mon Sep 17 00:00:00 2001 From: asivery Date: Sun, 11 Feb 2024 23:13:07 +0100 Subject: [PATCH] avformat/matroska: Add support for A_ATRAC/AT1 Signed-off-by: asiv

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-06-28 Thread asivery
Hi, it's really not a problem. Thanks and please let me know if I need to change anything for this to be merged. --- Original Message --- On Saturday, June 17th, 2023 at 3:41 AM, Andreas Rheinhardt wrote: > asivery: > > > Hello, apologies for bothe

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-06-16 Thread asivery
in advance. --- Original Message --- On Monday, April 17th, 2023 at 2:27 AM, asivery wrote: > I'd appreciate it if someone took a look at this. > If there's anything I need to change to make this patch viable for merging, > please let me know. > > Best regards, > asivery

Re: [FFmpeg-devel] [PATCH] libavformat/aea EOF Patch

2023-03-08 Thread asivery
pb, pkt, s->streams[0]->codecpar->block_align); } const AVInputFormat ff_aea_demuxer = { --- Original Message --- On Thursday, March 9th, 2023 at 12:28 AM, Marton Balint wrote: > > On Sat, 4 Mar 2023, asivery wrote: > > > Could someone please take a look? This wou

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-03-06 Thread asivery
It's been added recently. Here's the definition: https://github.com/ietf-wg-cellar/matroska-specification/blob/master/codec_specs.md#a_atracat1 --- Original Message --- On Monday, March 6th, 2023 at 7:39 PM, Paul B Mahol wrote: > On 3/6/23, asivery asiv...@protonmail.com wr

[FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-03-05 Thread asivery
Signed-off-by: asivery --- libavformat/matroska.c | 1 + libavformat/matroskadec.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 90d94b65bf..37305a523c 100644 --- a/libavformat/matroska.c +++ b/libavformat/matroska.c @@ -55,6 +55,7

Re: [FFmpeg-devel] [PATCH] libavformat/aea EOF Patch

2023-03-04 Thread asivery
Could someone please take a look? This would improve AEA demuxing, right now every AEA file makes ffmpeg crash with an error. Thank you in advance :) --- Original Message --- On Saturday, October 22nd, 2022 at 7:43 PM, asivery wrote: > Hello, > This patch aims to fix a proble

[FFmpeg-devel] [PATCH] libavformat/aea EOF Patch

2022-10-22 Thread asivery
d, instead of always returning AVERROR(EIO). I am sending this patch again because of an incorrect mime type of the first one. Best regards,AsiveryFrom cc127ff24d82a04611fac14cf4114a2262f87111 Mon Sep 17 00:00:00 2001 From: asivery Date: Tue, 27 Sep 2022 00:13:10 +0200 Subject: [PATCH] avformat