[FFmpeg-devel] [DEVEL][PATCH] ffmpeg: Fix channel_layout bug on non-default layout

2018-02-25 Thread pkv.stream
Hi Michael, this is a ping. You had reviewed earlier versions of the patch but had left the latest version without comments (3 months ago). This is a patch for ticket 6706 : The -channel_layout option is not working when the channel layout is not a default one (ex: for 4 channels, quad is

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-10 Thread pkv.stream
Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-10 Thread pkv.stream
Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread pkv.stream
Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: > Hi Michael, > > >> ffmpeg_opt.c | 11 ++- > >> 1 file changed, 10 insertions(+), 1 deletion(-) > >>2af07f4366efdfaf1018bb2ea29be672befe0823 > >>0001-ffmpeg-fix-channel_layout-bug-on-non-default-layout.patch > >> From

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread pkv.stream
Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug-on-non-default-layout.patch From 4ec55dc88923108132307b41300a1abddf32e6f7 Mon Sep 17 00:00:00 2001 From: pkviet

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread Michael Niedermayer
On Thu, Oct 05, 2017 at 12:37:13AM +0200, pkv.stream wrote: > Le 04/10/2017 à 11:18 PM, Moritz Barsnick a écrit : > >On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > >> if (!ost->stream_copy) { > >>-char *sample_fmt = NULL; > >>+ > >>+ char *sample_fmt = NULL; >

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread pkv.stream
Le 04/10/2017 à 11:18 PM, Moritz Barsnick a écrit : On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: if (!ost->stream_copy) { -char *sample_fmt = NULL; + + char *sample_fmt = NULL; This is very obviously a patch which will not be accepted. -

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread Kv Pham
Le 4 oct. 2017 11:24 PM, "Moritz Barsnick" a écrit : On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > if (!ost->stream_copy) { > -char *sample_fmt = NULL; > + > + char *sample_fmt = NULL; > This is very obviously a patch which will not be

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread Moritz Barsnick
On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > if (!ost->stream_copy) { > -char *sample_fmt = NULL; > + > + char *sample_fmt = NULL; > This is very obviously a patch which will not be accepted. > -MATCH_PER_STREAM_OPT(sample_fmts, str, sample_fmt,

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread pkv.stream
Le 02/10/2017 à 9:50 PM, pkv.stream a écrit : Thanks Michael; replaced the offending MSVC function. Le 02/10/2017 à 9:35 PM, Michael Niedermayer a écrit : On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: Hello the submitted patch addresses the regression discussed in ticket #6706.

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-02 Thread pkv.stream
Thanks Michael; replaced the offending MSVC function. Le 02/10/2017 à 9:35 PM, Michael Niedermayer a écrit : On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: Hello the submitted patch addresses the regression discussed in ticket #6706. The

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-02 Thread Michael Niedermayer
On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: > Hello > > the submitted patch addresses the regression discussed in ticket #6706. > > > > The -channel_layout option is not working when the channel layout is not > a default one (ex: for 4

[FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-09-30 Thread pkv.stream
Hello the submitted patch addresses the regression discussed in ticket #6706. The -channel_layout option is not working when the channel layout is not a default one (ex: for 4 channels, quad is interpreted as 4.0 which is the default layout for 4