Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-16 Thread Li, Zhong
> I found your new patch after having this discussion a little disturbing. > > Carl Eugen I believe it is a little different as this patch. MFX_SCALING_MODE_DEFAULT/ MFX_SCALING_MODE_QUALITY are only buildable with QSV_HAVE_SCALING_CONFIG. It is same as the libx264 case we discussed.

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-16 Thread Carl Eugen Hoyos
2019-01-16 7:44 GMT+01:00, Li, Zhong : >> > Is it a possible way to show "not supported" info and set the option >> > to default off instead of just hiding the option? >> > >> > Like: >> > #if QSV_HAVE_VDENC >> > { "low_power", "enable low power mode (experimental, many >> > limitations by

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-15 Thread Li, Zhong
> > Is it a possible way to show "not supported" info and set the option > > to default off instead of just hiding the option? > > > > Like: > > #if QSV_HAVE_VDENC > > { "low_power", "enable low power mode (experimental, many > > limitations by mfx version, HW platform, BRC modes, etc.)", > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-14 Thread Carl Eugen Hoyos
rg> >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC >> support for H264 >> >> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On >> Behalf >> > Of Carl Eugen Hoyos >> > Sent: Friday, January 11, 2019 10:39

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-14 Thread Fu, Linjie
avc/qsvenc: add VDENC > support for H264 > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf > > Of Carl Eugen Hoyos > > Sent: Friday, January 11, 2019 10:39 AM > > To: FFmpeg development discussions and patches > > > > Subject: Re:

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-11 Thread Carl Eugen Hoyos
2019-01-11 5:43 GMT+01:00, Li, Zhong : >> Which libx264 option is / can be hidden? > This one: > #if X264_BUILD >= 144 > { "autovariance-biased", "Auto-variance AQ with bias to dark scenes", 0, > AV_OPT_TYPE_CONST, {.i64 = X264_AQ_AUTOVARIANCE_BIASED}, INT_MIN, INT_MAX, > VE, "aq_mode" }, >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Li, Zhong
> Which libx264 option is / can be hidden? This one: #if X264_BUILD >= 144 { "autovariance-biased", "Auto-variance AQ with bias to dark scenes", 0, AV_OPT_TYPE_CONST, {.i64 = X264_AQ_AUTOVARIANCE_BIASED}, INT_MIN, INT_MAX, VE, "aq_mode" }, #endif

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Carl Eugen Hoyos
2019-01-11 4:42 GMT+01:00, Li, Zhong : >> >> 2019-01-10 14:51 GMT+01:00, Linjie Fu : >> >> >> >> > +#if QSV_HAVE_VDENC >> >> > +{ "low_power", "enable low power mode(experimental: many >> >> > +limitations by >> >> > mfx version, BRC modes, etc.)", OFFSET(qsv.low_power), >> >> >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Friday, January 11, 2019 10:39 AM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC > support for H264

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Carl Eugen Hoyos
Fmpeg-cvslog] lavc/qsvenc: add VDENC >> support for H264 >> >> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On >> Behalf >> > Of Carl Eugen Hoyos >> > Sent: Friday, January 11, 2019 1:06 AM >> > To: ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Friday, January 11, 2019 10:29 AM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC > support for H264 >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Carl Eugen Hoyos
2019-01-11 3:28 GMT+01:00, Li, Zhong : >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Carl Eugen Hoyos >> Sent: Friday, January 11, 2019 1:06 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc:

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Friday, January 11, 2019 1:06 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC > support for H264 > > 2019-01-10 14

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-10 Thread Carl Eugen Hoyos
2019-01-10 14:51 GMT+01:00, Linjie Fu : > +#if QSV_HAVE_VDENC > +{ "low_power", "enable low power mode(experimental: many limitations by > mfx version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { > .i64 = 0 }, 0, 1, VE}, > +#endif This seems wrong to me: The visibility of