Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Gyan
On 11-07-2019 02:01 AM, greg Luce wrote: Yes, but it's not needed. These are constants, so they have to be referenced within a function. There are two suitable ones: e and eif e.g. drawtext=text='pos %{e\:pkt_pos}, dur %{e\:pkt_duration}, size %{e\:pkt_size}' Oh my goodness gracious that's a

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread greg Luce
> Yes, but it's not needed. These are constants, so they have to be > referenced within a function. There are two suitable ones: e and eif > > e.g. > > drawtext=text='pos %{e\:pkt_pos}, dur %{e\:pkt_duration}, size > %{e\:pkt_size}' Oh my goodness gracious that's amazing! Thanks, I'll try that out

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread greg Luce
> You haven't tested your patch? Correct ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Gyan
On 11-07-2019 01:33 AM, greg Luce wrote: What output were you expecting with the first patch and what command did you test to check? I was hoping it would make -filter_complex [0:v]drawtext=text='%{pkt_duration}' (and also pkt_size and pkt_pos) work the same way as -filter_complex [0:v]drawtex

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Paul B Mahol
On 7/10/19, greg Luce wrote: >> What output were you expecting with the first patch and what command did >> you test to check? > > I was hoping it would make > -filter_complex [0:v]drawtext=text='%{pkt_duration}' > (and also pkt_size and pkt_pos) work the same way as > -filter_complex [0:v]drawtex

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread greg Luce
> What output were you expecting with the first patch and what command did > you test to check? I was hoping it would make -filter_complex [0:v]drawtext=text='%{pkt_duration}' (and also pkt_size and pkt_pos) work the same way as -filter_complex [0:v]drawtext=text='%{frame_num}' does currently, but

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Gyan
On 11-07-2019 12:52 AM, greg Luce wrote: This makes very little sense, please try hard to avoid similar commits in the future. What makes very little sense? Gyan Carl, if you mean the language is confusing I'm happy to write stuff differently! I'm very new to ffmpeg-devel in general. If yo

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread greg Luce
> > This makes very little sense, please try hard to avoid similar commits in > > the future. > What makes very little sense? > > Gyan Carl, if you mean the language is confusing I'm happy to write stuff differently! I'm very new to ffmpeg-devel in general. If you mean you can't picture someone

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Gyan
On 10-07-2019 02:01 PM, Carl Eugen Hoyos wrote: Am 07.07.2019 um 07:43 schrieb Calvin Walton : ffmpeg | branch: master | Calvin Walton | Fri Jun 21 09:08:03 2019 -0400| [2bd21b96096320bc12532119a6b0f7a974db6c19] | committer: Gyan Doshi vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Paul B Mahol
On 7/10/19, Carl Eugen Hoyos wrote: > > > >> Am 07.07.2019 um 07:43 schrieb Calvin Walton : >> >> ffmpeg | branch: master | Calvin Walton | Fri >> Jun 21 09:08:03 2019 -0400| [2bd21b96096320bc12532119a6b0f7a974db6c19] | >> committer: Gyan Doshi >> >> vf_drawtext: Add pkt_pos, pkt_duration, pkt_si

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Carl Eugen Hoyos
> Am 07.07.2019 um 07:43 schrieb Calvin Walton : > > ffmpeg | branch: master | Calvin Walton | Fri Jun > 21 09:08:03 2019 -0400| [2bd21b96096320bc12532119a6b0f7a974db6c19] | > committer: Gyan Doshi > > vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables > > Changes to vf_drawtext