Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-23 Thread Michael Niedermayer
On Tue, Apr 21, 2015 at 05:25:37PM -0300, Pedro Arthur wrote: New patch with changes. 2015-04-21 13:14 GMT-03:00 Pedro Arthur bygran...@gmail.com: I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-22 Thread Pedro Arthur
Thank you for the tips, I'll work on it. 2015-04-22 3:06 GMT-03:00 nand n...@nand.wakku.to: I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the correct gamma based on the input, thus for now it is

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-22 Thread Kevin Wheatley
I'll add that for some encodings filters with negative lobes will cause ringing no matter the direction up/down, especially true for higher dynamic range encodings like log and HDR options like SMPTE ST 2084 Kevin ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-22 Thread nand
I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the correct gamma based on the input, thus for now it is hardcode. This is how we do it in mpv: 1. If the source has enum AVColorTransferCharacteristic

[FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Pedro Arthur
Patch which adds support for gamma correct scaling in libswscale. From fe34ea493ffae9b6c1655112a66b5e0c4cfef26d Mon Sep 17 00:00:00 2001 From: Pedro Arthur bygran...@gmail.com Date: Fri, 17 Apr 2015 17:08:42 -0300 Subject: [PATCH] Add gamma encodign/decoding before/after scaling in libswscale

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Michael Niedermayer
On Tue, Apr 21, 2015 at 12:07:54PM -0300, Pedro Arthur wrote: Patch which adds support for gamma correct scaling in libswscale. options.c |3 ++ swscale.c | 51 +++ swscale.h |1 swscale_internal.h |9 +- utils.c

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Nicolas George
Le duodi 2 floréal, an CCXXIII, Pedro Arthur a écrit : Subject: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct sws: add support for gamma-correct scaling +{ true,enable,0, AV_OPT_TYPE_CONST, { .i64 = 1

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Kevin Wheatley
Pedro I understand the desire to 'degamma' images prior to scaling, I'd be interested in understanding how this could work with the colour_trc options rather than only assuming a simple gamma. Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Pedro Arthur
New patch with changes. 2015-04-21 13:14 GMT-03:00 Pedro Arthur bygran...@gmail.com: I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the correct gamma based on the input, thus for now it is hardcode.

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Nicolas George
Le duodi 2 floréal, an CCXXIII, Pedro Arthur a écrit : #define SWS_SPLINE0x400 +#define SWS_GAMMA_CORRECT 0x800 Sorry, I forgot one comment in my first email: This has risks of conflicts if the avconv fork adds a different flag with the same value. To avoid that, we usually leave a

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-21 Thread Pedro Arthur
I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the correct gamma based on the input, thus for now it is hardcode. 2015-04-21 12:31 GMT-03:00 Kevin Wheatley kevin.j.wheat...@gmail.com: Pedro I understand