Re: [FFmpeg-devel] [PATCH/WIP] avcodec/x86: move simple_idct to external assembly

2017-05-23 Thread James Darnley
On 2017-05-18 19:13, Ronald S. Bultje wrote: > - do you think a checkasm test makes sense? That would also make > performance measuring easier. The (I)DCT code seems to have its own test program in the fate-idct8x8 test. That is built from libavcodec/tests/dct.c. It even includes its own benchma

Re: [FFmpeg-devel] [PATCH/WIP] avcodec/x86: move simple_idct to external assembly

2017-05-18 Thread Ronald S. Bultje
Hi, cursory review, I appreciate that this is work in progress so don't read too much into it. General points: - I really like how you're doing a literal translation without trying to change it, this makes review easier and also reduces the likelihood that there's performance implications. - do y

[FFmpeg-devel] [PATCH/WIP] avcodec/x86: move simple_idct to external assembly

2017-05-12 Thread James Darnley
--- For initial review and comments. I plan to drop the '2' from the filename before pushing. I haven't done it yet because I am still working on the file. I didn't make any changes with speedup in mind so I haven't done any benchmarking yet. libavcodec/x86/Makefile | 4 +- libavcod