Re: [FFmpeg-devel] [PATCH][RFC] libavformat/mov Extend metadata handling to read in the keys from the 'keys' atom

2015-09-07 Thread Kevin Wheatley
I've updated and extended the metadata reading to include some of the numeric types, based on the feedback from the comments about adding to the utility functions of AVDictionary, I've directly formatted the values as strings in the .mov format code seams less risky. Kevin From

Re: [FFmpeg-devel] [PATCH][RFC] libavformat/mov Extend metadata handling to read in the keys from the 'keys' atom

2015-09-04 Thread Kevin Wheatley
On Thu, Sep 3, 2015 at 7:49 PM, Michael Niedermayer wrote: > missing checks for interger overflows of the addition and subtraction > > also the subject says "RFC", is there a reason not to push this to > git master once it otherwise looks good ? it is incomplete, basically I

[FFmpeg-devel] [PATCH][RFC] libavformat/mov Extend metadata handling to read in the keys from the 'keys' atom

2015-09-03 Thread Kevin Wheatley
Looking for feedback on this patch, in particular the use of the 'keys' dictionary within the MOVContext structure. With the patch FFmpeg can now 'find' the metadata in ARRI's sample footage see here: http://www.arri.com/camera/alexa/learn/alexa_sample_footage/ Thanks Kevin From

Re: [FFmpeg-devel] [PATCH][RFC] libavformat/mov Extend metadata handling to read in the keys from the 'keys' atom

2015-09-03 Thread Michael Niedermayer
On Thu, Sep 03, 2015 at 04:04:53PM +0100, Kevin Wheatley wrote: > Looking for feedback on this patch, in particular the use of the > 'keys' dictionary within the MOVContext structure. > > With the patch FFmpeg can now 'find' the metadata in ARRI's sample > footage see here: > >