Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-17 Thread Michael Niedermayer
On Wed, May 15, 2019 at 12:13:07PM -0700, Adam Richter wrote: > On Tue, May 14, 2019 at 6:48 PM myp...@gmail.com wrote: > > > > On Wed, May 15, 2019 at 7:01 AM Hendrik Leppkes wrote: > > > > > > On Tue, May 14, 2019 at 11:25 PM Adam Richter > > > wrote: [...] > > > > > > > > Also after this, I

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-15 Thread Hendrik Leppkes
On Wed, May 15, 2019 at 9:21 PM Adam Richter wrote: > > On Tue, May 14, 2019 at 6:48 PM myp...@gmail.com wrote: > > > > On Wed, May 15, 2019 at 7:01 AM Hendrik Leppkes wrote: > > > > > > On Tue, May 14, 2019 at 11:25 PM Adam Richter > > > wrote: > > > > > > > > Consider, for example, if you

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-15 Thread Adam Richter
On Tue, May 14, 2019 at 6:48 PM myp...@gmail.com wrote: > > On Wed, May 15, 2019 at 7:01 AM Hendrik Leppkes wrote: > > > > On Tue, May 14, 2019 at 11:25 PM Adam Richter > > wrote: > > > > > > Consider, for example, if you agree that columnization makes this range > > > check > > > more

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-14 Thread myp...@gmail.com
On Wed, May 15, 2019 at 7:01 AM Hendrik Leppkes wrote: > > On Tue, May 14, 2019 at 11:25 PM Adam Richter wrote: > > > > Consider, for example, if you agree that columnization makes this range > > check > > more recognizable in a glance and makes it easier to spot what the bounds > > are > >

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-14 Thread Hendrik Leppkes
On Tue, May 14, 2019 at 11:25 PM Adam Richter wrote: > > Consider, for example, if you agree that columnization makes this range check > more recognizable in a glance and makes it easier to spot what the bounds are > (the sixteen space indentation is taken from the code in which it appeared): > >

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-14 Thread Adam Richter
On Sun, May 12, 2019 at 11:16 AM Michael Niedermayer wrote: > > On Sun, May 12, 2019 at 05:58:50PM +0100, Mark Thompson wrote: > > On 12/05/2019 16:24, Adam Richter wrote: > > > This patch separates statements of the form "assert(a && b);" into > > > "assert(a);" and "assert(b);", typically

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-13 Thread Michael Niedermayer
On Sun, May 12, 2019 at 08:24:11AM -0700, Adam Richter wrote: > This patch separates statements of the form "assert(a && b);" into > "assert(a);" and "assert(b);", typically involving an assertion > function like av_assert0. > > This patch covers all of ffmpeg, except for the libavformat, which I

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-12 Thread Michael Niedermayer
On Sun, May 12, 2019 at 05:58:50PM +0100, Mark Thompson wrote: > On 12/05/2019 16:24, Adam Richter wrote: > > This patch separates statements of the form "assert(a && b);" into > > "assert(a);" and "assert(b);", typically involving an assertion > > function like av_assert0. > > > > This patch

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-12 Thread Mark Thompson
On 12/05/2019 16:24, Adam Richter wrote: > This patch separates statements of the form "assert(a && b);" into > "assert(a);" and "assert(b);", typically involving an assertion > function like av_assert0. > > This patch covers all of ffmpeg, except for the libavformat, which I > have already

[FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

2019-05-12 Thread Adam Richter
This patch separates statements of the form "assert(a && b);" into "assert(a);" and "assert(b);", typically involving an assertion function like av_assert0. This patch covers all of ffmpeg, except for the libavformat, which I have already submitted separately. I have not tested this patch other