On Fri, Dec 22, 2023 at 4:41 PM Ronald S. Bultje wrote:
> Hi Paul,
>
> On Fri, Dec 22, 2023 at 10:33 AM Paul B Mahol wrote:
>
> > There are some serious issues in this code.
> >
>
> While already very insightful, it would be enormously helpful if you could
> expand on this statement with more
Hi Paul,
On Fri, Dec 22, 2023 at 10:33 AM Paul B Mahol wrote:
> There are some serious issues in this code.
>
While already very insightful, it would be enormously helpful if you could
expand on this statement with more detail, such as a list of issues as they
exist in this code.
Ronald
There are some serious issues in this code.
Also missing tests.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with
On Wed, Dec 20, 2023 at 2:56 PM Vittorio Giovara
wrote:
>
>
> On Wed, Dec 20, 2023 at 2:50 PM Nicolas George wrote:
>
>> Vittorio Giovara (12023-12-20):
>> > If there are no more comments, I'll push this today or tomorrow.
>>
>> I think the change you made after the last request might go too
On Wed, Dec 20, 2023 at 2:50 PM Nicolas George wrote:
> Vittorio Giovara (12023-12-20):
> > If there are no more comments, I'll push this today or tomorrow.
>
> I think the change you made after the last request might go too far, but
> I have not had time to look at the code carefully enough to
Vittorio Giovara (12023-12-20):
> If there are no more comments, I'll push this today or tomorrow.
I think the change you made after the last request might go too far, but
I have not had time to look at the code carefully enough to be sure.
If a filter can produce several output frames from one
On Fri, Dec 15, 2023 at 3:12 PM Vittorio Giovara
wrote:
>
>
> On Fri, Dec 15, 2023 at 12:34 PM Andreas Rheinhardt <
> andreas.rheinha...@outlook.com> wrote:
>
>> > +static int list_add_frame(FrameList **list, size_t *size, AVFrame
>> > *frame)
>> > +{
>> > +FrameList *element =
On Fri, Dec 15, 2023 at 12:34 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> > +static int list_add_frame(FrameList **list, size_t *size, AVFrame
> > *frame)
> > +{
> > +FrameList *element = av_mallocz(sizeof(FrameList));
>
> The overhead of this FrameList is unnecessary:
Vittorio Giovara:
> +#include "avfilter.h"
> +#include "formats.h"
> +#include "internal.h"
> +#include "video.h"
> +
> +#define TILT_NONE -1
> +#define TILT_FRAME 0
> +#define TILT_BLACK 1
Why is this not an enum?
> +
> +typedef struct FrameList {
> +AVFrame *frame;
> +struct
On Tue, Dec 12, 2023 at 3:00 AM Nicolas George wrote:
> Vittorio Giovara (12023-12-11):
> > This is an older filter I wrote and never got around publishing.
> > It can be used to generate a distortion effect like
> > https://vimeo.com/104938599?share=copy
> > Please see attached.
>
> Your code
Vittorio Giovara (12023-12-11):
> This is an older filter I wrote and never got around publishing.
> It can be used to generate a distortion effect like
> https://vimeo.com/104938599?share=copy
> Please see attached.
Your code is doing in request_frame() what should be done in
filter_frame().
This is an older filter I wrote and never got around publishing.
It can be used to generate a distortion effect like
https://vimeo.com/104938599?share=copy
Please see attached.
--
Vittorio
0001-Add-new-vf_tiltandshift-filter.patch
Description: Binary data
12 matches
Mail list logo
