Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-26 Thread Aman Gupta
On Sat, Sep 7, 2019 at 11:39 AM Marton Balint wrote: > > > On Wed, 4 Sep 2019, Anthony Delannoy wrote: > > > Hi > > > > I'm still interested to have those three commits merged (update in > attachments). > > Ok, below are some more comments. > > > > > But I'd like to see data decoder in the future

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-19 Thread Marton Balint
On Thu, 12 Sep 2019, Anthony Delannoy wrote: But I'd like to see data decoder in the future to use more easily EPG/NIT/BAT etc tables. Will it be possible? With modifications if it needs to be? I don't see how, as it does not fit into the concept of the libav* libraries. I feel this belongs

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-11 Thread Anthony Delannoy
> > But I'd like to see data decoder in the future to use more easily > > EPG/NIT/BAT etc tables. > > Will it be possible? With modifications if it needs to be? > > I don't see how, as it does not fit into the concept of the libav* > libraries. I feel this belongs to a separate library. A new liba

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-07 Thread Marton Balint
On Wed, 4 Sep 2019, Anthony Delannoy wrote: Hi I'm still interested to have those three commits merged (update in attachments). Ok, below are some more comments. But I'd like to see data decoder in the future to use more easily EPG/NIT/BAT etc tables. Will it be possible? With modificati

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-04 Thread Anthony Delannoy
Hi I'm still interested to have those three commits merged (update in attachments). But I'd like to see data decoder in the future to use more easily EPG/NIT/BAT etc tables. Will it be possible? With modifications if it needs to be? Anthony Delannoy Le mar. 3 sept. 2019 à 23:39, Marton Balint

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-03 Thread Marton Balint
Hi, I am not sure if you are interested getting only patch 1, 2 and 3 merged, but if you are, then here are my comments for patch 3. From 025ec8e8d607d02f2e5b4021783ab8f3b42d0bc1 Mon Sep 17 00:00:00 2001 From: Anthony Delannoy Date: Wed, 21 Aug 2019 11:46:56 +0200 Subject: [PATCH 03/10] lavf/m

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-26 Thread Anthony Delannoy
Okay, thanks I will patch that Le sam. 24 août 2019 à 20:09, Marton Balint a écrit : > > > On Fri, 23 Aug 2019, Anthony Delannoy wrote: > > >> I think we should only merge the part of this patchset which makes the EIT > >> available as a data stream. Parsing the whole EIT or dumping the data as

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-24 Thread Marton Balint
On Fri, 23 Aug 2019, Anthony Delannoy wrote: I think we should only merge the part of this patchset which makes the EIT available as a data stream. Parsing the whole EIT or dumping the data as ASCII is not libavcodec's or libavutil's job. The EPG decoder does not change the table's data, it j

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-23 Thread Anthony Delannoy
> I think we should only merge the part of this patchset which makes the EIT > available as a data stream. Parsing the whole EIT or dumping the data as > ASCII is not libavcodec's or libavutil's job. The EPG decoder does not change the table's data, it just store them and it happens to contains te

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Marton Balint
On Thu, 22 Aug 2019, Anthony Delannoy wrote: Hi fails to build on MIPS Seems to be because of these two structs within EPGTable and EPGSubTable: +struct { +int nb_descriptors; +void **descriptors; +}; I made modifications to avoid issues you encountered and put fa

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Carl Eugen Hoyos
Am Do., 22. Aug. 2019 um 12:42 Uhr schrieb Michael Niedermayer : > > On Wed, Aug 21, 2019 at 06:28:08PM +0200, Anthony Delannoy wrote: > > Hi, > > > > In the attached files is the first implementation of: > > * dvb descriptors parsing api to ease their use on different sections (for > > now i've on

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 06:28:08PM +0200, Anthony Delannoy wrote: > Hi, > > In the attached files is the first implementation of: > * dvb descriptors parsing api to ease their use on different sections (for > now i've only implemented EIT section) > * EIT table and subtable > * EIT callback in lav