Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

On Sat, Nov 15, 2014 at 01:34:29PM +0900, TOYAMA Shin-ichi wrote: Thank you for discussing about this. Michael Niedermayer wrote in 20141114203251.GX32286@nb4 +ctx-has_palette = 0; +ret = avio_open2(ifo, p, AVIO_FLAG_READ, NULL, NULL); libavcodec does not depend on libavformat,

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Thanks for many comments. Attached is the forth try. Please review it. -- TOYAMA Shin-ichi mailto:sh...@wmail.plala.or.jp 0001-New-option-for-obtaining-global-palette-from-.IFO-fi.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

On Sat, Nov 15, 2014 at 02:25:48AM +0900, TOYAMA Shin-ichi wrote: Thanks for many comments. Attached is the forth try. Please review it. -- TOYAMA Shin-ichi mailto:sh...@wmail.plala.or.jp doc/decoders.texi |3 ++ libavcodec/dvdsubdec.c | 58

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Le quartidi 24 brumaire, an CCXXIII, Michael Niedermayer a écrit : libavformat OTOH could read the IFO file with avio_open2/avio_read into extradata or some newly added ifo specific side data and dvdsubdec.c could then parse the palette out of that. That would work. It can be even reasonably

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Thank you for discussing about this. Michael Niedermayer wrote in 20141114203251.GX32286@nb4 +ctx-has_palette = 0; +ret = avio_open2(ifo, p, AVIO_FLAG_READ, NULL, NULL); libavcodec does not depend on libavformat, thus libavcodec cannot use avio_* directly. I should have

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Nicolas George wrote in 20141110140122.ga22...@phare.normalesup.org Thanks for the patch. See comments below. O.K. I've finished to revise the patch. Please see attached. The update for the documentation is missing. Added short description to doc/decoders.texi. + if (strncmp(p, ifo:, 4) ==

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

On Tue, Nov 11, 2014 at 11:41:53PM +0900, TOYAMA Shin-ichi wrote: Nicolas George wrote in 20141110140122.ga22...@phare.normalesup.org Thanks for the patch. See comments below. O.K. I've finished to revise the patch. Please see attached. The update for the documentation is missing.

[FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Attached patch enables parsing DVD color palette directly from IFO file via -palette option using syntax `-palette ifo:filename` This is a straightforward implementation of the procedure described in the following post to ffmpeg-user mailing list.

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Le decadi 20 brumaire, an CCXXIII, TOYAMA Shin-ichi a écrit : Attached patch enables parsing DVD color palette directly from IFO file via -palette option using syntax `-palette ifo:filename` This is a straightforward implementation of the procedure described in the following post to

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

On 2014-11-10 15:01, Nicolas George wrote: + fread(c, 1, 1, in); + fread(Y, 1, 1, in); + fread(Cr, 1, 1, in); + fread(Cb, 1, 1, in); You could replace that with a single read into an array; that would not allow to call the variables R, Cr, Cb, but that does not matter

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

On Mon, Nov 10, 2014 at 3:01 PM, Nicolas George geo...@nsup.org wrote: + + /* YCrCb - RGB conversion */ + Cr = Cr - 128; + Cb = Cb - 128; + R = Y + Cr + (Cr2) + (Cr3) + (Cr5); + G = Y - ((Cb2) + (Cb4) + (Cb5)) - ((Cr1) + (Cr3) + (Cr4) + (Cr5)); + B =

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

Nicolas George wrote in 20141110140122.ga22...@phare.normalesup.org Thanks for the patch. See comments below. Thank you for your quick reply. I will go through many comments from you and others, and will post revised patch in some time. # I think it will take long for me to update documents ...