Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-27 Thread zhilizhao(赵志立)
> On Feb 23, 2023, at 23:01, Hendrik Leppkes wrote: > > On Thu, Feb 23, 2023 at 3:37 PM copypaste wrote: >> It gets included because this platform does indeed have Video4Linux so some >> of the aarch64 stuff is relevant. Furthermore I think that the HEVC stuff >> includes it. >> > > If

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-24 Thread copypaste
Here's my attempt to do just that. :-) Compiled fine with: configuration: --prefix=/data/data/com.termux/files/usr/local --enable-indev=alsa --enable-indev=xcbgrab --enable-libfreetype --enable-libfontconfig --cc=clang --cxx=clang++ --disable-libxcb-shm --enable-vulkan

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread Hendrik Leppkes
On Thu, Feb 23, 2023 at 3:37 PM copypaste wrote: > It gets included because this platform does indeed have Video4Linux so some > of the aarch64 stuff is relevant. Furthermore I think that the HEVC stuff > includes it. > If its relevant for V4L or other hardware integration is fine and all ...

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread copypaste
Sorry Anton, I stupidly misread your message. You are telling me not to start my identifiers with underscores not talking about Android. Well, I can certainly change it but just making them lowercase will not fix the issue because those collide with ffmpeg's variables. Perhaps what I

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread copypaste
It gets included because this platform does indeed have Video4Linux so some of the aarch64 stuff is relevant. Furthermore I think that the HEVC stuff includes it. I have attached the file, whether or not it is not allowed seems immaterial because it is done by Android whether we like

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread Anton Khirnov
Quoting copypaste (2023-02-22 10:12:08) > Applied to libavcodec/aaccoder.c: > :%s/\([*]\)\?\([ \t]\{-}\)\?\(\<[BD-Z]\([0-9]*\)\)\>/\1\2_\3/g > > This stops B0 and B1 from colliding with a define in > /usr/include/asm-generic/termbits.h: Why is that file even being included? Also > All

[FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-22 Thread copypaste
Best, Fred Brennan (copypaste.wtf) From e9a889bfbf38bda7855792edd8248f4f4a56af7e Mon Sep 17 00:00:00 2001 From: Fredrick Brennan Date: Tue, 21 Feb 2023 12:58:38 -0500 Subject: [PATCH 1/2] Fix build on Android due to termbits.h collision! Applied to libavcodec/aaccoder.c: