Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-27 Thread Marton Balint
On Mon, 7 Oct 2019, just.one@yandex.ru wrote: Please use a proper commit title: e.g: avformat/segment: fix non-zero start pts Also make sure you provide the author name you want when you send the patch email. (you only provided an email address in the From field, not a full name, I gues

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-27 Thread Vasily
Can anyone answer me?.. :( чт, 17 окт. 2019 г., 12:24 Vasily : > Can I have _any_ response please? It was more than a week of silence... :( > > Thanks, > Vasily > > чт, 10 окт. 2019 г., 13:05 Vasily : > >> Anything else I have to do to make this patch eventually taken in? >> >> Thanks, >> Vasily

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-17 Thread Vasily
Can I have _any_ response please? It was more than a week of silence... :( Thanks, Vasily чт, 10 окт. 2019 г., 13:05 Vasily : > Anything else I have to do to make this patch eventually taken in? > > Thanks, > Vasily > > пн, 7 окт. 2019 г. в 15:54, : > >> When incoming media has non-zero start PT

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-10 Thread Vasily
Anything else I have to do to make this patch eventually taken in? Thanks, Vasily пн, 7 окт. 2019 г. в 15:54, : > When incoming media has non-zero start PTS, > segment muxer would fail to correctly calculate > the point where to chunk segments, as it always > assumed that media starts with PTS==

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-07 Thread just . one . man
When incoming media has non-zero start PTS, segment muxer would fail to correctly calculate the point where to chunk segments, as it always assumed that media starts with PTS==0. This change removes this assumption by remembering the PTS of the very first frame passed through the muxer. Also fix

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-07 Thread Nicolas George
just.one@yandex.ru (12019-10-07): > Updated patch This should be after the triple dash, because it does not belong in the commit message. > --- > > When incoming media has non-zero start PTS, > segment muxer would fail to correctly calculate > the point where to chunk segments, as it always

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-07 Thread just . one . man
Updated patch --- When incoming media has non-zero start PTS, segment muxer would fail to correctly calculate the point where to chunk segments, as it always assumed that media starts with PTS==0. This change removes this assumption by remembering the PTS of the very first frame passed through th

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-06 Thread Vasily
I used that value somewhere during patch development, but I eventually settled on -1, because that "start_pts" and "end_pts" are using some other units, not the unit used by pkt->pts. So I wanted to make a distinction. Though a possibility of negative timestamps didn't come to me, so I probably ha

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-06 Thread Marton Balint
On Thu, 3 Oct 2019, just.one@yandex.ru wrote: It seems that my first attempt to send the patch failed (probably because my box where I executed "git send-email" failed reverse smtp check), so I'm going to re-send it to this same thread. --- When incoming media has non-zero start PTS, s

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-03 Thread just . one . man
It seems that my first attempt to send the patch failed (probably because my box where I executed "git send-email" failed reverse smtp check), so I'm going to re-send it to this same thread. --- When incoming media has non-zero start PTS, segment muxer would fail to correctly calculate the poin

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-02 Thread just . one . man
Note that the second e-mail contains a more full version of patch which also updates times used to generate the playlist, so playlist is now also correct. --- Thanks, Vasily 02.10.2019, 14:22, "Vasily" : > When incoming media has non-zero start PTS, > segment muxer would fail to correctly calcul