Le 04/06/2023 à 20:24, Tomas Härdin a écrit :
tor 2023-06-01 klockan 17:19 +0200 skrev Cédric Le Barz:
Attach to this mail, is my new patch for adding jpeg2000 sub-
descriptor
in MXF file taking into account remarks from FFmpeg community
(remarks
from Pierre-Anthony above as well as this from
tor 2023-06-01 klockan 17:19 +0200 skrev Cédric Le Barz:
> Attach to this mail, is my new patch for adding jpeg2000 sub-
> descriptor
> in MXF file taking into account remarks from FFmpeg community
> (remarks
> from Pierre-Anthony above as well as this from Tomas), i.e. :
>
> 1 - When there is
Le 09/05/2023 à 16:28, Pierre-Anthony Lemieux a écrit :
Couple of follow-up comments.
- "mxf_parse_jpeg2000_frame" could be moved to one of jpeg2000 source
files, to keep J2K parsing code together. Maybe there is a way to
reuse jpeg2000_read_main_headers() at jpeg2000dec.c?
- when defining
Couple of follow-up comments.
- "mxf_parse_jpeg2000_frame" could be moved to one of jpeg2000 source
files, to keep J2K parsing code together. Maybe there is a way to
reuse jpeg2000_read_main_headers() at jpeg2000dec.c?
- when defining the J2K descriptor items, please refer to the symbol
name
> +if (j2k_ncomponents != component_count) {
> +av_log(s, AV_LOG_ERROR, "Incoherence about components image
> number.\n");
> +}
I still think you should error out here, since mismatched component
count is indicative of broken internal logic
/Tomas
Le 27/04/2023 à 14:45, Tomas Hardin a écrit :
static inline uint16_t rescale_mastering_chroma(AVRational q)
{
@@ -1260,7 +1305,6 @@ static int64_t
mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID
f1 *= 2;
}
-
Stray deleted line
+/* Image components
> static inline uint16_t rescale_mastering_chroma(AVRational q)
> {
> @@ -1260,7 +1305,6 @@ static int64_t
> mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID
> f1 *= 2;
> }
>
> -
Stray deleted line
> +/* Image components number */
> +
Le 05/04/2023 à 15:53, Tomas Härdin a écrit :
ons 2023-04-05 klockan 15:05 +0200 skrev Cédric Le Barz:
Le 03/04/2023 à 17:14, Michael Niedermayer a écrit :
On Mon, Apr 03, 2023 at 10:08:25AM +0200, Cédric Le Barz wrote:
Hi,
I've attached the patch to this mail, in order to solve newlines
On Wed, Mar 29, 2023 at 1:54 PM Cédric Le Barz wrote:
>
> Add jpeg2000 subdescriptor in MXF file.
>
> Signed-off-by: Cedric Le Barz
> ---
> ffmpeg/libavformat/mxf.h| 1 +
> ffmpeg/libavformat/mxfenc.c | 74 -
> 2 files changed, 74 insertions(+), 1
