Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

On 26 October 2017 at 16:34, Carl Eugen Hoyos wrote: > Was this already mentioned somewhere? > Do other codecs with large sample rates in mp4 play with Firefox? not if the metadata reports a sampling rate of 0 ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-10-26 8:37 GMT+02:00 Jean-Yves Avenard : > Hi > > On 25 October 2017 at 23:57, Carl Eugen Hoyos wrote: > >>> ISOBMFF only defines that AudioSampleEntryV1 should be used instead, >>> in which case the sampling_rate is a 32 bits integer (ISO 14496-12

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

Hi On 25 October 2017 at 23:57, Carl Eugen Hoyos wrote: >> ISOBMFF only defines that AudioSampleEntryV1 should be used instead, >> in which case the sampling_rate is a 32 bits integer (ISO 14496-12 >> 12.2.3.2) > > Not sure I understand: > In ticket #6609, I asked if this is

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

On Wed, Oct 25, 2017 at 06:48:06PM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 25, 2017 at 5:57 PM, Carl Eugen Hoyos > wrote: > > > 2017-10-25 16:52 GMT+02:00 Jean-Yves Avenard : > > > hi > > > > > > On 26 August 2017 at 12:08, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

Hi, On Wed, Oct 25, 2017 at 5:57 PM, Carl Eugen Hoyos wrote: > 2017-10-25 16:52 GMT+02:00 Jean-Yves Avenard : > > hi > > > > On 26 August 2017 at 12:08, Carl Eugen Hoyos wrote: > >> 2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-10-25 16:52 GMT+02:00 Jean-Yves Avenard : > hi > > On 26 August 2017 at 12:08, Carl Eugen Hoyos wrote: >> 2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard : >> >>> +if (track->par->codec_id == AV_CODEC_ID_FLAC) { >> >> Why

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

hi On 26 August 2017 at 12:08, Carl Eugen Hoyos wrote: > 2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard : > >> +if (track->par->codec_id == AV_CODEC_ID_FLAC) { > > Why does this only apply to flac? > Sorry, I had missed your reply. The

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

Hi, On Fri, Aug 25, 2017 at 7:29 PM, Michael Niedermayer wrote: > On Fri, Aug 25, 2017 at 01:25:23PM +0200, Jean-Yves Avenard wrote: > > From 9baa7166fa96ed6beac9146c7e3b4dcf425a67d0 Mon Sep 17 00:00:00 2001 > > From: Jean-Yves Avenard > > Date:

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard : > +if (track->par->codec_id == AV_CODEC_ID_FLAC) { Why does this only apply to flac? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

On Fri, Aug 25, 2017 at 01:25:23PM +0200, Jean-Yves Avenard wrote: > From 9baa7166fa96ed6beac9146c7e3b4dcf425a67d0 Mon Sep 17 00:00:00 2001 > From: Jean-Yves Avenard > Date: Fri, 25 Aug 2017 13:11:28 +0200 > Subject: [PATCH] Properly store sampling rate for FLAC in mp4 > >

[FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

From 9baa7166fa96ed6beac9146c7e3b4dcf425a67d0 Mon Sep 17 00:00:00 2001 From: Jean-Yves Avenard Date: Fri, 25 Aug 2017 13:11:28 +0200 Subject: [PATCH] Properly store sampling rate for FLAC in mp4 Fixes ticket #6609 Signed-off-by: Jean-Yves Avenard

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

Note that that it's also not correct for other codecs when the sampling rate is greater than 65536. Right now it stores 0. If in quicktime mode, it could use a SoundDescription v2 box, but in mp4 that doesn't exist. Per ISO 14496-12 , it should be using a AudioSampleEntryV1 along a