Re: [FFmpeg-devel] [PATCH] Read |state| under the protection of |mutex| or |progress_mutex|.

2016-03-01 Thread Ronald S. Bultje
Hi, On Tue, Mar 1, 2016 at 1:47 PM, Wan-Teh Chang wrote: > Hi Ronald, > > On Fri, Feb 26, 2016 at 12:16 PM, Ronald S. Bultje > wrote: > > > > This will be slower, right? Is this an actual issue? Like, can you point > to > > cases like [1] (i.e. a real-world race condition with real-world > > co

Re: [FFmpeg-devel] [PATCH] Read |state| under the protection of |mutex| or |progress_mutex|.

2016-03-01 Thread Wan-Teh Chang
Hi Ronald, On Fri, Feb 26, 2016 at 12:16 PM, Ronald S. Bultje wrote: > > This will be slower, right? Is this an actual issue? Like, can you point to > cases like [1] (i.e. a real-world race condition with real-world > consequences) that were fixed with your patch? > > Ronald > > https://blogs.gno

Re: [FFmpeg-devel] [PATCH] Read |state| under the protection of |mutex| or |progress_mutex|.

2016-02-26 Thread Ronald S. Bultje
Hi, On Thu, Feb 25, 2016 at 9:18 PM, Wan-Teh Chang wrote: > Although not documented, |state| is guarded by either |mutex| or > |progress_mutex|. In several places |state| is read without mutex > protection, often as a double-checked locking style performance > optimization. Fix the data races by

[FFmpeg-devel] [PATCH] Read |state| under the protection of |mutex| or |progress_mutex|.

2016-02-25 Thread Wan-Teh Chang
Although not documented, |state| is guarded by either |mutex| or |progress_mutex|. In several places |state| is read without mutex protection, often as a double-checked locking style performance optimization. Fix the data races by reading |state| under mutex protection. --- libavcodec/pthread_fram