Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-25 Thread Juan De León
I submitted another patch in a new email thread addressing your concerns, apologies for the confusion. The subject is "[PATCH] Extract QP from h264 encoded videos". Here is the link to the archive http://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247037.html

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-22 Thread Lynne
Jul 23, 2019, 12:23 AM by juandl-at-google@ffmpeg.org: >> On Mon, Jul 22, 2019 at 12:17 PM Lynne wrote: >> You can't hack a decoder in any nice and performant way for it to output >> > data to an analyzer. > Hi, Lynne > I hear your concern about the decoder performance. > I believe that the

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-22 Thread Juan De León
> On Mon, Jul 22, 2019 at 12:17 PM Lynne wrote: > You can't hack a decoder in any nice and performant way for it to output data to an analyzer. Hi, Lynne I hear your concern about the decoder performance. I believe that the way we would like to modify the decoder should not affect its

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-22 Thread Lynne
Jul 22, 2019, 8:03 PM by juandl-at-google@ffmpeg.org: > On Fri, Jul 19, 2019 at 12:47 PM Moritz Barsnick wrote: > >> On Fri, Jul 19, 2019 at 10:00:52 +0200, Nicolas George wrote: >> > I do not judge whether this filter would be useful and should be >> > included, but if so, then I would

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-22 Thread Juan De León
On Fri, Jul 19, 2019 at 12:47 PM Moritz Barsnick wrote: > On Fri, Jul 19, 2019 at 10:00:52 +0200, Nicolas George wrote: > > I do not judge whether this filter would be useful and should be > > included, but if so, then I would appreciate that the output be done > > using AVIO, so that it can go

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-19 Thread Moritz Barsnick
On Fri, Jul 19, 2019 at 10:00:52 +0200, Nicolas George wrote: > I do not judge whether this filter would be useful and should be > included, but if so, then I would appreciate that the output be done > using AVIO, so that it can go to any supported protocol. The metadata filter has a nice example

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-19 Thread Nicolas George
Juan De León (12019-07-17): > +FILE *stats_file; I do not judge whether this filter would be useful and should be included, but if so, then I would appreciate that the output be done using AVIO, so that it can go to any supported protocol. Regards, -- Nicolas George signature.asc

[FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-18 Thread Juan De León
Thanks for the feedback, appreciate it. I added the AV_FRAME_DATA_QUANTIZATION_PARAMS type to AVFrameSideData and I removed the filter since it is not complete yet. I will send the filter and the modification to the encoders when those are done. --- libavutil/Makefile | 2 +

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-18 Thread Lynne
Jul 18, 2019, 12:25 AM by juandl-at-google@ffmpeg.org : > For context > https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing > >

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-18 Thread Moritz Barsnick
On Wed, Jul 17, 2019 at 16:18:11 -0700, Juan De León wrote: > --- > libavfilter/vf_extractqp.c | 116 > libavutil/Makefile | 2 + > libavutil/quantization_params.c | 28 > libavutil/quantization_params.h | 98

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-17 Thread Juan De León
For context https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing Feel free to comment the doc. On Wed, Jul 17, 2019 at 4:18 PM Juan De León wrote: > --- > libavfilter/vf_extractqp.c | 116 > libavutil/Makefile

[FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-17 Thread Juan De León
--- libavfilter/vf_extractqp.c | 116 libavutil/Makefile | 2 + libavutil/quantization_params.c | 28 libavutil/quantization_params.h | 98 +++ 4 files changed, 244 insertions(+) create mode 100644