Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Tue, Oct 27, 2015 at 11:28:32AM +, Lucas Andrade wrote: > Here is the patch to backport it to release/2.8. To be fixed on 2.8.2. > Anything else I should do? > > ps. Sorry, that's my first time on opensource project, I'm a little > confused that I needed to add it to the release branch. >

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Em sex, 30 de out de 2015 às 07:44, Michael Niedermayer escreveu: > On Tue, Oct 27, 2015 at 11:28:32AM +, Lucas Andrade wrote: > > Here is the patch to backport it to release/2.8. To be fixed on 2.8.2. > > Anything else I should do? > > > > ps. Sorry, that's my first

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Fri, Oct 30, 2015 at 12:26:55PM +, Lucas Andrade wrote: > Em sex, 30 de out de 2015 às 07:44, Michael Niedermayer > escreveu: > > > On Tue, Oct 27, 2015 at 11:28:32AM +, Lucas Andrade wrote: > > > Here is the patch to backport it to release/2.8. To be fixed on

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Em ter, 27 de out de 2015 às 09:28, Lucas Andrade escreveu: > Here is the patch to backport it to release/2.8. To be fixed on 2.8.2. > Anything else I should do? > > ps. Sorry, that's my first time on opensource project, I'm a little > confused that I needed to add it to

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Here is the patch to backport it to release/2.8. To be fixed on 2.8.2. Anything else I should do? ps. Sorry, that's my first time on opensource project, I'm a little confused that I needed to add it to the release branch. b3f3eab029eb429660fc1651a33dafe097cbac0e.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Can this patch be added to 2.9-dev? I think it should be released on 2.8.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Fri, Sep 25, 2015 at 9:50 AM, Lucas Andrade wrote: > Here it is. Also sent as PR on github. FYI, we don't do pull requests on github: See "Contributing" at https://github.com/FFmpeg/FFmpeg. > > ___ > ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Ok, I know I did it wrong with the PR. I've used the PR to create the patch. Sorry for trying to help. Anyway, here it is the all-in-one patch. Update Cookies response with Setcookie.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Fri, 25 Sep 2015 15:16:34 + Lucas Andrade wrote: > Ok, I know I did it wrong with the PR. I've used the PR to create the > patch. Sorry for trying to help. > Anyway, here it is the all-in-one patch. Thanks! I applied and pushed it. Sorry for the back and forth.

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Fri, 25 Sep 2015 14:23:27 + Lucas Andrade wrote: > Ok, I'll try to merge all those patches at a single one. Should be simple enough... the reason why I want a git format-patch is that you can set your commit message, author name, and email properly. Sorry for not

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Fri, 25 Sep 2015 02:00:29 + Lucas Andrade wrote: > diff --git a/libavformat/hls.c b/libavformat/hls.c > index adaa33a..f9f86af 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -525,6 +525,14 @@ static int url_connect(struct playlist *pls, >

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

I did test with a similar command posted on the tracker, cookies were updated correctly. Em sex, 25 de set de 2015 às 10:26, wm4 escreveu: > On Fri, 25 Sep 2015 02:00:29 + > Lucas Andrade wrote: > > > diff --git a/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Here it is. Also sent as PR on github. Update Cookies Setcookie response.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Fri, 25 Sep 2015 13:38:20 + Lucas Andrade wrote: > I did test with a similar command posted on the tracker, cookies were > updated correctly. Wanted to apply, but it's only a .diff. Can you send a patch produced with git format-patch? Also, stop

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Ok, I'll try to merge all those patches at a single one. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Here it goes. Update Cookies on Setcookie response.diff Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Wed, 23 Sep 2015 00:55:39 + Lucas Andrade wrote: > I've tested and this works. Cookies is being set correctly. As you can see, > I've removed the opts2 as it isn't needed anymore. I've added the cookie > update to open_url (setting the HLSContext->cookies and the

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Tue, 22 Sep 2015 17:20:13 + Lucas Andrade wrote: > Sorry about top posting.. That's the gmail default. Anyway, I've double > checked and think you're right. I'll add that to open_url, but I need to > set the right HLSContext cookies. Right now it isn't passed as

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Sorry about top posting.. That's the gmail default. Anyway, I've double checked and think you're right. I'll add that to open_url, but I need to set the right HLSContext cookies. Right now it isn't passed as parameter to open_url, that way, I'll have to pass it ahead. About the opts, it isn't

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

I've tested and this works. Cookies is being set correctly. As you can see, I've removed the opts2 as it isn't needed anymore. I've added the cookie update to open_url (setting the HLSContext->cookies and the opts (maybe used on ciphered stream). diff --git a/libavformat/hls.c b/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Tue, 22 Sep 2015 04:37:48 + Lucas Andrade wrote: > This fixes the https://trac.ffmpeg.org/ticket/4808, as it sets the cookie > on playlist response with setcookie header. > > Update Cookies on Setcookie playlist response > --- > libavformat/hls.c | 2 ++ > 1 file

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

You're right, I should at least check if ret == 0. I'll update the patch and check if it works. Em ter, 22 de set de 2015 às 08:09, Lucas Andrade escreveu: > I think the other code paths already sets the cookie. > > Em Ter, 22 de set de 2015 04:41, wm4

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

I think the other code paths already sets the cookie. Em Ter, 22 de set de 2015 04:41, wm4 escreveu: > On Tue, 22 Sep 2015 04:37:48 + > Lucas Andrade wrote: > > > This fixes the https://trac.ffmpeg.org/ticket/4808, as it sets the > cookie > >

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Tue, 22 Sep 2015 13:47:37 + Lucas Andrade wrote: > You're right, I should at least check if ret == 0. I'll update the patch > and check if it works. > Well, I meant, maybe this should be in open_url(), instead of adding it on every code path. Right now everything

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

On Tue, 22 Sep 2015 04:37:48 + Lucas Andrade wrote: > This fixes the https://trac.ffmpeg.org/ticket/4808, as it sets the cookie > on playlist response with setcookie header. > > Update Cookies on Setcookie playlist response > --- > libavformat/hls.c | 2 ++ > 1 file

[FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

This fixes the https://trac.ffmpeg.org/ticket/4808, as it sets the cookie on playlist response with setcookie header. Update Cookies on Setcookie playlist response --- libavformat/hls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index