Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-26 Thread Niklesh Lalwani
On 26-Apr-2015 10:46 AM, Philip Langdale phil...@overt.org wrote: On Sun, 26 Apr 2015 05:04:07 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sun, Apr 26, 2015 at 08:22:56AM +0530, Niklesh Lalwani wrote: On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-26 Thread Niklesh Lalwani
On 26-Apr-2015 4:00 PM, wm4 nfx...@googlemail.com wrote: We usually write: text_style[i].face_style_flags It's the same. Got it. Thank you. :) -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-26 Thread wm4
On Sun, 26 Apr 2015 08:33:34 +0530 Niklesh Lalwani lalwani1...@gmail.com wrote: On Sun, Apr 26, 2015 at 7:05 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: +if ((text_style + i)-face_style_flags This

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Michael Niedermayer
On Sun, Apr 26, 2015 at 05:31:21AM +0530, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch uses struct for the Style Records. The pointer to this struct is updated to point to the start of style records in the TextStyleModifierBox. However, in doing this, I get a

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Carl Eugen Hoyos
Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: +if ((text_style + i)-face_style_flags This looks very strange imo... +long tsmb_size; int64_t ? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Niklesh Lalwani
On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at wrote: +struct __attribute__((__packed__)) StyleRecord { you cant do this attribute packed is not ANSI/ISO C How do I implement packed structures then here? ( since I don't want padding for proper alignment with the

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Philip Langdale
On Sun, 26 Apr 2015 05:04:07 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sun, Apr 26, 2015 at 08:22:56AM +0530, Niklesh Lalwani wrote: On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at wrote: +struct __attribute__((__packed__)) StyleRecord {

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Michael Niedermayer
On Sun, Apr 26, 2015 at 08:22:56AM +0530, Niklesh Lalwani wrote: On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at wrote: +struct __attribute__((__packed__)) StyleRecord { you cant do this attribute packed is not ANSI/ISO C How do I implement packed

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Niklesh Lalwani
On Sun, Apr 26, 2015 at 7:05 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: +if ((text_style + i)-face_style_flags This looks very strange imo... What's wrong? I point my structure to the start of the style