Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On June 22, 2016 at 12:12:02 PM, Amancio Hasty (aha...@gmail.com) wrote: On Jun 22, 2016, at 10:20 AM, Aman Gupta wrote: This patch should fix the assertion failure you see: https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4 Aman On Sat, Jun 18,

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Jun 22, 2016, at 10:20 AM, Aman Gupta wrote: > > This patch should fix the assertion failure you see: > https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4 > >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

This patch should fix the assertion failure you see: https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4 Aman On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty wrote: > > > On Jun 16, 2016, at 11:16 AM, Aman Gupta wrote: > > > > The

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Jun 16, 2016, at 11:16 AM, Aman Gupta wrote: > > The patchset that was merged into libav is now available in ffmpeg as well: > https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c > > You can compile ffmpeg from the master branch > with --enable-omx

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

The patchset that was merged into libav is now available in ffmpeg as well: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c You can compile ffmpeg from the master branch with --enable-omx --enable-omx-rpi Aman On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On May 9, 2016, at 7:55 AM, Amancio Hasty wrote: > > Hi, > > So what is the next step? > > If you want testers I suggest posting to ccrisan’s motionpie mailing list. > Cheers > Amancio > > >> On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: >> >> I

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

Hi, So what is the next step? If you want testers I suggest posting to ccrisan’s motionpie mailing list. Cheers Amancio > On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > I am not a lawyer… > > > I updated the patch. vc264.c now has a the copyright notice embedded

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

I confirmed that this patch works on the rpi3, when compiling ffmpeg with `--enable-omx --enable-omx-rpi` and using `ffmpeg -v:c h264_omx` I had to make some minor changes for ffmpeg compatibility which I pushed to my rebase branch. Aman On Thu, Apr 21, 2016 at 10:14 AM, Amancio Hasty

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

Curious, Do these patches work with ffmpeg running on RPi? Thanks, Amancio > On Apr 19, 2016, at 12:00 PM, Aman Gupta wrote: > > On Thu, Apr 7, 2016 at 3:03 AM, Mark Thompson > wrote: > >> On 06/04/16 14:25, Amancio Hasty wrote: >>>

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > I am not a lawyer… > > > I updated the patch. vc264.c now has a the copyright notice embedded in > a volatile global so if a binary is compiled against vc264.o , the copyright > notice > can be displayed by: >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On 06/04/16 14:25, Amancio Hasty wrote: > >> On Apr 6, 2016, at 3:42 AM, wm4 wrote: >> >> On Wed, 6 Apr 2016 02:56:49 -0700 >> Amancio Hasty wrote: >> >>> If you think is better and it works , are there any plans to incorporate >>> such an older patch?

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Apr 6, 2016, at 3:42 AM, wm4 wrote: > > On Wed, 6 Apr 2016 02:56:49 -0700 > Amancio Hasty wrote: > >> If you think is better and it works , are there any plans to incorporate >> such an older patch? > > I asked the author - he's looking into

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Wed, 6 Apr 2016 02:56:49 -0700 Amancio Hasty wrote: > If you think is better and it works , are there any plans to incorporate such > an older patch? I asked the author - he's looking into getting it ready for merge. ___

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Apr 6, 2016, at 1:29 AM, wm4 wrote: > > On Tue, 5 Apr 2016 16:09:42 -0700 > Amancio Hasty > wrote: > >>> On Apr 5, 2016, at 3:57 PM, Michael Niedermayer >>> wrote: >>> >>> On Tue, Apr 05, 2016 at

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Tue, 5 Apr 2016 16:09:42 -0700 Amancio Hasty wrote: > > On Apr 5, 2016, at 3:57 PM, Michael Niedermayer > > wrote: > > > > On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote: > >> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Apr 5, 2016, at 3:57 PM, Michael Niedermayer > wrote: > > On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote: >> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote: >>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On 01/04/16 03:27, Amancio Hasty wrote: > LICENSE.md | 36 + > MAINTAINERS| 1 + > configure | 11 ++ > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 + > libavcodec/vc264.c | 389 >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote: > On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote: > > > > > On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > > > > > I am not a lawyer… > > > > > > > > > I updated the patch. vc264.c

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote: > > > On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > > > I am not a lawyer… > > > > > > I updated the patch. vc264.c now has a the copyright notice embedded in > > a volatile global so if a binary is

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > I am not a lawyer… > > > I updated the patch. vc264.c now has a the copyright notice embedded in > a volatile global so if a binary is compiled against vc264.o , the copyright > notice > can be displayed by: >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Apr 4, 2016, at 10:41 AM, wm4 wrote: > > On Mon, 4 Apr 2016 10:08:56 -0700 > Amancio Hasty > wrote: > >>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: >>> >>> I am not a lawyer… >>> >>> >>> I

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Mon, 4 Apr 2016 10:08:56 -0700 Amancio Hasty wrote: > > On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > > > I am not a lawyer… > > > > > > I updated the patch. vc264.c now has a the copyright notice embedded in > > a volatile global so if a

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty wrote: > > I am not a lawyer… > > > I updated the patch. vc264.c now has a the copyright notice embedded in > a volatile global so if a binary is compiled against vc264.o , the copyright > notice > can be displayed by: >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

I am not a lawyer… I updated the patch. vc264.c now has a the copyright notice embedded in a volatile global so if a binary is compiled against vc264.o , the copyright notice can be displayed by: strings ffmpeg | grep -i copyright LICENSE.md has been updated to include Broadcom’s copyright

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Mar 23, 2016, at 8:17 AM, Michael Niedermayer > wrote: > > On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote: > [...] > >> +static int vc264_init(AVCodecContext *avctx) { >> + >> + >> + >> + OMX_ERRORTYPE r; >> + int error; >> + >> + >> + >> +

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

Hi, On Wed, Mar 23, 2016 at 11:41 AM, Amancio Hasty wrote: > Is there a pretty formatter for ffmpeg’s coding style and > coding style guideline? https://ffmpeg.org/developer.html#Coding-Rules-1 Please don't top-post. Ronald ___

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

Is there a pretty formatter for ffmpeg’s coding style and coding style guideline? Amancio > On Mar 23, 2016, at 8:17 AM, Michael Niedermayer > wrote: > > On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote: > [...] > >> +static int vc264_init(AVCodecContext

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote: [...] > +static int vc264_init(AVCodecContext *avctx) { > + > + > + > + OMX_ERRORTYPE r; > + int error; > + > + > + > + VC264Context *vc = avctx->priv_data; > + > + vc->width = avctx->width; > + vc->height = avctx->height; >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Mar 22, 2016, at 12:12 PM, Lou Logan wrote: > > On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote: > >> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001 >> From: Amancio Hasty >> Date: Mon, 21 Mar 2016 18:56:05 -0700 >>

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Tue, Mar 22, 2016 at 11:12:18 -0800, Lou Logan wrote: > > +* Redistributions of source code must retain the above copyright > > + notice, this list of conditions and the following disclaimer. > > + * Redistributions in binary form must reproduce the above copyright > > + notice,

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote: > From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001 > From: Amancio Hasty > Date: Mon, 21 Mar 2016 18:56:05 -0700 > Subject: [PATCH] added support for hardware assist H264 video encoding for > the

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

> On Mar 18, 2016, at 12:20 PM, Lou Logan wrote: > > On Fri, 18 Mar 2016 12:12:24 -0700, Amancio Hasty wrote: > >> The patch was against: >> 2016-02-26-raspbian-jessie.img >> >> In my Raspberry Pi system: >> /opt/vc/include/bcm_host.h >> >> in ffmpeg/configure: >> if enabled

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Fri, 18 Mar 2016 12:12:24 -0700, Amancio Hasty wrote: > The patch was against: > 2016-02-26-raspbian-jessie.img > > In my Raspberry Pi system: > /opt/vc/include/bcm_host.h > > in ffmpeg/configure: > if enabled vc264_encoder && [ -n "$target_os_default"="linux" ] ; then >

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Fri, 18 Mar 2016 11:13:58 -0700, Amancio Hasty wrote: > From be5f142f820e05b411bfdc95719e0ab6388bcbe5 Mon Sep 17 00:00:00 2001 > From: Amancio Hasty > Date: Fri, 18 Mar 2016 10:00:14 -0700 > Subject: [PATCH] added support for hardware assist H264 video encoding for > the

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

I wrote this driver a while ago before the mmal decoding was submitted… Amancio > On Mar 18, 2016, at 11:57 AM, wm4 wrote: > > On Fri, 18 Mar 2016 11:13:58 -0700 > Amancio Hasty wrote: > >> Amancio Hasty >> > > It seems a bit strange that decoding

[FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

0001-added-support-for-hardware-assist-H264-video-encodin.patch Description: Binary data Amancio Hasty ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

On Fri, 18 Mar 2016 11:13:58 -0700 Amancio Hasty wrote: > Amancio Hasty > It seems a bit strange that decoding now uses MMAL, and encoding OMX? Probably also precludes transcoding without copying. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

The patch was against: 2016-02-26-raspbian-jessie.img In my Raspberry Pi system: /opt/vc/include/bcm_host.h in ffmpeg/configure: if enabled vc264_encoder && [ -n "$target_os_default"="linux" ] ; then add_cflags ' -I/opt/vc/include/… ——— Amancio > On Mar 18, 2016, at 11:50 AM, Lou