Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On Wed, Apr 11, 2018 at 11:44:47AM +0200, Jerome Martinez wrote: > On 11/04/2018 00:16, Lou Logan wrote: > >On Tue, Apr 10, 2018, at 2:05 PM, Michael Niedermayer wrote: > >>what do you mean by "Git and me are not good friends" ? > >>If git hates you and sometimes does things that you didnt intend

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On 11/04/2018 00:16, Lou Logan wrote: On Tue, Apr 10, 2018, at 2:05 PM, Michael Niedermayer wrote: what do you mean by "Git and me are not good friends" ? If git hates you and sometimes does things that you didnt intend at all then that would be a problem with direct pushes as theres no way to

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On Tue, Apr 10, 2018, at 2:05 PM, Michael Niedermayer wrote: > > what do you mean by "Git and me are not good friends" ? > If git hates you and sometimes does things that you didnt intend at all then > that would be a problem with direct pushes as theres no way to undo. > But maybe i

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On Tue, Apr 10, 2018 at 09:41:05PM +0200, Jerome Martinez wrote: > On 10/04/2018 12:34, Carl Eugen Hoyos wrote: > >2018-04-10 12:28 GMT+02:00, Kieran O Leary : > >>I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci > >>Resolve. > >Testing is good,

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On 10/04/2018 12:34, Carl Eugen Hoyos wrote: 2018-04-10 12:28 GMT+02:00, Kieran O Leary : I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci Resolve. Testing is good, apart I thought the patch was "technically" OK, as I answered to all change

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On Tue, Apr 10, 2018 at 3:16 PM, Paul B Mahol wrote: > On 4/10/18, Kieran O Leary wrote: >> >> Hopefully this is a bit better than just using ffmpeg? > > No, you must not use tragic software ever. > > Besides ffmpeg also can give you checksums for

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On 4/10/18, Kieran O Leary wrote: > Actually, here's another test that might be a bit more meaningful. > This is using graphicksmagic and the identify/signature command in > order to generate sha256 hashes for the image data only. > > It is producing identical hashes

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

Actually, here's another test that might be a bit more meaningful. This is using graphicksmagic and the identify/signature command in order to generate sha256 hashes for the image data only. It is producing identical hashes for: 1. The original 12-bit DPX from Da Vinci Resolve (not packed to

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

Hi On Tue, Apr 10, 2018 at 11:34 AM, Carl Eugen Hoyos wrote: > 2018-04-10 12:28 GMT+02:00, Kieran O Leary : >> I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci >> Resolve. > > Testing is good, apart from more brackets (and less

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

2018-04-10 12:41 GMT+02:00, Paul B Mahol : > On 4/10/18, Kieran O Leary wrote: >> I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci >> Resolve. Encoding to FFV1 and back again to DPX produced the same framemd5 >> values. >> >> Does

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On 4/10/18, Kieran O Leary wrote: > I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci > Resolve. Encoding to FFV1 and back again to DPX produced the same framemd5 > values. > > Does any more testing need to happen before this can be merged? > >

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

2018-04-10 12:28 GMT+02:00, Kieran O Leary : > I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci > Resolve. Testing is good, apart from more brackets (and less comments) it would be better if Jerome sends his public keys to Michael and pushes the

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci Resolve. Encoding to FFV1 and back again to DPX produced the same framemd5 values. Does any more testing need to happen before this can be merged? Best, Kieran ___ ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

On 08/02/2018 11:28, Jerome Martinez wrote: Currently RGB and RGBA 12-bit are supported by DPX decoder only if component values are padded (packing "Filled to 32-bit words, method A"). This patch adds decoding of RGB and RGBA 12-bit with no padding (packing "Packed into 32-bit words"). As I